[PATCH] gianfar: Enable eTSEC-106 erratum w/a for MPC8548E Rev2

Enable workaround for MPC8548E erratum eTSEC 106, "Excess delays when transmitting TOE=1 large frames". (see commit 53fad77375ce "gianfar: Enable eTSEC-20 erratum w/a for P2020 Rev1") This erratum was fixed in Rev 3.1.x. Signed-off-by: Atsushi Nemoto <nem...@toshiba-tops.

[PATCH] net: eth: altera: Fix the initial device operstate

Call netif_carrier_off() prior to register_netdev(), otherwise userspace can see incorrect link state. Signed-off-by: Atsushi Nemoto <nem...@toshiba-tops.co.jp> --- drivers/net/ethernet/altera/altera_tse_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/

Re: [PATCH] net: eth: altera: fix napi poll_list corruption

On Wed, 2 Sep 2015 22:32:54 -0700, David Miller wrote: >> I think napi_gro_flush() can be called with irq enabled, so moving the >> spin_lock_irqsave() just before the __napi_complete() (or moving the >> __napi_complete() just after the spin_lock_irqsave()) would be better,

[PATCH] net: eth: altera: fix napi poll_list corruption

tse_poll() calls __napi_complete() with irq enabled. This leads napi poll_list corruption and may stop all napi drivers working. Use napi_complete() instead of __napi_complete(). Signed-off-by: Atsushi Nemoto <nem...@toshiba-tops.co.jp> --- drivers/net/ethernet/altera/altera_tse_main.c

Re: [PATCH] net: eth: altera: fix napi poll_list corruption

On Wed, 2 Sep 2015 11:25:00 -0700, David Miller wrote: > Two lines below this change you are disabling interrupts anyways, > so I would suggest just moving the spin_lock_irqsave() before the > napi_gro_flush() to fix this. > > Many of the checks done by napi_complete_done()

Re: [PATCH] macb: Fix speed setting

On Thu, 21 Feb 2008 15:12:46 +0100, Haavard Skinnemoen [EMAIL PROTECTED] wrote: I have to admit that even after looking through include/linux/phy.h and include/linux/mii.h, I don't have the faintest idea what values we can expect to find in the speed field of phydev. The comment above struct

Re: [PATCH] macb: Fix speed setting

, this patch fixes problem with 10Mbps on AT91SAM9260 board. --- Atsushi Nemoto -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tc35815: remove redefinition of lp

' was here Signed-off-by: Yoichi Yuasa [EMAIL PROTECTED] Thanks! Acked-by: Atsushi Nemoto [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fix wrong argument of tc35815_read_plat_dev_addr()

On Wed, 18 Jul 2007 11:13:42 +0900, Yoichi Yuasa [EMAIL PROTECTED] wrote: Fix wrong argument of tc35815_read_plat_dev_addr() Oh my fault! Thanks! Acked-by: Atsushi Nemoto [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH] tc35815: Remove unnecessary skb-dev assignment

Apply changes in commit 4c13eb6657fe9ef7b4dc8f1a405c902e9e5234e0 to newly added piece of code. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index f1e2dfc..463d600 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

On Sun, 29 Apr 2007 02:10:37 +0900 (JST), Atsushi Nemoto [EMAIL PROTECTED] wrote: platform_device_register_simple() copies *res by value, so I believe we can make res[] static __initdata. This way we don't need to evaluate the array on the stack at runtime, and the data gets discarded

[PATCH 0/5] ne: MIPS: platform_driver

) * Add NEEDS_PORTLIST to control ISA auto-probe. (sugested by Jeff Garzik) * Less ifdef CONFIG_PM. (by Andrew Morton) * Make rbtx4927_ne_init()'s res[] static __initdata. (by Andrew Morton) --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[PATCH 1/5] ne: Add platform_driver

Add a platform_driver interface to ne driver. (Existing legacy ports did not covered by this ne_driver for now) Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- drivers/net/ne.c | 91 - 1 files changed, 89 insertions(+), 2 deletions

[PATCH 2/5] ne: Misc fixes for platform driver.

Miscellaneous fixes to make ne platform driver work properly. * Make ioaddr 'unsigned long'. * Move a printk down to show dev-name assigned in register_netdev. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- drivers/net/ne.c | 13 +++-- 1 files changed, 7 insertions(+), 6

[PATCH 3/5] ne: Add NEEDS_PORTLIST to control ISA auto-probe

Add NEEDS_PORTLIST cpp macro to control ISA auto-probe. (I'm not sure M32R needs auto-probe but it is current behavior) Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- drivers/net/ne.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ne.c b

[PATCH 4/5] ne: MIPS: Use platform_driver for ne on RBTX49XX

-by: Atsushi Nemoto [EMAIL PROTECTED] --- .../toshiba_rbtx4927/toshiba_rbtx4927_setup.c | 19 +++ arch/mips/tx4938/toshiba_rbtx4938/setup.c | 20 drivers/net/Kconfig|2 +- drivers/net/ne.c

[PATCH 5/5] MIPS: Drop unnecessary CONFIG_ISA from RBTX49XX

Those boards do not need CONFIG_ISA if the ne driver could be selectable without it. Disable it and update a defconfig. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- arch/mips/Kconfig |2 -- arch/mips/configs/rbhma4500_defconfig | 31

Re: [PATCH 1/3] ne: Add platform_driver

depends on ethN order of built-in drivers). So I chose least intrusive way. --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

... --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ne: Add platform_driver

. Please split this patch into two patches: one patch does platform_driver conversion, and the other patch is the other two items you describe above. OK, I'll update and split the patch. Thank you. --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

[base_addr]; dev-irq = orig_irq; if (ne_probe1(dev, ioaddr) == 0) return 0; } #endif --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

On Wed, 25 Apr 2007 01:55:49 +0900 (JST), Atsushi Nemoto [EMAIL PROTECTED] wrote: This patch lets RBTX49XX boards use generic platform_driver interface for the ne driver. This patch obsolates a patch I send on 1 Mar. Subject: [PATCH] Fix broken RBTX4927 support in ne.c Message-Id: [EMAIL

[PATCH 2/3] ne: MIPS: Use platform_driver for ne on RBTX49XX

an ifdef for netcard_portlist[] to avoid unnecessary auto-probe. (I'm not sure M32R needs auto-probe but it is current behavior) Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- .../toshiba_rbtx4927/toshiba_rbtx4927_setup.c | 19 +++ arch/mips/tx4938/toshiba_rbtx4938/setup.c

[PATCH 1/3] ne: Add platform_driver

legacy ports did not covered by this ne_driver for now) * Make ioaddr 'unsigned long'. * Move a printk down to show dev-name assigned in register_netdev. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- drivers/net/ne.c | 103 + 1 files changed

Re: [PATCH] Netpoll support for Sibyte MAC

from interrupt context (or irq disabled). See commit bce305f4fe779f29d99d414685243f5da0803254 for example. --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

[PATCH] tc35815: Zap changelog from source code

Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index eed78b5..755fdd4 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -20,45 +20,6 @@ * * (C) Copyright TOSHIBA CORPORATION 2004-2005 * All Rights Reserved

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

removes the entire changelog from the driver source code :) OK, Done :) --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

On Thu, 08 Mar 2007 10:35:13 +0900 (JST), Atsushi Nemoto [EMAIL PROTECTED] wrote: netpoll_rx() should be invokable from hardware interrupt context. What is the crash you are seeing? The problem is not netpoll_rx(). It should be called from irq context. The problem is, netif_receive_skb

[PATCH] tc35815: Fix an usage of streaming DMA API.

The tc35815 driver lacks a call to pci_dma_sync_single_for_device() on receiving. Recent fix of MIPS dma_sync_single_for_cpu() reveal this bug. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- This patch can be applied to netdev-2.6 tree or 2.6.21-rc3-mm2. diff --git a/drivers/net/tc35815.c

Re: [PATCH] tc35815: Fix an usage of streaming DMA API.

send a revised patch dropping this line? --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 12/19] fix irq problem with NAPI + NETPOLL

() is called from irq context though it seems not designed to do so. It looks like perhaps the kfree_skb() calls need to be modified in __netpoll_rx(). Well, it seems an another netpoll bug. --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] tc35815 driver update (take 2)

On Tue, 06 Mar 2007 06:20:04 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: applied to #upstream, let's give it a good review while it hangs out in libata-dev.git#ALL and -mm Thank you. I believe you mean netdev-2.6.git :) --- Atsushi Nemoto - To unsubscribe from this list: send the line

[PATCH 2/2] tc35815 driver update (part 2)

More updates for tc35815 driver, including: * TX4939 support. * NETPOLL support. * NAPI support. (disabled by default) * Reduce memcpy on receiving. * PM support. * Many cleanups and bugfixes. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- drivers/net/tc35815.c | 827

[PATCH] Fix broken RBTX4927 support in ne.c

There are some ifdefs for RBTX4927, but need some more bits. Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] --- diff --git a/drivers/net/ne.c b/drivers/net/ne.c index a5c4199..02cc78b 100644 --- a/drivers/net/ne.c +++ b/drivers/net/ne.c @@ -55,8 +55,10 @@ static const char version2[] = #include

Re: possible bug in net/tc35815.c in linux-2.6.19

in MontaVista did not complain I can send CELF's one available at http://tree.celinuxforum.org/pubwiki/moin.cgi/PatchArchive. (it needs some changes for recent kernel, for example pt_regs removal, but it would be easy). Sergei? --- Atsushi Nemoto - To unsubscribe from this list: send the line

Re: [RFC] [PATCH 1/2] Driver to remember ethernet MAC values: maclist

code. --- Atsushi Nemoto - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html