Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

[ fixed Johns address - the openwrt.org email was apparently never restored? ] Greg Ungerer writes: > The following change helped alot, but I still get some problems under > sustained load and some types of port setups. Still trying to figure > out what exactly is going on. > > ---

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

g...@kernel.org writes: > I have been working towards supporting the MT7530 switch as used in the > MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621 is built around > a dual core MIPS CPU architecture. But underneath it is what appears to > be the same 7530 switch. Great! Good to see

Re: Can decnet be deprecated?

David Miller writes: > From: David Ahern > Date: Sat, 24 Nov 2018 17:12:48 -0700 > >> IPX was moved to staging at the end of last year. Can decnet follow >> suit? git log seems to indicate no active development in a very long time. > > Last time I tried to do that someone immediately said on the

[PATCH] net/{ipv4,ipv6}: Do not put target net if input nsid is invalid

ils due to bad attributes") Cc: David Ahern Signed-off-by: Bjørn Mork --- net/ipv4/devinet.c | 1 + net/ipv6/addrconf.c | 1 + 2 files changed, 2 insertions(+) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 9250b309c742..a34602ae27de 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/

Re: [net-next][PATCH] net/ipv4: fix a net leak

David Ahern writes: > On 10/24/18 9:02 AM, David Ahern wrote: >> On 10/24/18 3:36 AM, Li RongQing wrote: >>> put net when input a invalid ifindex, otherwise it will be leaked >>> >>> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a >>> specific device") >>> Cc: David Ahern

Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion ALASxx WWAN interface

Giacinto Cifelli writes: > Added support for Gemalto's Cinterion ALASxx WWAN interfaces > by adding QMI_FIXED_INTF with Cinterion's VID and PID. > > Signed-off-by: Giacinto Cifelli Acked-by: Bjørn Mork

Re: [PATCH net] qmi_wwan: Support dynamic config on Quectel EP06

ed? Are you sure there can't be any other type of serial function with 3 endpoints and ff/ff/ff? Well, I guess no one knows for sure... And this is more than good enough until it breaks. Thanks for solving the puzzle. Looks good to me. Acked-by: Bjørn Mork

Re: [PATCH net-next] net: qmi_wwan: Add pass through mode

Subash Abhinov Kasiviswanathan writes: > Pass through mode is to allow packets in MAP format to be passed > on to the stack. rmnet driver can be used to process and demultiplex > these packets. Note that pass through mode can be enabled when the > device is in raw ip mode only. The concepte

Re: Qualcomm rmnet driver and qmi_wwan

Subash Abhinov Kasiviswanathan writes: >> thanks, I will test it on Monday. >> >> Just a question for my knowledge: is the new sysfs attribute really >> needed? I mean, is there not any other way to understand from qmi_wwan >> without user intervention that there is the rmnet device attached? >>

Re: Qualcomm rmnet driver and qmi_wwan

Subash Abhinov Kasiviswanathan writes: >> I followed Dan's advice and prepared a very basic test patch >> (attached) for testing it through ip link. >> >> Basically things seem to be properly working with qmicli, but I needed >> to modify a bit qmi_wwan, so I'm adding Bjørn that maybe can help.

Re: ANNOUNCE: Enhanced IP v1.4

Willy Tarreau writes: > I agree on these points, but I'd like to figure what can be done to put > a bit more pressure on ISPs to *always* provide IPv6. Most ISPs are in it for the money. So what you can do is either to make it more expensive to provide IPv4-only services or more profitable to

Re: [PATCH] net: qmi_wwan: Add Netgear Aircard 779S

Josh Hill <j...@joshuajhill.com> writes: > Add support for Netgear Aircard 779S > > Signed-off-by: Josh Hill <j...@joshuajhill.com> Acked-by: Bjørn Mork <bj...@mork.no> Please queue this for stable too. Thanks. Bjørn

[PATCH net-next] qmi_wwan: apply SET_DTR quirk to the SIMCOM shared device ID

: add QMI_QUIRK_SET_DTR for Telit PID 0x1201") Initial testing on an older SIM7100 modem shows no immediate side effects. Reported-by: Sebastian Sjoholm <sebastian.sjoh...@gmail.com> Cc: Reinhard Speyerer <rs...@arcor.de> Signed-off-by: Bjørn Mork <bj...@mork.no> --- I propose this

[PATCH net,stable] qmi_wwan: do not steal interfaces from class drivers

or MBIM, without the device ID changing either. Fix by requiring the vendor-specific class for interface number based matching. Functions of other classes can and should use class based matching instead. Fixes: 03304bcb5ec4 ("net: qmi_wwan: use fixed interface number matching") Signed-off

Re: [PATCH] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2

"SZ Lin (林上智)" <sz@moxa.com> writes: > This patch adds support for PID 0x90b2 of ublox R410M. Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] net: qmi_wwan: add Wistron Neweb D19Q1

or.) Sub=06 Prot=50 Driver=(none) > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us > > Tested on openwrt distribution > > Signed-off-by: Pawel Dembicki <paweldembi...@gmail.com> Acked-by: Bjørn Mork <bj...@mork.no>

[PATCH v3 net,stable] tun: fix vlan packet truncation

f ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebpf socket filter") Cc: Jason Wang &

[PATCH v2 net,stable] tun: fix vlan packet truncation

f ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebpf socket filter") Cc: Jason Wang &

Re: [PATCH net,stable] tun: fix vlan packet truncation

David Miller writes: > The VLAN business might be bogus, and needs to be removed. > > However, the pskb_trim() has to stay in some form. I think this is what > Jason is trying to say. > > The semantics of running a BPF program is that the program returns the > desired

Re: [PATCH net,stable] tun: fix vlan packet truncation

Jason Wang writes: > Good catch, Thanks. I guess I am "lucky" as I apparently use configs no one else are using, and therefore often experience breakage ;-) I have been using tagged interfaces over tap for an occasional virtual "lab" of kvm machines for years. It's a

[PATCH net,stable] tun: fix vlan packet truncation

f ff ff ff ff ff 76 cf 76 37 d5 0a 81 00 00 14 ..v.v7.. 0010 08 06 00 01 08 00 06 04 00 01 76 cf 76 37 d5 0a ..v.v7.. 0020 0a 09 09 09 00 00 00 00 00 00 .. Fixes: aff3d70a07ff ("tun: allow to attach ebpf socket filter") Cc: Jason Wang &

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Bassem Boubaker writes: > +#define GEMALTO_VENDOR_ID0x1e2d This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. I have no idea which defintion is most correct, but I believe the macros should be kept identical whatever you decide. Anything else

Re: [PATCH net,stable] qmi_wwan: Add support for Quectel EP06

Kristian Evensen <kristian.even...@gmail.com> writes: > The Quectel EP06 is a Cat. 6 LTE modem. It uses the same interface as > the EC20/EC25 for QMI, and requires the same "set DTR"-quirk to work. > > Signed-off-by: Kristian Evensen <kristian.even...@gmail

Re: [PATCH] usbnet: silence an unnecessary warning

Oliver Neukum writes: > That a kevent could not be scheduled is not an error. > Such handlers must be able to deal with multiple events anyway. > As the successful scheduling of a work is a debug event, make > the failure debug priority, too. > > Signed-off-by: Oliver Neukum

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

{QMI_FIXED_INTF(0x05c6, 0x920d, 5)}, > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */ > {QMI_FIXED_INTF(0x0846, 0x68a2, 8)}, > {QMI_FIXED_INTF(0x12d1, 0x140c, 1)},/* Huawei E173 */ > {QMI_FIXED_INTF(0x12d1, 0x14ac, 1)},/* Huawei E1820 */ Perfect. Thanks Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

Vamsi Samavedam <vskri...@codeaurora.org> writes: > On Thu, Dec 14, 2017 at 07:55:50PM +0100, Bjørn Mork wrote: >> It has been reported that the dummy byte we add to avoid >> ZLPs can be forwarded by the modem to the PGW/GGSN, and that >> some operators will drop the

[PATCH net-next] qmi_wwan: set FLAG_SEND_ZLP to avoid network initiated disconnect

. The latter assumption failed. Let's test out the first. Signed-off-by: Bjørn Mork <bj...@mork.no> --- I am a bit worried about the effect of this change on all the devices I can't test myself. But trying it is the only way we can ever find out drivers/net/usb/qmi_wwan.c | 4 ++-- 1 file c

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit ME910 PID 0x1101 support

Daniele Palmas <dnl...@gmail.com> writes: > This patch adds support for Telit ME910 PID 0x1101. > > Signed-off-by: Daniele Palmas <dnl...@gmail.com> Acked-by: Bjørn Mork <bj...@mork.no> > bInterfaceSubClass254 Just curious: Is there some meaning hidden here? Bjørn

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

Telekom Speedstick LTE II > (Alcatel One Touch L100V LTE) */ > {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},/* Alcatel L800MA */ > {QMI_FIXED_INTF(0x2357, 0x0201, 4)},/* TP-LINK HSUPA Modem MA180 */ Looks good except for the duplicate 'From' line. Drop that and you can add Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] usbnet: fix alignment for frames with no ethernet header

David Miller <da...@davemloft.net> writes: > From: Bjørn Mork <bj...@mork.no> > Date: Wed, 6 Dec 2017 20:21:24 +0100 > >> The qmi_wwan minidriver support a 'raw-ip' mode where frames are >> received without any ethernet header. This causes alignment issues >&g

[PATCH] usbnet: fix alignment for frames with no ethernet header

per-device flag, since the same minidriver also supports 'ethernet' mode. Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode") Reported-and-tested-by: Jay Foster <j...@systech.com> Signed-off-by: Bjørn Mork <bj...@mork.no> --- drivers/net/usb/qmi_wwa

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Reinhard Speyerer writes: > before posting this problem report > https://developer.gemalto.com/threads/ipv6dualstack-problems-pls8-e-revision-03017 > in the Gemalto developer forum I tested the qmi_wwan/cdc_ether changes > you suggested above and apart from having two working QMI

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Oliver Graute <oliver.gra...@gmail.com> writes: > On 23/11/17, Bjørn Mork wrote: >> Oliver Graute <oliver.gra...@gmail.com> writes: >> >> > When the PLS8 devices show up with PID 0x0061 they will expose both a >> > QMI port and a WWAN interf

Re: [PATCH net] net: qmi_wwan: add support for Cinterion PLS8

Oliver Graute writes: > When the PLS8 devices show up with PID 0x0061 they will expose both a > QMI port and a WWAN interface. Please remove the indentation. > Signed-off-by: Oliver Graute > --- > drivers/net/usb/qmi_wwan.c | 1 + >

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

e BG96. > > Signed-off-by: Sebastian Sjoholm <ssjoh...@mac.com> Perfect. Thanks. Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

Shrirang Bagul writes: > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > series modems which will by default boot with vid 0x413c and pid's > 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support > qmi_wwan on the usb

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

On November 20, 2017 5:19:21 AM GMT+01:00, ssjoh...@mac.com wrote: >From: ssjoholm > >Signed-off-by: ssjoholm > >Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both >CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel >development

[PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

and constant by converting the constant to LE. Reported-by: Ben Hutchings <ben.hutchi...@codethink.co.uk> Fixes: 2b02c20ce0c2 ("cdc_ncm: Set NTB format again after altsetting switch for Huawei devices") Cc: Enrico Mioso <mrkiko...@gmail.com> Cc: Christian Panton <christ...@panton.

Re: [PATCH 4.4 27/56] cdc_ncm: Set NTB format again after altsetting switch for Huawei devices

Ben Hutchings writes: > On Tue, 2017-07-11 at 17:21 +0200, Enrico Mioso wrote: >> From: Enrico Mioso >> >> commit 2b02c20ce0c28974b44e69a2e2f5ddc6a470ad6f upstream. > [...] >> --- a/drivers/net/usb/cdc_ncm.c >> +++ b/drivers/net/usb/cdc_ncm.c

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

ve > no MAC header and the interface is configured as-such, it seems certain > parts of the network stack expects a "good" value in skb->mac_header. Thanks. Yes, I see that the tun driver also does this. Acked-by: Bjørn Mork <bj...@mork.no> And his should probably go to stable

[PATCH net,stable] net: cdc_ether: fix divide by 0 on bad descriptors

Setting dev->hard_mtu to 0 will cause a divide error in usbnet_probe. Protect against devices with bogus CDC Ethernet functional descriptors by ignoring a zero wMaxSegmentSize. Signed-off-by: Bjørn Mork <bj...@mork.no> --- I believe the problem found by syzcaller in qmi_wwan als

[PATCH net,stable] net: qmi_wwan: fix divide by 0 on bad descriptors

based WWAN devices") Reported-by: Andrey Konovalov <andreyk...@google.com> Signed-off-by: Bjørn Mork <bj...@mork.no> --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 8c37

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

Andrey Konovalov writes: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thanks. It would have helped a lot of you said *what* you were fuzzing, though But based on where the bug is, I assume it is USB descriptors? > On commit

Re: [PATCH 00/10] staging/irda/net: Adjustments for several function implementations

Did you read drivers/staging/irda/TODO ? There is no need to answer that. You already have. Thanks a lot for your ever lasting invaluable contributions to /dev/null. Please continue. Bjørn

Re: [PATCH] rndis_host: support Novatel Verizon USB730L

ork with *any* such device until we've actually seen one. This is just my opinion, and probably full of bogus assumptions as usual. I was sort of hoping that some expert would speak up so I didn't have to :-) But FWIW: Reviewed-by: Bjørn Mork <bj...@mork.no> Bjørn

Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

Douglas Anderson writes: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly useful. I agree, FWIW. These

Re: [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

Douglas Anderson writes: > If rx_submit() returns an error code then nobody calls usb_free_urb(). > That means it's leaked. Nope. rx_submit() will call usb_free_urb() before returning an error: static int rx_submit (struct usbnet *dev, struct urb *urb, gfp_t flags) ..

Re: [PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer base. > >

[PATCH net,stable] qmi_wwan: fix NULL deref on disconnect

ail.com> Signed-off-by: Bjørn Mork <bj...@mork.no> --- Needed for v4.12 and later drivers/net/usb/qmi_wwan.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index ff6f39fe6c00..8c3733608271 100644 --- a/driv

Re: [PATCH 0/6] In-kernel QMI handling

Bjorn Andersson writes: > This series starts by moving the common definitions of the QMUX protocol to > the > uapi header, as they are shared with clients - both in kernel and userspace. > > This series then introduces in-kernel helper functions for aiding the

Re: qmi_wwan: Null pointer dereference when removing driver

? device_release_driver_internal+0x154/0x210 ? qmi_wwan_unbind+0x6d/0xc0 [qmi_wwan] ? usbnet_disconnect+0x6c/0xf0 [usbnet] ? qmi_wwan_disconnect+0x87/0xc0 [qmi_wwan] ? usb_unbind_interface+0x71/0x270 [usbcore] ? device_release_driver_internal+0x154/0x210 Reported-by: Nathaniel R

Re: [PATCH V3] Set NTB format again after altsetting switch for Huawei devices

Oliver Neukum writes: > Am Dienstag, den 11.07.2017, 17:21 +0200 schrieb Enrico Mioso: >> Some firmwares in Huawei E3372H devices have been observed to switch back >> to NTB 32-bit format after altsetting switch. >> This patch implements a driver flag to check for the device

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

"Baxter, Jim" writes: > I tested this with printk's to show when the low memory code was triggered > and the value of ctx->tx_low_mem_val and ctx->tx_low_mem_max_cnt. > I created a workqueue that slowly used up the atomic memory until the > code is triggered. > > I could

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

ld tell the user that the initial buffer allocation has failed. Maybe add some sort of debug helper(s) in a followup patch? How did you verify the patch operation while testing it? Anyway, that's no show stopper of course. So FWIW: Reviewed-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

Jay Vosburgh writes: > Michael J Dilmore wrote: > >>if (WARN_ON(!new_active_slave) { >>netdev_dbg("Can't add new active slave - pointer null"); >>return ERROR_CODE >>} > > In general, yes, but in this case, the condition

Re: [RFC 1/3] networking: make skb_put & friends return void pointers

Johannes Berg writes: > From: Johannes Berg > > It seems like a historic accident that these return unsigned char *, > and in many places that means casts are required, more often than not. > > Make these functions (skb_put, __skb_put and

[PATCH net,stable] qmi_wwan: new Telewell and Sierra device IDs

A new Sierra Wireless EM7305 device ID used in a Toshiba laptop, and two Longcheer device IDs entries used by Telewell TW-3G HSPA+ branded modems. Reported-by: Petr Kloc <petr_k...@yahoo.com> Reported-by: Teemu Likonen <tliko...@iki.fi> Signed-off-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH net-next] ipv6: Initial skb->dev and skb->protocol in ip6_output

Chenbo Feng writes: > This patch is still under working since it may have problem with > ip_fragment() call, did you applied it already? Should I send a revert > patch to you then? It does? I initially thought so too, but looking closer I believe the

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

David Laight writes: > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter >> Sent: 16 May 2017 18:41 >> >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the

Re: [RFC]RNDIS filter issue

Oliver Neukum writes: > @@ -472,7 +489,6 @@ static void usbnet_cdc_zte_status(struct usbnet *dev, > struct urb *urb) > > if (urb->actual_length < sizeof(*event)) > return; > - > event = urb->transfer_buffer; > > if (event->bNotificationType

Re: [PATCH] cdc-ether: divorce initialisation with a filter reset and a generic method

Oliver Neukum writes: > @@ -417,7 +434,7 @@ int usbnet_cdc_bind(struct usbnet *dev, struct > usb_interface *intf) > BUILD_BUG_ON((sizeof(((struct usbnet *)0)->data) > < sizeof(struct cdc_state))); > > - status = usbnet_generic_cdc_bind(dev,

[PATCH net,stable] qmi_wwan: add another Lenovo EM74xx device ID

In their infinite wisdom, and never ending quest for end user frustration, Lenovo has decided to use a new USB device ID for the wwan modules in their 2017 laptops. The actual hardware is still the Sierra Wireless EM7455 or EM7430, depending on region. Signed-off-by: Bjørn Mork <bj...@mork

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Jim Baxter writes: > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of

Re: [PATCH] usbnet: no address filtering on RNDIS

Oliver Neukum writes: > RNDIS does not do multicast filtering and the commands crash a few devices. > Make it conditional. Strange. I thought we already discussed this when the filter reset request was initially added 3 years ago. Ref

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit ME910 support

Daniele Palmas <dnl...@gmail.com> writes: > This patch adds support for Telit ME910 PID 0x1100. > > Signed-off-by: Daniele Palmas <dnl...@gmail.com> Acked-by: Bjørn Mork <bj...@mork.no> David, please add this to your stable queue as well. Thanks Bjørn

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Daniele Palmas writes: > So, I applied your debug patch and this is what is happening: Thanks > [ 4306.730786] wdm_open: qmi_wwan 2-2:1.2: draining queued data > [ 4306.730955] wdm_write: qmi_wwan 2-2:1.2: Tx URB has been submitted index=2 > > Here qmicli is stuck. Then I

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Aleksander Morgado writes: > I'm just running --dms-get-operating-mode multiple times, and getting > errors frequently: Could you retry that with cdc-wdm debugging enabled (e.g. "echo 'module cdc_wdm +fp' > /sys/kernel/debug/dynamic_debug/control") and something like

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Aleksander Morgado <aleksan...@aleksander.es> writes: > On Wed, Apr 19, 2017 at 7:28 PM, Bjørn Mork <bj...@mork.no> wrote: >>> as a side note in latest kernels I had troubles with qmi devices >>> (e.g. I/O error when using qmicli). >>> >>> I fou

Re: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201

Daniele Palmas writes: > as a side note in latest kernels I had troubles with qmi devices > (e.g. I/O error when using qmicli). > > I found your suggestion in libqmi mailing list to revert commit > > 833415a3e781a26fe480a34d45086bdb4fe1e4c0 > cdc-wdm: fix "out-of-sync" due to

Re: [PATCHv4] net: usbnet: support 64bit stats

rs/net/wireless/rndis_wlan.c | 1 + > include/linux/usb/usbnet.h| 4 +++ > 18 files changed, 73 insertions(+), 4 deletions(-) > > v2: EXPORT usbnet_get_stats64() > rebase on top of net-next > > v3: use percpu vars for stats64 counters > > v4: update all usbnet drivers to use stats64 Looking good. For the qmi_wwan part: Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

On March 31, 2017 3:27:59 PM CEST, Greg Ungerer <g...@linux-m68k.org> wrote: >On 31/03/17 18:48, Bjørn Mork wrote: > >>> +void usbnet_get_stats64(struct net_device *net, struct >rtnl_link_stats64 *stats) >>> +{ >>> + struct usbnet *dev = ne

Re: [PATCHv3] net: usbnet: support 64bit stats in qmi_wwan driver

Greg Ungerer writes: > Add support for the net stats64 counters to the usbnet core and then to > the qmi_wwan driver. > > This is a strait forward addition of 64bit counters for RX and TX packets > and byte counts. It is done in the same style as for the other net drivers >

Re: [PATCH] net: usbnet: support 64bit stats in qmi_wwan driver

Greg Ungerer writes: > Add support for the net stats64 counters to the usbnet core and then to > the qmi_wwan driver. > > This is a strait forward addition of 64bit counters for RX and TX packets > and byte counts. It is done in the same style as for the other net drivers >

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

Tony Lindgren <t...@atomide.com> writes: > * Bjørn Mork <bj...@mork.no> [170319 09:33]: >> Tony Lindgren <t...@atomide.com> writes: >> >> > This gets qmicli working with the MDM6600 modem. >> > >> > Cc: Bjørn Mork <bj...@mork.no>

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

Tony Lindgren <t...@atomide.com> writes: > This gets qmicli working with the MDM6600 modem. > > Cc: Bjørn Mork <bj...@mork.no> > Reviewed-by: Sebastian Reichel <s...@kernel.org> > Tested-by: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Tony Lindgr

[PATCH net,stable] qmi_wwan: add Dell DW5811e

This is a Dell branded Sierra Wireless EM7455. It is operating in MBIM mode by default, but can be configured to provide two QMI/RMNET functions. Signed-off-by: Bjørn Mork <bj...@mork.no> --- Note regarding stable backports: This device should only be added to v4.5 and later. It d

Re: [PATCH v2] fjes: Do not load fjes driver if system does not have extended socket device.

Yasuaki Ishimatsu writes: > The fjes driver is used only by FUJITSU servers and almost of all > servers in the world never use it. But currently if ACPI PNP0C02 > is defined in the ACPI table, the following message is always shown: > > "FUJITSU Extended Socket Network

Re: 4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume

Bjørn Mork <bj...@mork.no> writes: > This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa > ("e1000e: driver trying to free already-free irq"), which looks more > than suspicious in this context. Haven't had time to test a revert > yet. Just wante

4.11-rc1 regression: e1000e "BUG at drivers/pci/msi.c" on unplugged suspend+resume

This is new with v4.11-rc1, so I strongly suspect commit 7e54d9d063fa ("e1000e: driver trying to free already-free irq"), which looks more than suspicious in this context. Haven't had time to test a revert yet. Just wanted to give an advance warning in case this isn't known. Suspending and

Re: [PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

ays for IPv6) correct? If so, then this makes sense. But I think it might be worth a note about what we replace here and why, in case you happen to know that... I realise that this is inherited from the original driver. Just minor nits. Overall this looks very good to me, FWIW. Reviewed-by: Bjørn Mork <bj...@mork.no> Bjørn

[RESENT PATCH net,stable] qmi_wwan/cdc_ether: add device ID for HP lt2523 (Novatel E371) WWAN card

card") Cc: Dan Williams <d...@redhat.com> Signed-off-by: Bjørn Mork <bj...@mork.no> --- Resending with correct author and to address. I didn't manage to spell kernel correctly... I guess I should have had one more cup of coffee this morning. No changes to the diff. drivers/n

Re: bad interaction between privacy extensions, prefix lifetimes and protocols that maintain long-term connections.

peter green writes: > Disabling privacy extensions solved the issue but obviously reveals > the MAC address of my new machine to the world which is undesirable. I have no solution to the problem with privacy extensions, but just wanted to let you know there is a third

Re: [PATCH 1/1] NET: usb: cdc_mbim: add quirk for supporting Telit LE922A

ry for > other modems. > > Signed-off-by: Daniele Palmas <dnl...@gmail.com> Thanks. This looks as nice as we can possibly do for now. I am happy to add Reviewed-by: Bjørn Mork <bj...@mork.no> This patch also helped me understanding the problem you face even better: It's

Re: [PATCH 1/1] NET: usb: cdc_ncm: adding MBIM RESET_FUNCTION request and modifying ncm bind common code

Daniele Palmas writes: > I went back to this and further checking revealed that MBIM function > reset is not needed and the only problem is related to commit > 48906f62c96cc2cd35753e59310cb70eb08cc6a5 cdc_ncm: toggle altsetting to > force reset before setup, that, however, is

Re: [PATCH 1/1] NET: usb: qmi_wwan: add support for Telit LE922A PID 0x1040

Daniele Palmas <dnl...@gmail.com> writes: > This patch adds support for PID 0x1040 of Telit LE922A. LGTM Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH net] cdc_ether: Fix handling connection notification

Kristian Evensen writes: > +void usbnet_cdc_zte_status(struct usbnet *dev, struct urb *urb) > +{ > + struct usb_cdc_notification *event; > + > + if (urb->actual_length < sizeof(*event)) > + return; > + > + event = urb->transfer_buffer; > + > +

Re: [PATCH 1/1] NET: usb: cdc_ncm: adding MBIM RESET_FUNCTION request and modifying ncm bind common code

Bjørn Mork <bj...@mork.no> writes: > Finally, I found my modems (or at least a number of them) again today. > But I'm sorry to say, that the troublesome Huawei E3372h-153 is still > giving us a hard time. It does not work with your patch. The symptom is > the same as earlier:

Re: [PATCH 1/1] NET: usb: cdc_ncm: adding MBIM RESET_FUNCTION request and modifying ncm bind common code

Finally, I found my modems (or at least a number of them) again today. But I'm sorry to say, that the troublesome Huawei E3372h-153 is still giving us a hard time. It does not work with your patch. The symptom is the same as earlier: The modem returns MBIM frames with 32bit headers. So for now,

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

Jussi Peltola writes: > So here's another stab. The comments and the current implementation are > not in sync: any non-multicast address starting with a null octet gets > rewritten, while the comment specifically mentions 00:a0:c6:00:00:00. It > is certainly not elegant but

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

Jussi Peltola writes: > This brokenness appears reliably after running "rdisc6 wwan0" but I have > not debugged if this is related to timing or the format of the router > solicitation. Before receiving a router solicitation, v4 is received > correctly and v6 does not work. After

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Alan Stern writes: > On Thu, 10 Nov 2016, Kai-Heng Feng wrote: > >> Is there a way to force XHCI run at HighSpeed? > > Yes, like I said above: Use a USB-2 cable instead of a USB-3 cable. It's an m.2 form factor modem, so there most likely isn't any cable involved. But

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Kai-Heng Feng <kai.heng.f...@canonical.com> writes: > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork <bj...@mork.no> wrote: >> Oliver Neukum <oneu...@suse.com> writes: >> >>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >>> >>>> Th

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Oliver Neukum writes: > On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: > >> These problems could very well be caused by running at SuperSpeed >> (USB-3) instead of high speed (USB-2). >> >> Is there any way to test what happens when the device is attached to >> the

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

Alan Stern writes: > On Tue, 8 Nov 2016, Kai-Heng Feng wrote: > >> Hi, >> >> On Mon, Nov 7, 2016 at 7:02 PM, Oliver Neukum wrote: >> > On Fri, 2016-11-04 at 17:57 +0800, Kai-Heng Feng wrote: >> >> Sometimes cdc_mbim failed to probe if runtime pm is

[PATCH net] qmi_wwan: add support for Quectel EC21 and EC25

nce we cannot enable this unconditionally for all older devices, and there doesn't appear to be anything we can use in the USB descriptors to identify these chips, we are forced to use a device specific quirk flag. Reported-and-tested-by: Sebastian Sjoholm <sebastian.sjoh...@gmail.com> Sig

Re: cdc_ncm driver padding problem

> ==From: Marek Brudka .. > ==The bad thing is DHCP. It seems, that cdc_ncm driver somehow consumes DHCP > ==replies. I had to manually setup wwan0 interface as well as routing > ==using the result > ==of Hayes command > == > ==AT^DHCP? > ==^DHCP: >

Re: [PATCH net-next 0/3] r8152: configuration setting

Hayes Wang <hayesw...@realtek.com> writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Thursday, September 08, 2016 3:55 PM > [...] >> Yes, I see that. But is that strictly necessary? Couldn't you just say: >> "CDC ECM is supported by cdc_ether an

Re: [PATCH net-next 0/3] r8152: configuration setting

Hayes Wang <hayesw...@realtek.com> writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Wednesday, September 07, 2016 9:51 PM > [...] >> So this adds a lot of code to work around the issues you introduced by >> unnecessarily blacklisting the CDC ECM configurati

Re: [PATCH net-next 0/3] r8152: configuration setting

[ CCing Oliver, who AFAIK still is the cdc_ether maintainer and should have the final word on this ] Hayes Wang writes: > Some people prefer to use ECM mode rather than vendor mode. Therefore, I add > CONFIG_RTL8152_CONFIG_VALUE in Kconfig. Then, the users could choose

Re: [PATCH 2/2] kaweth: fix oops upon failed memory allocation

Oliver Neukum writes: > Just return an error upon failure. > > Signed-off-by: Oliver Neukum > --- > drivers/net/usb/kaweth.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c > index

  1   2   3   >