Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit

On 9/28/18 6:38 AM, Hangbin Liu wrote: > On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: >> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: >>> Phil pointed out that there is a mismatch between vxlan and geneve ttl >>> inherit. >>> We should define it as a flag and use

Re: [PATCH iproute2 net-next] bridge: fdb: add support for sticky flag

On 9/27/18 7:35 AM, Nikolay Aleksandrov wrote: > Add support for the new sticky flag that can be set on fdbs and update the > man page. > > CC: David Ahern > Signed-off-by: Nikolay Aleksandrov > --- > bridge/fdb.c | 9 +++-- > man/man8/bridge.8 | 6 +

Re: [PATCH 04/11] net: ip6_multipath_l3_keys() - use new style struct initializer instead of memset

On 9/27/18 5:00 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Signed-off-by: Maciej Żenczykowski > --- > net/ipv6/route.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index d28f83e01593..9cb024451fc5

Re: [PATCH 03/11] net: fib_multipath_hash() - use new style struct initializer instead of memset

On 9/27/18 5:00 PM, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Signed-off-by: Maciej Żenczykowski > --- > net/ipv4/route.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index 048919713f4e..17953a52fbd0

Re: [PATCH iproute2 net-next] ipneigh: support setting of NTF_ROUTER on neigh entries

On 9/25/18 3:15 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Signed-off-by: Roopa Prabhu > --- > ip/ipneigh.c | 2 ++ > 1 file changed, 2 insertions(+) > applied to iproute2-next. And then I noticed you did not update the help or the man page. Please send a follow up.

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On 9/27/18 3:36 PM, Cong Wang wrote: > On Thu, Sep 27, 2018 at 2:16 PM Eric Dumazet wrote: >> >> >> >> On 09/27/2018 01:42 PM, Cong Wang wrote: >>> It is clearly a copy-n-paste. >>> >>> Signed-off-by: Cong Wang >>> --- >>> net/sched/cls_api.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next 0/7] rtnetlink: add RTM_GETADDR2

On 9/27/18 11:58 AM, Christian Brauner wrote: > Various userspace programs (e.g. iproute2) have sent RTM_GETADDR > requests with struct ifinfomsg. This is wrong and should have been > struct ifaddrmsg all along as mandated by the manpages. However, dump > requests so far didn't parse the netlink

Re: [RFC PATCH iproute2-next V2] man: Add devlink exception man page

On 9/27/18 8:32 AM, Jiri Pirko wrote: > But still, I need the code so I can play with it, to > see the outputs etc. +1

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

On 9/25/18 11:51 PM, Jiri Benc wrote: > On Tue, 25 Sep 2018 09:37:41 -0600, David Ahern wrote: >> For ifaddrmsg ifa_flags aligns with ifi_type which is set by kernel side >> so this should be ok. > > Does the existing user space set ifi_type to anything? Does it zero out >

Re: [PATCH 2/2] net-ipv4: remove 2 always zero parameters from ipv4_redirect()

> net/xfrm/xfrm_interface.c | 2 +- > 11 files changed, 14 insertions(+), 15 deletions(-) Reviewed-by: David Ahern

Re: [PATCH 1/2] net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu()

| 8 +++- > net/ipv6/sit.c | 2 +- > net/netfilter/ipvs/ip_vs_core.c | 3 +-- > net/xfrm/xfrm_interface.c | 2 +- > 12 files changed, 14 insertions(+), 18 deletions(-) > Reviewed-by: David Ahern

Re: [PATCH net-next v1 1/5] net: allow binding socket in a VRF when there's an unbound socket

On 9/25/18 9:26 AM, Mike Manning wrote: > On 24/09/2018 23:44, David Ahern wrote: >> On 9/24/18 10:13 AM, Mike Manning wrote: >>> From: Robert Shearman >>> >>> There is no easy way currently for applications that want to receive >>> packets in the def

Re: netlink: 16 bytes leftover after parsing attributes in process `ip'.

On 9/25/18 8:47 AM, Jiri Benc wrote: > On Tue, 25 Sep 2018 11:49:10 +0200, Christian Brauner wrote: >> So if people really want to hide this issue as much as we can then we >> can play the guessing game. I could send a patch that roughly does the >> following: >> >> if (nlmsg_len(cb->nlh) <

netlink: 16 bytes leftover after parsing attributes in process `ip'.

On top of net-next I am see a dmesg error: netlink: 16 bytes leftover after parsing attributes in process `ip'. I traced it to address lists and commit: commit 6ecf4c37eb3e89b0832c9616089a5cdca3747da7 Author: Christian Brauner Date: Tue Sep 4 21:53:50 2018 +0200 ipv6: enable

Re: [PATCH net-next v1 2/5] ipv6: allow link-local and multicast packets inside vrf

On 9/24/18 10:13 AM, Mike Manning wrote: > Packets that are multicast or to link-local addresses are not enslaved > to the vrf of the socket that they are received on. This is needed for > NDISC, but breaks applications that rely on receiving such packets when > in a VRF. Also to make IPv6

Re: [PATCH net-next v1 5/5] ipv6: add vrf table handling code for ipv6 mcast

table *rt' declaration removed the rest of the change looks fine. Reviewed-by: David Ahern

Re: [PATCH net-next v1 4/5] ipv6: do not drop vrf udp multicast packets

On 9/24/18 10:13 AM, Mike Manning wrote: > From: Dewi Morgan > > For bound udp sockets in a vrf, also check the sdif to get the index > for ingress devices enslaved to an l3mdev. Verify the multicast address > against the enslaved rather than the l3mdev device. > > Signed-off-by: Dewi Morgan >

Re: [PATCH net-next v1 3/5] ipv4: Allow sending multicast packets on specific i/f using VRF socket

arman > Signed-off-by: Mike Manning > --- > net/ipv4/datagram.c | 2 +- > net/ipv4/ping.c | 2 +- > net/ipv4/raw.c | 2 +- > net/ipv4/udp.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: David Ahern

Re: [PATCH net-next v1 1/5] net: allow binding socket in a VRF when there's an unbound socket

On 9/24/18 10:13 AM, Mike Manning wrote: > From: Robert Shearman > > There is no easy way currently for applications that want to receive > packets in the default VRF to be isolated from packets arriving in > VRFs, which makes using VRF-unaware applications in a VRF-aware system > a potential

Re: [PATCH net-next v1 5/5] ipv6: add vrf table handling code for ipv6 mcast

just started looking at this set. Compiler notes one problem: On 9/24/18 10:13 AM, Mike Manning wrote: > @@ -2146,6 +2157,7 @@ static void ip6_mr_forward(struct net *net, struct > mr_table *mrt, > > int ip6_mr_input(struct sk_buff *skb) > { > + struct rtable *rt = skb_rtable(skb); The

Re: [PATCH iproute2] Makefile: add help target

On 9/21/18 9:16 AM, Stephen Hemminger wrote: > Add help target to Makefile. > > Signed-off-by: Stephen Hemminger > --- > Makefile | 12 > 1 file changed, 12 insertions(+) > Acked-by: David Ahern

Re: [PATCH net] net/ipv4: avoid compile error in fib_info_nh_uses_dev

Move device validation to helper") > Signed-off-by: Eric Dumazet > Cc: David Ahern > --- > net/ipv4/fib_frontend.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c &g

Re: [PATCH ipsec] net: xfrm: pass constant family to nf_hook function

On 9/21/18 8:55 AM, Florian Westphal wrote: > David Ahern wrote: >>> David, i hope this will silence the warning, would be nice >>> if you could test it. >> >> I still the warning. > > Wait. Do you see this warning everywhere or just in xfrm? > just the one file.

Re: [PATCH ipsec] net: xfrm: pass constant family to nf_hook function

ould be to increase hooks_arp[] size, but that > increases struct net size needlesly. > > Reported-by: David Ahern > Signed-off-by: Florian Westphal > --- > David, i hope this will silence the warning, would be nice > if you could test it. I still the warning. > >

Re: [PATCH net-next 0/5] vrf: allow simultaneous service instances in default and other VRFs

On 9/20/18 1:58 AM, Mike Manning wrote: > Services currently have to be VRF-aware if they are using an unbound > socket. One cannot have multiple service instances running in the > default and other VRFs for services that are not VRF-aware and listen > on an unbound socket. This is because there

Re: [PATCH iproute2-next] iplink: add ipvtap support

On 9/18/18 8:03 PM, Hangbin Liu wrote: > IPVLAN and IPVTAP are using the same functions and parameters. So we can > just add a new link_util with id ipvtap. Others are the same. > > Signed-off-by: Hangbin Liu > --- > ip/iplink.c | 4 ++-- > ip/iplink_ipvlan.c| 28

Re: array bounds warning in xfrm_output_resume

On 9/20/18 7:06 AM, Florian Westphal wrote: > David Ahern wrote: >>> $ make O=kbuild/perf -j 24 -s >>> In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, >>> from /home/dsa/kernel-3.git/include/linux/list.h:9, >>>

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

On 9/18/18 6:12 AM, Patrick Ruddy wrote: > > I've hit a small snag with adding the new groups. The number of defined > groups currently sits at 31 so I can only add one before hitting the I believe you have no more available. RTNLGRP_* has been defined from 0 (RTNLGRP_NONE) to 31

Re: [PATCH net-next] ipv6: Allow the l3mdev to be a loopback

net/ipv6/route.c | 3 ++- > 3 files changed, 5 insertions(+), 2 deletions(-) > Reviewed-by: David Ahern Been on my to-do list for a while. Thanks for the patch. This resolves, for example, a harmless error message from the 'host' command from bind9-host-9.10.3 which probes fo

Re: array bounds warning in xfrm_output_resume

On 6/18/18 11:10 AM, David Ahern wrote: > Florian: > > I am seeing this warning: > > $ make O=kbuild/perf -j 24 -s > In file included from /home/dsa/kernel-3.git/include/linux/kernel.h:10:0, > from /home/dsa/kernel-3.git/include/linux/list.h:9, >

Re: [PATCH net 2/2] ipv6: fix memory leak on dst->_metrics

st_metrics *)DST_METRICS_PTR(dst); > struct rt6_info *rt = (struct rt6_info *)dst; > struct fib6_info *from; > struct inet6_dev *idev; > > - dst_destroy_metrics_generic(dst); > + if (p != _default_metrics && refcount_dec_and_test(>refc

Re: [PATCH net 1/2] Revert "ipv6: fix double refcount of fib6_metrics"

> --- > net/ipv6/route.c | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: David Ahern

Re: [RFC 1/5] netlink: remove NLA_NESTED_COMPAT

3 deletions(-) > Reviewed-by: David Ahern

Re: [RFC 2/5] netlink: set extack error message in nla_validate()

On 9/18/18 6:12 AM, Johannes Berg wrote: > diff --git a/lib/nlattr.c b/lib/nlattr.c > index 120ad569e13d..efbd6c1aff29 100644 > --- a/lib/nlattr.c > +++ b/lib/nlattr.c > @@ -181,9 +181,13 @@ int nla_validate(const struct nlattr *head, int len, int > maxtype, > int rem; > >

Re: [Patch net v2] net/ipv6: do not copy dst flags on rt init

size due to > DST_NOCOUNT not set and thus no counter decrements on gc-ed routes. > > Fixes: 3b6761d18bc1 ("net/ipv6: Move dst flags to booleans in fib entries") > Cc: David Ahern > Acked-by: Wei Wang > Signed-off-by: Peter Oskolkov > --- > net/ipv6/route.c | 2 -- >

Re: [PATCH net] net/ipv6: do not copy DST_NOCOUNT flag on rt init

On 9/17/18 9:11 AM, Peter Oskolkov wrote: > On Thu, Sep 13, 2018 at 9:11 PM David Ahern wrote: >> >> On 9/13/18 1:38 PM, Peter Oskolkov wrote: >> >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index 3eed045c65a5..a3902f805305 100644 >>> -

Re: [PATCH net] net/ipv6: do not copy DST_NOCOUNT flag on rt init

On 9/17/18 9:11 AM, Peter Oskolkov wrote: > On Thu, Sep 13, 2018 at 9:11 PM David Ahern wrote: >> >> On 9/13/18 1:38 PM, Peter Oskolkov wrote: >> >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index 3eed045c65a5..a3902f805305 100644 >>> -

Re: [PATCH net] netfilter: bridge: Don't sabotage nf_hook calls from an l3mdev

Pablo: DaveM has this marked as waiting for upstream. Any comment on this patch? Thanks, David On 9/7/18 3:08 PM, dsah...@kernel.org wrote: > From: David Ahern > > For starters, the bridge netfilter code registers operations that > are invoked any time nh_hook is called.

Re: [PATCH iproute2] libnetlink: fix leak and using unused memory on error

On 9/14/18 10:48 AM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 13, 2018 at 12:33 PM, Stephen Hemminger > wrote: >> If an error happens in multi-segment message (tc only) >> then report the error and stop processing further responses. >> This also fixes refering to the buffer after free.

Re: [PATCH net] net/ipv6: do not copy DST_NOCOUNT flag on rt init

On 9/13/18 1:38 PM, Peter Oskolkov wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 3eed045c65a5..a3902f805305 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -946,7 +946,7 @@ static void ip6_rt_init_dst_reject(struct rt6_info *rt, > struct fib6_info *ort) > >

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

On 9/10/18 7:04 PM, Hangbin Liu wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 18e00ce..62621b4 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -998,6 +998,21 @@ static void ip6_rt_copy_init(struct rt6_info *rt, struct > fib6_info *ort) > rt->rt6i_prefsrc =

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

On 9/10/18 11:55 AM, Xin Long wrote: > On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote: >> >> On 9/9/18 12:29 AM, Xin Long wrote: >>>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>>>> index 18e00ce..e554922 100644 >>>

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

On 9/9/18 12:29 AM, Xin Long wrote: >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >>> index 18e00ce..e554922 100644 >>> --- a/net/ipv6/route.c >>> +++ b/net/ipv6/route.c >>> @@ -4670,20 +4670,33 @@ static int rt6_fill_node(struct net *net, struct >>> sk_buff *skb, >>>

Re: [PATCH net] ipv6: use rt6_info members when dst is set in rt6_fill_node

On 9/8/18 3:24 AM, Xin Long wrote: > In inet6_rtm_getroute, since Commit 93531c674315 ("net/ipv6: separate > handling of FIB entries from dst based routes"), it has used rt->from > to dump route info instead of rt. > > However for some route like cache, its information is not the same as > that

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

Hi Thomas: On 9/7/18 12:52 PM, Thomas Haller wrote: > Hi David, > > > On Mon, 2018-09-03 at 20:54 -0600, David Ahern wrote: > >> From init_net: >> $ ip monitor all-nsid > > I thought the concern of the patch is the overhead of sending one > additional RTM_

Re: [**EXTERNAL**] Re: VRF with enslaved L3 enabled bridge

On 9/7/18 9:56 AM, D'Souza, Nelson wrote: > > *From:* David Ahern > *Sent:* Thursday, September 6, 2018 5:27 PM > *To:* D'Souza, Nelson; netdev@vger.kernel.org > *Subject:* Re: [**EXTERNAL**] Re: VRF w

Re: [**EXTERNAL**] Re: VRF with enslaved L3 enabled bridge

On 9/5/18 12:00 PM, D'Souza, Nelson wrote: > Just following up would you be able to confirm that this is a Linux VRF > issue? I can confirm that I can reproduce the problem. Need to find time to dig into it.

Re: [PATCH net] net/ipv6: fix incorrect fib6 gateway info after do redirect

On 9/6/18 6:57 AM, Hangbin Liu wrote: > When receive a redirect message and call rt6_do_redirect(), we allocate > a new rt6_info and set new flags and gateway info, but not update these > info to fib6_info. > > Then if a user try to get the route info via `ip route get`, he will still > get the

Re: BUG: unable to handle kernel paging request in fib6_node_lookup_1

On 9/5/18 12:11 AM, Song Liu wrote: > We are debugging an issue with fib6_node_lookup_1(). > > We use a 4.16 based kernel, and we have back ported most upstream > patches in ip6_fib.{c.h}. The only major differences I can spot are > Did you backport all patches in each set that included a

Re: [PATCH RFC net-next 00/18] net: Improve route scalability via support for nexthop objects

On 9/2/18 11:34 AM, David Miller wrote: > From: dsah...@kernel.org > Date: Fri, 31 Aug 2018 17:49:35 -0700 > >> Examples >> 1. Single path >> $ ip nexthop add id 1 via 10.99.1.2 dev veth1 >> $ ip route add 10.1.1.0/24 nhid 1 >> >> $ ip next ls >> id 1 via 10.99.1.2 src 10.99.1.1

Re: [PATCH iproute2-next] ip: Add support for nexthop objects

will eventually come from the kernel via header sync, so I have to stick to whatever style is appropriate for the uapi files. >> diff --git a/ip/ipnexthop.c b/ip/ipnexthop.c >> new file mode 100644 >> index ..9fa4b7292426 >> --- /dev/null >> +++ b/ip/ipn

Re: [PATCH RFC net-next 18/18] net/ipv4: Optimization for fib_info lookup

On 9/1/18 2:43 PM, Stephen Hemminger wrote: > On Fri, 31 Aug 2018 17:49:53 -0700 > dsah...@kernel.org wrote: > >> +static inline unsigned int fib_info_hashfn_cfg(const struct fib_config *cfg) >> +{ >> +unsigned int mask = (fib_info_hash_size - 1); >> +unsigned int val = 0; >> + >> +

Re: [PATCH net-next v1 3/5] ipv4: enable IFA_IF_NETNSID for RTM_GETADDR

On 9/2/18 10:37 PM, Christian Brauner wrote: > - Backwards Compatibility: > If userspace wants to determine whether ipv4 RTM_GETADDR requests support > the new IFA_IF_NETNSID property they should verify that the reply after > sending a request includes the IFA_IF_NETNSID property. If it does

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

On 9/3/18 3:10 AM, Thomas Haller wrote: > Hi, > > On Sat, 2018-09-01 at 17:45 -0600, David Ahern wrote: >> On 9/1/18 3:05 AM, Lorenzo Bianconi wrote: >>> >>> I was thinking about the commit 38e01b30563a and then I realized I >>> misread the code >>&

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

On 9/1/18 3:05 AM, Lorenzo Bianconi wrote: > > I was thinking about the commit 38e01b30563a and then I realized I > misread the code > yesterday. The commit 38e01b30563a provides all relevant info but it > emits the event > for veth1 (the device moved in the new namespace). > An userspace

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

On 8/31/18 10:19 AM, Lorenzo Bianconi wrote: >> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: >>> When moving a veth device to another namespace, userspace receives a >>> RTM_DELLINK message indicating the device has been removed from current >>> netns. However, the other peer does not receive a

Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

On 8/31/18 5:43 AM, Lorenzo Bianconi wrote: > When moving a veth device to another namespace, userspace receives a > RTM_DELLINK message indicating the device has been removed from current > netns. However, the other peer does not receive a netlink event > containing new values for

Re: [PATCH net] net/ipv6: Only update MTU metric if it set

On 8/30/18 3:49 PM, Jan Janssen wrote: > You mentioned that systemd-networkd is doing something silly here, so I was > wondering if you could make a bug report to fix the underlying issue? I don't > mind doing it myself but you're the expert and can explain things better. It is silly in the

Re: [PATCH v2 iproute2-next 0/3] support delivering packets in

On 8/26/18 8:42 PM, Yousuk Seung wrote: > This series adds support for the new "slot" netem parameter for > slotting. Slotting is an approximation of shared media that gather up > packets within a varying delay window before delivering them nearly at > once. > > Dave Taht (2): > tc: support

Re: [PATCH net] ipv6: don't get lwtstate twice in ip6_rt_copy_init()

> rt->rt6i_src = ort->fib6_src; > #endif > rt->rt6i_prefsrc = ort->fib6_prefsrc; > - rt->dst.lwtstate = lwtstate_get(ort->fib6_nh.nh_lwtstate); > } > > static struct fib6_node* fib6_backtrack(struct fib6_node *fn, > Thanks for the patch. Reviewed-by: David Ahern

Re: [PATCH RFC net-next] net/fib: Poptrie based FIB lookup

On 8/27/18 10:24 AM, Stephen Hemminger wrote: > > Also, as Dave mentioned any implementation needs to handle multiple namespaces > and routing tables. > > Could this alternative lookup be enabled via sysctl at runtime rather than > kernel config? > I spent time a couple of years ago

Re: Regression: youtube-dl hanging on download

On 8/25/18 9:23 AM, Jan Janssen wrote: > Hi, > > youtube-dl hangs trying to download videos from youtube. The commit below is > my regression test result. Disabling ipv6 indeed does fix this for me. > Thanks for the report. Can you boot a pre-4.18 kernel and send me, offlist, the output of 'ip

Re: oops with ip6_rt_cache_alloc

On 8/24/18 4:26 PM, Yonghong Song wrote: > Hi, > > We got a kernel oops with the following stack trace: > > CPU: 24 PID: 0 Comm: swapper/24 Not tainted > 4.16.0-10_fbk1_1183_g7e4ee4c8171c #10 > "Hardware name: Quanta Leopard-DDR3/Leopard-DDR3, BIOS F06_3A16.DDR3 > 11/19/2015" > RIP:

Re: [PATCH] net/ipv6: init ip6 anycast rt->dst.input as ip6_input

Fixes: 6edb3c96a5f02 ("net/ipv6: Defer initialization of dst to data path") > Signed-off-by: Hangbin Liu > --- > net/ipv6/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Good catch. Reviewed-by: David Ahern

Re: [Patch net] addrconf: reduce unnecessary atomic allocations

On 8/22/18 1:58 PM, Cong Wang wrote: > All the 3 callers of addrconf_add_mroute() assert RTNL > lock, they don't take any additional lock either, so > it is safe to convert it to GFP_KERNEL. > > Same for sit_add_v4_addrs(). > > Cc: David Ahern > Signed-off-by: Cong

Re: Bug in FIB insert

On 8/16/18 6:59 PM, Md. Islam wrote: > There is a bug in fib_table_insert(). If I add following routes, > > 23.20.0.0/14     veth1 > 23.20.0.0/15     veth2 > > FIB lookup on 23.22.111.212  results veth1, not veth2. > veth1 is the correct lookup

Re: [iproute PATCH v5 1/2] Make colored output configurable

++-- > man/man8/ip.8 | 13 +++-- > man/man8/tc.8 | 13 +++-- > tc/tc.c | 3 +-- > 8 files changed, 77 insertions(+), 13 deletions(-) > LGTM. Reviewed-by: David Ahern

Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

On 8/17/18 1:31 AM, Shmulik Ladkani wrote: > This allows the user to specify the LWTUNNEL_IP_SRC/LWTUNNEL_IP6_SRC > when setting an lwtunnel encapsulation route. > > Signed-off-by: Shmulik Ladkani > --- > ip/iproute_lwtunnel.c | 22 -- > 1 file changed, 20 insertions(+), 2

Re: [iproute PATCH v4] Make colored output configurable

On 8/16/18 3:37 AM, Phil Sutter wrote: > Allow for -color={never,auto,always} to have colored output disabled, > enabled only if stdout is a terminal or enabled regardless of stdout > state. > > Signed-off-by: Phil Sutter > --- > Changes since v1: > - Allow to override isatty() check by

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:51 AM, Phil Sutter wrote: > Should I respin the fixes or will you apply the series > partially? Stephen has released 4.18 but not merged -next to master yet, so I applied the first 3 to -next.

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:39 AM, Phil Sutter wrote: > On Wed, Aug 15, 2018 at 10:24:31AM -0600, David Ahern wrote: >> On 8/15/18 10:21 AM, Phil Sutter wrote: >>> Add an additional prerequisite to check_enable_color() to make sure >>> stdout actually points to an open TTY d

Re: [iproute PATCH v2 4/4] lib: Enable colored output only for TTYs

On 8/15/18 10:21 AM, Phil Sutter wrote: > Add an additional prerequisite to check_enable_color() to make sure > stdout actually points to an open TTY device. Otherwise calls like > > | ip -color a s >/tmp/foo > > will print color escape sequences into that file. Allow to override this > check by

Re: [PATCH v3 net-next] veth: Free queues on link delete

On 8/15/18 2:07 AM, Toshiaki Makita wrote: > David Ahern reported memory leak in veth. > ... > veth_rq allocated in veth_newlink() was not freed on dellink. > > We need to free up them after veth_close() so that any packets will not > reference the queues afterwar

Re: [iproute PATCH 4/4] lib: Enable colored output only for TTYs

On 8/15/18 3:06 AM, Phil Sutter wrote: > Add an additional prerequisite to check_enable_color() to make sure > stdout actually points to an open TTY device. Otherwise calls like > > | ip -color a s >/tmp/foo > > will print color escape sequences into that file. > > Signed-off-by: Phil Sutter >

Re: [PATCH v2 net-next] veth: Free queues on link delete

On 8/14/18 7:16 PM, Toshiaki Makita wrote: > Hmm, on second thought this queues need to be freed after veth_close() > to make sure no packet will reference them. That means we need to free > them in .ndo_uninit() or destructor. > (rtnl_delete_link() calls dellink() before

Re: [PATCH net] veth: Free queues on link delete

On 8/14/18 6:37 PM, Toshiaki Makita wrote: > On 2018/08/15 7:36, dsah...@kernel.org wrote: >> From: David Ahern >> >> kmemleak reported new suspected memory leaks. >> $ cat /sys/kernel/debug/kmemleak >> unreferenced object 0x880130b6ec00 (size 1024):

Re: [PATCH v2 iproute2-next] Add SKB Priority qdisc support in tc(8)

On 8/13/18 8:57 PM, Nishanth Devarajan wrote: > sch_skbprio is a qdisc that prioritizes packets according to their > skb->priority > field. Under congestion, it drops already-enqueued lower priority packets to > make space available for higher priority packets. Skbprio was conceived as a >

Re: [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable

On 8/13/18 5:36 AM, Toke Høiland-Jørgensen wrote: > This patch makes sch_cake's gso/gro splitting configurable > from userspace. > > To disable breaking apart superpackets in sch_cake: > > tc qdisc replace dev whatever root cake no-split-gso > > to enable: > > tc qdisc replace dev whatever

Re: [Patch net] ipv6: fix double refcount of fib6_metrics

ave the same life time, so the > whole fib6_metrics refcnt can be removed actually. > > This fixes a kmemleak warning reported by Sabrina. > > Fixes: 93531c674315 ("net/ipv6: separate handling of FIB entries from dst > based routes") > Reported-by: Sabrina Dubroca &

Re: The recvmsg() with IP_PKTINFO for local addresses returns various ipi_ifindex

On 8/9/18 2:13 AM, Damir Mansurov wrote: > Greetings, > > I use the IP_PKTINFO to detect ipi_ifindex from which the packet was > arrived, it used to work for local addresses also. > > For local addresses ipi_ifindex always returned 1, but starting from > Linux 4.14 ip_ifindex began to return

Re: [PATCH iproute2-next 3/3] q_netem: slotting with non-uniform distribution

On 8/6/18 11:09 AM, Yousuk Seung wrote: > @@ -417,21 +421,53 @@ static int netem_parse_opt(struct qdisc_util *qu, int > argc, char **argv, > } > } > } else if (matches(*argv, "slot") == 0) { > - NEXT_ARG(); > -

Re: [PATCH iproute2-next 2/3] q_netem: support delivering packets in delayed time slots

On 8/6/18 11:09 AM, Yousuk Seung wrote: > diff --git a/tc/q_netem.c b/tc/q_netem.c > index 9f9a9b3df255..f52a36b6c31c 100644 > --- a/tc/q_netem.c > +++ b/tc/q_netem.c > @@ -40,7 +40,10 @@ static void explain(void) > " [ loss gemodel PERCENT [R [1-H [1-K]]]\n" \ > "

Re: [PATCH iproute2-next 1/3] tc: support conversions to or from 64 bit nanosecond-based time

On 8/6/18 11:09 AM, Yousuk Seung wrote: > diff --git a/tc/tc_core.h b/tc/tc_core.h > index 1dfa9a4f773b..a0fe0923d171 100644 > --- a/tc/tc_core.h > +++ b/tc/tc_core.h > @@ -7,6 +7,10 @@ > > #define TIME_UNITS_PER_SEC 100 > > +#define NSEC_PER_USEC 1000 > +#define NSEC_PER_MSEC 100 >

Re: [PATCH iproute2-next] Add SKB Priority qdisc support in tc(8)

On 8/8/18 12:24 PM, Nishanth Devarajan wrote: > sch_skbprio is a qdisc that prioritizes packets according to their > skb->priority > field. Under congestion, it drops already-enqueued lower priority packets to > make space available for higher priority packets. Skbprio was conceived as a >

Re: [PATCHi iproute2-next] ip: show min and max mtu

On 7/27/18 2:43 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Add min/max MTU to the link details > > Signed-off-by: Stephen Hemminger > --- > include/uapi/linux/if_link.h | 2 ++ > ip/ipaddress.c | 10 ++ > 2 files changed, 12 insertions(+) > applied to

Re: [PATCH RFC/RFT net-next 00/17] net: Convert neighbor tables to per-namespace

On 7/24/18 11:14 AM, David Miller wrote: > From: David Ahern > Date: Tue, 24 Jul 2018 09:14:01 -0600 > >> I get the impression there is no longer a strong resistance against >> moving the tables to per namespace, but deciding what is the right >> approach to han

Re: [PATCH RFC/RFT net-next 00/17] net: Convert neighbor tables to per-namespace

On 7/25/18 11:38 AM, Eric W. Biederman wrote: > > Absolutely NOT. Global thresholds are exactly correct given the fact > you are running on a single kernel. > > Memory is not free (Even though we are swimming in enough of it memory > rarely matters). One of the few remaining challenges is for

Re: [PATCH iproute2] iplink: report drop stats for VFs

On 7/25/18 10:22 AM, Ivan Vecera wrote: > Kernel commit c5a9f6f0ab40 ("net/core: Add drop counters to VF > statistics") added support for Rx/Tx packet drops but these stats are > not reported by 'ip link'. > > Cc: Eugenia Emantayev > Cc: Saeed Mahameed > > Signed-off-by: Ivan Vecera > --- >

Re: [patch iproute2/net-next v4] tc: introduce support for chain templates

On 7/23/18 1:24 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko > --- > v3->v4: > - reworked to chain object > v1->v2: > - moved the template handling > from "tc filter template" to "tc chaintemplate" > --- > include/uapi/linux/rtnetlink.h | 7 +++ > man/man8/tc.8

Re: [PATCH iproute2-next] ip: Add violation counters to VF statisctics

On 7/22/18 4:31 AM, Eran Ben Elisha wrote: > Extend VFs statistics by receive and transmit violation counters. > > Example: "ip -s link show dev enp5s0f0" > > 6: enp5s0f0: mtu 1500 qdisc mq state UP > mode DEFAULT group default qlen 1000 > link/ether 24:8a:07:a5:28:f0 brd ff:ff:ff:ff:ff:ff

Re: [PATCH RFC/RFT net-next 00/17] net: Convert neighbor tables to per-namespace

On 7/25/18 6:33 AM, Eric W. Biederman wrote: > Cong Wang writes: > >> On Tue, Jul 24, 2018 at 8:14 AM David Ahern wrote: >>> >>> On 7/19/18 11:12 AM, Cong Wang wrote: >>>> On Thu, Jul 19, 2018 at 9:16 AM David Ahern wrote: >>>>> >&g

Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

On 7/24/18 11:55 AM, Xin Long wrote: > INFO: bc_forwarding disabled on r1 => > INFO: h1 -> net2: reply from r1 (not forwarding) > TEST: ping 198.51.100.255, expected reply from 192.0.2.1[PASS] > INFO: h1 -> net3: reply from r1 (not forwarding) > TEST: ping 198.51.200.255, expected

Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

On 7/24/18 11:24 AM, Xin Long wrote: > On Mon, Jul 23, 2018 at 11:17 PM, David Ahern wrote: >> On 7/23/18 5:51 AM, Xin Long wrote: >>> +ping_ipv4() >>> +{ >>> + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0 >>> + >>> + bc_forwardi

Re: [PATCH net] net/ipv6: Fix linklocal to global address with VRF

On 7/21/18 8:32 PM, David Miller wrote: > > Applied and queued up for -stable. > >> Dave: I can look at the backports to stable if needed. > > Please do, that will help me a lot. > It applies cleanly to 4.17 and 4.14. I tested 4.14 it is fine. Since 4.18 and 4.14 work I have no reason to

Re: [**EXTERNAL**] Re: VRF with enslaved L3 enabled bridge

On 7/23/18 7:43 PM, D'Souza, Nelson wrote: > I copy and pasted the configs onto my device, but pings on test-vrf do not > work in my setup. > I'm essentially seeing the same issue as I reported before. > > In this case, pings sent out on test-vrf (host ns) are received and replied > to by the

Re: [**EXTERNAL**] Re: VRF with enslaved L3 enabled bridge

On 7/20/18 1:03 PM, D'Souza, Nelson wrote: > Setup is as follows: > > ethUSB(ingress port) -> mgmtbr0 (bridge) -> mgmtvrf (vrf) | netns foo [ test-vrf ]| | | [ br0 ] 172.16.1.1 | | | [ veth1 ]

Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

On 7/23/18 5:51 AM, Xin Long wrote: > +ping_ipv4() > +{ > + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0 > + > + bc_forwarding_disable > + ping_test_from $h1 198.51.100.255 192.0.2.1 > + ping_test_from $h1 198.51.200.255 192.0.2.1 > + ping_test_from $h1 192.0.2.255

Re: [PATCH net] ipv6: use fib6_info_hold_safe() when necessary

ked-by: Eric Dumazet > --- > include/net/ip6_fib.h | 5 + > net/ipv6/addrconf.c | 3 ++- > net/ipv6/route.c | 41 +++++++-- > 3 files changed, 38 insertions(+), 11 deletions(-) Reviewed-by: David Ahern Thanks for fixing.

Re: [PATCH net-next] selftests: forwarding: gre_multipath: Drop IPv6 tests

re_multipath.sh | 113 > ++--- > 1 file changed, 6 insertions(+), 107 deletions(-) Reviewed-by: David Ahern Thanks for following up.

Re: VRF with enslaved L3 enabled bridge

On 7/20/18 1:03 PM, D'Souza, Nelson wrote: > Hi Dave, > > It is good to know that this works in your case. However, I'm not able to > pinpoint what the issue is and looking for a way to narrow down to the root > cause. > Do you know if this has been an issue in the past and resolved in Linux >

<    1   2   3   4   5   6   7   8   9   10   >