Re: [PATCH,RFC] Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-09-08 Thread Francois Romieu
Lennert Buytenhek [EMAIL PROTECTED] : [...] I suspect it's a chip bug. I rechecked with I/O space, and that works okay, so this artifact (bug) only manifests itself when you do the upper write in MMIO space. Are there any plans to switch r8169 to the iomap API? Would you take a patch if

Re: [PATCH,RFC] Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-09-08 Thread Francois Romieu
Lennert Buytenhek [EMAIL PROTECTED] : [...] I tried your series from step (1) plus my TxDesc change (so I didn't include the hunk from (2)), and that seems to work fine. I.e. I don't need to disable error interrupts anymore to keep it working. So really the only thing that would need

Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6

2006-09-07 Thread Francois Romieu
Arjan van de Ven [EMAIL PROTECTED] : [...] dev-trans_start = jiffies; + tasklet_enable(np-tx_tasklet); + writew(DEFAULT_INTR, ioaddr + IntEnable); + return; this looks like a PCI posting bug Btw tx_tasklet is introduced in the relevant struct in patch #2. Patch #1 will not

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-09-05 Thread Francois Romieu
Thomas Klein [EMAIL PROTECTED] : [...] Somehow I don't get your point concerning the usage of 'k'. We need another iterator as the for loops using 'k' use 'i' as their terminating condition. Something like the code below perhaps (with more local variables maybe): static int

Re: [PATCH] DM9000 interrupt is hardware dependant

2006-09-04 Thread Francois Romieu
Jürgen Schindele [EMAIL PROTECTED] : [...] Please comment an review my patch which is attached here diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c index 24996da..0a71f7b 100644 --- a/drivers/net/dm9000.c +++ b/drivers/net/dm9000.c @@ -598,10 +598,11 @@ static int dm9000_open(struct

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-09-04 Thread Francois Romieu
Arnd Bergmann [EMAIL PROTECTED] : [...] The driver should get merged as a single commit anyway, even if split diffs are posted for review. Even if it gets merged like this, bisect will work since the Kconfig option is added in the final patch. I have seen/done worse but it's not exactly

Re: Possible circular locking in current wireless-dev.git

2006-09-03 Thread Francois Romieu
Larry Finger [EMAIL PROTECTED] : When booting the latest version of Linville's wireless-dev and starting my BCM4306 with WPA-PSK TKIP, the I get the following INFO printout that indicates a possible circular locking dependency involving 80211 and wpa_supplicant. Please try the patch below

Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

2006-09-02 Thread Francois Romieu
Krzysztof Halasa [EMAIL PROTECTED] : [...] === [ INFO: possible circular locking dependency detected ] --- swapper/0 is trying to acquire lock: (dev-queue_lock){-+..}, at: [c02c8c46]

Re: [PATCH 0/7] 8139cp: misc minor changes

2006-09-01 Thread Francois Romieu
Pierre Ossman [EMAIL PROTECTED] : Ehm... why am I included in this? :) To preserve an happy 8139cp user :o) -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 0/7] 8139cp: misc minor changes

2006-08-31 Thread Francois Romieu
The serie contains the patches summarized below: - 1/7 trim ring_info - 2/7 remove gratuitous indirection - 3/7 ring_info removal for the receive path - 4/7 sync the device private data with its r8169 counterpart - 5/7 removal of useless BUG_ON() check - 6/7 pci_get_drvdata(pdev) can not be NULL

[PATCH 4/7] 8139cp: sync the device private data with its r8169 counterpart

2006-08-31 Thread Francois Romieu
struct cp_private is reorganized to be more easily compared between the r8169 and the 8139cp drivers. The alignment should not be impacted. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions

[PATCH 1/7] 8139cp: trim ring_info

2006-08-31 Thread Francois Romieu
Fat removal: the mapping address is available from the Rx/Tx descriptors. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c | 33 - 1 files changed, 16 insertions(+), 17 deletions(-) 3598b57be449a2ee9178e5c511bdb1a8aaccba20 diff --git

[PATCH 5/7] 8139cp: removal of useless BUG_ON() check

2006-08-31 Thread Francois Romieu
netdev_priv() will provide a nice oops a few lines before the BUG_ON() check. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) e68970e7543815133224f79a858e7c9e0c42f4de diff --git a/drivers/net/8139cp.c b

[PATCH 3/7] 8139cp: ring_info removal for the receive path

2006-08-31 Thread Francois Romieu
The ring_info.len field is not used at all. cp_private.rx_skb is turned into an array of sk_buff *. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) 0ba894d420b845667e2981c2147af974a755fba2 diff

[PATCH 2/7] 8139cp: remove gratuitous indirection

2006-08-31 Thread Francois Romieu
dev is an argument of the current function. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) c48e9399e895834f26dff9149de1930ba18a0d6c diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 8f5d779

[PATCH 7/7] 8139cp: use PCI_DEVICE() to shorten the PCI device table

2006-08-31 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) cccb20d3a9b7c6d4b6e1b52ee02814e6094aaa12 diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index a123d28..bbdaa18 100644 --- a/drivers/net/8139cp.c

[PATCH 6/7] 8139cp: pci_get_drvdata(pdev) can not be NULL in suspend handler

2006-08-31 Thread Francois Romieu
-driver provide the expected result. St Mary's day was a bit rainy here. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/8139cp.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) 7668a4945ba0e17a61e535a6c67aa64a319a03b4 diff --git a/drivers/net/8139cp.c b

Re: RTL8136

2006-08-31 Thread Francois Romieu
Darren Salt [EMAIL PROTECTED] : [...] The former. Without that, the connection is persistently re-negotiated (though, according to the switch's LEDs, it's fine before the module is loaded). The state of the LEDs at startup is not necessarily significant (it can come from the eeprom). I have

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-30 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : [...] Added: 0043-ip1000-use-the-new-IRQF_-constants-and-the-dma_-alloc-free-_coherent-AP I.txt 0044-ip1000-mixed-case-and-upper-case-removal.txt 0045-ip1000-add-ipg_-r-w-8-16-32-macros.txt Added: 0046-ip1000-kiss-TxBuffDMAhandle-goodbye.txt 0047-ip1000

Re: RTL8136

2006-08-27 Thread Francois Romieu
Darren Salt [EMAIL PROTECTED] : [...] Whoops. I'd not noticed the -rc4 patches... These seem to help a little: mii-tool can reset it and bring the link up regardless of RTL_CFG_{1,2}. After that, RTL_CFG_1 allows sending to work, and RTL_CFG_2 allows both sending and receiving to work

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-27 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : Jesse Huang [EMAIL PROTECTED] : [...] Added: 0039-ip1000-cosmetic-in-ipg_interrupt_handler.txt 0040-ip1000-irq-handler-and-device-close-race.txt 0041-ip1000-schedule-the-host-error-recovery-to-user-context.txt 0042-ip1000-no-need-to-mask-a-constant

Re: RTL8136

2006-08-25 Thread Francois Romieu
Darren Salt [EMAIL PROTECTED] : In case you don't yet have an lspci dump for an RTL8136, here's one for a device which is working with the r1000 driver which is supplied with Ubuntu dapper (though the machine in question - a Toshiba Equium A110-233 - is actually running Debian testing.)

Re: [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver - patch for big-endian systems

2006-08-24 Thread Francois Romieu
wen xiong [EMAIL PROTECTED] : [...] diff -Nuar old/drivers/net/netxen/netxen_nic_hw.c new/drivers/net/netxen/netxen_nic_hw.c --- old/drivers/net/netxen/netxen_nic_hw.c2006-08-23 12:58:43.0 -0500 +++ new/drivers/net/netxen/netxen_nic_hw.c2006-08-23 13:15:19.0 -0500

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-24 Thread Francois Romieu
Jesse Huang [EMAIL PROTECTED] : [...] Added: 0039-ip1000-cosmetic-in-ipg_interrupt_handler.txt 0040-ip1000-irq-handler-and-device-close-race.txt 0041-ip1000-schedule-the-host-error-recovery-to-user-context.txt 0042-ip1000-no-need-to-mask-a-constant-field-with-RSVD_MASK.txt ipg_reset() may still

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-23 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : [...] or as a serie of patches at: http://www.fr.zoreil.com/linux/2.6.x/2.6.18-rc4/ip1000 Typo. It should be: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.18-rc4/ip1000 -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-23 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : [...] Typo. It should be: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.18-rc4/ip1000 Added 0038-ip1000-CodingStyle.txt. More local variables, more unsigned int, less MixedCase, ipg_nic_rx() fits in your favorite 80 cols console. -- Ueimor

Re: [PATCH] IP1000A: IC Plus update 2006-08-22

2006-08-22 Thread Francois Romieu
Jesse Huang [EMAIL PROTECTED] : Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. The suggestion was probably to submit the whole driver as one patch to akpm for wider testing

Re: Linker error on via-velocity driver

2006-08-21 Thread Francois Romieu
Henne [EMAIL PROTECTED] : [...] I found a bug in the via-velocity driver, but I cant find a maintainer for that, so I write to the lists. This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled. This is tested on i386 and x86_64. I'm not familiar with network stuff but I don't

Re: [PATCH,RFC] Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-08-20 Thread Francois Romieu
Lennert Buytenhek [EMAIL PROTECTED] : [...] The hack patch below makes it work. There's two issues here: 1. Writing zero to the upper part of the TxDescStartAddr register (via the MMIO region) somehow also clears the lower part, and writing the upper and lower halves the other way

Re: [PATCH 5/7] ip1000: Modify coding style of ipg_config_autoneg()

2006-08-19 Thread Francois Romieu
Jesse Huang [EMAIL PROTECTED] : From: Jesse Huang [EMAIL PROTECTED] This is only coding style modify for ipg_config_autoneg(). Thanks for the suggestion form Francois. Change Logs: Modify coding style of ipg_config_autoneg() --- drivers/net/ipg.c | 17 ++--- 1

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-02 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : Mezigues : [...] Does the platform guarantees that the register write has actually reached the real register when the udelay is issued ? I think so, but maybe you can help me check. The LAN911x device is always directly connected to a simple

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-08-02 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] Sorry, to pester you, but I was wondering if you had a chance to look at the register dump. No problem. It would have been easier with a decoded output of the register dump though (see Lennert dump below). Lines prefixed by '' come from Realtek's

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Francois Romieu
Lennert Buytenhek [EMAIL PROTECTED] : [...] We're currently working on getting the Thecus n2100 supported in 2.6. http://www.thecus.com/products_over.php?cid=1pid=1 I should really write some wish-list one day... Amongst other nice goodies, it has two on-board RTL8110SB gigabit

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Francois Romieu
Martin Michlmayr [EMAIL PROTECTED] : [...] Here's the output using the r8169 driver: RealTek RTL-8110 registers: -- The (untested) patch below should apply to the source code that Realtek included in linux-r1000(103).zip, wherence supporting the extraction of the

Re: SMSC LAN911x and LAN921x vendor driver

2006-07-28 Thread Francois Romieu
[...] diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c new file mode 100644 index 000..12bbe67 --- /dev/null +++ b/drivers/net/smsc911x.c [...] +/* Tasklet declarations */ +static unsigned long rx_tasklet_parameter; +static void smsc911x_rx_tasklet(unsigned long data); +

Re: Hello, We have IP100A Linux driver need to submit to 2.6.x kernel

2006-07-27 Thread Francois Romieu
Jesse Huang [EMAIL PROTECTED] : [...] I am IC Plus software engineer. We have IP100A 10/100 fast network adapter driver need to submit to Linux 2.6.x kernel. Please tell me who should I submit to. IP100A's device ID is 0x13f0 0200. You do not need to do anything:

Update of the r8169 branch

2006-07-26 Thread Francois Romieu
of the 8167 and 8136 is not known in this regard. Signed-off-by: Francois Romieu [EMAIL PROTECTED] commit 4ff96fa67379c31ced69f193c7ffba17051f38e8 r8169: remove rtl8169_init_board Rationale: - its signature is not exactly pretty; - it has no knowledge of pci_device_id

Re: [PATCH] via-velocity: fix reported speed and link detected status

2006-07-20 Thread Francois Romieu
Jay Cliburn [EMAIL PROTECTED] : The via-velocity driver reports incorrect speed and link detected status as viewed by ethtool (and probably other tools). This patch fixes those incorrect reports and prettifies a long line. Looks fine. Fixed the whitespace/tabs damage, the 190 cols comment

Re: [RFT] Realtek 8168 ethernet support

2006-07-18 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : The patch below agaisnt 2.6.17-rc6 includes the following changes: commit 3072cc0aba3ac0c944e196a63c4154ca5746ec0b r8169: sync with vendor's driver - add several PCI ID for the PCI-E adapters ; - new identification strings

[mini-RFT] via-velocity cleanup

2006-07-04 Thread Francois Romieu
Against 2.6.17: http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.17/via-velocity/ The mii operations look now more familiar. There should be no functional change. The patches do not clash with Jeff's netdev-2.6#upstream. Please report if I have broken something. -- Ueimor - To unsubscribe from

Re: rtl8139: NETDEV WATCHDOG: eth0: transmit timed out

2006-07-01 Thread Francois Romieu
Marcus Better [EMAIL PROTECTED] : I'm seeing this problem on my Acer Travelmate 223X laptop with built-in Realtek 8139: The ethernet stops working, usually after at most a few minutes operation. The problem appears in kernel 2.6.16 and 2.6.17, but not in 2.6.15. Broken again :o( In a better

Re: [PATCH 8/9] pcnet32: NAPI implementation.

2006-06-30 Thread Francois Romieu
Don Fry [EMAIL PROTECTED] : [...] No need to save/restore (it's true in pcnet32_{get_regs/suspend} too). This lock is taken by the interrupt handler and my reading of spinlocks.txt says I do need to use spin_lock_irqsave unless I misunderstand. The only spin_lock() is in the interrupt

Re: PATCH SB1250 NAPI support

2006-06-29 Thread Francois Romieu
Tom Rix [EMAIL PROTECTED] : [...] diff -rup a/drivers/net/sb1250-mac.c b/drivers/net/sb1250-mac.c --- a/drivers/net/sb1250-mac.c 2006-03-09 04:25:41.0 -0600 +++ b/drivers/net/sb1250-mac.c 2006-03-09 05:30:52.0 -0600 [...] @@ -2079,13 +2095,31 @@ static irqreturn_t sbmac_intr(int

Re: [PATCH 8/9] pcnet32: NAPI implementation.

2006-06-29 Thread Francois Romieu
Nit below. Don Fry [EMAIL PROTECTED] : [...] --- linux-2.6.17-git13/drivers/net/purge.pcnet32.cThu Jun 29 13:28:24 2006 +++ linux-2.6.17-git13/drivers/net/pcnet32.c Thu Jun 29 13:28:31 2006 [...] +#ifdef CONFIG_PCNET32_NAPI +static int pcnet32_poll(struct net_device *dev, int *budget)

Re: [Repost PATCH 6/6] PMC MSP85x0 gigabit ethernet driver

2006-06-27 Thread Francois Romieu
Kiran Thota [EMAIL PROTECTED] : [...] +/* + * Allocate the SKBs for the Rx ring. Also used + * for refilling the queue + */ + +static int msp85x0_ge_rx_task(struct net_device *netdev, + msp85x0_ge_port_info *msp85x0_ge_eth) +{ + struct device *device =

Re: [Repost PATCH 6/6] PMC MSP85x0 gigabit ethernet driver

2006-06-26 Thread Francois Romieu
Kiran Thota [EMAIL PROTECTED] : [...] - Based on linux-2.6.12 from http://www.linux-mips.org/pub/linux/mips/kernel/v2.6/linux-2.6.12.tar.gz Is there a reason why the patch is not diffed against a more recent version of the mips tree ? The patch includes ~130 lines ending with a tab or space

Pull request for 'upstream' branch

2006-06-22 Thread Francois Romieu
Please pull from branch 'upstream' to get the change below: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Patch applies to jeff#upstream, jeff#upstream-fixes and jeff#upstream-linus. Shortlog Roy Marples: via-velocity: the link is not correctly detected when the

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Francois Romieu
Ron Mercer [EMAIL PROTECTED] : [...] Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. $ less qla3xxxpatch1-v2.02.00-k31.txt [...] + * See LICENSE.qla3xxx for copyright and licensing details. 1 - The patch contains no such file (though the file is MODULE_LICENSE(GPL)).

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-15 Thread Francois Romieu
Grant Grundler [EMAIL PROTECTED] : [shared irq] I thought we've worked through that already: http://www.spinics.net/lists/netdev/msg05902.html Patch v3 takes care of that problem. The first step in the sequence is to mask IRQs on the tulip. The neighbor device sharing the IRQ will not

Pull request for 'upstream' branch

2006-06-15 Thread Francois Romieu
Please pull from branch 'upstream' to get the change below: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Patch applies both to jeff#upstream and jeff#upstream-fixes Shortlog Pedro Alejandro López-Valencia: sundance: PCI ID for ip100a Patch - diff --git

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Francois Romieu
Grant Grundler [EMAIL PROTECTED] : [...] I'm not keen on adding more code to tulip_interrupt() routine for something that rarely happens (compared to IRQs) and is handled outside the interrupt routine. I'm pretty sure stopping interrupts before stopping DMA is sufficient. Can you show an

Re: [RFT] Realtek 8168 ethernet support

2006-06-12 Thread Francois Romieu
Mourad De Clerck [EMAIL PROTECTED] : [...] I just tried this patch set, but it doesn't do anything for the freeze at high speed I mentioned on 2006-06-09. It still locks up. (As an additional data point: I installed win2k on this machine, and it seems to have no problems transferring at high

Re: [RFT] Realtek 8168 ethernet support

2006-06-12 Thread Francois Romieu
Mourad De Clerck [EMAIL PROTECTED] : [...] I do notice a pattern with more and less complicated/cpu intensive traffic: using http (wget) I manage to finish doing the transfer of the same reasonably big file. With scp I only manage to get to 90% of that file before it freezes - I should still

Re: [RFT] Realtek 8168 ethernet support

2006-06-11 Thread Francois Romieu
not help: be it under BSD or Linux, their r1000 driver include a USE_IO_SPACE #define but the bar address is always hardcoded to 1 in the MM case. :o/ Signed-off-by: Francois Romieu [EMAIL PROTECTED] commit 33857396c4f7d171f4ccaca86356df5fe2fdd304 r8169: remove

Re: [RFT] Realtek 8168 ethernet support

2006-06-10 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : Francois Romieu wrote: Jeff Garzik [EMAIL PROTECTED] : Randy.Dunlap wrote: Conversely, any reason to use the RealTek r1000 driver? FWIW, RealTek emailed me about merging r1000. I suggested that, if the Which one ? r1000_n.c where #define RELEASE_DATE

Re: [RFT] Realtek 8168 ethernet support

2006-06-10 Thread Francois Romieu
Francois Romieu [EMAIL PROTECTED] : [...] - the != ... ... != test above seems inverted. Answering to myself: yes, it is. The 8100 and 8101 are PCI Express fast ethernet only (but they should do 802.1q, go figure). -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev

Re: [RFT] Realtek 8168 ethernet support

2006-06-09 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : Randy.Dunlap wrote: Conversely, any reason to use the RealTek r1000 driver? FWIW, RealTek emailed me about merging r1000. I suggested that, if the Which one ? r1000_n.c where #define RELEASE_DATE 2006/02/23 -- Ueimor - To unsubscribe from this list: send

Re: [RFT] Realtek 8168 ethernet support

2006-06-08 Thread Francois Romieu
Randy.Dunlap [EMAIL PROTECTED] : [...] static struct pci_device_id r1000_pci_tbl[] __devinitdata = { { 0x10ec, 0x8169, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, { 0x10ec, 0x8167, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, { 0x10ec, 0x8168, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, { 0x10ec,

[PATCH] TCP: removal of unused label

2006-06-05 Thread Francois Romieu
Signed-off-by: Francois Romieu [EMAIL PROTECTED] diff --git a/net/ipv4/tcp_compound.c b/net/ipv4/tcp_compound.c index bc54f7e..a3c36c0 100644 --- a/net/ipv4/tcp_compound.c +++ b/net/ipv4/tcp_compound.c @@ -401,6 +401,7 @@ static void tcp_compound_cong_avoid(stru static void

[RFT] r8169: MAC address change support

2006-06-01 Thread Francois Romieu
It works fine here (x86 so far) but I would welcome more testers. The patch applies against 2.6.17-rcX. diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 0ad3310..4208d9a 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1381,6 +1381,41 @@ static void

Re: [RFT] Realtek 8168 ethernet support

2006-06-01 Thread Francois Romieu
Daniel Drake [EMAIL PROTECTED] : [...] @@ -1442,20 +1444,24 @@ rtl8169_init_board(struct pci_dev *pdev, } } - /* make sure PCI base addr 1 is MMIO */ - if (!(pci_resource_flags(pdev, 1) IORESOURCE_MEM)) { - if (netif_msg_probe(tp)) { -

Re: [RFC PATCH 1/2] Hardware button support for Wireless cards: radiobtn

2006-05-30 Thread Francois Romieu
Ivo van Doorn [EMAIL PROTECTED] : [...] diff --git a/drivers/input/misc/radiobtn.c b/drivers/input/misc/radiobtn.c new file mode 100644 index 000..8d3b84a --- /dev/null +++ b/drivers/input/misc/radiobtn.c [...] +void radiobtn_poll(unsigned long data) static ? [...] +int

Re: [PATCH] r8169: add new PCI ID

2006-05-27 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : [...] applied $ grep 8129 drivers/net/*.[ch] [...] drivers/net/8139too.c: {0x10ec, 0x8129, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 } Not a big issue but I would be really surprized that it does trigger a few PR. -- Ueimor - To unsubscribe from this list: send

Re: [PATCH] via-velocity: allow MTU size less than 1500 bytes

2006-05-27 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : [...] ACK, but patch won't apply: I have regenerated it against mainline. It can be pulled from the repository git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git velocity -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: reminder, 2.6.18 window...

2006-05-25 Thread Francois Romieu
Phil Dibowitz [EMAIL PROTECTED] : [...] Right. I think the point here is that it does _NOT_ inherently break things. If you don't like the behavior, don't run ethtool -z eth0, it's that simple. It would be better to explain why several sysadmins want this feature and why it can't be done in an

Re: [PATCH 1/4] b44: add wol and setup for later 4401

2006-05-24 Thread Francois Romieu
Gary Zambrano [EMAIL PROTECTED] : This patch adds set and get functions and support for the later 4401 revs. Signed-off-by: Gary Zambrano [EMAIL PROTECTED] diff --git a/drivers/net/b44.c b/drivers/net/b44.c index 7b3dfc4..e42e0aa 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c

Re: [PATCH 2/4] b44: wol setup for older 4401

2006-05-24 Thread Francois Romieu
Gary Zambrano [EMAIL PROTECTED] : [...] diff --git a/drivers/net/b44.c b/drivers/net/b44.c index b9e2462..6f4d1d4 100644 --- a/drivers/net/b44.c +++ b/drivers/net/b44.c [...] +static void b44_setup_pseudo_magicp(struct b44 *bp) +{ + + u32 val; + int plen0, plen1, max, i, j; +

Re: [PATCH] via-velocity: allow MTU size less than 1500 bytes

2006-05-23 Thread Francois Romieu
Jay Cliburn [EMAIL PROTECTED] : Change the minimum allowable MTU size from 1500 bytes to 64 bytes. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] Fine-With-Me: Francois Romieu [EMAIL PROTECTED] -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-13 Thread Francois Romieu
Brice Goglin [EMAIL PROTECTED] : [...] Return in a middle of a spinlock-intensive function. :o( What do you mean ? It is preferred for maintenance purpose (hello Mr Morton) to organize the control flow with a single spin_{lock/unlock} pair: if there is a branch in the control flow, it

[PATCH] dl2k: use explicit DMA_48BIT_MASK

2006-05-10 Thread Francois Romieu
Typo will be harder with this one. Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/dl2k.c | 13 ++--- include/linux/dma-mapping.h |1 + 2 files changed, 7 insertions(+), 7 deletions(-) 5019a27a2a4e259f29a7bd03e905764eedfa034c diff --git a/drivers/net

Re: r8169+NAPI soft lockup

2006-05-10 Thread Francois Romieu
Richard Gregory [EMAIL PROTECTED] : [...] # locked in 1 min. Output in bug5.txt $ for i in `seq 0 26` ; do cat /dev/md1 /dev/tcp/linuxbox/9 $ cat /dev/md0 /dev/tcp/localhost/9 Can you replace /dev/tcp/foo with a simple /dev/null and send the output of 'vmstat 1' during 2 minutes of test ?

Re: [PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Francois Romieu
Brice Goglin [EMAIL PROTECTED] : [PATCH 3/6] myri10ge - Driver header files myri10ge driver header files. myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h is automatically generated from our firmware image. Signed-off-by: Brice Goglin [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Francois Romieu
Brice Goglin [EMAIL PROTECTED] : [PATCH 4/6] myri10ge - First half of the driver The first half of the myri10ge driver core. Signed-off-by: Brice Goglin [EMAIL PROTECTED] Signed-off-by: Andrew J. Gallatin [EMAIL PROTECTED] myri10ge.c | 1483

Re: r8169+NAPI soft lockup

2006-05-09 Thread Francois Romieu
Richard Gregory [EMAIL PROTECTED] : I'm seeing the crash below using 2.6.16.11 custom based on RedHat FC2. The main culprit being the r8169+NAPI module, although the it821x module (with noraid=1) seems to bring out the bug, maybe because it uses the same interrupt. (lot of things to

Re: r8169+NAPI soft lockup

2006-05-09 Thread Francois Romieu
Richard Gregory [EMAIL PROTECTED] : Francois Romieu wrote: [...] Is netconsole enabled ? It can be. How much output do you need, a single soft lockup? Nonononono. Keep it disabled. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: r8169: only works in 10mbit/half duplex

2006-05-09 Thread Francois Romieu
Johannes Berg [EMAIL PROTECTED] : [...] I'm thinking this is a hardware failure, is there any reason to believe otherwise? It's hard to tell without data. It could be any of the usual suspects or a genuine bug. Can you send the complete dmesg from boot + lspci -vvx + /proc/interrupts of the

Re: r8169+NAPI soft lockup

2006-05-09 Thread Francois Romieu
Richard Gregory [EMAIL PROTECTED] : [...] Can you send me your drivers/ide/ide-io.o ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Hardware flow control on RTL8169

2006-05-08 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : [...] I'm using a kurobox (www.kurobox.com) with a 2.6.15 kernel and I'd like to use hardware flow control with it. However it seems the driver doesn't support it, is that correct ? At least I see the device continue sending even when the other device is

Re: [PATCH] phy: new SMSC LAN83C185 PHY driver

2006-05-07 Thread Francois Romieu
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c new file mode 100644 index 000..b96eb52 --- /dev/null +++ b/drivers/net/phy/smsc.c [...] +/* prototypes */ +static int lan83c185_config_init(struct phy_device *); +static int lan83c185_config_intr(struct phy_device *);

Re: Fwd: r8169 MAC address change problem

2006-05-04 Thread Francois Romieu
Stefano Cavallari [EMAIL PROTECTED] : I sent this to netdev@vger.kernel.org, but I got no replies. I am subscribed to netdev but the original has not landed in my mailbox yet. Can you try the patch available in: http://bugzilla.kernel.org/show_bug.cgi?id=6032 -- Ueimor - To unsubscribe from

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
in branch 'netdev-ipg' at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git Former branch 'netdev-ipg' was moved to 'netdev-ipg.log'. I have added a new patch (see (way) below). $ git log master.. commit 17adeb85054a693224a2ab7787a224c722bdd4eb Author: Francois Romieu [EMAIL PROTECTED

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-04 Thread Francois Romieu
David Vrabel [EMAIL PROTECTED] : [...] ipg: replace #define with enum Added some underscores to improve readability. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Nack. Register names in code should match those used in the documentation (even if they are a bit

Re: [PATCH 2/2] ipg: redundancy with mii.h

2006-05-03 Thread Francois Romieu
: http://www.fr.zoreil.com/people/francois/misc/20060504-2.6.17-rc3-git-ip1000-test.patch ChangeLog from yesterday version: commit 8b0a8db32d1ac6e9bc23300a6a0533b4d7e251e3 Author: Francois Romieu [EMAIL PROTECTED] Date: Thu May 4 00:29:59 2006 +0200 ipg: remove forward declarations

Re: [PATCH 2/3] ipg: leaks in ipg_probe

2006-05-02 Thread Francois Romieu
Pekka J Enberg [EMAIL PROTECTED] : [...] Is this tested with hardware? No. Alignment of the start address looks bogus for sure, but any idea why they had it in the first place? No clear idea but it matches the significant part of the BAR register for the 256 bytes of I/O space that the

Re: forcedeth driver NAPI?

2006-05-02 Thread Francois Romieu
Andi Kleen [EMAIL PROTECTED] : On Tuesday 02 May 2006 21:11, Stephen Hemminger wrote: [napi for forcedeth] Making it support netpoll would be nice too. wishlist Disable/resume the device with something less gross than http://bugzilla.kernel.org/show_bug.cgi?id=6398 /wishlist -- Ueimor - To

[PATCH 2/3] ipg: leaks in ipg_probe

2006-05-01 Thread Francois Romieu
The error paths are badly broken. Bonus: - remove duplicate initialization of sp; - remove useless NULL initialization of dev; - USE_IO_OPS is not used (and the driver does not seem to care about posted writes, rejoice). Signed-off-by: Francois Romieu [EMAIL PROTECTED] --- drivers/net/ipg.c

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Francois Romieu
Ivo van Doorn [EMAIL PROTECTED] : From: Ivo van Doorn [EMAIL PROTECTED] This adds the rt61pci driver to the tree Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] Available on server: http://mendiosus.nl/rt2x00/rt61pci.diff It is nice that you are doing this work but I still don't feel

Re: [PATCH 2/3] rt2x00 drivers: rt61pci

2006-04-29 Thread Francois Romieu
Ivo van Doorn [EMAIL PROTECTED] : [...] Not sure about that either. I usually choose the type of the counter depending on the max size of that counter. It is not arch-neutral. powerpc favors unsigned int over int but I am too lazy to check if the size matters. [...] Perhaps, but I prefer the

Re: IP1000 gigabit nic driver

2006-04-27 Thread Francois Romieu
David G??mez [EMAIL PROTECTED] : [...] Does anybody in this list know why the IP1000 driver is not included in the kernel ? Afaik the driver has never been submitted for inclusion. At least not on netdev@vger.kernel.org (hint, hint). [...] The card in question is: Sundance Technology Inc

Re: [PATCH 2/5] sky2: add fake idle irq timer

2006-04-25 Thread Francois Romieu
Stephen Hemminger [EMAIL PROTECTED] : [...] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:48:47.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c2006-04-25 10:53:32.0 -0700 @@ -2086,6 +2086,20 @@ } } +/* If idle then force a fake soft NAPI poll once a

Re: [PATCH 2/5] sky2: add fake idle irq timer

2006-04-25 Thread Francois Romieu
Stephen Hemminger [EMAIL PROTECTED] : [...] Any objection against moving mod_timer() from sky2_poll() to sky2_idle() so as to keep poll() path unmodified ? If traffic is moving, then I want the timer to keep getting rescheduled farther out. If my version of the driver is not stale, the

Re: [patch 2/5] s2io driver updates

2006-04-22 Thread Francois Romieu
Ananda Raju [EMAIL PROTECTED] : [...] Signed-off-by: Ananda Raju [EMAIL PROTECTED] --- diff -upNr perf_fixes/drivers/net/s2io.c dmesg_param_fixes/drivers/net/s2io.c --- perf_fixes/drivers/net/s2io.c 2006-04-13 08:02:56.0 -0700 +++ dmesg_param_fixes/drivers/net/s2io.c

Re: [PATCH 01/11] ixgb: Fix compilation errors by initializing variables

2006-04-22 Thread Francois Romieu
Jeff Kirsher [EMAIL PROTECTED] : diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c index cfd67d8..0b9481a 100644 --- a/drivers/net/ixgb/ixgb_main.c +++ b/drivers/net/ixgb/ixgb_main.c [...] @@ -346,7 +346,7 @@ ixgb_probe(struct pci_dev *pdev, const struct

Re: [PATCH 03/11] ixgb: Fix hard coded numbers

2006-04-22 Thread Francois Romieu
Jeff Kirsher [EMAIL PROTECTED] : [...] diff --git a/drivers/net/ixgb/ixgb_ethtool.c b/drivers/net/ixgb/ixgb_ethtool.c index e8d83de..978be30 100644 --- a/drivers/net/ixgb/ixgb_ethtool.c +++ b/drivers/net/ixgb/ixgb_ethtool.c [...] diff --git a/drivers/net/ixgb/ixgb_main.c

Re: [PATCH 02/11] ixgb: Fix the use of dprintk rather than printk

2006-04-22 Thread Francois Romieu
Jeff Kirsher [EMAIL PROTECTED] : [...] diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h index c83271b..a696c33 100644 --- a/drivers/net/ixgb/ixgb.h +++ b/drivers/net/ixgb/ixgb.h [...] @@ -192,6 +197,7 @@ struct ixgb_adapter { /* structs defined in ixgb_hw.h */

Re: [patch 08/10] bcm43xx: sysfs code cleanup

2006-04-19 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : From: Michael Buesch [EMAIL PROTECTED] This cleans up the bcm43xx sysfs code and makes it compliant with the unwritten sysfs rules (at least I hope so). Signed-off-by: Michael Buesch [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Greg KH

Re: [patch 08/10] bcm43xx: sysfs code cleanup

2006-04-19 Thread Francois Romieu
Michael Buesch [EMAIL PROTECTED] : [...] the deleted code parses binary input. The new code parses human readable hex input. No offence intended but it was not clear from the description of the patch. pavlov Does it imply an user space visible API change ? /pavlov -- Ueimor - To unsubscribe

Re: [patch 08/10] bcm43xx: sysfs code cleanup

2006-04-19 Thread Francois Romieu
Michael Buesch [EMAIL PROTECTED] : [...] Yes it does, but: * We did not release a stable kernel with it in the meantime. * There is no software using it at the moment. (Well, the bcm43xx-sprom tool is kind of using it, but it can handle both binary and hex input anyway) Ok. Thanks for

Re: r8169 locks up in 2.6.16.5

2006-04-17 Thread Francois Romieu
Thomas A. Oehser [EMAIL PROTECTED] : [...] Ok, here it all is, the attached archive has: - .before is right after the interface came up - .mid is after flooding it with ping -f commands from 2 machines at once - .bad is after doing the cpio over nc that killed it after 170MB - .back is

Re: r8169 locks up in 2.6.16.5

2006-04-16 Thread Francois Romieu
Thomas A. Oehser [EMAIL PROTECTED] : [...] I tested with everything turned off (no SMP, no swap, no USB, no firewire, no iptables, no lmsensors, flat 1G memory, etc. etc. etc.) except the bare minimum (LSI new Megaraid for the SCSI and SATA raid arrays, both of which use the same driver, EXT3,

<    2   3   4   5   6   7   8   9   >