Re: [PATCH net-next 1/7] net: stmmac: set MSS for each tx DMA channel

Hi Niklas I had a look at this series that looks ok for me. Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> On 2/19/2018 6:11 PM, Niklas Cassel wrote: The DMA engine in dwmac4 can segment a large TSO packet to several smaller packets of (max) size Maximum Segment Size (MSS). T

Re: [PATCH net-next v2] net: stmmac: Fix reception of Broadcom switches tags

). To be as little invasive as possible, this is only done for gmac1000 when the network device is DSA-enabled (netdev_uses_dsa() returns true). Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- Changes in v2: - fixed b

Re: [PATCH net-next] net: stmmac: Fix reception of Broadcom switches tags

Hi Florian for gmac4.x and gmac3.x series the ACS bit is the Automatic Pad or CRC Stripping, so the core strips the Pad or FCS on frames if the value of the length field is < 1536 bytes. For MAC10-100 there is the Bit 8 (ASTP) of the reg0 that does the same if len is < 46bytes. In your patch

Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

--Original Message----- From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com] Sent: Thursday, November 23, 2017 11:58 AM To: Bhadram Varka <vbhad...@nvidia.com>; joao.pi...@synopsys.com Cc: linux-netdev <netdev@vger.kernel.org> Subject: Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): tran

Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

in TQS/RQS fields Thanks, Bhadram. -Original Message- From: Giuseppe CAVALLARO [mailto:peppe.cavall...@st.com] Sent: Monday, November 20, 2017 6:37 PM To: Bhadram Varka <vbhad...@nvidia.com>; joao.pi...@synopsys.com Cc: linux-netdev <netdev@vger.kernel.org> Subject: Re: NETDEV WA

Re: NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

Hello Bhadram there are some new patches actually in net/net-next repo that you should have; for example: [PATCH net-next v2 0/2] net: stmmac: Improvements for multi-queuing and for AVB Let me know if these help you. Regards Peppe On 11/20/2017 7:38 AM, Bhadram Varka wrote: Hi

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hello On 10/27/2017 11:05 AM, Jose Abreu wrote: I think we should take advantage of the fact that this is working and ready to be merged. Its just HW configuration but maybe it can serve as momentum for other drivers to also integrate this? Let me propose to have it now in the next-next.

Re: [PATCH net-next v2 0/2] net: stmmac: Improvements for multi-queuing and for AVB

Yes you need these settings, thx for these patches. Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> On 10/13/2017 11:58 AM, Jose Abreu wrote: Hi, Two improvements for stmmac: First one corrects the available fifo size per queue, second one corrects enabling of AVB queues. Mor

Re: [PATCH] net: ethernet: stmmac: Convert timers to use

On 10/5/2017 2:50 AM, Kees Cook wrote: In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Giuseppe Cavallaro <peppe.cavall...@st.com> Cc: Ale

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hi Thomas On 7/29/2017 9:54 PM, Thomas Petazzoni wrote: Hello Giuseppe, On Wed, 28 Jun 2017 16:40:51 +0200, Giuseppe CAVALLARO wrote: I do not want to change a critical reset function shared among different platforms where this problem has never met but you are right that we have to find

Re: [PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer

.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/s

Re: [PATCH 2/3] net: stmmac: Fix error handling path in 'alloc_dma_tx_desc_resources()'

he JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/e

Re: [PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()'

he JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/e

Re: [PATCHv2 1/3] ethtool: stmmac: Fix Designware ethtool register dump

e DMA registers at the DMA register offset (0x1000) but ethtool (stmmac.c) looks for the DMA registers after the MAC registers which is offset 12. This patch adds the DMA register offset so that indexing is correct. Signed-off-by: Thor Thayer <thor.tha...@linux.intel.com> Acked-

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

, On Mon, 15 May 2017 16:27:34 +0200, Thomas Petazzoni wrote: On Wed, 10 May 2017 09:18:17 +0200, Thomas Petazzoni wrote: On Wed, 10 May 2017 09:03:12 +0200, Giuseppe CAVALLARO wrote: Please, read again my patch and the description of the problem that I have sent. But basically, any

Re: [PATCH 2/2] ethtool: stmmac: Add DMA HW Feature Register

this kind of changes Sorry if I didn't it in the past. the, you can send the series with my Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> Regards peppe fprintf(stdout, "Reg%d 0x%08X\n", i, *stmmac_reg++); return 0;

Re: [PATCH] net: stmmac: Add additional registers for dwmac1000_dma ethtool

s Mode Register Offset 11 - AHB or AXI Status Register Offset 22 - HW Feature Register Signed-off-by: Thor Thayer <thor.tha...@linux.intel.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c | 4 ++-- drivers/net/ether

Re: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

Hi Joao On 6/8/2017 8:02 PM, Joao Pinto wrote: This patch fixes the description of the DT AVB parameters and gives an accurate example. It was also included the base values that were used to get the example' CBS paremeter values. Signed-off-by: Joao Pinto ---

Re: [PATCH net] net: stmmac: fix completely hung TX when using TSO

as...@axis.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ma

Re: Stmmac: fix for hw timestamp of GMAC 3 unit

Hi Mario thanks for your tests, and, at first glance, your patches seem to be sensible so, please, send the changes as patches for net.git kernel. Regards Peppe On 6/6/2017 12:11 AM, Mario Molitor wrote: Dear stmmac maintainer group, I have found an problem in stmmac driver of linux

Re: [PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

for this fix. Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/altr_tse_pcs.c b/drivers/net/ethernet/stmicro/stmmac/al

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hi Thomas On 5/8/2017 9:12 PM, Thomas Petazzoni wrote: Hello, On Mon, 8 May 2017 16:28:21 +0200, Giuseppe CAVALLARO wrote: I just see that GMAC_CONTROL and MAC_CTRL_REG are the same, so why not create a custom adjust_link for each dwmac type ? This will permit to call it instead of set_ps

Re: [PATCH 0/4] net: stmmac: Fine-tuning for four function implementations

main.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello On 5/3/2017 4:30 PM, Corentin Labbe wrote: On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote: Hello Thomas this was initially set by using the hw->link.port; both the core_init and adjust callback should invoke the hook and tuning the PS bit according to the sp

Re: [PATCH v1 1/4] stmmac: pci: set default number of rx and tx queues

/* Set the maxmtu to a default of JUMBO_LEN */ plat->maxmtu = JUMBO_LEN; + /* Set default number of RX and TX queues to use */ + plat->tx_queues_to_use = 1; + plat->rx_queues_to_use = 1; + return 0; } For the Series, please consider my Acked-by: Giuseppe

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello Thomas this was initially set by using the hw->link.port; both the core_init and adjust callback should invoke the hook and tuning the PS bit according to the speed and mode. So maybe the ->set_ps is superfluous and you could reuse the existent hook let me know Regards peppe On

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = []; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii"; Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

e used for a single packet, the field should be set to the sum of the buffers contained in: [ ... ... ], which should be equal to skb->len. Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmm

Re: [PATCH net-next v2] bindings: net: stmmac: add missing note about LPI interrupt

Hi Niklas On 4/10/2017 9:43 AM, Niklas Cassel wrote: From: Niklas Cassel The hardware has a LPI interrupt. There is already code in the stmmac driver to parse and handle the interrupt. However, this information was missing from the DT binding. i wonder if we could

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

Hi Niklas patch looks ok for me, Alex any feedback? peppe On 4/10/2017 8:33 PM, Niklas Cassel wrote: From: Niklas Cassel Field FL/TPL in register TDES3 is not correctly set on GMAC4. TX appears to be functional on GMAC 4.10a even if this field is not set, however, to

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 4/3/2017 3:12 PM, Joao Pinto wrote: Yes older cores do not support multiple queues and I tried to isolate the features not to affect older versions. ok so we are inline ;-) Do you think that functions as "ndev = alloc_etherdev_mqs" has some sort of influence? I do not think

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Joao On 3/30/2017 6:42 PM, Joao Pinto wrote: Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: On 03/30/2017 04:34 PM, Thierry Reding wrote: On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH v3 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr

Hello Alex do you can check if this has to be done for ST platforms? I do not remember that it was necessary when build as module so I cannot expect this should be only for dwmac-sun8i. Regards peppe On 4/3/2017 11:14 AM, Corentin Labbe wrote: Thoses symbol will be needed for the

Re: [PATCH v3 02/20] net: stmmac: add optional setup function

Hello Corentin On 4/3/2017 11:14 AM, Corentin Labbe wrote: Instead of adding more ifthen logic for adding a new mac_device_info setup function, it is easier to add a function pointer to the function needed. Signed-off-by: Corentin Labbe ---

Re: stmmac still supporting spear600 ?

Hi Thomas I tested the SMSC on other platform (+ stmmac), not on SPEAr. ok for reset, keep the radar on clock. Hmm, can you attach a piece of log file to see the failure? Regards Peppe On 4/2/2017 11:30 PM, Thomas Petazzoni wrote: Hello, On Thu, 23 Mar 2017 11:33:23 +0100, Giuseppe

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote: Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hello On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using in order for me to reproduce >in my side? Joao, you have a really powerful HW integration with multiple channels for

Re: stmmac still supporting spear600 ?

Hello Thomas On 3/21/2017 3:50 PM, Thomas Petazzoni wrote: Hello, On Thu, 9 Mar 2017 15:56:31 +0100, Giuseppe CAVALLARO wrote: On 3/9/2017 10:32 AM, Thomas Petazzoni wrote: OK, I'll have a look. However, I'm still confused by this DMA_RESET bit that never clears, contrary to what

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hello Corentin yes, bisect process is really good approach to me. Pls give us more details. Recently the multi DMA channel logic has been added so it could be that something is needed to allow your platform to manage the new code. Or we introduced some regression. If I have some other idea, I

Re: linux-next-20170320 break stmmac on dwmac-sunxi

+ Joao please Joao, could you do a check if new changes have any impact on that? peppe On 3/20/2017 8:54 PM, Corentin Labbe wrote: Hello Just pushed next-20170320 to my boards and stmmac stop working on both intree dwmac-sunxi and my dev dwmac-sun8i. It seems that interrupts never fire, and

Re: stmmac still supporting spear600 ?

Hello Thomas On 3/9/2017 10:32 AM, Thomas Petazzoni wrote: OK, I'll have a look. However, I'm still confused by this DMA_RESET bit that never clears, contrary to what the datasheet says. Are there some erratas? I suggest you to take a look at the tx/rx clocks from PHY. You have to provide

Re: stmmac still supporting spear600 ?

Hello We do not test stmmac on this spear board since many years and I guess you have to provide parameters from the platform. In fact, stmmac is recently tested with DT. IIRC, the mac on spear600 could not have the HW cap register so it is mandatory to provide all the right parameters and

Re: [PATCH RFC] net: stmmac: unify registers dumps methods

regs" to "fill the reg_space used by ethtool". Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Thx I find it really useful, Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 4 +- .../net/ethernet

Re: [PATCH 0/8] net: stmmac: misc patchs

On 2/15/2017 8:39 AM, Corentin Labbe wrote: Since all patch in v2 already hit linux-next, I just want to be sure, I can add "Acked-by and Reviewed-by" to thoses 8 new patchs ? Right I have just seen the V2 patches are in net-next. pls consider, for this set, my Acked-by: Giuseppe

Re: [PATCH 0/8] net: stmmac: misc patchs

Hello Corentin On 2/14/2017 8:54 PM, Corentin Labbe wrote: Hello This is a follow up of my previous stmmac serie which address some comment done in v2. I wonder if you can resend all the patches as V3 please add the Acked-by and Reviewed-by. This will help on final review and integration.

Re: Performance in stmmac

Hi Joao On 2/7/2017 8:33 PM, Joao Pinto wrote: I am seeing tx being performed in all queues, but rx is just being routed to queue 0. The reason why only queue 0 is processing the packets is because I am using priority tagged routing for now and iperf is not capable of producing priority tagged

Re: [PATCH v2 04/16] net: stmmac: remove freesoftware address

On 2/8/2017 9:31 AM, Corentin Labbe wrote: This patch fix the checkpatch warning about free software address. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> just wonder if this should be sent separately for net-next instead of Anyway... Acked-by: Giuseppe Cavallaro <pep

Re: [PATCH v2 08/16] net: stmmac: Use readl_poll_timeout

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The dwmac_dma_reset function use an open coded of readl_poll_timeout(). Replace the open coded handling with the proper function. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: [PATCH v2 13/16] net: stmmac: print phy information

On 2/8/2017 9:31 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/

Re: [PATCH v2 10/16] net: stmmac: Correct the error message about invalid speed

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The message about invalid speed does not state 1000 as a valid speed. It is much simpler to said that the speed is invalid. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com>

Re: [PATCH v2 02/16] net: stmmac: Remove the bus_setup function pointer

On 2/8/2017 9:31 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. no longer used... Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: stmmac: GMAC_RGSMIIIS reports bogus values

Hello Alexey On 1/31/2017 2:24 PM, Alexey Brodkin wrote: Hi Giuseppe, On Tue, 2017-01-31 at 10:55 +0100, Giuseppe CAVALLARO wrote: On 1/27/2017 11:23 AM, Alexey Brodkin wrote: That's why my initial proposal was to ignore whatever we read from this register if we have MDIO bus instantiated

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

re SMA block is used if yes, pls consider my: Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 33 --- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmm

Re: [PATCH 03/17] net: stmmac: fix some typos in comments

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch fix some typos in comments. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac_lib.c | 6 +++--- drivers/

Re: [PATCH 07/17] net: stmmac: replace stmmac_mdio_busy_wait by readl_poll_timeout

On 1/31/2017 11:39 AM, Corentin Labbe wrote: On Tue, Jan 31, 2017 at 11:13:49AM +0100, Giuseppe CAVALLARO wrote: On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac_mdio_busy_wait() function do the same job than readl_poll_timeout(). So is is better to replace it. Signed-off-by: Corentin

Re: [PATCH 15/17] net: stmmac: remove dead code in stmmac_tx_clean

...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3

Re: [PATCH 00/17] net: stmmac: misc fix

On 1/31/2017 11:23 AM, Joao Pinto wrote: Hi Peppe, Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor

Re: [PATCH 13/17] net: stmmac: Implement NAPI for TX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The stmmac driver run TX completion under NAPI but without checking the work done by the TX completion function. This patch add work/budget to the TX completion function. The visible effect is that it keep the driver longer under NAPI and boost

Re: [PATCH 17/17] net: stmmac: replace unsigned by u32

On 1/31/2017 10:11 AM, Corentin Labbe wrote: checkpatch complains about two unsigned without type after. Since the value return is u32, it is simpler to replace it by u32 instead of "unsigned int" Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Gi

Re: [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The u64 x variable in sysfs_display_ring is unused. This patch remove it. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> well spot Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/st

Re: [PATCH 14/17] net: stmmac: print phy information

On 1/31/2017 10:11 AM, Corentin Labbe wrote: When a PHY is found, printing which one was found (and which type/model) is a good information to know. Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1

Re: [PATCH 12/17] net: stmmac: rename rx_crc to rx_crc_errors

Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 2 +- drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 +- drivers/

Re: [PATCH 10/17] net: stmmac: Correct the error message about invalid speed

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Add 1000 as a valid speed in the error message about invalid speed in stmmac_adjust_link() Signed-off-by: Corentin Labbe --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 11/17] net: stmmac: Rewrite two test against NULL value

On 1/31/2017 10:11 AM, Corentin Labbe wrote: This patch rewrite two test against NULL value with correct style. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

Re: [PATCH 06/17] net: stmmac: fix some code style problem

On 1/31/2017 10:11 AM, Corentin Labbe wrote: Checkpatch complains about some code style problem on stmmac_mdio.c. This patch fix them. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/st

Re: [PATCH 09/17] net: stmmac: replace ENOSYS by EINVAL

On 1/31/2017 10:11 AM, Corentin Labbe wrote: As said by checkpatch ENOSYS means 'invalid syscall nr' and nothing else. This patch replace ENOSYS by the more appropriate value EINVAL. Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall.

Re: [PATCH 01/17] net: stmmac: fix the typo on MAC_RNABLE_RX

On 1/31/2017 10:11 AM, Corentin Labbe wrote: the define MAC_RNABLE_RX have a typo, rename it to MAC_ENABLE_RX Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> --- drivers/net/ethernet/stmicro/stmmac/common.h| 2

Re: [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer

On 1/31/2017 10:11 AM, Corentin Labbe wrote: The bus_setup function pointer is not used at all, this patch remove it. indeed this was used and documented on some previous kernels where some ST40/SH4 platforms (w/o DT). It's ok to remove it in the new MAC generation; I do not think that ST

Re: [PATCH 00/17] net: stmmac: misc fix

Hello Corentin On 1/31/2017 10:11 AM, Corentin Labbe wrote: Hello I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. This serie is the result of all minor problem found in the stmmac driver. thank for this effort, many changes are to tidy up some part of the code so

Re: stmmac: GMAC_RGSMIIIS reports bogus values

On 1/27/2017 11:23 AM, Alexey Brodkin wrote: That's why my initial proposal was to ignore whatever we read from this register if we have MDIO bus instantiated already. sorry for my late reply, I agree with this approach, according to the HW and platform configuration the driver has to

Re: [PATCH] stmmac: fix memory barriers

On 12/18/2016 9:38 PM, Pavel Machek wrote: Fix up memory barriers in stmmac driver. They are meant to protect against DMA engine, so smp_ variants are certainly wrong, and dma_ variants are preferable. Signed-off-by: Pavel Machek <pa...@denx.de> Acked-by: Giuseppe Cavallaro <pep

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

On 12/15/2016 10:45 AM, Pavel Machek wrote: Giuseppe, is there documentation available for the chip? Driver says Documentation available at: http://www.stlinux.com but that page does not work for me... Hi Pavel, yes the page has been removed but all the relevant and updated

Re: stmmac driver...

Hello Jie On 12/14/2016 5:05 AM, Jie Deng wrote: Hi Peppe, On 2016/12/12 22:17, Giuseppe CAVALLARO wrote: Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you

Re: Synopsys Ethernet QoS

Hello Niklas On 12/13/2016 10:38 AM, Niklas Cassel wrote: On 12/13/2016 08:22 AM, Giuseppe CAVALLARO wrote: On 12/12/2016 5:25 PM, Niklas Cassel wrote: On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko

Re: stmmac DT property snps,axi_all

On 12/13/2016 9:26 AM, Niklas Cassel wrote: On 12/13/2016 07:47 AM, Giuseppe CAVALLARO wrote: Hello Niklas, Alex, my fault and a step behind... Current code is OK when manage the AAL that, although it is passed from the axi structure, it is always used to program, for all the chip versions

Re: Synopsys Ethernet QoS

On 12/12/2016 5:25 PM, Niklas Cassel wrote: On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko a écrit : On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote: It's kind of sad

Re: stmmac DT property snps,axi_all

Peppe On 12/12/2016 3:18 PM, Giuseppe CAVALLARO wrote: Please Niklas when you send the patch, add my Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> On 12/9/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue

Re: stmmac DT property snps,axi_all

Please Niklas when you send the patch, add my Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> On 12/9/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue wrote: Hi Niklas, On 12/05/2016 05:18 PM, Niklas

Re: stmmac driver...

Hi David On 12/7/2016 7:06 PM, David Miller wrote: Giuseppe and Alexandre, There are a lot of patches and discussions happening around the stammc driver lately and both of you are listed as the maintainers. I really need prompt and conclusive reviews of these patch submissions from you, and

Re: Synopsys Ethernet QoS

Hello All. On 12/12/2016 11:19 AM, Joao Pinto wrote: Hi, Às 1:44 AM de 12/10/2016, Florian Fainelli escreveu: Le 12/09/16 à 16:16, Andy Shevchenko a écrit : On Sat, Dec 10, 2016 at 12:52 AM, Florian Fainelli wrote: It's kind of sad that customers of that IP (stmmac,

Re: stmmac DT property snps,axi_all

Hello On 12/9/2016 5:06 PM, Alexandre Torgue wrote: Hi Niklas On 12/09/2016 10:53 AM, Niklas Cassel wrote: On 12/09/2016 10:20 AM, Niklas Cassel wrote: On 12/08/2016 02:36 PM, Alexandre Torgue wrote: Hi Niklas, On 12/05/2016 05:18 PM, Niklas Cassel wrote: Hello Giuseppe I'm trying to

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi Alex On 12/2/2016 3:26 PM, Alexandre Torgue wrote: 4.4 has no GMAC4 support. Alex, do you remember any patches to fix that? No sorry Peppe. Pavel, Sorry but I'm a little bit confused. I'm dropped in some mails without historic. I see cleanup, coalescence issue and TSO question. What is

Re: stmmac: turn coalescing / NAPI off in stmmac

Hi Pavel On 12/2/2016 11:42 AM, Pavel Machek wrote: Hi! Anyway... since you asked. I belive I have way to disable NAPI / tx coalescing in the driver. Unfortunately, locking is missing on the rx path, and needs to be extended to _irqsave variant on tx path. I have just replied to a previous

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

On 12/2/2016 1:32 PM, Pavel Machek wrote: Hi! Well, if you have a workload that sends and receive packets, it tends to work ok, as you do tx_clean() in stmmac_poll(). My workload is not like that -- it is "sending packets at 3MB/sec, receiving none". So the stmmac_tx_timer() is rescheduled and

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi Pavel On 12/2/2016 9:45 AM, Pavel Machek wrote: Hi! 1 HZ, which is the lowest granularity of non-highres timers in the kernel, is variable as well as already too large of a delay for effective TX coalescing. I seriously think that the TX coalescing support should be ripped out or disabled

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

On 12/2/2016 9:58 AM, Corentin Labbe wrote: On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: Hello Corentin patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

Hi Florian sorry for my delay. On 11/24/2016 7:23 PM, Florian Fainelli wrote: +Peppe, Le 24/11/2016 à 07:38, Andrew Lunn a écrit : As for enabling advertising and correct working of cpsw do you mean it would be better to disable EEE in any PHY on cpsw initialization as long as cpsw doesn't

Re: [PATCH 1/4] bindings: net: stmmac: correct note about TSO

S Mode parameters, and the parser actually expects it to be in the root node, not in the stmmac-axi-config. Also added a note about snps,tso only being available on GMAC4 and newer. Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> Acked-by: Giuseppe Cavallaro <peppe.c

Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks

mentioned helper hits mainline. Note that these patches have only been compile tested. For common and STi part: Acked-by: Giuseppe Cavallaro <peppe.cavall...@st.com> thx peppe Johan Johan Hovold (7): net: ethernet: stmmac: dwmac-socfpga: fix use-after-free on probe errors

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

Hello Corentin patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work. Regards Peppe On 12/1/2016 4:19 PM, Corentin Labbe wrote: This patch simply rename regValue to value, like it

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

+ Lino On 12/2/2016 9:24 AM, Giuseppe CAVALLARO wrote: Hello On 11/24/2016 10:25 PM, Pavel Machek wrote: Hi! I'm debugging strange delays during transmit in stmmac driver. They seem to be present in 4.4 kernel (and older kernels, too). Workload is burst of udp packets being sent, pause

Re: stmmac: turn coalescing / NAPI off in stmmac

On 12/1/2016 11:48 PM, Pavel Machek wrote: @@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev, features &= ~NETIF_F_CSUM_MASK; /* Disable tso if asked by ethtool */ - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { -

Re: [PATCH] stmmac: simplify flag assignment

+ Alex On 11/30/2016 12:44 PM, Pavel Machek wrote: Simplify flag assignment. Signed-off-by: Pavel Machek diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ed20668..0b706a7 100644 ---

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hello On 11/24/2016 10:25 PM, Pavel Machek wrote: Hi! I'm debugging strange delays during transmit in stmmac driver. They seem to be present in 4.4 kernel (and older kernels, too). Workload is burst of udp packets being sent, pause, burst of udp packets, ... ... 4.9-rc6 still has the

Re: Synopsys Ethernet QoS Driver

On 11/23/2016 12:43 PM, Joao Pinto wrote: > Rabin Vincent can review and test that the port works properly on our Artpec-chips that use dwc_eth_qos.c today. > > The main porting step is to implement the device tree binding in bindings/net/snps,dwc-qos-ethernet.txt. Also our chip has a strict

Re: [net-next PATCH v1 0/2] stmmac: dwmac-meson8b: configurable RGMII TX delay

On 11/24/2016 5:08 PM, Jerome Brunet wrote: On Thu, 2016-11-24 at 15:34 +0100, Martin Blumenstingl wrote: Currently the dwmac-meson8b stmmac glue driver uses a hardcoded 1/4 cycle TX clock delay. This seems to work fine for many boards (for example Odroid-C2 or Amlogic's reference boards) but

Re: [PATCH 3/4] net: stmmac: dwmac-generic: add missing compatible strings

ng to figure out what hardware a certain driver supports, you usually look at the compatible strings in the struct of_device_id, and not in some function defined in a completely different file. No functional change intended. Signed-off-by: Niklas Cassel <niklas.cas...@axis.com> Acked-by:

Re: Synopsys Ethernet QoS Driver

Hello Joao, Lars. On 11/22/2016 3:16 PM, Joao Pinto wrote: Ok, it makes sense. > Just for curiosity the target setup is the following: > https://www.youtube.com/watch?v=8V-LB5y2Cos > but instead of using internal drivers, we desire to use mainline drivers only. > > Thanks! Regarding this

Re: Synopsys Ethernet QoS Driver

ools work but indeed should be extended to support more for QoS. This is another task we have to keep in mind, well spot. Peppe Regards, Ozgur 21.11.2016, 16:38, "Giuseppe CAVALLARO" <peppe.cavall...@st.com>: Hello Joao On 11/21/2016 2:48 PM, Joao Pinto wrote: Synopsys QoS

Re: Synopsys Ethernet QoS Driver

On 11/21/2016 4:00 PM, Joao Pinto wrote: On 21-11-2016 14:36, Giuseppe CAVALLARO wrote: Hello Joao On 11/21/2016 2:48 PM, Joao Pinto wrote: Synopsys QoS IP is a separated hardware component, so it should be reusable by all implementations using it and so have its own "core d

  1   2   3   >