Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-10 Thread Herbert Xu
hen sk_forward_alloc is updated in receive processing. >I understand performance issue might occur, but ... Having discussed this with Dave we've agreed that this is the best way to go. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} &

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Herbert Xu
's responsibility to set the appropriate hard life time if ESNs are not in use. Either way is fine with me. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Herbert Xu
e we need to know whether ESNs are in use or not. The easiest fix is to just force the hard_packet_limit to 2^32. upon SA creation. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-08 Thread Herbert Xu
++x->replay.oseq; > + if (x->replay.oseq == 0) > + goto error; Yes we need this check. However please add an unlikely around it since it's a 1-in-4 billion event :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAI

Re: 'default' vs. 'all'

2007-12-08 Thread Herbert Xu
or backwards compatibility it's set on address addition not device up. I was in the process of doing it for IPv6 too but got distracted by other things. I might still have that tree on my hard drive if anyone is interested. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~

Re: 'default' vs. 'all'

2007-12-08 Thread Herbert Xu
ackwards compatibility. If you delete that call then it's as you described. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.tx

Re: [PATCH net-2.6.25] Cleanup IN_DEV_MFORWARD macro

2007-12-07 Thread Herbert Xu
On Fri, Dec 07, 2007 at 07:19:38PM +0300, Pavel Emelyanov wrote: > This is essentially IN_DEV_ANDCONF with proper arguments. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Herbert Xu <[EMAIL PROTECTED]> Thanks Pavel! I must have written that one before

Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements

2007-12-06 Thread Herbert Xu
ith 'size_t' (since it is unsigned, compared to (some) > 'int')? I agree with Dave. There are so many useful things that we can do (and need to do) in IPsec that bool/size_t conversions just add churn without adding much value. Thanks, -- Visit Openswan at http://www.op

Re: [PATCH net-2.6.25 10/11][INET] Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

2007-12-06 Thread Herbert Xu
to allocate the ifa (hard to happen, but), we will > make this device not to accept the default propagation. Yes that's unintentional. > If this is a relevant note, I can prepare the patch. It certainly seems easy enough to fix by just swapping the order. Please do. Thanks, -- Visit O

Re: [PATCH net-2.6.25 10/11][INET] Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

2007-12-06 Thread Herbert Xu
gs, > read setting from the real filesystem config giles, in order to change > this. Perhaps a boot time command line option? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PG

Re: [PATCH net-2.6.25 10/11][INET] Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

2007-12-05 Thread Herbert Xu
l the user modified the setting, with an ioctl to revert to the current behaviour for compatibility. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/include/net/udp.h b/include/net/udp.h index 87170bb..98cb09c 100644 --- a/include/net/udp.h +++ b/inclu

Re: sockets affected by IPsec always block (2.6.23)

2007-12-05 Thread Herbert Xu
On Wed, Dec 05, 2007 at 01:55:58AM -0800, David Miller wrote: > > If it hits sysctl_tcp_syn_retries SYN attempts, the connect will hard > fail. Right. Let's just forget about this until we have a queueing system :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: He

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
; packets and RXRPC packets to go missing. > > > > This patch restores all of these. > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Applied. Sorry, Eric spotted a build problem in my patch. So you'll need to replace this with the fixed v

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
crements The previous move of the the UDP inDatagrams counter caused the counting of encapsulated packets, SUNRPC data (as opposed to call) packets and RXRPC packets to go missing. This patch restores all of these. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> diff --git a/include/net

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
On Wed, Dec 05, 2007 at 05:04:48PM +0800, Wang Chen wrote: > > Yes, now, sunrpc only supports INET and INET6. > But UDPX_INC_STATS_BH is defined in udp.h, in case others use it :) Which other family would that be :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-05 Thread Herbert Xu
On Wed, Dec 05, 2007 at 04:39:48PM +0800, Wang Chen wrote: > Herbert Xu said the following on 2007-12-5 10:15: > > +#define UDPX_INC_STATS_BH(sk, field) \ > > + do { \ > > + if ((sk)->sk_family == AF_INET) \ > > + UDP_INC_STATS_BH(fie

Re: sockets affected by IPsec always block (2.6.23)

2007-12-04 Thread Herbert Xu
hing to just sit and wait > for the connect() to succeed instead of failing. Hmm, but connect(2) should succeed in that case thanks to the blackhole route, no? The subsequent SYNs will then be dropped until the IPsec SAs are in place. Cheers, -- Visit Openswan at http://www.openswan.org/ Email

Re: sockets affected by IPsec always block (2.6.23)

2007-12-04 Thread Herbert Xu
On Tue, Dec 04, 2007 at 11:12:00PM -0800, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Wed, 5 Dec 2007 17:51:32 +1100 > > > Does anybody actually need the 0 setting? What would we break if > > the default became 1? > > I bet there are UDP a

Re: sockets affected by IPsec always block (2.6.23)

2007-12-04 Thread Herbert Xu
ault became 1? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe ne

Re: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

2007-12-04 Thread Herbert Xu
more to this than just changing the multicast handling. We also talked about consolidating the driver interface so that all these calls have the same environment rather than the mix-and-match that we have now. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>H

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-04 Thread Herbert Xu
rements The previous move of the the UDP inDatagrams counter caused the counting of encapsulated packets, SUNRPC data (as opposed to call) packets and RXRPC packets to go missing. This patch restores all of these. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> diff --git a/include/

Re: [PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-04 Thread Herbert Xu
On Wed, Dec 05, 2007 at 12:01:09AM +1100, Herbert Xu wrote: > > [UDP]: Restore missing inDatagrams increments Oops, I got the mode wrong for the SNMP calls. [UDP]: Restore missing inDatagrams increments The previous move of the the UDP inDatagrams counter caused the counting of encaps

Re: sockets affected by IPsec always block (2.6.23)

2007-12-04 Thread Herbert Xu
to implement the larval IPsec dst stuff that we talked about. For now let's just revert to the old behaviour on non-blocking sockets. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED

Re: [PATCH 1/4] netns: Tag the network flow with the network namespace it is in (v2)

2007-12-04 Thread Herbert Xu
-- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning

2007-12-04 Thread Herbert Xu
ve been busy so I haven't completed the patches yet. But as this problem is not urgent let's not just put on a bandaid. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP

[PATCH 3/3] [UDP]: Only increment counter on first peek/recv

2007-12-04 Thread Herbert Xu
n this and made skb_recv_datagram a wrapper around it. The plan is to eventually replace all uses of skb_recv_datagram with this new function at which time it can be renamed its proper name. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/linux/skbuff.h |3 +++ net/core/data

[PATCH 2/3] [UDP]: Restore missing inDatagrams increments

2007-12-04 Thread Herbert Xu
data (as opposed to call) packets and RXRPC packets to go missing. This patch restores all of these. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/net/udp.h |4 include/net/udplite.h |3 --- net/ipv4/udp.c|6 +- net/rxrpc/ar-input.c |4

[PATCH 1/3] [UDP]: Avoid repeated counting of checksum errors due to peeking

2007-12-04 Thread Herbert Xu
packet and only incrementing the counter if it did. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> --- include/linux/skbuff.h |2 +- net/core/datagram.c|9 - net/ipv4/udp.c |5 ++--- net/ipv6/udp.c |4 ++-- 4 files changed, 13 insertions(+), 7 del

Re: net-2.6.25 patches status

2007-12-04 Thread Herbert Xu
more :) or rework the > whole approach? If you can see them in my net-2.6.25 tree then they're in. Otherwise please resend them to Dave. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herber

Re: [NETLINK]: af_netlink.c checkpatch cleanups

2007-12-04 Thread Herbert Xu
xpatch script :) BTW, Dave is now back so please redirect future patches to him. I'll forward this one. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apa

Re: IPv6 IPsec input

2007-12-03 Thread Herbert Xu
because all this work is for the benefit of IPv6 :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this l

Re: [PATCH][IPv6][IPsec] fix the address family for xfrm_state_lookup in xfrm_input

2007-12-03 Thread Herbert Xu
ify the family through skb->cb. Credit goes to Kazunori Miyazawa for diagnosing this and providing an initial patch. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Pag

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-03 Thread Herbert Xu
made it work. It's better to declare these inclusions explicitly as otherwise they may break on less common architectures later. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-03 Thread Herbert Xu
concerns. But let's wait and see what Dave has to say about this too. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [README] away until Dec 3rd

2007-12-03 Thread Herbert Xu
On Thu, Nov 22, 2007 at 12:27:47PM +0800, Herbert Xu wrote: > On Tue, Nov 20, 2007 at 08:29:21PM -0800, David Miller wrote: > > > > During this time Herbert Xu (CC:'d) will take care of both the net-2.6 > > stable tree and the net-2.6.25 devel tree. > > For

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-03 Thread Herbert Xu
On Mon, Dec 03, 2007 at 10:54:35PM +1100, Herbert Xu wrote: > > Hmm, wasn't someone else talking about a non-atomic version of atomic > ops lately (i.e., atomic with respect to the local CPU only)? Perhaps > this is the killer app for it :) Never mind, we already have that

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-03 Thread Herbert Xu
On Mon, Dec 03, 2007 at 02:49:12PM +0300, Alexey Kuznetsov wrote: > On Mon, Dec 03, 2007 at 10:39:35PM +1100, Herbert Xu wrote: > > So we need to fix this, and whatever the fix is will probably render > > the BH/USER distinction obsolete. > > Hmm, I would think opposite.

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-12-03 Thread Herbert Xu
ss-context kernel code or for that matter migrate to other CPUs, neither of which is true with PREEMPT on. So we need to fix this, and whatever the fix is will probably render the BH/USER distinction obsolete. Any takers? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV

Re: [PATCH net-2.6.25] TCP: Fix copy-paste (or code move) error

2007-12-03 Thread Herbert Xu
t Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EM

Re: [PATCH] SMC911X: Fix using of dereferenced skb after netif_rx

2007-12-03 Thread Herbert Xu
-- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH]: fix lro_gen_skb() alignment

2007-12-03 Thread Herbert Xu
r. Fair enough. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH 0/2] [IPSEC]: Reinject packet instead of calling netfilter directly on input

2007-12-03 Thread Herbert Xu
; only;->). Sorry for the late response Jamal. I've been too busy to give this issue proper thought. It's still in my mailbox so I will respond to it once things quiten down a little. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} &

Re: [PATCH 0/5] [IrDA] IrDA updates for net-2.6

2007-12-02 Thread Herbert Xu
On Mon, Dec 03, 2007 at 10:28:31AM +0100, Samuel Ortiz wrote: > Hi Herbert, > > Here goes a series of 5 IrDA patches against your latest net-2.6 tree. I seem to be missing 3/5. Could you please resend? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>

Re: [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-12-02 Thread Herbert Xu
_mutex); Actually this causes a dead-lock when the handlers are built as modules because we try to load them with that mutex held. I've fixed it with this patch on top. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home

Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-02 Thread Herbert Xu
hose list heads) to > TCP_SKB_CB and tcp_skb_pcount if some DEBUG thing is set. Those two should > catch at least 98% of the invalid users. > > ...Not sure if CONFIG_DEBUG_LIST is right one to use, suggestion welcome. Sounds OK to me. Thanks, -- Visit Openswan at http://www.openswan.

Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

2007-12-01 Thread Herbert Xu
sk->sk_send_head = NULL; This crashed my machine on boot. The reason is that prev was empty. I've added this fix to net-2.6.25. [TCP]: Fix crash in tcp_advance_send_head We need to check whether there is a prev in tcp_advance_send_head before dereferencing it. This patch does just that

Re: [PATCH 13/21] [TCP]: Store retransmit queue packets in RB tree.

2007-12-01 Thread Herbert Xu
Did David really do this? :) I suppose if we moved this into cb (by growing it by the required amount) then at least the new space can be used by others. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.

Re: [RFC PATCH net-2.6.25 0/21]: TCP tweaks & RB-tree WIP preview

2007-12-01 Thread Herbert Xu
it Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [E

Re: [PATCH net-2.6.25 (resend) 3/3][IPV6] Use ctl paths to register addrconf sysctls

2007-12-01 Thread Herbert Xu
rsion is just the patch > offsets, that changed due to changes in the patch #2. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Both applied. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: htt

Re: [PATCH net-2.6.25 (resend) 3/3][IPV4] Use ctl paths to register devinet sysctls

2007-12-01 Thread Herbert Xu
l. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-12-01 Thread Herbert Xu
e, and a couple of > additions to feature-removal-schedule.txt heralding the end of softmac. All applied to net-2.6.25. Thanks John! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Herbert Xu
3/3. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-2.6.25 2/3][IPV6] Unify and cleanup calls to addrconf_sysctl_register

2007-12-01 Thread Herbert Xu
case for IPv4. So let's get rid of that while we're at it. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsu

Re: [PATCH net-2.6.25 2/3][IPV4] Unify and cleanup calls to devinet_sysctl_register

2007-12-01 Thread Herbert Xu
f CONFIG_SYSCTL > - devinet_sysctl_register(in_dev, &in_dev->cnf); > + devinet_sysctl_register(dev, &in_dev->cnf); How about just giving it in_dev instead? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTE

Re: [PATCH net-2.6.25 1/3][IPV4] Cleanup the devinet_sysctl_register

2007-12-01 Thread Herbert Xu
did with the neigh ctl-s. > > Besides, I fixed the goto's and the labels - they were indented > with spaces :( > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied to net-2.6.25. Thanks. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>

Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-01 Thread Herbert Xu
ore importantly, it uses sk_forward_alloc so not every packet needs to touch the global counter. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

Re: [PATCH net-2.6.25 2/2][NEIGH] Use the ctl paths to create neighbours sysctls

2007-12-01 Thread Herbert Xu
t's fine. > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Both applied to net-2.6.25. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.

Re: [PATCH 4/4 (resent) net-2.6.25][UNIX] Make the unix sysctl tables per-namespace

2007-12-01 Thread Herbert Xu
ormous. It's also one of those files that causes everything to get recompiled. Maybe we ought to make a rule that each subsystem only gets to have at most one entry in it :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home

Re: [PATCH] remove extra memset from dn_fib_check_nh

2007-12-01 Thread Herbert Xu
On Fri, Nov 30, 2007 at 06:54:01PM +0300, Denis V. Lunev wrote: > [PATCH] remove extra memset from dn_fib_check_nh > > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]> Applied to net-2.6.25. Thanks Denis! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{P

Re: [PATCH] XFRM: SPD auditing fix to include the netmask/prefix-length

2007-12-01 Thread Herbert Xu
silence as an indication of approval :) Patch applied to net-2.6.25. Thanks Paul. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- T

Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-01 Thread Herbert Xu
subtract from sk_forward_alloc. There is one big problem with this though, UDP is not serialised like TCP. So you can't just use sk_forward_alloc since it's not an atomic_t. We'll need to think about this one a bit more. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herber

Re: [PATCH 2/4] datagram: mem_scheudle functions

2007-12-01 Thread Herbert Xu
Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode

2007-11-30 Thread Herbert Xu
SG_DONTWAIT) > | > Is it not the other way round ?? :- I agree. Wang Chen, please change this and other appropriate BH calls to USER. Basically recvmsg should always be USER while rcv is BH. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} &

Re: [PATCH] Remove rcu_assign_pointer() penalty for NULL pointers

2007-11-30 Thread Herbert Xu
ive.com/netdev@vger.kernel.org/msg54852.html > > Tested on x86_64 and ppc64, also compiled the four cases (NULL/non-NULL > and const/non-const) with gcc version 4.1.2, and hand-checked the > assembly output. > > Signed-off-by: Paul E. McKenney <[EMAIL PROTECTED]> Acke

Re: [PATCH]: fix lro_gen_skb() alignment

2007-11-30 Thread Herbert Xu
te the padding as ALIGN(mac_hdr_len, 4) - mac_hdr_len or even simpler ~(mac_hdr_len - 1) & 3 Bonus points for putting this in a macro alongside NET_IP_ALIGN :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL P

Re: [PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-30 Thread Herbert Xu
Ingo Molnar <[EMAIL PROTECTED]> wrote: > >> Patch applied to net-2.6. Thanks. > > aimed at 2.6.24 merging, right? Yep. net-2.6 is for 2.6.24 while net-2.6.25 is for 2.6.25. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL

Re: net-2.6.25 rebased

2007-11-30 Thread Herbert Xu
On Fri, Nov 30, 2007 at 01:32:19AM +1100, Herbert Xu wrote: > > Just to let you all know that I've just rebased net-2.6.25 so that it now > contains all of net-2.6 as it currently stands. I've rebased it again. Cheers, -- Visit Openswan at http://www.openswan.org/ Email:

Re: [PATCH 0/4] Sysctl namespace support

2007-11-30 Thread Herbert Xu
d them all to net-2.6.25 with Andrew's fixes included. Thanks Eric. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscrib

Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-30 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:35:43PM +, Steven Whitehouse wrote: > > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> > Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> Patch applied. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{Pm

Re: [Bugme-new] [Bug 9440] New: Problem in joinning a socket to ipv6 multicast address in specific scenario

2007-11-30 Thread Herbert Xu
On Fri, Nov 30, 2007 at 03:25:16PM +0300, Evgeniy Polyakov wrote: > > Ok, added netdev_up too. > > Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> Applied to net-2.6. Thanks Evgeniy! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMA

Re: Please pull 'fixes-davem' branch of wireless-2.6

2007-11-30 Thread Herbert Xu
On Thu, Nov 29, 2007 at 10:31:58PM -0500, John W. Linville wrote: > Dave/Herbert, > > Here is another clutch of patches intended for 2.6.24. > > Let me know if there are any problems! Pulled. Thanks John! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{P

Re: [GIT PULL] SCTP bug fixes for net-2.6

2007-11-30 Thread Herbert Xu
in the git repository at: > > aster.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git pending Pulled. Thanks Vlad! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.

Re: [PATCH] AF_RXRPC: Configure crypto correctly for AF_RXRPC

2007-11-30 Thread Herbert Xu
On Wed, Nov 28, 2007 at 02:37:53PM +, David Howells wrote: > AF_RXRPC uses the crypto services, so should depend on or select CRYPTO. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Patch applied to net-2.6. Thanks. -- Visit Openswan at http://www.openswan.org/ Email: H

Re: [Bugme-new] [Bug 9440] New: Problem in joinning a socket to ipv6 multicast address in specific scenario

2007-11-30 Thread Herbert Xu
s like a good change. However, we should also change NETDEV_UP as well to recreate idev if it isn't there and the MTU is big enough. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~he

Re: [PATCH]: fix lro_gen_skb() alignment

2007-11-30 Thread Herbert Xu
It would be nice to have another macro for that I suppose. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from t

Re: ZD1211RW unaligned accesses...

2007-11-30 Thread Herbert Xu
ed up the user-kernel wireless interface for the 32-in-64 case. But rest assured we will be working on that. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.or

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
smp_wmb(); \ > (p) = (v); \ > }) Yes that's what I was thinking. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
nowhere near 10Gb) NICs are the norm for violating alignment :) So I'd prefer something that only penalised them rather than everybody else. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
the rule. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe n

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
mehow get an illegal value through, dropping the packet sounds like a sane action to follow and I'm sure people will notice pretty quickly when packets don't flow anymore :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
e > order (Itanium, POWER, ARM, some MIPS boxes according to rumor, ...). Good point! Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey

Re: ZD1211RW unaligned accesses...

2007-11-29 Thread Herbert Xu
re still discussing. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe

Re: [NET 00/02]: Remove NET_ACT_NAT dependency on NETFILTER

2007-11-29 Thread Herbert Xu
d happily change it if someone suggests something better. Looks good to me. I've applied both to net-2.6.25. Thanks Patrick! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

net-2.6.25 rebased

2007-11-29 Thread Herbert Xu
Hi: Just to let you all know that I've just rebased net-2.6.25 so that it now contains all of net-2.6 as it currently stands. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/

Re: [PATCH] tcp-illinois: incorrect beta usage

2007-11-29 Thread Herbert Xu
ct on a congested network. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied to net-2.6. Thanks Stephen! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH net-2.6.25 (v2)] [TCP]: Two fixes to new sacktag code

2007-11-29 Thread Herbert Xu
ng before the next merge window. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: + xfrm_policy-warning-fix.patch added to -mm tree

2007-11-29 Thread Herbert Xu
gt; Fix this: > > net/xfrm/xfrm_policy.c: In function '__xfrm_lookup': > net/xfrm/xfrm_policy.c:1449: warning: 'dst' may be used uninitialized in this > function > > by checking for impossible values in the switch(). Thanks Andrew. I've added the foll

Re: [PATCH] Nicer WARN_ON in netstat_show

2007-11-29 Thread Herbert Xu
Thanks. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev&q

Re: wireless vs. alignment requirements

2007-11-29 Thread Herbert Xu
:) it would be good to have. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "uns

Re: [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
quick response! Patch applied to net-2.6. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line &q

Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
ssignment. Since NULL does not need to be initialised you don't need the barrier :) Hmm, perhaps we could even build this logic into rcu_assign_pointer. Then again, who still uses an Alpha? Mine died years ago :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>

Re: [PATCH][BRIDGE] Lost call to br_fdb_fini() in br_init() error path

2007-11-29 Thread Herbert Xu
PROTECTED]> Patch applied to net-2.6. Thanks Pavel! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: sen

Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
rotect has to use the correct RCU primitives for this to work. Synchronisation is like tango, it always takes two to make it work :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP K

Re: [PATCH][UNIX] EOF on non-blocking SOCK_SEQPACKET

2007-11-29 Thread Herbert Xu
ce the risk of this breaking an existing application seems to be minimal, I've applied your patch to net-2.6. However, I had to reformat it so that it fits with the Linux coding style. Please take this into account for future patches. Thanks, -- Visit Openswan at http://www.openswan.org/

Re: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter

2007-11-29 Thread Herbert Xu
-Lite", not UDP. We could just drop the mention of UDP completely: The total number of datagrams delivered to applications. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ P

Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-29 Thread Herbert Xu
isit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 07:54:59PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > I've fixed up those errors. OK, patch applied to net-2.6.25. Thanks everyone! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http:/

Re: [PATCH] sungem: fix napi regression with reset work

2007-11-29 Thread Herbert Xu
unning. > > Also removes a superfluous test of gp->running in the same function. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> Patch applied to net-2.6. Thanks Johannes! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROT

<    5   6   7   8   9   10   11   12   13   14   >