Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

On Wed, 2016-09-07 at 02:00 +, ronnie.ku...@microchip.com wrote: > Microchip's internal convention is for register (offset) definitions > to be capitalized (i.e.: MY_REGISTER). Our convention for bits > (position) definitions within a register is to carry as a prefix the > name of the register

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

On Tue, 2016-09-06 at 23:19 +, woojung@microchip.com wrote: > > Joe Perches (2): > >   lan78xx: Remove locally defined trailing underscores from defines and uses > >   microchipphy.h and uses: Remove trailing underscores from defines and > > uses > > &g

[PATCH 1/2] lan78xx: Remove locally defined trailing underscores from defines and uses

(?!LAN88XX_)([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \ drivers/net/usb/lan78xx.[ch] and some editing to realign columns in the .h file. No change in defconfig object. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/usb/lan78xx.c | 340 +++ drivers/net/usb/lan78xx.h

[PATCH 2/2] microchipphy.h and uses: Remove trailing underscores from defines and uses

/lan78xx.c \ drivers/net/phy/microchip.c and some editing to realign columns in the .h file. No change in defconfig objects. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/phy/microchip.c | 4 +-- drivers/net/usb/lan78xx.c| 28 - include/linux/microchipphy.

[PATCH 0/2] lan78xx: Remove trailing underscores from macros

Joe Perches (2): lan78xx: Remove locally defined trailing underscores from defines and uses microchipphy.h and uses: Remove trailing underscores from defines and uses drivers/net/phy/microchip.c |4 +- drivers/net/usb/lan78xx.c| 368 +++ drivers/net/usb/lan78xx.h

[PATCH] smsc95xx: Remove trailing underscores from macros and uses

in defconfig objects. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/usb/smsc95xx.c | 198 +-- drivers/net/usb/smsc95xx.h | 330 ++--- 2 files changed, 264 insertions(+), 264 deletions(-) diff --git a/drivers/n

Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

On Tue, 2016-09-06 at 19:04 +0300, Saeed Mahameed wrote: > From: Huy Nguyen [] > +void mlx5_port_module_event(struct mlx5_core_dev *dev, struct mlx5_eqe *eqe) > +{ > > + struct mlx5_eqe_port_module *module_event_eqe; > > + u8 module_status; > > + u8 module_num; > > +

Re: [PATCH 02/29] netfilter: physdev: add missed blank

On Mon, 2016-09-05 at 12:58 +0200, Pablo Neira Ayuso wrote: [] > diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c [] > @@ -107,8 +107,8 @@ static int physdev_mt_check(const struct xt_mtchk_param > *par) >    info->invert & XT_PHYSDEV_OP_BRIDGED) && >  

Re: [PATCH v3 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

On Mon, 2016-09-05 at 14:56 +0200, Daniel Mack wrote: > On 08/27/2016 02:08 AM, Alexei Starovoitov wrote: [] > > + switch (attr->attach_type) { > > + case BPF_ATTACH_TYPE_CGROUP_INET_INGRESS: > > + case BPF_ATTACH_TYPE_CGROUP_INET_EGRESS: { > > + struct cgroup *cgrp; > > + > > +

[net-next PATCH V2] qed: Remove OOM messages

/ethernet/qlogic/qed/built-in.o.new 132474 27969 32800 193243 2f2db drivers/net/ethernet/qlogic/qed/built-in.o.old Miscellanea: o Change allocs to the generally preferred forms where possible. Signed-off-by: Joe Perches <j...@perches.com> --- V2: Respun against net-next, updated

Re: [PATCH] qed: Remove OOM messages

On Sun, 2016-09-04 at 13:28 -0700, David Miller wrote: > From: Joe Perches <j...@perches.com> > Date: Fri,  2 Sep 2016 10:48:47 -0700 > > > These messages are unnecessary as OOM allocation failures already do > > a dump_stack() giving more or less the same information.

[PATCH 0/2] hso: neatening

This seems to be the only code in the kernel that uses macro defines with a trailing underscore. Fix that. Joe Perches (2): hso: Use a more common logging style hso: Convert printk to pr_ drivers/net/usb/hso.c | 118 +++--- 1 file changed, 55

[PATCH 2/2] hso: Convert printk to pr_

Use a more common logging style Miscellanea: o Add pr_fmt to prefix each output message o Realign arguments Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/usb/hso.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/net/usb

[PATCH 1/2] hso: Use a more common logging style

. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/usb/hso.c | 97 +++ 1 file changed, 44 insertions(+), 53 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c5544d3..6c37512 100644 --- a/drivers/net/usb

Re: [PATCH net-next 2/3] smsc95xx: Add register define

On Fri, 2016-09-02 at 20:34 +, woojung@microchip.com wrote: > From: Woojung Huh > > Add STRAP_STATUS defines. [] > diff --git a/drivers/net/usb/smsc95xx.h b/drivers/net/usb/smsc95xx.h [] > @@ -144,6 +144,14 @@ >   >  #define BURST_CAP(0x38)

[PATCH] qed: Remove OOM messages

/ethernet/qlogic/qed/built-in.o.new 131506 27968 32800 192274 2ef12 drivers/net/ethernet/qlogic/qed/built-in.o.old Miscellanea: o Change allocs to the generally preferred forms where possible. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/qlogic/qed/qed

Re: [PATCH] qed: fix kzalloc-simple.cocci warnings

On Thu, 2016-09-01 at 07:37 +, Yuval Mintz wrote: > > drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1230:13-20: WARNING: kzalloc > > should be used for dcbx_info, instead of kmalloc/memset > > drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1192:13-20: WARNING: kzalloc > > should be used for

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > I'm not sure why this hasn't been done before because it seems obvious, > so maybe there is some reason that memcpy is used instead of > ether_addr_copy in this code.  But let's try this anyway. > > Change memcpy to ether_addr_copy. I looked

Re: [PATCH] mwifiex: scan: Simplify code

On Wed, 2016-08-31 at 13:50 +0200, Christophe JAILLET wrote: > This patch: >    - improves code layout >    - removes a useless memset(0) for some memory allocated with kzalloc >    - removes a useless if. We know that 'if (chan_band_tlv)' will succeed >  because it has been tested a few lines

[PATCH] ath10k: Spelling and miscellaneous neatening

Correct some trivial comment typos. Remove unnecessary parentheses in a long line. Convert a return; before the end of a void function definition to just ; Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath10k/ce.c| 2 +- drivers/net/wireless/ath/

Re: [PATCH] irda: Fix likely typo in output format string

(added Chunyan Zhang to cc) On Fri, 2016-08-26 at 23:14 -0400, Oleg Drokin wrote: > %ul would print an unsigned with a letter l at the end which does > not seem to be desired here, on the other hand the value being printed > is u32 so just drop the l instead of converting to %lu Fixes:

Re: [PATCH] drivers: net: stmmac: fix spelling mistake "mulitcast" -> "multicast"

On Fri, 2016-08-26 at 19:35 +0100, Colin King wrote: > Trivial fix to spelling mistake in dev_warn message. Thanks Colin Are you also fixing up comments and such? $ git grep -i -E "\bmulit" Documentation/networking/kcm.txt:Kernel Connection Mulitplexor arch/arm/mach-s3c64xx/include/mach/irqs.h:

Re: [PATCH, net-next] qede: hide 32-bit compile warning

On Fri, 2016-08-26 at 17:37 +0200, Arnd Bergmann wrote: > The addition of the per-queue statistics introduced a harmless warning > on all 32-bit architectures: > > drivers/net/ethernet/qlogic/qede/qede_ethtool.c: In function > 'qede_get_ethtool_stats': >

Re: [PATCH net-next] drivers/net: Use priority level to printk() calls

On Fri, 2016-08-26 at 00:22 +0200, citestra wrote: > Add priority level 'KERN_ERR' to a printk() call [] > diff --git a/drivers/net/ethernet/amd/am79c961a.c > b/drivers/net/ethernet/amd/am79c961a.c [] > @@ -182,7 +182,7 @@ am79c961_ramtest(struct net_device *dev, unsigned int val) >  

Re: CVE-2014-9900 fix is not upstream

On Tue, 2016-08-23 at 21:09 +0100, Al Viro wrote: > On Tue, Aug 23, 2016 at 11:24:06AM -0700, David Miller wrote: > > > On some versions and architectures.  Can you guarantee that you will > > > notice when an exception appears? > > Again, show me the assembler output exhibiting the lack of > >

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 19:27 +0400, Loganaden Velvindron wrote: > Better be safe than sorry. Better still would be to create a tool via something like coccinelle that could be run on the entire kernel than submit a single patch for a construct that likely occurs dozens of times in the kernel

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 07:21 -0700, Eric Dumazet wrote: > On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: > > From: Avijit Kanti Das > > > > memset() the structure ethtool_wolinfo that has padded bytes > > but the padded bytes have not been zeroed out. [] > >

Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote: > From: Avijit Kanti Das > > memset() the structure ethtool_wolinfo that has padded bytes > but the padded bytes have not been zeroed out. I expect there are more of these in the kernel tree. While this patch

Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

On Mon, 2016-08-22 at 22:50 +0200, SF Markus Elfring wrote: > > @@ -2289,6 +2299,10 @@ sub process { > >   } > >   > >   if ($found_file) { > > + if (is_maintained_obsolete($realfile)) { > > + WARN("OBSOLETE", > > +

[PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

Use get_maintainer to check the status of individual files. If "obsolete", suggest leaving the files alone. Signed-off-by: Joe Perches <j...@perches.com> --- scripts/checkpatch.pl | 14 ++ 1 file changed, 14 insertions(+) diff --git a/scripts/checkpatch.pl b/scrip

Re: [PATCH 0/3] hostap: Fine-tuning for a few functions

On Mon, 2016-08-22 at 18:49 +0300, Kalle Valo wrote: > Arend van Spriel writes: [] > But yeah, not really sure what to do with these obsolete drivers like > hostap, ray_cs and wl3501. Maybe marking sections obsolete in MAINTAINERS could flag some "shouldn't touch

[PATCH] i40e: Remove XSTRINGIFY macro definitions and uses

Use __stringify instead. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/intel/i40e/i40e.h| 4 drivers/net/ethernet/intel/i40e/i40e_client.h | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40

Re: [PATCH net-next V2 08/18] liquidio: CN23XX queue manipulation

On Fri, 2016-08-12 at 11:20 -0700, Raghu Vatsavayi wrote: > This patch adds support for cn23xx queue manipulation. trivia: > diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c > b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c [] > @@ -315,6 +315,52 @@ static void

Re: [PATCH net-next V2 02/18] liquidio: Firmware version management

On Fri, 2016-08-12 at 11:20 -0700, Raghu Vatsavayi wrote: > This patch contains changes for firmware version management. trivial note: > diff --git a/drivers/net/ethernet/cavium/liquidio/liquidio_common.h > b/drivers/net/ethernet/cavium/liquidio/liquidio_common.h [] > @@ -30,10 +30,26 @@ >   >  

Re: [PATCH net-next V2 01/18] liquidio: Consolidate common functionality

On Fri, 2016-08-12 at 11:20 -0700, Raghu Vatsavayi wrote: > Consolidate common functionality of various devices > from different files into lio_core.c/octeon_console.c. trivial notes: > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c >

Re: [PATCH v2 12/14] net: ethernet: ti: cpsw: fix int dbg message

On Sat, 2016-08-06 at 13:48 +0300, Ivan Khoronzhuk wrote: > While poll handlers there is no possibility to figure out > which network device is handling packets, as cpdma channels > are common for both network devices in dual_emac mode. Currently, > the messages are printed only for one device, in

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

On Wed, 2016-07-27 at 07:24 +, Yuval Mintz wrote: > > > > Current DP_ macros generate a lot of code. > > Using functions with vsprintf extension %pV helps reduce that size. > > > >  drivers/net/ethernet/qlogic/qed/Makefile   |  2 +- > >  drivers/net/ethernet/qlogic/qed/qed_util.c | 82 > >

Re: [PATCH] qed: Add and use specific logging functions to reduce object size

On Tue, 2016-07-26 at 14:25 -0700, Joe Perches wrote: > Current DP_ macros generate a lot of code. > Using functions with vsprintf extension %pV helps reduce that size. Yuval, I used the same KERN_ output types, but it is unusual that DP_INFO outputs at KERN_NOTICE. Was that a copy/paste

[PATCH] qed: Add and use specific logging functions to reduce object size

Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/qlogic/qed/Makefile | 2 +- drivers/net/ethernet/qlogic/qed/qed_util.c | 82 ++ include/linux/qed/qed_if.h | 60 +- 3 files changed, 106 insertions(

Re: [PATCH net-next 2/3] bnxt_en: Log a message, if enabling NTUPLE filtering fails.

On Sun, 2016-07-24 at 23:21 -0400, Michael Chan wrote: > If there are not enough resources to enable ntuple filtering, > log a warning message. [] > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt.c [] > @@ -5790,8 +5790,14 @@ static bool

Re: [net-next 14/14] ixgbe: cleanup crosstalk fix

On Fri, 2016-07-22 at 23:49 -0700, Jeff Kirsher wrote: > From: Don Skidmore > > This patch address a few issues with the initial crosstalk fix.  Most > important of which is the SDP that indicates the presents of a SFP+ > module changes between HW types.  With this

Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, 2016-07-20 at 06:02 +, Levy, Amir (Jer) wrote: > On Tue, Jul 19 2016, 08:14 PM, Joe Perches wrote: > > On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote: > > > > > > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. > >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote: > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > This is the debugging message interface. > > https://www.kernel.org/doc/Documentation/networking/netif-msg.txt > This document was updated last time in 2006 and I doubt

Re: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote: > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. [] >  Documentation/00-INDEX   |2 + >  Documentation/thunderbolt-networking.txt |  135 ++ >  drivers/thunderbolt/Kconfig  |   25 +- >  

Re: [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware

On Mon, 2016-07-11 at 11:28 -0700, Yeshaswi M R Gowda wrote: > The Chelsio's Crypto Hardware can perform the following operations: > SHA1, SHA224, SHA256, SHA384 and SHA512, HMAC(SHA1), HMAC(SHA224), > HMAC(SHA256), HMAC(SHA384), HAMC(SHA512), AES-128-CBC, AES-192-CBC, > AES-256-CBC, AES-128-XTS,

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Tue, 2016-07-05 at 09:31 +, Dexuan Cui wrote: > > > +/* This is the address fromat of Hyper-V Sockets. > > format > I suppose you meant I should change  > /* This is ... > to  > /* >   * This is ... > I'll fix this. No, I just meant fromat should  be format

Re: [PATCH v14 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Thu, 2016-06-30 at 15:58 +, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. trivia: > diff --git

Re: [PATCH net-next V2 02/10] liquidio: Macro replacements

On Sun, 2016-07-03 at 13:56 -0700, Raghu Vatsavayi wrote: > This patch has minor replacements of ACCESS_ONCE macros with > WRITE_ONCE and replacement of BUG_ON with polite version WARN_ON. And makes some functions static. > diff --git a/drivers/net/ethernet/cavium/liquidio/cn66xx_device.c >

Re: [PATCH 02/17] batman-adv: statically print gateway table header

On Fri, 2016-07-01 at 15:08 +0200, Simon Wunderlich wrote: > To make it easier to search through the code it is better to print static > strings directly instead of using format strings printing constants. It's also generally smaller object code and faster at runtime. $ size

Re: [PATCH v2 net-next 1/9] MAINTAINERS: add maintainers for hns driver

On Thu, 2016-06-30 at 15:25 +0800, Yisen Zhuang wrote: > From: Daode Huang > > This patch adds maintainers for hisilicon network subsystem driver [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -5421,6 +5421,15 @@ F: include/uapi/linux/if_hippi.h >  F:

Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote: > The bgmac_* print wrappers call dev_* prints with the dev pointer from > the bcma core.  In anticipation of removing the bcma requirement for > this driver, these must be changed to not reference that struct.  So, > simply change all of the

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote: > On 06/25/2016 05:46 PM, Joe Perches wrote: > > > > This debugging macro can expand to a lot of code. > > Make it a function to reduce code size. > > > > (x86-64 defconfig w/ all rtlwifi drivers and all

Re: [PATCH net-next 6/9] net: hns: normalize two different loop

On Mon, 2016-06-27 at 15:00 +0300, Andy Shevchenko wrote: > On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote: > > > > On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: > > > > > > From: Daode Huang <huangda...@hisilicon.com> > > > > &g

Re: [PATCH net-next 6/9] net: hns: normalize two different loop

On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: > From: Daode Huang > > There are two approaches to assign data, one does 2 loops, another > does 1 loop. This patch normalize the different methods to 1 loop. [] > diff --git

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: > On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > > > > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > > > > > > RT_TRACE does not add a newline to the end of a messa

Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > RT_TRACE does not add a newline to the end of a message and always > > emits at KERN_DEBUG so these are susceptible to message interleaving > > from other pr

[PATCH] rtlwifi: Add missing newlines to RT_TRACE calls

RT_TRACE does not add a newline to the end of a message and always emits at KERN_DEBUG so these are susceptible to message interleaving from other processes without the newline. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/core.c

[PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

drivers/net/wireless/realtek/rtlwifi/built-in.o.old Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/realtek/rtlwifi/debug.c | 25 + drivers/net/wireless/realtek/rtlwifi/debug.h | 17 + 2 files changed, 34 insertions(+), 8 del

[PATCH] netfilter: Convert FWINV<[foo]> macros and uses to NF_INVF

macro. Miscellanea: o Neaten the alignment around these uses o A few lines are > 80 columns for intelligibility Signed-off-by: Joe Perches <j...@perches.com> --- include/linux/netfilter/x_tables.h| 4 +++ include/linux/netfilter_bridge/ebtables.h | 2 -- net/bridge/netfilter/e

[PATCH] etherdevice.h & bridge: netfilter: Add and use ether_addr_equal_masked

There are code duplications of a masked ethernet address comparison here so make it a separate function instead. Miscellanea: o Neaten alignment of FWINV macro uses to make it clearer for the reader Signed-off-by: Joe Perches <j...@perches.com> --- include/linux/etherdevice.h

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Thu, 2016-06-23 at 19:36 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 15, 2016 at 01:58:45PM -0700, Joe Perches wrote: > > > > There is code duplication of a masked ethernet address comparison here > > so make it a separate function instead. > > > > Miscell

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Wed, 2016-06-22 at 14:40 -0600, Jason Gunthorpe wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > > The output changes now do not include line #, but do include the > > function offset. > I've been using a technique like this in some code with good re

[PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

/ethernet/mellanox/mlx5/core/built-in.o.new  188679    2059  16  190754   2e922 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.old The output changes now do not include line #, but do include the function offset. Signed-off-by: Joe Perches <j...@perches.com> ---  drivers/net/ethernet/me

Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support

On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote: > This patch adds support for gmii2rgmii converter > in the macb driver. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -376,6 +389,20 @@ static int macb_mii_probe(struct

Re: rfc: netfilter: Unhide FWINV macro arguments ?

On Fri, 2016-06-17 at 13:59 +0200, Pablo Neira Ayuso wrote: > On Thu, Jun 16, 2016 at 11:20:59AM -0700, Joe Perches wrote: > > There are several FWINV #defines with identical form > > that hide a specific structure variable and dereference > > it with a invflags member

Re: [PATCH] brcmfmac: use const char * for interface name in brcmf_add_if

On Fri, 2016-06-17 at 12:48 +0200, Rafał Miłecki wrote: > This function can work just fine with const pointer, it only calls > alloc_netdev which take const as well. Moreover it makes this function > more flexible as some cfg80211 callback may provide const char * as > well, e.g. add_virtual_intf.

rfc: netfilter: Unhide FWINV macro arguments ?

There are several FWINV #defines with identical form that hide a specific structure variable and dereference it with a invflags member. $ git grep "define FWINV" include/linux/netfilter_bridge/ebtables.h:#define FWINV(bool,invflg) ((bool) ^ !!(info->invflags & invflg))

Re: [PATCH 6/8] net: gianfar: fix old-style declaration

On Thu, 2016-06-16 at 21:02 +0300, Sergei Shtylyov wrote: > On 06/16/2016 04:52 PM, Arnd Bergmann wrote: > > Modern C standards expect the '__inline__' keyword to come before the return > > type in a declaration, and we get a warning for this with "make W=1": [] > > diff --git

Re: [PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

On Wed, 2016-06-15 at 13:58 -0700, Joe Perches wrote: > There is code duplication of a masked ethernet address comparison here > so make it a separate function instead. > > Miscellanea: > > o Neaten alignment of FWINV macro uses to make it clearer for the reader > > Si

[PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

There is code duplication of a masked ethernet address comparison here so make it a separate function instead. Miscellanea: o Neaten alignment of FWINV macro uses to make it clearer for the reader Signed-off-by: Joe Perches <j...@perches.com> --- This masked_ether_addr_equal function co

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

On Wed, 2016-06-08 at 19:38 +0200, Pablo Neira Ayuso wrote: > On Wed, Jun 08, 2016 at 07:31:21PM +0200, Pablo Neira Ayuso wrote: > > Then you can follow up with a patch to add this function. > > > > Just a suggestion, let me know if this is fine with you. > Forget this idea. > > Actually your

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

On Wed, 2016-06-08 at 13:52 +0200, Pablo Neira Ayuso wrote: > On Tue, Jun 07, 2016 at 11:02:30AM -0700, Joe Perches wrote: > > On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote: > > > On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote: > > > > On

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

On Tue, 2016-06-07 at 19:34 +0200, Pablo Neira Ayuso wrote: > On Tue, Jun 07, 2016 at 10:04:40AM -0700, Joe Perches wrote: > > One more question, is this chunk below correct from > > coding style point of view? > > if (info->bitmask & EBT_STP_ROOTADDR) { &

Re: [PATCH 1/3] bridge: netfilter: checkpatch whitespace fixes

On Tue, 2016-06-07 at 17:14 +0200, Pablo Neira Ayuso wrote: > On Tue, May 10, 2016 at 11:26:56AM +1000, tcharding wrote: > > From: Tobin C Harding > > This is my second linux kernel patch. Unsure if I was meant to cc multiple > > mailing lists? [] > > diff --git

Re: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

On Sat, 2016-06-04 at 16:43 -0300, Augusto Mecking Caringi wrote: > On Sat, Jun 4, 2016 at 4:01 PM, Colin King wrote: > > From: Colin Ian King > > trivial fix to spelling mistake in pr_err message [] > > diff --git

[PATCH] rxrpc: Use pr_ and pr_fmt, reduce object size a few KB

74448 122d0 net/rxrpc/built-in.o.new 6751219728304 77788 12fdc net/rxrpc/built-in.o.old Miscellanea: o Consolidate the ASSERT macros to use a single pr_err call with decimal and hexadecimal output and a stringified #OP argument Signed-off-by: Joe Perches <j...@perches.com>

Re: [PATCH v8 22/22] MAINTAINERS: Add maintainers for HiSilicon RoCE driver

On Wed, 2016-05-25 at 23:05 +0800, Lijun Ou wrote: > This patch added maintainers for RoCE driver. Please add sections in alphabetic order. > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -10121,6 +10121,14 @@ W: http://www.emulex.com >  S: Supported >  F: drivers/infiniband/hw/ocrdma/ >  

Re: [PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv

On Mon, 2016-04-18 at 22:00 -0700, Bjorn Andersson wrote: > From: Pontus Fuchs > > While poking at this I also change two related things. I rename one > variable to make the names consistent. I also move one assignment of > priv_sta to the declaration to save a few lines.

Re: [Intel-wired-lan] [PATCH net-next V2 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Mon, 2016-04-18 at 16:52 +, KY Srinivasan wrote: [] > > > +bool ixgbevf_on_hyperv(struct ixgbe_hw *hw) > > > +{ > > > +   if (hw->mbx.ops.check_for_msg == NULL) > > > +   return true; > > > +   else > > > +   return false; > > > +} trivia: bool func(...) {

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Thu, 2016-04-07 at 18:36 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. [] > diff --git

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote: > Joe Perches <j...@perches.com> wrote: > > > Joe Perches <j...@perches.com> wrote: > > > > It might be better to remove kenter and _enter > > > > altogether and use function tracing instead.

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 18:05 +0100, David Howells wrote: > Joe Perches <j...@perches.com> wrote: > > It might be better to remove kenter and _enter > > altogether and use function tracing instead. > Possibly - but not at this time. Swell. > Besides, isn't th

Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled.

On Thu, 2016-04-07 at 17:23 +0100, David Howells wrote: > Disable a debugging statement that has been left enabled > > Signed-off-by: David Howells > --- > >  net/rxrpc/ar-ack.c |2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/rxrpc/ar-ack.c

Re: [PATCH v7 net-next 1/1] hv_sock: introduce Hyper-V Sockets

On Thu, 2016-04-07 at 05:50 -0700, Dexuan Cui wrote: > Hyper-V Sockets (hv_sock) supplies a byte-stream based communication > mechanism between the host and the guest. It's somewhat like TCP over > VMBus, but the transportation layer (VMBus) is much simpler than IP. style trivia: > diff --git

Re: [PATCH v2 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

On Wed, 2016-04-06 at 14:53 -0300, Marcelo Ricardo Leitner wrote: > It wastes space and gets worse as we add new flags, so convert bit-wide > flags to a bitfield. > > Currently it already saves 4 bytes in sctp_sock, which are left as holes > in it for now. The whole struct needs packing, which

Re: [net-next 03/16] fm10k: Avoid crashing the kernel

On Tue, 2016-04-05 at 01:01 -0700, Jeff Kirsher wrote: > From: Bruce Allan > > Use BUILD_BUG_ON() instead of BUG_ON() where appropriate to get a compile > error rather than crash the kernel. > > Signed-off-by: Bruce Allan > Acked-by: Alexander

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > > > Joe Perches <j...@perches.com> writes: > > > > > > > > Using the normal kernel logg

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > Using the normal kernel logging mechanisms makes this code > > a bit more like other wireless drivers. > Personally I don't see the point but I don't have any strong opin

Re: [PATCH] drivers : Remove unnecessary void pointer conversions

On Sat, 2016-03-26 at 20:42 -0700, Bhaskar Jupudi wrote: > Explicit void pointer conversion is unnecessary > because the conversions to and from a void pointer > are always implicit in 'C'. Changed two instances  > of such conversions. Your patch subject is incorrect, this is for fman not all of

Re: [PATCH RFC 3/9] net: Add fast receive encapsulation

On Fri, 2016-03-25 at 16:40 -0400, David Miller wrote: > From: Tom Herbert > Date: Wed, 23 Mar 2016 15:36:52 -0700 > > > +{ > > + struct udp_sock *up = udp_sk(sk); > > + int is_udplite = IS_UDPLITE(sk); > > + > > + int (*encap_rcv)(struct sock *sk, struct

Re: [PATCH 2/2] drivers: net: ethernet: dlink: dl2k: fix indent

If dl2k is modified at all, maybe convert the printks to netdev_ too so that the logging output is more like other networking drivers. Something like: ---  drivers/net/ethernet/dlink/dl2k.c | 181 +-  1 file changed, 100 insertions(+), 81 deletions(-) diff

Re: [PATCH 1/2] net: ethernet: dlink: dl2k: fix code style

On Wed, 2016-03-23 at 17:36 +0300, Maxim Zhukov wrote: > This commit fixed spacing errors and warnings. This commit log should show that you've tested this by stating something like: "git diff -w shows no difference" and "objdiff shows no changes" If objdiff shows changes, you

Re: [PATCH] ath9k: fix checkpatch.pl identation and sapce errors.

On Tue, 2016-03-22 at 12:23 +0530, Ashwini Singh wrote: > Signed-off-by: Ashwini Singh It might be better to break this into a few different patches. o Remove trailing whitespace o Fix vertical line / brace location o Multi-line statement parenthesis alignment o Space

Re: [PATCH] mac80211: fix order of flag descriptions

On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > Fix order of mac80211_rx_flags description to match the enum. > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > I want ahead and fixed the order of the descriptions. checkpatch.pl was giving > a warning

Re: [PATCH] mac80211: fix order of flag descriptions

On Fri, 2016-03-18 at 17:40 +, Luis de Bethencourt wrote: > On 18/03/16 17:29, Joe Perches wrote: > > On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > > > Fix order of mac80211_rx_flags description to match the enum. [] > > > I want ahead and fixed th

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

On Thu, 2016-03-17 at 21:54 -0500, Larry Finger wrote: > On 03/17/2016 07:00 PM, Joe Perches wrote: > > Use a more common logging style. [ 300K+ quote without comment ] > Joe, Hi Larry. > The patch looks good, but it has conflict in  > drivers/net/wireless/realtek

Re: [PATCH] net: consolidate lock/unlock into unlock_wait

On Fri, 2016-03-18 at 17:37 -0400, David Miller wrote: > From: Nicholas Mc Guire > > The spin_lock()/spin_unlock() is synchronizing on the adapter->work_lock > > as the comment also suggests, which is equivalent to spin_unlock_wait() > > but the later should be more efficient.

Re: [RFC net-next 0/2] Create ancient subdirectories for old hardware

On Fri, 2016-03-18 at 23:16 -0400, David Miller wrote: > From: Joe Perches <j...@perches.com> Date: Fri, 18 Mar 2016 19:28:02 -0700 > > On Fri, 2016-03-18 at 22:11 -0400, David Miller wrote: > >> From: Joe Perches <j...@perches.com> Date: Fri, 18 Mar 2016 17:33:29 -07

Re: [RFC net-next 0/2] Create ancient subdirectories for old hardware

On Fri, 2016-03-18 at 22:11 -0400, David Miller wrote: > From: Joe Perches <j...@perches.com> > Date: Fri, 18 Mar 2016 17:33:29 -0700 > > > Maybe something like this: > >  > > Old, rare, and unsupported hardware should be exposed as ancient. > >  >

[RFC net-next 0/2] Create ancient subdirectories for old hardware

Maybe something like this: Old, rare, and unsupported hardware should be exposed as ancient. The drivers for these ancient hardwares are generally untested with current kernels. Joe Perches (2): drivers/net: Create an ANCIENT_NETDEVICES symbol chelsio: Move original cxgb driver into ancient

<    1   2   3   4   5   6   7   8   9   >