[RFC net-next 2/2] chelsio: Move original cxgb driver into ancient subdirectory

This hardware is no longer sold or supported by Chelsio. The hardware is relatively rare, so move it to an ancient subdirectory. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/chelsio/Kconfig| 2 +- drivers/net/ethernet/chelsio/Ma

[RFC net-next 1/2] drivers/net: Create an ANCIENT_NETDEVICES symbol

Many drivers are ancient and written for hardware that is no longer available. These drivers are effectively untested under current kernels. Add a symbol that could guard inclusions of these drivers into modern kernels unless specifically requested. Signed-off-by: Joe Perches <j...@perches.

Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t

On Tue, 2016-03-15 at 11:03 +0100, Arnd Bergmann wrote: > A recent change to the mbus driver added a warning printk that > prints a phys_addr_t using the %x format string, which fails in > case we build with 64-bit phys_addr_t: Hey Arnd. This is a bad patch subject, %pad is for a dma_addr_t. The

Re: [PATCH 2/2] isdn: hisax: isac: fixed code style issues.

On Sun, 2016-03-13 at 21:21 +0200, Cosmin-Gabriel Samoila wrote: > Fixed errors and warnings reported by checkpatch.pl. Generally it's better to send multiple patches that each change a specific type of style defect. As is, this patch changes object code. Fixing style inconsistency should not do

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

On Wed, 2016-03-09 at 08:08 -0800, Alexander Duyck wrote: > On Tue, Mar 8, 2016 at 10:31 PM, Tom Herbert wrote: > > I took a look inlining these. > > > > #define rol32(V, X) ({  \ > > int word = V;   \ > > if

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

On Tue, 2016-03-08 at 21:23 -0800, Alexander Duyck wrote: > On Tue, Mar 8, 2016 at 3:25 PM, Joe Perches <j...@perches.com> wrote: > > On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: > > > The code for csum_block_add was doing a funky byteswap to swap the even &

Re: [net-next PATCH] csum: Update csum_block_add to use rotate instead of byteswap

On Tue, 2016-03-08 at 14:42 -0800, Alexander Duyck wrote: > The code for csum_block_add was doing a funky byteswap to swap the even and > odd bytes of the checksum if the offset was odd.  Instead of doing this we > can save ourselves some trouble and just shift by 8 as this should have the > same

[PATCH] cisco: enic: Update logging macros and uses

Don't hide varibles used by the logging macros. Miscellanea: o Use the more common ##__VA_ARGS__ extension o Add missing newlines to formats o Realign arguments Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/cisco/enic/enic.h | 22 -- drive

[PATCH 4/5] ti: wl1251: Convert wl1251_notice to wiphy_info/pr_info

Use the more common logging mechanisms. Convert to wiphy_info as these wl1251_notice uses were actually emitted at KERN_INFO. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ti/wl1251/main.c | 4 ++-- drivers/net/wireless/ti/wl1251/sdio.c | 2 +- drivers/net/wi

[PATCH 2/5] ti: wl1251: Convert wl1251_error to wiphy_err/pr_err

Use the more common logging mechanisms. Miscellanea: o Coalesce formats o Realign arguments o Reflow to fit 80 columns o Add #define pr_fmt when pr_ is used Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ti/wl1251/acx.c| 6 ++--- drivers/net/wireless/ti/

[PATCH 5/5] ti: wl1251: Convert wl1251_info to wl1251_debug

These logging messages are always emitted at KERN_DEBUG. Add a DEBUG_ALWAYS enum to the debug type enum and convert the macro and uses from wl1251_info( to wl1251_debug(DEBUG_ALWAYS, Miscellanea: o Remove the now unused wl1251_info macro Signed-off-by: Joe Perches <j...@perches.

[PATCH 3/5] ti: wl1251: Convert wl1251_warning to wiphy_warn

Use the more common logging mechanism. Miscellanea: o Coalesce formats o Realign arguments o Reflow to fit 80 columns Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ti/wl1251/acx.c| 91 - drivers/net/wireless/ti/wl1251/cmd.c

[PATCH 1/5] ti: Convert wl1271_ logging macros to dev_ or pr_

sly incorrect \n uses o Realign arguments o Correct a couple typos and grammar defects o Split a multiple line error message to multiple calls of dev_err o Add #define pr_fmt when pr_ is used o Remove unnecessary/duplicate pr_fmt use from wl1271_debug macro Signed-off-by: Joe Perches <j...@perch

[PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

Using the normal kernel logging mechanisms makes this code a bit more like other wireless drivers. Joe Perches (5): ti: Convert wl1271_ logging macros to dev_ or pr_ ti: wl1251: Convert wl1251_error to wiphy_err/pr_err ti: wl1251: Convert wl1251_warning to wiphy_warn ti: wl1251: Convert

Re: [PATCH 2/3] net: macb: Fix more coding style issues

On Mon, 2016-03-07 at 08:17 -0800, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -127,8

Re: [PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout

On Fri, 2016-03-04 at 09:05 -0700, Troy Kisky wrote: > On 3/4/2016 3:06 AM, Fugang Duan wrote: > > From: Troy Kisky Sent: Thursday, February > > 25, 2016 8:37 AM [] > > > Print the current interrupt flags and mask and the interrupt state during > > > the last > >

Re: [ethtool PATCH v2 10/12] internal.h: TRUE/FALSE macros

On Thu, 2016-03-03 at 20:23 -0800, David Decotigny wrote: > From: David Decotigny [] > diff --git a/internal.h b/internal.h [] > @@ -42,6 +42,14 @@ typedef int32_t s32; >  #include "ethtool-copy.h" >  #include "net_tstamp-copy.h" >   > +#ifndef TRUE > +#  define TRUE (!0) >

Re: [PATCH V3 2/4] net-next: mediatek: add support for MT7623 ethernet

On Thu, 2016-03-03 at 21:02 +0100, John Crispin wrote: > Add ethernet support for MediaTek SoCs from the MT7623 family. [] > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h > b/drivers/net/ethernet/mediatek/mtk_eth_soc.h [] > +/* ugly macro hack to make sure hw_stats and ethtool strings

Re: [PATCH net-next v3 2/3] nsh: logging module

On Tue, 2016-03-01 at 11:11 +, Brian Russell wrote: > Module can register for Type 1 or specified classes of Type 2 metadata > and will then log incoming matching packets. This logging mechanism seems like a way to fill/DoS logs. Maybe use pr_info_ratelimit? Maybe use the trace_events

Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

On Wed, 2016-02-17 at 19:38 -0800, Jeff Kirsher wrote: > From: Mitch Williams > > Mr. Spock would certainly raise an eyebrow to see us using bitwise > operators, when we should clearly be relying on logic. Fascinating. I think it read better before this change.

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

On Sat, 2016-01-30 at 09:51 -0800, Eric Dumazet wrote: > On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote: > > On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy wrote: > > > On 30.01, Lucas Tanure wrote: > > > > As suggested by checkpatch.pl: > > > > CHECK: Prefer kernel

Re: [PATCH] lib: fix callers of strtobool to use char array

On Wed, 2016-01-27 at 16:45 -0800, Kees Cook wrote: > Some callers of strtobool were passing a pointer to unterminated strings. > This fixes the issue and consolidates some logic in cifs. This may be incomplete as it duplicates the behavior for the old number of characters, but this is not a

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

On Wed, 2016-01-06 at 19:01 -0500, David Miller wrote: > The caller checks for NULL, and this is the default implementation > doing precisely what it is meant to do. Yeah, I noticed that later. Nevermind... cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: > A repeating pattern in drivers has become to use OF node information > and, if not found, platform specific host information to extract the > ethernet address for a given device. [] > diff --git a/include/linux/etherdevice.h

Re: [PATCH v2] net: Add eth_platform_get_mac_address() helper.

On Thu, 2016-01-07 at 00:26 +0100, Bjørn Mork wrote: > Joe Perches <j...@perches.com> writes: > > On Wed, 2016-01-06 at 16:33 -0500, David Miller wrote: > > > A repeating pattern in drivers has become to use OF node information > > > and, if not found, platform spe

Re: [PATCH net-next 1/2] Support outside netns for tunnels.

On Mon, 2016-01-04 at 11:47 -0800, Tom Herbert wrote: > On Mon, Jan 4, 2016 at 10:45 AM, Saurabh Mohan > wrote: > > > > This patch enchances a tunnel interface, like gre, to have the tunnel > > encap/decap be in the context of a network namespace that is different

Re: [RFC PATCH net-next 05/24] phy: add phydev_name() macro

On Mon, 2016-01-04 at 18:36 +0100, Andrew Lunn wrote: > Add a phydev_name() macro, to help with moving some structure members > from phy_device. [] > diff --git a/include/linux/phy.h b/include/linux/phy.h [] > @@ -783,6 +783,8 @@static inline int phy_read_status(struct phy_device > *phydev) >  

Re: [PATCH 05/12] net-next: mediatek: add switch driver for mt7621

On Sun, 2016-01-03 at 16:26 +0100, John Crispin wrote: > This driver is very basic and only provides basic init and irq support. > The SoC and switch core both have support for a special tag making DSA > support possible. trivia: > diff --git a/drivers/net/ethernet/mediatek/gsw_mt7621.c >

Re: [PATCH next] net/core/dev: Warn on an impossibly short offload frame

On Sat, 2016-01-02 at 19:25 -0500, Aaron Conole wrote: > When signaling that a GRO frame is ready to be processed, the network stack > correctly checks length and aborts processing when a frame is less than 14 > bytes. However, such a condition is really indicative of a broken driver, > and should

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

On Sat, 2016-01-02 at 18:50 +0100, SF Markus Elfring wrote: > A few update suggestions were taken into account > from static source code analysis. While static analysis can be useful, I don't think these specific conversions are generally useful. Perhaps it would be more useful to convert the

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == X) are equal > for X >= 0. X is not guaranteed to be >= 0 here > Signed-off-by: Ivan Safonov > --- >  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c |

Re: [PATCH] /drivers/net/wireless/ath/ath9k remove unnecessary ?: operator

On Tue, 2015-12-29 at 01:38 +0700, Ivan Safonov wrote: > On 12/29/2015 12:56 AM, Joe Perches wrote: > > On Mon, 2015-12-28 at 20:48 +0700, Ivan Safonov wrote: > > > ((thermometer < 0) ? 0 : (thermometer == X)) and (thermometer == > > > X) are equal for X >= 0. &

Re: pull-request: mac80211 2015-12-15

On Thu, 2015-12-17 at 13:44 +0100, Johannes Berg wrote: > On Wed, 2015-12-16 at 18:34 -0500, David Miller wrote: > >   > > Something about your text encoding kept this from ending up > > in patchwork for some reason. > > > > Hm. I don't see anything special with this, seems to just be plain >

Re: [PATCH 01/15] i40e: Add support for client interface for IWARP driver

On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > From: Anjali Singhai Jain > > This patch adds a Client interface for i40iw driver > support. Also expands the Virtchannel to support messages > from i40evf driver on behalf of i40iwvf driver. [] > diff --git

Re: [PATCH 02/15] i40iw: add main, hdr, status

On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > i40iw_main.c contains routines for i40e <=> i40iw interface and setup. > i40iw.h is header file for main device data structures. > i40iw_status.h is for return status codes. [] > diff --git a/drivers/infiniband/hw/i40iw/i40iw.h >

Re: [PATCH net-next] ipv6: add IPV6_HDRINCL option for raw sockets

On Wed, 2015-12-16 at 17:22 +0100, Hannes Frederic Sowa wrote: > Same as in Windows, we miss IPV6_HDRINCL for SOL_IPV6 and SOL_RAW. > The SOL_IP/IP_HDRINCL is not available for IPv6 sockets. [] > diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c [] > @@ -972,6 +972,11 @@ static int

Re: [PATCH 00/15] add Intel(R) X722 iWARP driver

On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > This series contains the addition of the i40iw.ko driver. This series should probably be respun against -next instead of linus' tree. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros

On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: > On 2015-12-07 17:33, David Laight wrote: > > From: Michal Marek > > > Sent: 04 December 2015 15:26 > > > Otherwise make tags can't parse them: > > > > > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern > > > "\1"

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

On Mon, 2015-12-07 at 16:58 +0800, Yankejian (Hackim Yim) wrote: > On 2015/12/7 11:32, Joe Perches wrote: > > On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote: > > > > From: yankejian <yankej...@huawei.com> > > > > Date: Sat, 5 Dec 2015 15:32:29 +08

Re: [PATCH net-next] net: hns: optimize XGE capability by reducing cpu usage

On Sun, 2015-12-06 at 22:29 -0500, David Miller wrote: > From: yankejian > Date: Sat, 5 Dec 2015 15:32:29 +0800 > > > +#if (PAGE_SIZE < 8192) > > + if (hnae_buf_size(ring) == HNS_BUFFER_SIZE_2048) { > > + truesize = hnae_buf_size(ring); > > + } else { >

Re: [PATCH] mwifiex: fix semicolon.cocci warnings

On Sun, 2015-12-06 at 22:56 +0100, Julia Lawall wrote: > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci There are a lot more of these arch/arm/mach-ixp4xx/goramo_mlr.c:78:static u32 hw_bits = 0xFFFD;/* assume all hardware present */;

Re: use-after-free in sctp_do_sm

On Fri, 2015-12-04 at 11:47 -0500, Jason Baron wrote: > When DYNAMIC_DEBUG is enabled we have this wrapper from > include/linux/dynamic_debug.h: > > if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) > > > So the compiler is not emitting the side-effects in this > case. Huh?  Do I

Re: [net-next v5 2/8] dpaa_eth: add support for DPAA Ethernet

On Fri, 2015-12-04 at 14:55 -0500, David Miller wrote: > From: Madalin Bucur > Date: Thu, 3 Dec 2015 15:49:43 +0200 > > > @@ -0,0 +1,22 @@ > > +menuconfig FSL_DPAA_ETH > > + tristate "DPAA Ethernet" > > + depends on FSL_SOC && FSL_BMAN && FSL_QMAN && FSL_FMAN

Re: [PATCH] MAINTAINERS: add myself as Renesas Ethernet drivers reviewer

On Sat, 2015-12-05 at 04:13 +0300, Sergei Shtylyov wrote: > On 12/05/2015 04:02 AM, Joe Perches wrote: > > > Since you seem to be get_maintainers.pl maintainer, I (and not only I) > > > would like to propose a switch to suppress the committers/authors/etc. > > >

Re: [PATCH] MAINTAINERS: add myself as Renesas Ethernet drivers reviewer

On Sat, 2015-12-05 at 03:57 +0300, Sergei Shtylyov wrote: > Since you seem to be get_maintainers.pl maintainer, I (and not only I) > would like to propose a switch to suppress the committers/authors/etc. It's  > generally annoying and unhelpful to have the bunch of people listed, none of  > which

Re: [PATCH] MAINTAINERS: add myself as Renesas Ethernet drivers reviewer

On Sat, 2015-12-05 at 03:03 +0300, Sergei Shtylyov wrote: > liAdd myself as  a reviewer for the Renesas Ethernet drivers -- > hopefully I > won't miss the buggy  patches anymore. :-) > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against DaveM's

Re: use-after-free in sctp_do_sm

On Thu, 2015-12-03 at 15:10 -0500, Jason Baron wrote: > On 12/03/2015 03:03 PM, Joe Perches wrote: > > On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > > > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > > > I think that as a minimum, the following patch shou

Re: use-after-free in sctp_do_sm

On Thu, 2015-12-03 at 13:52 -0500, Aaron Conole wrote: > Dmitry Vyukov writes: > > On Thu, Dec 3, 2015 at 6:02 PM, Eric Dumazet wrote: > > > On Thu, Dec 3, 2015 at 7:55 AM, Dmitry Vyukov wrote: > > > > On Thu, Dec 3, 2015 at 3:48 PM,

Re: use-after-free in sctp_do_sm

On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: > On 12/03/2015 01:52 PM, Aaron Conole wrote: > > I think that as a minimum, the following patch should be evaluted, > > but am unsure to whom I should submit it (after I test): [] > Agreed - the intention here is certainly to have no side

Re: use-after-free in sctp_do_sm

(adding lkml as this is likely better discussed there) On Thu, 2015-12-03 at 15:42 -0500, Jason Baron wrote: > On 12/03/2015 03:24 PM, Joe Perches wrote: > > On Thu, 2015-12-03 at 15:10 -0500, Jason Baron wrote: > > > On 12/03/2015 03:03 PM, Joe Perches wrote: > > > &g

Re: [net-next 01/17] fm10k: Fix error handling in the function fm10k_setup_tc for certain function calls

On Thu, 2015-12-03 at 16:29 -0800, Jeff Kirsher wrote: > From: Nick I guess this is an OK patch, but the From line isn't correct (missing full name) and the changelog is nigh on unreadable. > This fixes the function fm10k_setup_tc to properly check if the > calls to either

[PATCH] i40e: Fix i40e_print_features() VEB mode output

ot kzalloc o Don't initialize i to 0, use result of first snprintf Noticed-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Joe Perches <j...@perches.com> ---  drivers/net/ethernet/intel/i40e/i40e_main.c | 42 +  1 file changed, 19 inser

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

On Wed, 2015-12-02 at 15:48 -0500, David Miller wrote: > From: Joe Perches <j...@perches.com> 02 Dec 2015 02:12:29 -0800 > > On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > >> On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > >> > Notic

Re: [PATCH] i40e: Fix i40e_print_features() VEB mode output

On Wed, 2015-12-02 at 01:56 -0800, Jeff Kirsher wrote: > On Wed, 2015-12-02 at 00:38 -0800, Joe Perches wrote: > > Commit 7fd89545f337 ("i40e: remove BUG_ON from feature string > > building") > > added defective output when I40E_FLAG_VEB_MODE_ENABLED was set in &

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

On Wed, 2015-11-25 at 11:36 -0800, Joe Perches wrote: > On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > > > From: S

Re: [PATCH] vhost: replace % with & on data path

On Mon, 2015-11-30 at 10:34 +0200, Michael S. Tsirkin wrote: > We know vring num is a power of 2, so use & > to mask the high bits. [] > diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c [] > @@ -1366,10 +1366,12 @@ int vhost_get_vq_desc(struct vhost_virtqueue *vq, > /* Only get

Re: [PATCH] staging: net: core: skbuff.c: Added do-while pair for complex macros

On Thu, 2015-11-26 at 22:06 +0530, Jitendra Kumar Khasdev wrote: > This patch is to file skbuff.c that fixes up following error, > reported by checkpatch.pl tool, Your subject title is not correct. This is not a staging patch. > 1. ERROR: Macros with multiple statements should be enclosed >

Re: [net-next v2 04/15] i40e: remove BUG_ON from feature string building

On Wed, 2015-11-25 at 10:35 -0800, Jeff Kirsher wrote: > On Wed, 2015-11-25 at 21:26 +0300, Sergei Shtylyov wrote: > > On 11/25/2015 09:21 PM, Jeff Kirsher wrote: > > > > > From: Shannon Nelson > > > > > > There's really no reason to kill the kernel thread just because

Re: [net-next 06/16] i40e: Properly cast type for arithmetic

On Wed, 2015-11-25 at 02:46 -0800, Jeff Kirsher wrote: > On Tue, 2015-11-24 at 16:43 -0800, Joe Perches wrote: > > On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote: > > > From: Helin Zhang <helin.zh...@intel.com> > > > > > > Pointer of type void *

Re: [net-next 06/16] i40e: Properly cast type for arithmetic

On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote: > From: Helin Zhang > > Pointer of type void * shouldn't be used in arithmetic, which may > result in compilation error. Casting of (u8 *) can be added to fix > that. > void * arithmetic is used quite frequently in

Re: [net-next 11/16] i40e/i40evf: clean up error messages

On Tue, 2015-11-24 at 16:04 -0800, Jeff Kirsher wrote: > Clean up and enhance error messages related to VF MAC/VLAN filters. > Indicate which VF is having issues, and if possible indicate the MAC > address or VLAN involved. trivia: > diff --git

Re: [PATCH net-next] MAINTAINERS: PHY: Change maintainer to reviewer

On Tue, 2015-11-24 at 15:29 -0800, Florian Fainelli wrote: > Now that there is a reviewer role, add myself as reviewer since the PHY > library code is maintained via the networking tree. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -4195,7 +4195,7 @@ F:

Re: [PATCH] net/ipv4/ipconfig: Rejoin broken lines in console output

On Tue, 2015-11-24 at 14:08 +0100, Geert Uytterhoeven wrote: > Commit 09605cc12c078306 ("net ipv4: use preferred log methods") replaced > a few calls of pr_cont() after a console print without a trailing > newline by pr_info(), causing lines to be split during IP > autoconfiguration Thanks

Re: [net-next 04/15] ixgbe: Delete redundant include file

On Mon, 2015-11-23 at 11:36 -0800, Jeff Kirsher wrote: > Delete a redundant include of net/vxlan.h. unrelated trivia: > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c [] > char ixgbe_driver_name[] = "ixgbe"; This could be const or

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

On Sun, 2015-11-15 at 15:31 +0800, Dave Young wrote: > cfg80211 module prints a lot of messages like below. Actually printing > once is acceptable but sometimes it will print again and again, it looks > very annoying. It is better to change these detail messages to debugging > only. So maybe add

Re: [PATCH v2] stmmac: avoid ipq806x constant overflow warning

On Fri, 2015-11-13 at 08:37 +0100, Geert Uytterhoeven wrote: > On Thu, Nov 12, 2015 at 10:03 PM, Arnd Bergmann > wrote: > > Building dwmac-ipq806x on a 64-bit architecture produces a harmless > > warning from gcc: > > > > stmmac/dwmac-ipq806x.c: In function 'ipq806x_gmac_probe': >

Re: [PATCH] decnet: remove macro-local declarations

On Thu, 2015-11-05 at 20:38 +0100, Julia Lawall wrote: > On Thu, 5 Nov 2015, David Miller wrote: > > From: Julia Lawall > > Date: Thu, 5 Nov 2015 11:18:16 +0100> > > > Move the variable declarations from the for_nexthops macro to the > > > surrounding context, so that it

Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > This introduces the Freescale Data Path Acceleration Architecture > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > the Freescale DPAA QorIQ platforms. []

Re: [net-next v4 1/8] devres: add devm_alloc_percpu()

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Introduce managed counterparts for alloc_percpu() and free_percpu(). > Add devm_alloc_percpu() and devm_free_percpu() into the managed > interfaces list. trivia, could be fixed later > +/** > + * __devm_alloc_percpu - Resource-managed

Re: [net-next v4 3/8] dpaa_eth: add support for S/G frames

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add support for Scater/Gather (S/G) frames. The FMan can place > the frame content into multiple buffers and provide a S/G Table > (SGT) into one first buffer with references to the others. trivia: scatter > diff --git

Re: [net-next v4 6/8] dpaa_eth: add ethtool statistics

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add a series of counters to be exported through ethtool: > - add detailed counters for reception errors; > - add detailed counters for QMan enqueue reject events; > - count the number of fragmented skbs received from the stack; > - count

Re: [net-next v4 3/8] dpaa_eth: add support for S/G frames

On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote: > Add support for Scater/Gather (S/G) frames. The FMan can place > the frame content into multiple buffers and provide a S/G Table > (SGT) into one first buffer with references to the others. trivia: > diff --git

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

On Fri, 2015-10-16 at 13:28 +0200, Arnd Bergmann wrote: > On Friday 16 October 2015 11:14:44 David Laight wrote: > > From: Arnd Bergmann > > > Sent: 16 October 2015 11:01 > > > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > > > has bits set that do not fit into a

Re: [PATCH] net: hisilicon: add OF dependency

On Sat, 2015-10-17 at 02:16 +0800, kbuild test robot wrote: > All errors (new ones prefixed by >>): >drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c: In function > 'hns_dsaf_get_cfg': > >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:151:3: error: implicit > >> declaration of

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

On Fri, 2015-10-16 at 21:50 +0300, Sergei Shtylyov wrote: > On 10/16/2015 09:04 PM, Joe Perches wrote: > > >>>> BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > >>>> has bits set that do not fit into a 32-bit variable on 64-bit >

Re: [net-next 05/17] i40e: Change some messages from info to debug only

On Thu, 2015-10-15 at 02:39 -0700, Jeff Kirsher wrote: > From: Neerav Parikh > > There are several error messages that have been printing when there is > no functional issue. These messages should be available at debug message > level only. [] > diff --git

[PATCH] ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

It seems that kernel memory can leak into userspace by a kmalloc, ethtool_get_strings, then copy_to_user sequence. Avoid this by using kcalloc to zero fill the copied buffer. Signed-off-by: Joe Perches <j...@perches.com> --- stable too... On Tue, 2015-10-13 at 23:59 -0700, Jeff Kirsher

Re: [PATCH 5/6] e1000 driver remove checkpatch errors, warnings and checks.

On Tue, 2015-10-13 at 15:23 -0700, Alexander Duyck wrote: > Please don't just blindly > follow checkpatch as it can give out erroneous information. > > Looking over most of this patch series it seems like it is taking > readability in the wrong direction and reducing the ability to maintain >

Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

On Mon, 2015-10-12 at 13:59 +0200, Arnd Bergmann wrote: > On Monday 12 October 2015 11:23:44 huangdaode wrote: > > + s += sprintf(s, > > + "\t\ttx_ring on > > %p:%u,%u,%u,%u,%u,%llu,%llu\n", > > +

Re: [PATCH] net: nhs: fix 32-bit build warning

On Tue, 2015-10-06 at 23:53 +0200, Arnd Bergmann wrote: > diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c > b/drivers/net/ethernet/hisilicon/hns/hnae.c [] > @@ -448,12 +448,12 @@ static ssize_t handles_show(struct device *dev, > s += sprintf(buf + s, "handle %d (eport_id=%u

Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro

Hello Huang. On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote: > This patch changes the code style to make the code more simple. > also removes the once used HNADEL_TX_MSG macro, according to the HANDEL_TX_MSG typo > review comments from Joe Perches. > > Signed-off-by: huan

Re: [PATCH net-next] bnxt_en: New Broadcom ethernet driver.

On Sat, 2015-10-10 at 07:39 -0400, Michael Chan wrote: > Broadcom ethernet driver for the new family of NetXtreme-C/E > ethernet devices. Thanks. In addition to the kbuild test robot suggestions, you might try running scripts/checkpatch.pl on this and fix up some style trivia. Maybe try

Re: [PATCH] mISDN: use kstrdup() in dsp_pipeline_build

On Sat, 2015-10-10 at 02:32 -0700, Geliang Tang wrote: > Use kstrdup instead of strlen-kmalloc-strcpy. Not the same code. Instead of returning early, a 0 length string will now set pipeline->inuse to 0. Maybe that's OK, but you should state why in the commit log. > diff --git

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote: > The recently added mlxsw driver produces warnings in ARM > allmodconfig: > > drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': > drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count > >=

Re: [PATCH v2 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote: > So this patch replace all pr_xxx by their dev_xxx counterpart. Minor mismatch between subject and commit message. Maybe not worth resending. Thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

On Thu, 2015-09-10 at 14:37 +0200, LABBE Corentin wrote: > replace all > if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) > by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Thanks. Trivia: > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

On Wed, 2015-09-09 at 10:38 +0200, Rasmus Villemoes wrote: > The double memset is a little ugly; using kzalloc avoids it altogether. [] > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c > b/drivers/net/ethernet/marvell/mv643xx_eth.c [] > @@ -1859,14 +1859,11 @@ oom: >

Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote: > The stmmac driver use lots of pr_xxx functions to print information. > This is bad since we cannot know which device logs the information. > (moreover if two stmmac device are present) [] > So this patch replace all pr_xxx by their dev_xxx

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

On Wed, 2015-09-09 at 11:45 -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > > the memory

[PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast_filter

The code around the allocation and loops are a bit obfuscated. Neaten it by using: o kcalloc with decimal count and sizeof(u32) o Decimal loop indexing and i++ not i += 4 o A promiscuous block using a similar style to the multicast block o Remove unnecessary variables Signed-off-by: Joe

Re: [PATCH 3/4] net: mv643xx_eth: use kzalloc

On Wed, 2015-09-09 at 20:34 +0200, Rasmus Villemoes wrote: > mc_spec and mc_other are u32*, we allocate 0x200 = 512 bytes = 128 > u32s, and pointer arithmetic makes mc_other point to the latter 64. Then > the memory is cleared 256 bytes at a time. > > It's unusual and slightly obfuscated code,

Re: [PATCH] net/core/sysctl_net_core.c unused variable

On Sun, 2015-09-06 at 16:36 +0100, Nick Warne wrote: > On 06/09/15 16:28, Joe Perches wrote: > > On Sun, 2015-09-06 at 16:16 +0100, Nick Warne wrote: > >> On 06/09/15 15:52, Joe Perches wrote: > >> > On Sun, 2015-09-06 at 15:13 +0100, Nick Warne wrote: > &g

Re: [GIT] Networking

On Thu, 2015-09-03 at 11:22 -0700, Linus Torvalds wrote: > On Thu, Sep 3, 2015 at 10:40 AM, David Miller wrote: > > > > Linus, what GCC version are you using and what does the warning look > > like? > > I'm on whatever is in F22. gcc -v says > >gcc version 5.1.1

Re: [PATCH net-next] flow_dissector: Fix function argument ordering dependency

On Tue, 2015-09-01 at 18:11 -0700, Tom Herbert wrote: > Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash > based on flowi") introduced a bug in __skb_set_sw_hash where we > require a dependency on evaluating arguments in a function in order. > There is no such ordering

Re: [PATCH] flow_dissector: Use 'const' where possible.

On Tue, 2015-09-01 at 21:19 -0700, David Miller wrote: > Signed-off-by: David S. Miller [] > net/core/flow_dissector.c | 79 > --- Thanks David. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH] mwifiex: Make mwifiex_dbg a function, reduce object size

On Tue, 2015-09-01 at 15:09 +, David Laight wrote: > From: Joe Perches > > Sent: 31 August 2015 18:47 > > > > The mwifiex_dbg macro has two tests that could be consolidated > > into a function reducing overall object size ~10KB (~4%). > > > &g

[PATCH] mwifiex: Make mwifiex_dbg a function, reduce object size

4809 246539 3c30b drivers/net/wireless/mwifiex/built-in.o.new 24394986284809 257386 3ed6a drivers/net/wireless/mwifiex/built-in.o.old Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/mwifiex/main.c | 20 drivers/net/wireless/mwifiex/

Re: [PATCH RFC V3 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

On Sat, 2015-08-29 at 07:32 -0700, Eric Dumazet wrote: On Sat, 2015-08-29 at 14:37 +0530, Raghavendra K T wrote: static inline void __snmp6_fill_stats64(u64 *stats, void __percpu *mib, - int items, int bytes, size_t syncpoff) +

Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

On Fri, 2015-08-28 at 15:29 -0700, Eric Dumazet wrote: On Fri, 2015-08-28 at 14:26 -0700, Joe Perches wrote: 1) u64 array[XX] on stack is naturally aligned, Of course it is. kzalloc() wont improve this at all. Not sure what you believe. An alloc would only reduce stack use. Copying

Re: [PATCH RFC V2 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once

On Fri, 2015-08-28 at 13:33 -0700, Eric Dumazet wrote: We do not bother for small struct. Here, the array is big enough that David prefers having an explicit memset() so that it clearly shows that author of this code was aware of this. It's 288 bytes on stack, maybe a kzalloc would be

<    1   2   3   4   5   6   7   8   9   >