Re: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass

On Thu, 27 Sep 2018 at 00:39, wrote: > > > > As I understand Justin's version adds a generic handler, using the NCSI > > > Netlink interface to pass OEM commands and responses to and from > > > userspace, which does the actual packet handling. > > Thanks for the direction Sam! Justin, if you

[PATCH v2 2/4] net/ncsi: Drop no more channels message

This does not provide useful information. As the ncsi maintainer said: > either we get a channel or broadcom has gone out to lunch Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manag

[PATCH v2 3/4] net/ncsi: Use netdev_dbg for debug messages

c netdev_dbg is enabled > via the dynamic debug control file. Which is what we're after in this case. Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- v2: update commit message net/ncsi/ncsi-aen.c| 6 +++--- net/ncsi/ncsi-manage.c | 33 +++-- 2 fi

[PATCH v2 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

Sam has been handing the maintenance of NCSI for a number release cycles now. Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9d5eeff51b5f..44851f7c46fc 100644 --- a/MAINTAINERS

[PATCH v2 1/4] net/ncsi: Silence debug messages

. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- v2: Fix alignment in ftgmac100 change --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- net/ncsi/ncsi-aen.c

[PATCH v2 0/4] Slience NCSI logging

v2: Fix indent issue and commit message based on Joe's feedback Add Sam's acks Here are three changes to silence unnecessary warnings in the ncsi code. The final patch adds Sam as the maintainer for NCSI. Joel Stanley (4): net/ncsi: Silence debug messages net/ncsi: Drop no more channels

[PATCH 0/4] Slience NCSI logging

Here are three changes to silence unnecessary warnings in the ncsi code. The final patch adds Sam as the maintainer for NCSI. Joel Stanley (4): net/ncsi: Silence debug messages net/ncsi: Drop no more channels message net/ncsi: Use netdev_dbg for debug messages MAINTAINERS: Add Sam

[PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to netdev_dbg. There is no change in behaviour. Signed-off-by: Joel Stanley --- net/ncsi/ncsi-aen.c| 6 +++--- net/ncsi/ncsi-manage.c | 33 +++-- 2 files changed, 18 insertions(+), 21 deletions

[PATCH 4/4] MAINTAINERS: Add Sam as the maintainer for NCSI

Sam has been handing the maintenance of NCSI for a number release cycles now. Signed-off-by: Joel Stanley --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9d5eeff51b5f..44851f7c46fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9756,6

[PATCH 2/4] net/ncsi: Drop no more channels message

This does not provide useful information. As the ncsi maintainer said: > either we get a channel or broadcom has gone out to lunch Signed-off-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c in

[PATCH 1/4] net/ncsi: Silence debug messages

. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Signed-off-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 2 +- net/ncsi/ncsi-aen.c | 4 ++-- net/ncsi/ncsi-manage.c | 14

[PATCH] virto_net: remove empty file 'virtio_net.'

Looks like this was mistakenly added to the tree as part of commit 186b3c998c50 ("virtio-net: support XDP_REDIRECT"). Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/virtio_net. | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 drivers/net/v

[PATCH v3] net: ftgmac100: Request clock and set speed

to be no other upstream users of the FTGMAC100 driver it is hard to know the clocking requirements of other platforms. Therefore a conservative approach was taken with enabling clocks. If the platform is not ASPEED, both requesting the clock and configuring the speed is skipped. Signed-off-by: Joel Stanley &l

[PATCH v2] net: ftgmac100: Request clock and set speed

to be no other upstream users of the FTGMAC100 driver so it is hard to know the clocking requirements of other platforms. Therefore a conservative approach was taken with enabling clocks. If the platform is not ASPEED, both requesting the clock and configuring the speed is skipped. Signed-off-by: Joel Stanley

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 4:14 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > On Tue, 2017-10-10 at 15:19 +1030, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or hi

Re: [PATCH] net: ftgmac100: Request clock and set speed

On Tue, Oct 10, 2017 at 2:34 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > > > On 10/09/2017 09:49 PM, Joel Stanley wrote: >> According to the ASPEED datasheet, gigabit speeds require a clock of >> 100MHz or higher. Other speeds require 25MHz or higher. >>

[PATCH] net: ftgmac100: Request clock and set speed

According to the ASPEED datasheet, gigabit speeds require a clock of 100MHz or higher. Other speeds require 25MHz or higher. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++ 1 file changed, 22 insertions(+) diff

Re: [PATCH net-next v2 3/3] ftgmac100: Support NCSI VLAN filtering when available

when not doing ncsi. The HW doesn't have a > filter in that case (we do have HW vlan tag extraction and injection, > which my driver supports, but that's different flags). Reviewed-by: Joel Stanley <j...@jms.id.au> > --- > v2: Moved ftgmac100 change into same patch and reord

Re: [PATCH net-next v2 1/3] net/ncsi: Fix several packet definitions

the current definitions > need to be gone over, there's a few command/response code paths that are > never triggered and could be broken in similar ways. So we're okay here. > Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com> Reviewed-by: Joel Stanley <j...@jms.id.au> C

Re: [PATCH net-next v2 2/3] net/ncsi: Configure VLAN tag filter

On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas wrote: > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI > stack process new VLAN tags and configure the channel VLAN filter > appropriately. > Several VLAN tags can be set and a "Set VLAN Filter"

[PATCH] ftgmac100: return error in ftgmac100_alloc_rx_buf

have a bug not returning the error. Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac1

Re: [PATCH 2/2] ftgmac100: Make the MDIO bus a child of the ethernet device

Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> Acked-by: Joel Stanley <j...@jms.id.au> > --- > drivers/net/ethernet/faraday/ftgmac100.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > b/drivers/net/ethernet/

Re: [PATCH 1/2] ftgmac100: Increase reset timeout

This bumps the timeout to 200us. > > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> I gave this a spin on the problematic hardware, as well as a few other machines. Looks good, thanks Ben. Tested-by: Joel Stanley <j...@jms.id.au> Cheers, Joel > --- >

Re: [PATCH] net: phy: broadcom: Add support for the BCM54210E

On Wed, Apr 5, 2017 at 3:17 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > > > On 04/04/2017 10:33 PM, Joel Stanley wrote: >> This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL. > > This looks go

[PATCH] net: phy: broadcom: Add support for the BCM54210E

This device is a single-port RGMII 10/100/1000BASE-T PHY with EEE & WOL. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/phy/broadcom.c | 13 + include/linux/brcmphy.h| 2 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/net/phy/broadcom.c b/d

Re: [PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h

rm today. > Add a explicit includes. > > Signed-off-by: Mark Brown <broo...@kernel.org> Acked-by: Joel Stanley <j...@jms.id.au> Thank you for fixing this Mark. Cheers, Joel > --- > drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH 1/2] net: phy: broadcom: Update Auxiliary Control Register macros

igned-off-by: Xo Wang <x...@google.com> Reviewed-by: Joel Stanley <j...@jms.id.au> Cheers, Joel > --- > include/linux/brcmphy.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 2/2] net: phy: broadcom: Add support for BCM54612E

On Sat, Oct 22, 2016 at 3:50 AM, Xo Wang <x...@google.com> wrote: > This PHY has internal delays enabled after reset. This clears the > internal delay enables unless the interface specifically requests them. > > Signed-off-by: Xo Wang <x...@google.com> Reviewed-by: Joel

Re: [PATCH net 2/5] net/ncsi: Split out logic for ncsi_dev_state_suspend_select

Hi Gavin, On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote: > This splits out the code that handles ncsi_dev_state_suspend_select > so that we can add more code to the handler in subsequent patch. > Apart from adding a error tag to reuse the code in error path, > no

Re: [PATCH net 3/5] net/ncsi: Fix stale link state of inactive channels on failover

On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote: > The issue was found on BCM5718 which has two NCSI channels in one > package: C0 and C1. Both of them are connected to different LANs, > means they are in link-up state and C0 is chosen as the active > one until

Re: [PATCH net 4/5] net/ncsi: Choose hot channel as active one if necessary

On Fri, Oct 14, 2016 at 1:23 PM, Gavin Shan wrote: > The issue was found on BCM5718 which has two NCSI channels in one > package: C0 and C1. C0 is in link-up state while C1 is in link-down > state. C0 is chosen as active channel until unplugging and plugging > C0's

[PATCH net-next v2 3/6] net/faraday: Adapt for Aspeed SoCs

marked as reserved but still functional. In the ast2500 this bit is reused for another function, so we need a work around. This was confirmed with engineers from Aspeed that using bit 30 is correct for both the ast2400 and ast2500 SoCs. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drive

[PATCH net-next v2 6/6] net/faraday: Mask out PHYSTS_CHG interrupt

discussion. Signed-off-by: Joel Stanley <j...@jms.id.au> --- v2: - Reworked to mask out PHYSTS_CHG instead of trying to determine the IRQ line level drivers/net/ethernet/faraday/ftgmac100.c | 10 +++--- drivers/net/ethernet/faraday/ftgmac100.h | 1 + 2 files changed, 4 insertions

[PATCH net-next v2 1/6] net/faraday: Separate rx page storage from rxdesc

mac100. Signed-off-by: Andrew Jeffery <and...@aj.id.au> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/dr

Re: [PATCH net-next 0/7] ftgmac100 support for ast2500

Please ignore this one. On Thu, Sep 22, 2016 at 8:33 AM, Joel Stanley <j...@jms.id.au> wrote: > Hello Dave, > > This series adds support to the ftgmac100 driver for the Aspeed ast2400 and > ast2500 SoCs. In particular, they ensure the driver works correctly on the > ast250

[PATCH net-next v2 4/6] net/faraday: Clear stale interrupts

he MAC. Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday

[PATCH net-next v2 5/6] net/faraday: Configure old MDIO interface on Aspeed SoCs

The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5 SoCs. The old one is still available, so select it in order to remain compatible with the ftgmac100 driver. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 9 + drive

[PATCH net-next v2 0/6] ftgmac100 support for ast2500

interrupt, as it helps keep us safe from unhygienic (vendor) bootloaders. Cheers, Joel Andrew Jeffery (2): net/faraday: Separate rx page storage from rxdesc net/faraday: Make EDO{R,T}R bits configurable Gavin Shan (1): net/faraday: Clear stale interrupts Joel Stanley (3): net/faraday

[PATCH net-next v2 2/6] net/faraday: Make EDO{R,T}R bits configurable

From: Andrew Jeffery <and...@aj.id.au> These bits are #defined at a fixed location. In order to support future hardware that has chosen to move these bits around move the bits into a member of the struct ftgmac100. Signed-off-by: Andrew Jeffery <and...@aj.id.au> Signed-off-by: Joe

[PATCH net-next 0/7] ftgmac100 support for ast2500

with the NCSI stack and with a directly attached PHY. Cheers, Joel Andrew Jeffery (2): net/ftgmac100: Separate rx page storage from rxdesc net/ftgmac100: Make EDO{R,T}R bits configurable Gavin Shan (2): net/faraday: Avoid PHYSTS_CHG interrupt net/faraday: Clear stale interrupts Joel Stanley (3

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

On Wed, Sep 21, 2016 at 6:33 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > On Wed, 2016-09-21 at 11:32 +0930, Joel Stanley wrote: >> I had a look at the eval board schematic and it appears that the line >> has pull down resistors on it, explaining why th

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

On Wed, Sep 21, 2016 at 12:59 AM, Andrew Lunn <and...@lunn.ch> wrote: > On Tue, Sep 20, 2016 at 10:13:14PM +1000, Benjamin Herrenschmidt wrote: >> On Tue, 2016-09-20 at 16:00 +0930, Joel Stanley wrote: >> > On Aspeed SoC with a direct PHY connection (non-NSCI), we recei

[PATCH net-next 1/7] net/faraday: Separate rx page storage from rxdesc

mac100. Signed-off-by: Andrew Jeffery <and...@aj.id.au> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/dr

[PATCH net-next 2/7] net/faraday: Make EDO{R,T}R bits configurable

From: Andrew Jeffery <and...@aj.id.au> These bits are #defined at a fixed location. In order to support future hardware that has chosen to move these bits around move the bits into a member of the struct ftgmac100. Signed-off-by: Andrew Jeffery <and...@aj.id.au> Signed-off-by: Joe

[PATCH net-next 0/7] ftgmac100 support for ast2500

with the NCSI stack and with a directly attached PHY. Cheers, Joel Andrew Jeffery (2): net/ftgmac100: Separate rx page storage from rxdesc net/ftgmac100: Make EDO{R,T}R bits configurable Gavin Shan (2): net/faraday: Avoid PHYSTS_CHG interrupt net/faraday: Clear stale interrupts Joel Stanley (3

[PATCH net-next 3/7] net/faraday: Adapt for Aspeed SoCs

marked as reserved but still functional. In the ast2500 this bit is reused for another function, so we need a work around. This was confirmed with engineers from Aspeed that using bit 30 is correct for both the ast2400 and ast2500 SoCs. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drive

[PATCH net-next 5/7] net/faraday: Clear stale interrupts

he MAC. Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday

[PATCH net-next 4/7] net/faraday: Avoid PHYSTS_CHG interrupt

effect is CPU cycles wasted to process the false alarm. This sets bit#11 in MACCR (0x50) to avoid the bogus interrupt. Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 1 + drivers/ne

[PATCH net-next 7/7] net/faraday: Configure old MDIO interface on Aspeed SoCs

The Aspeed SoCs have a new MDIO interface as an option in the G4 and G5 SoCs. The old one is still available, so select it in order to remain compatible with the ftgmac100 driver. Signed-off-by: Joel Stanley <j...@jms.id.au> --- drivers/net/ethernet/faraday/ftgmac100.c | 9 + drive

[PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

: [ISR] = 0x200: PHYSTS_CHG [ 20.30] ftgmac100 1e66.ethernet eth0: [ISR] = 0x200: PHYSTS_CHG This is because the driver was enabling low-level sensitive interrupt generation where the systems are wired for high-level. All CPU cycles are spent servicing this interrupt. Signed-off-by: Joel