Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

On 03/12/2018 15:00, René van Dorst wrote: Quoting Bjørn Mork : Greg Ungerer writes: The following change helped alot, but I still get some problems under sustained load and some types of port setups. Still trying to figure out what exactly is going on. ---

Re: [PATCH 4/4] net: dsa: Add Lantiq / Intel DSA driver for vrx200

On 21/07/18 21:13, Hauke Mehrtens wrote: +#define MC_ENTRY(val, msk, ns, out, len, type, flags, ipv4_len) \ + { val, msk, (ns << 10 | out << 4 | len >> 1),\ + (len & 1) << 15 | type << 13 | flags << 9 | ipv4_len << 8 } +static const struct gswip_pce_microcode

Re: [PATCH 3/4] net: lantiq: Add Lantiq / Intel vrx200 Ethernet driver

On 21/07/18 21:13, Hauke Mehrtens wrote: + * Copyright (C) 2012 John Crispin that is not my mail addr :-)     John

Re: [PATCH v2 rfc 0/8] IGMP snooping for local traffic

On 06/09/17 02:47, Andrew Lunn wrote: Should this be done at the DSA level, or at the driver level? Do any chips do broadcast flooding in hardware already? Hence they currently see broadcast duplication? If i add a broadcast mdb at the DSA level, and the chip is already hard wired to flooding

Re: [PATCH 0/4] net-next: dsa: fix flow dissection

On 10/08/17 08:42, Eric Dumazet wrote: On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote: From: John Crispin <j...@phrozen.org> Date: Wed, 9 Aug 2017 14:41:15 +0200 RPS and probably other kernel features are currently broken on some if not all DSA devices. The root

[PATCH net-next] net: core: fix compile error inside flow_dissector due to new dsa callback

= skb->dev->dsa_ptr->tag_ops; ^ make[3]: *** [net/core/flow_dissector.o] Error 1 Signed-off-by: John Crispin <j...@phrozen.org> --- net/core/flow_dissector.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 5

Re: [PATCH 0/4] net-next: dsa: fix flow dissection

On 10/08/17 08:42, Eric Dumazet wrote: On Wed, 2017-08-09 at 22:52 -0700, David Miller wrote: From: John Crispin <j...@phrozen.org> Date: Wed, 9 Aug 2017 14:41:15 +0200 RPS and probably other kernel features are currently broken on some if not all DSA devices. The root

[PATCH 1/4] net-next: dsa: move struct dsa_device_ops to the global header file

We need to access this struct from within the flow_dissector to fix dissection for packets coming in on DSA devices. Signed-off-by: Muciri Gatimu <muc...@openmesh.com> Signed-off-by: Shashidhar Lakkavalli <shashidhar.lakkava...@openmesh.com> Signed-off-by: John Crispin <j

[PATCH 0/4] net-next: dsa: fix flow dissection

ter John Crispin (4): net-next: dsa: move struct dsa_device_ops to the global header file net-next: dsa: add flow_dissect callback to struct dsa_device_ops net-next: tag_mtk: add flow_dissect callback to the ops struct net-next: dsa: fix flow dissection include/net/dsa.h |

[PATCH 4/4] net-next: dsa: fix flow dissection

hashidhar Lakkavalli <shashidhar.lakkava...@openmesh.com> Signed-off-by: John Crispin <j...@phrozen.org> --- net/core/flow_dissector.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 0cc672aba1f0..5b5be9577257

[PATCH 2/4] net-next: dsa: add flow_dissect callback to struct dsa_device_ops

and offset of the network header. Signed-off-by: Muciri Gatimu <muc...@openmesh.com> Signed-off-by: Shashidhar Lakkavalli <shashidhar.lakkava...@openmesh.com> Signed-off-by: John Crispin <j...@phrozen.org> --- include/net/dsa.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/i

[PATCH 3/4] net-next: tag_mtk: add flow_dissect callback to the ops struct

hashing function properly. Signed-off-by: Muciri Gatimu <muc...@openmesh.com> Signed-off-by: Shashidhar Lakkavalli <shashidhar.lakkava...@openmesh.com> Signed-off-by: John Crispin <j...@phrozen.org> --- net/dsa/tag_mtk.c | 14 -- 1 file changed, 12 insertions(+), 2

[PATCH 0/2] net-next: mediatek: bring up QDMA RX ring 0

The MT7623 has several DMA rings. Inside the SW path, the core will use the PDMA when receiving traffic. While bringing up the HW path we noticed that the PPE requires the QDMA RX to also be brought up as it uses this ring internally for its flow scheduling. John Crispin (2): net-next: mediatek

[PATCH 1/2] net-next: mediatek: fix typos inside the header file

Trivial patch fixing 2 typos. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h

[PATCH 2/2] net-next: mediatek: bring up QDMA RX ring 0

This patch is in preparation for adding HW flow and QoS offloading. For those features to work, the driver needs to bring up the first QDMA RX ring. This ring is used by the PPE offloading HW. Signed-off-by: John Crisp in --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 36

[PATCH] net: dsa: mediatek: add adjust link support for user ports

-by: Shashidhar Lakkavalli <shashidhar.lakkava...@openmesh.com> Signed-off-by: Muciri Gatimu <muc...@openmesh.com> Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/mt7530.c | 38 ++ drivers/net/dsa/mt7530.h | 1 + 2 files chan

Re: [PATCH net-next v3 4/4] MAINTAINERS: add Sean/Nelson as MediaTek ethernet maintainers

g most of the qualifications , stress test and submitting a lot of patches for the driver while Nelson was looking into the aspects more on hardware additions and details such as introducing PDMA with Hardware LRO to the driver. Also update John's up-to-date mail address in the patch. Cc: John Cris

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

On 26/07/17 17:10, Andrew Lunn wrote: On Fri, Jul 21, 2017 at 10:58:12AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this is that skb_hash will call the flow_dissector. At this point the skb still

Re: [PATCH-next] net: ethernet: mediatek: fix implicit irq include causing build fails

in and similar follow-on errors as seen in arm allmodconfig builds. Cc: Sean Wang <sean.w...@mediatek.com> Cc: Felix Fietkau <n...@openwrt.org> Cc: John Crispin <blo...@openwrt.org> Cc: Matthias Brugger <matthias@gmail.com> Cc: linux-media...@lists.infradead.org Signe

Re: [RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

On 21/07/17 17:56, Paolo Abeni wrote: Hi, On Fri, 2017-07-21 at 17:20 +0200, John Crispin wrote: In order to make HW flow offloading work in latest MediaTek silicon we need to propagate part of the RX DMS descriptor to the upper layers populating the flow offload engines HW tables

[RFC 1/2] net-next: add a dma_desc element to struct skb_shared_info

the required information and make it persistent for the lifecycle of the skb and its clones. Signed-off-by: John Crispin <j...@phrozen.org> --- include/linux/skbuff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 4093552be1de..db9576

[RFC 2/2] net-next: mediatek: populate the shared

that is later required by the upper layers to populate the flow offloading engines HW tables properly. This patch sets the skb_shared_info's dma_desc field so that we can use the value later on. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +

[RFC 0/2] net-next: hw flow offloading

is still using NF hooks and I plan to rebase it and send it upstream once the flow table offloading patches that folks are working on are upstream. I am right now trying to get rid of the remaning hacks in the code and wanted to know if this series would be a feasible solution. John John Crispin

[PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file

We need to access this struct from within the flow_dissector to fix dissection for packets coming in on DSA devices. Signed-off-by: John Crispin <j...@phrozen.org> --- include/net/dsa.h | 7 +++ net/dsa/dsa_priv.h | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff

[PATCH V2 4/4] net-next: tag_mtk: add nh and proto offsets to the ops struct

The MT7530 inserts the 4 magic header in between the 802.3 address and protocol field. The patch defines these header such that the flow_disector can properly parse the packet and thus allows hashing to function properly. Signed-off-by: John Crispin <j...@phrozen.org> --- net/dsa/tag_mtk

[PATCH V2 3/4] net-next: dsa: fix flow dissection

ned by the dsa tag driver thus fixing dissection, hashing and RPS. Signed-off-by: John Crispin <j...@phrozen.org> --- net/core/flow_dissector.c | 12 1 file changed, 12 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index fc5fc4594c90..1268ae75c3

[PATCH V2 2/4] net-next: dsa: add 802.3 protocol offset to struct dsa_device_ops

Adding these 2 new fields allows a DSA device to indicate the offsets of the 802.3 header caused by the insertion of the switches tag. Signed-off-by: John Crispin <j...@phrozen.org> --- include/net/dsa.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/net/dsa.h b/inclu

Re: [PATCH net] net: ethernet: mediatek: avoid potential invalid memory access

hecker to avoid the kind of situation happening. Signed-off-by: Sean Wang <sean.w...@mediatek.com> Thanks, i ran into the same problem last week and was going to send a fix shortly. Acked-by: John Crispin <j...@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 6 +

Re: [RFC 1/2] net-next: fix DSA flow_disection

On 20/06/17 23:52, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices

Re: [RFC 1/2] net-next: fix DSA flow_disection

On 20/06/17 19:30, Florian Fainelli wrote: On 06/20/2017 07:01 AM, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call

Re: [RFC 1/2] net-next: fix DSA flow_disection

On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the flow_disector. Hi John What is the call path

Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

On 20/06/17 15:54, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote: The MT7530 inserts the 4 magic header in between the 802.3 address and protocol field. The patch defines these header such that the flow_disector can properly parse the packet and thus allows

[RFC 1/2] net-next: fix DSA flow_disection

hem in order to be able to create the real hash of the connection. Signed-off-by: John Crispin <j...@phrozen.org> --- include/net/dsa.h | 6 ++ net/core/flow_dissector.c | 12 2 files changed, 18 insertions(+) diff --git a/include/net/dsa.h b/include/net/ds

[RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

The MT7530 inserts the 4 magic header in between the 802.3 address and protocol field. The patch defines these header such that the flow_disector can properly parse the packet and thus allows hashing to function properly. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/

[PATCH 3/4] net-next: mediatek: split IRQ register locking into TX and RX

on each other under heavy load. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 79 ++--- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 5 +- 2 files changed, 54 insertions(+), 30 deletions(-) diff --git a/drivers/net/et

[PATCH 4/4] net-next: mediatek: set the rx_queue to 0

The get_rps_cpu() function will not do any RPS on the data flow when no queue is setup and always use the current cpu where the IRQ was handled to also handle the backlog. As we only have one physical queue we always set this to 0 unconditionally. Signed-off-by: John Crispin <j...@phrozen.

[PATCH 2/4] net-next: mediatek: add RX IRQ delay support

The PDMA engine used for RX allows IRQ aggregation. The patch sets up the corresponding registers to aggregate 4 IRQs into one. Using aggregation reduces the load on the core handling to a quarter thus reducing IRQ latency and increasing RX performance by around 10%. Signed-off-by: John Crispin

[PATCH 0/4] net-next: mediatek: various performance improvements

the throughput. Additionally the IRQ mask register is now locked independently for RX and TX. RX IRQ aggregation is also added. With all these patches applied we can almost triple the throughput. While at it we also add PHY status change reporting for GMACs connecting directly to a PHY. John Crispin

[PATCH 1/4] net-next: mediatek: print phy status changes for non DSA GMACs

Currently PHY status changes are only printed for DSA ports. This patch adds code to also print status changes for non-fixed links. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drive

Re: [PATCH V2 2/3] net-next: dsa: add multi cpu port support

on next-20170530] [cannot apply to v4.12-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/John-Crispin/Documentation-devicetree-add-multiple-cpu-port-DSA-binding/20170530-224954 config: x86_64

[PATCH V2 3/3] net-next: dsa: mt7530: add multi cpu port support

to connect to an external PHY. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/mt7530.c | 45 + drivers/net/dsa/mt7530.h | 1 - 2 files changed, 29 insertions(+), 17 deletions(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/n

[PATCH V2 2/3] net-next: dsa: add multi cpu port support

a phandle to the host interface it connects to. Each user port can have a phandle to a cpu port which should be used for traffic between the port and the CPU. Thus simple load sharing over the two CPU ports can be achieved. Signed-off-by: John Crispin <j...@phrozen.org> --- include

[PATCH V2 1/3] Documentation: devicetree: add multiple cpu port DSA binding

Extend the DSA binding documentation, adding the new property required when there is more than one CPU port attached to the switch. Cc: Rob Herring <robh...@kernel.org> Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin <j...@phrozen.org> --- Documentation/devicetree/bind

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

On 23/03/17 15:09, Felix Fietkau wrote: On 2017-03-23 09:06, Sean Wang wrote: Hi Andrew, The purpose for the regmap table registered is to provide a way which helps us to look up a specific register on the switch through regmap-debugfs. And not all ranges of register is defined so I

Re: [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support

On 13/03/17 17:11, sean.w...@mediatek.com wrote: From: Sean Wang MT7530 is a 7-ports Gigabit Ethernet Switch that could be found on Mediatek router platforms such as MT7623A or MT7623N which includes 7-port Gigabit Ethernet MAC and 5-port Gigabit Ethernet PHY. Among

[PATCH 1/2] Documentation: devicetree: change the mediatek ethernet compatible string

and upstream the DSA driver. There are no users of this binding yet. It should be safe to fix this now before it is too late and we need to provide backward compatibility for the mt7623-eth compat string. Reported-by: Sean Wang <sean.w...@mediatek.com> Signed-off-by: John Crispin <j...@ph

[PATCH 2/2] net-next: ethernet: mediatek: change the compatible string

and upstream the DSA driver. There are no users of this binding yet. It should be safe to fix this now before it is too late and we need to provide backward compatibility for the mt7623-eth compat string. Reported-by: Sean Wang <sean.w...@mediatek.com> Signed-off-by: John Crispin <j...@ph

[PATCH] net-next: korina: Fix NAPI versus resources freeing

mbis <a...@ozo.com> Tested-by: John Crispin <j...@phrozen.org> Signed-off-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/korina.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/eth

[RFC 0/4] net-next: dsa: add support for multiple cpu ports

: dsa: Refactor DT probing of a switch port net-next: dsa: Add support for multiple cpu ports. John Crispin (1): net-next: dsa: qca8k: add support for multiple cpu ports Documentation/devicetree/bindings/net/dsa/dsa.txt | 67 +- drivers/net/dsa/qca8k.c

[RFC 3/4] net-next: dsa: Add support for multiple cpu ports.

node in the DSA tree can now have a phandle to the host interface it connects to. Each user port can have a phandle to a cpu port which should be used for traffic between the port and the CPU. Thus simple load sharing over the two CPU ports can be achieved. Signed-off-by: John Crispin <j...@phro

[RFC 1/4] Documentation: devicetree: add multiple cpu port DSA binding

From: Andrew Lunn Extend the DSA binding documentation, adding the new properties required when there is more than one CPU port attached to the switch. Cc: Rob Herring Cc: devicet...@vger.kernel.org Signed-off-by: Andrew Lunn ---

[RFC 4/4] net-next: dsa: qca8k: add support for multiple cpu ports

/leave logic needs a small fix to work with having a cpu port other than 0. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/qca8k.c | 135 +++ drivers/net/dsa/qca8k.h |2 - 2 files changed, 78 insertions(+), 59 deletions(-) diff

[RFC 2/4] net-next: dsa: Refactor DT probing of a switch port

From: Andrew Lunn Move the DT probing of a switch port into a function of its own, since it is about to get more complex. Add better error handling as well. Signed-off-by: Andrew Lunn --- net/dsa/dsa.c | 138

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

On 16/12/2016 10:24, Volodymyr Bendiuga wrote: > Hi all, > > Does this mean we all agree on implementing caching > mechanism in net/dsa layer? If yes, then I can start > working on it immediately. > > Regards, > Volodymyr i think that the brcm approach is better as at least on QCA you can

Re: [PATCH net-next 1/3] net:dsa:mv88e6xxx: use hashtable to store multicast entries

On 15/12/2016 18:21, Vivien Didelot wrote: > Hi Volodymyr, > > Volodymyr Bendiuga writes: > >> Hi Andrew, >> >> I have tested the approach you wrote in previous mails, the one >> with setting next.mac to address we are looking for -1. It seems >> to be as slow as

Re: dsa: handling more than 1 cpu port

On 14/12/2016 12:00, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:35:30AM +0100, John Crispin wrote: >> >> >> On 14/12/2016 11:31, Andrew Lunn wrote: >>> On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: >>>> Hi Andrew, >>>>

Re: dsa: handling more than 1 cpu port

On 14/12/2016 12:00, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:35:30AM +0100, John Crispin wrote: >> >> >> On 14/12/2016 11:31, Andrew Lunn wrote: >>> On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: >>>> Hi Andrew, >>>>

Re: dsa: handling more than 1 cpu port

On 14/12/2016 11:31, Andrew Lunn wrote: > On Wed, Dec 14, 2016 at 11:01:54AM +0100, John Crispin wrote: >> Hi Andrew, >> >> switches supported by qca8k have 2 gmacs that we can wire an external >> mii interface to. Usually this is used to wire 2 of the SoCs MACs t

dsa: handling more than 1 cpu port

Hi Andrew, switches supported by qca8k have 2 gmacs that we can wire an external mii interface to. Usually this is used to wire 2 of the SoCs MACs to the switch. Thw switch itself is aware of one of the MACs being the cpu port and expects this to be port/mac0. Using the other will break the

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

On 18/10/2016 15:24, Andrew Lunn wrote: >> Hi Andrew >> >> i am testing on v4.4 which did not have a phy_disconnect() call. this >> seems to have been fixed by cda5c15b so please ignore this patch > > Hi John > > All patches must be against net-next, or net if it is a fix. Anything > else is

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

On 18/10/2016 14:29, Andrew Lunn wrote: > On Tue, Oct 18, 2016 at 02:12:40PM +0200, John Crispin wrote: >> The shutdown code only stopped the PHYs but does not diconnect them >> properly. This could lead to null pointer deref related kernel oopses >> during reboot

[PATCH] net: dsa: properly disconnect the slave PHYs

The shutdown code only stopped the PHYs but does not diconnect them properly. This could lead to null pointer deref related kernel oopses during reboot. Fix this by calling phy_disconnect() after the PHYs are stopped. Signed-off-by: John Crispin <j...@phrozen.org> --- net/dsa/slave.c

Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

} > > dev_info(eth->dev, "chip id = %d\n", *chip_id); > > return 0; > } > ... > static int mtk_probe(struct platform_device *pdev) > { > ... > err = mtk_get_chip_id(eth, >chip_id); > if (err) > return

Re: [PATCH net-next 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi

Hi Nelson, comment inline On 03/10/2016 09:18, Nelson Chang wrote: > Because hw lro started to be supported from MT7623, the proper way to check if > the feature is capable is to judge by the chip id instead of by the dtsi. > > Signed-off-by: Nelson Chang > --- >

Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

Hi Nelson, comments inline On 03/10/2016 09:18, Nelson Chang wrote: > The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers > in mtk_probe(). > > Signed-off-by: Nelson Chang > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 27

[PATCH 2/4] net-next: dsa: make the set_addr() operation optional

Only 1 of the 3 drivers currently has a set_addr() operation. Make the set_addr() callback optional to reduce the amount of empty stubs inside the drivers. Signed-off-by: John Crispin <j...@phrozen.org> --- net/dsa/dsa.c |8 +--- net/dsa/dsa2.c |8 +--- 2 files chang

[PATCH 3/4] net-next: dsa: b53: remove empty set_addr() stub

The set_addr() callback is now optional. Remove the empty stub that b53 has. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/b53/b53_common.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c

[PATCH 1/4] net-next: dsa: fix duplicate invocation of set_addr()

commit 83c0afaec7b730b ("net: dsa: Add new binding implementation") has a duplicate invocation of the set_addr() operation callback. Remove one of them. Signed-off-by: John Crispin <j...@phrozen.org> --- net/dsa/dsa2.c |4 1 file changed, 4 deletions(-) diff --git a/

[PATCH 0/4] net-next: dsa: set_addr should be optional

The Marvell driver is the only one that actually sets the switches HW address. All other drivers have an empty stub. fix this by making the callback optional. John Crispin (4): net-next: dsa: fix duplicate invocation of set_addr() net-next: dsa: make the set_addr() operation optional net

[PATCH 4/4] net-next: dsa: qca8k: remove empty set_addr() stub

The set_addr() callback is now optional. Remove the empty stub that qca8k has. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/qca8k.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 7f3f178..4788a89

Re: MDB offloading of local ipv4 multicast groups

On 15/09/2016 22:42, Ido Schimmel wrote: > On Thu, Sep 15, 2016 at 08:58:50PM +0200, John Crispin wrote: >> Hi, >> >> While adding MDB support to the qca8k dsa driver I found that ipv4 mcast >> groups don't always get propagated to the dsa driver. In my setup there

MDB offloading of local ipv4 multicast groups

Hi, While adding MDB support to the qca8k dsa driver I found that ipv4 mcast groups don't always get propagated to the dsa driver. In my setup there are 2 clients connected to the switch, both running a mdns client. The .port_mdb_add() callback is properly called for 33:33:00:00:00:FB but

[PATCH V3 1/3] Documentation: devicetree: add qca8k binding

Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * fixup example to include phy nodes and corresponding phandles * add a note explaining why we need to phy nodes Changes in V3 * add note s

[PATCH V3 3/3] net-next: dsa: add new driver for qca8xxx family

interface. Most of the extra callbacks of the DSA subsystem are already supported, such as bridge offloading, stp, fdb. Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * add proper locking for the FDB table * remove udelay when changing the page. neither datasheet nore SD

[PATCH V3 0/3] net-next: dsa: add QCA8K support

* fixed several minor issues to the port setup and arp learning * changed the namespacing as this driver to qca8k The driver has so far only been tested on qca8337/N. It should work on other QCA switches such as the qca8327 with minor changes. John Crispin (3): Documentation: devicetree: add qca8k

[PATCH V3 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

viewed-by: Florian Fainelli <f.faine...@gmail.com> Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * fix some comments * remove dead code * rename variable from phy->reg include/net/dsa.h |1 + net/dsa/Kconfig|3 ++ net/dsa/Makefile |1 + net/

Re: [PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family

On 14/09/2016 12:39, John Crispin wrote: > +static void > +qca8k_fdb_add(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_fdb *fdb, > + struct switchdev_trans *trans) > +{ > + struct qca8k_priv *priv = qca8k_to_priv(ds); > +

[PATCH V2 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

Add support for the 2-bytes Qualcomm tag that gigabit switches such as the QCA8337/N might insert when receiving packets, or that we need to insert while targeting specific switch ports. The tag is inserted directly behind the ethernet header. Signed-off-by: John Crispin <j...@phrozen.

[PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family

interface. Most of the extra callbacks of the DSA subsystem are already supported, such as bridge offloading, stp, fdb. Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * add proper locking for the FDB table * remove udelay when changing the page. neither datasheet nore SD

[PATCH V2 1/3] Documentation: devicetree: add qca8k binding

Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * fixup ecample to include phy nodes and corresponding phandles * add a note explaining why we need to phy nodes .../devicetree/bindings/n

[PATCH V2 0/3] net-next: dsa: add QCA8K support

* fixed several minor issues to the port setup and arp learning * changed the namespacing as this driver to qca8k The driver has so far only been tested on qca8337/N. It should work on other QCA switches such as the qca8327 with minor changes. John Crispin (3): Documentation: devicetree: add qca8k

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 21:07, Andrew Lunn wrote: >> Since the former alternative is prefered, we may want to remove the >> latter soon from DSA. If this phy_port_map is needed for that case, it'd >> be preferable not to add it. > > O.K, so maybe we should solve it the device tree way: > > > {

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 19:09, Florian Fainelli wrote: > On 09/13/2016 08:59 AM, Andrew Lunn wrote: >>> Hi Andrew, >>> >>> this function does indeed duplicate the functionality of >>> phy_ethtool_get_eee() with the small difference, that e->eee_active is >>> also set which phy_ethtool_get_eee() does not

Re: [PATCH V3] net-next: dsa: add FIB support

On 13/09/2016 18:21, Vivien Didelot wrote: > Hi John, > > John Crispin <j...@phrozen.org> writes: > >> @@ -237,6 +237,7 @@ struct switchdev_obj; >> struct switchdev_obj_port_fdb; >> struct switchdev_obj_port_mdb; >> struct switchdev_obj_port_vlan; &

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 03:23, Andrew Lunn wrote: > So lets see if i have this right. > > Port 0 has no internal phy. > Port 1 has an internal PHY at MDIO address 0. > Port 2 has an internal PHY at MDIO address 1. > ... > Port 5 has an internal PHY ad MDIO address 4. > Port 6 has no internal PHY. Hi

Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

On 13/09/2016 02:40, Andrew Lunn wrote: >> > +static int >> > +qca8k_get_eee(struct dsa_switch *ds, int port, >> > +struct ethtool_eee *e) >> > +{ >> > + struct qca8k_priv *priv = qca8k_to_priv(ds); >> > + struct ethtool_eee *p = >port_sts[qca8k_phy_to_port(port)].eee; >> > + u32 lp,

[PATCH V3] net-next: dsa: add FIB support

Add SWITCHDEV_OBJ_ID_IPV4_FIB support to the DSA layer. Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * rebase on latest net-next to fix compile errors Changes in V3 * fix subject prefix. this needs to go into the next tree Documentation/networking/dsa/dsa.txt

[PATCH V2] net: dsa: add FIB support

Add SWITCHDEV_OBJ_ID_IPV4_FIB support to the DSA layer. Signed-off-by: John Crispin <j...@phrozen.org> --- Changes in V2 * rebase on latest net-next to fix compile errors Documentation/networking/dsa/dsa.txt | 18 +++ include/net/dsa.h| 13 ++

Re: [PATCH] net: dsa: add FIB support

On 12/09/2016 16:00, Andrew Lunn wrote: > Hi John > >> +if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add) > > drv recently got renamed to ops, which is what 0-day is complaining > about. > > Andrew > i based this on a net-next from 5-6 days ago, will rebase/resend

[PATCH] net: dsa: add FIB support

Add SWITCHDEV_OBJ_ID_IPV4_FIB support to the DSA layer. Signed-off-by: John Crispin <j...@phrozen.org> --- Documentation/networking/dsa/dsa.txt | 18 +++ include/net/dsa.h| 13 +++ net/dsa/slave.c

[PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

interface. Most of the extra callbacks of the DSA subsystem are already supported, such as bridge offloading, stp, fdb. Signed-off-by: John Crispin <j...@phrozen.org> --- drivers/net/dsa/Kconfig |9 + drivers/net/dsa/Makefile |1 + drivers/net/dsa/qca8k.c

[PATCH 1/3] Documentation: devicetree: add qca8k binding

Add device-tree binding for ar8xxx switch families. Cc: devicet...@vger.kernel.org Signed-off-by: John Crispin <j...@phrozen.org> --- .../devicetree/bindings/net/dsa/qca8k.txt | 53 1 file changed, 53 insertions(+) create mode 100644 Documentation/devi

[PATCH 0/3] net-next: dsa: add QCA8K support

* fixed several minor issues to the port setup and arp learning * changed the namespacing as this driver to qca8k The driver has so far only been tested on qca8337/N. It should work on other QCA switches such as the qca8327 with minor changes. John Crispin (3): Documentation: devicetree: add qca8k

[PATCH 2/3] net-next: dsa: add Qualcomm tag RX/TX handler

Add support for the 2-bytes Qualcomm tag that gigabit switches such as the QCA8337/N might insert when receiving packets, or that we need to insert while targeting specific switch ports. The tag is inserted directly behind the ethernet header. Signed-off-by: John Crispin <j...@phrozen.

Re: [PATCH net-next v5 2/2] net: ethernet: mediatek: enhance RX path by aggregating more SKBs into NAPI

i am just not sure if this is something that is commonly done. someone with more overview of how NAPI should be used might want to comment on this. Tested-by: John Crispin <j...@phrozen.org> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 31 > -

Re: [PATCH net-next v5 1/2] net: ethernet: mediatek: enhance RX path by reducing the frequency of the memory barrier used

t a quick spin on my hardware and it works well even when using more than 1 gmac. Acked-by: John Crispin <j...@phrozen.org> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/eth

Re: [RESEND PATCH net 07/10] net: ethernet: mediatek: fix issue of driver removal with interface is up

On 25/08/2016 12:44, Sean Wang wrote: > 1) mtk_stop() must be called to stop for freeing DMA resources > acquired and restoring state changed by mtk_open() when module > removal. > > 2) group clock disabled related function into mtk_hw_deinit which > could be reused with others functionality

Re: [RESEND PATCH net 08/10] net: ethernet: mediatek: fix the missing of_node_put() after node is used done inside mtk_mdio_init

On 25/08/2016 12:44, Sean Wang wrote: > This patch adds the missing of_node_put() after finishing the usage > of of_get_child_by_name. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> Acked-by: John Crispin <j...@phrozen.org> > --- > drivers/net/ether

Re: [RESEND PATCH net 02/10] net: ethernet: mediatek: fix incorrect return value of devm_clk_get with EPROBE_DEFER

On 25/08/2016 12:44, Sean Wang wrote: > If the return value of devm_clk_get is EPROBE_DEFER, we should > defer probing the driver. The change is verified and works based > on 4.8-rc1 staying with the latest clk-next code for MT7623. > > Signed-off-by: Sean Wang > --- >

Re: [RESEND PATCH net 10/10] net: ethernet: mediatek: fix error handling inside mtk_mdio_init

On 25/08/2016 12:45, Sean Wang wrote: > return -ENODEV if no child is found in MDIO bus. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> Acked-by: John Crispin <j...@phrozen.org> > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +- > 1 file chang

  1   2   3   4   >