From: Andreas Fiedler
The TX stats should be started with the tx_stats_syncp,
there seems to be a copy/paste error in the driver.
Signed-off-by: Andreas Fiedler
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
alable at any web page
> (that I
> know of), but if you are interested in having it then I can send it in a mail
> to
> you.
I'd be delighted to have a look! I hope my mailbox survives that, otherise
sharing it on Google drive works fine.
Yours,
Linus Walleij
Commit 52638f71fcff ("dsa: Move gpio reset into switch driver")
moved the GPIO handling into the switch drivers but forgot
to remove the GPIO header includes.
Signed-off-by: Linus Walleij
---
net/dsa/dsa.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/dsa/dsa.c b/net/dsa/d
h
a bunch of OF nodes held. :/
(Yeah another universe of cleanups the day we need it
to work.)
Yours,
Linus Walleij
, but
no explanation of what the 8 different IO modes may be.
Set it to zero for the time being and drop a comment so
people know what is going on if they run into trouble. This
"mode zero" works fine with the D-Link DIR-685 with
RTL8366RB.
Signed-off-by: Linus Walleij
---
drivers/net/dsa/rtl836
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- No changes, just resending with the rest.
ChangeLog v1->v2:
- No changes, just resending with the rest.
---
drivers/net/ethernet/cortina/gemini.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/driv
The hardware supposedly handles frames up to 10236 bytes and
implements .ndo_change_mtu() so accept 10236 minus the ethernet
header for a VLAN tagged frame on the netdevices. Use
ETH_MIN_MTU as minimum MTU.
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- No changes, just resend
ethtool.
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- Use phy_attached_info() live all other drivers.
- Put it in an if (netif_msg_link()) clause like the
other message from phy_print_status().
- Explain more in the commit message.
ChangeLog v1->v2:
- Use a module parameter and the m
The code was not tested with two ports actually in use at
the same time. (I blame this on lack of actual hardware using
that feature.) Now after locating a system using both ports,
add necessary fix to make both ports come up.
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- No changes, j
The code to calculate the hardware register enumerator
for the maximum L3 length isn't entirely simple to read.
Use the existing defines and rewrite the function into a
table look-up.
Acked-by: Michał Mirosław
Signed-off-by: Linus Walleij
---
ChangeLog v2->v3:
- Collected Michał's
On Wed, Jul 4, 2018 at 10:35 PM Andrew Lunn wrote:
>
> On Wed, Jul 04, 2018 at 08:33:24PM +0200, Linus Walleij wrote:
> > The hardware supposedly handles frames up to 10236 bytes and
> > implements .ndo_change_mtu() so accept 10236 minus the ethernet
> > header
de on fixed links.
The phy-mode is still there as the fixes link in this case
is still an RGMII link.
Tested on the Cortina Gemini driver with the Vitesse DSA
router chip on a fixed 1Gbit link.
Suggested-by: Andrew Lunn
Signed-off-by: Linus Walleij
---
drivers/of/of_mdio.c | 17 +---
On Wed, Jul 4, 2018 at 10:40 PM Andrew Lunn wrote:
> On Wed, Jul 04, 2018 at 08:33:21PM +0200, Linus Walleij wrote:
> > @@ -300,23 +305,26 @@ static void gmac_speed_set(struct net_device *netdev)
> > status.bits.speed = GMAC_SPEED_1000;
> >
The hardware supposedly handles frames up to 10236 bytes and
implements .ndo_change_mtu() so accept 10236 minus the ethernet
header for a VLAN tagged frame on the netdevices. Use
ETH_MIN_MTU as minimum MTU.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Change the min MTU from 256 (ven
The code was not tested with two ports actually in use at
the same time. (I blame this on lack of actual hardware using
that feature.) Now after locating a system using both ports,
add necessary fix to make both ports come up.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- No changes, j
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- No changes, just resending with the rest.
---
drivers/net/ethernet/cortina/gemini.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cortina/gemini.c
b/drivers/net/ethernet/cortina/g
Switch over to using a module parameter and debug prints
that can be controlled by this or ethtool like everyone
else. Depromote all other prints to debug messages.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Use a module parameter and the message levels like all
other driv
The code to calculate the hardware register enumerator
for the maximum L3 length isn't entirely simple to read.
Use the existing defines and rewrite the function into a
table look-up.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- No changes, just resending with the rest.
---
drivers/
Instead of just specify that a PHY is connected at some
speed, also specify which one. This is helpful with several
PHYs on the system.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git
The hardware supposedly handles frames up to 10236 bytes and
implements .ndo_change_mtu() so accept 10236 minus the ethernet
header for a VLAN tagged frame on the netdevices.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 5 +
1 file changed, 5 insertions(+)
diff
The code to calculate the hardware register enumerator
for the maximum L3 length isn't entirely simple to read.
Use the existing defines and rewrite the function into a
table look-up.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 61 ---
1 file
The code was not tested with two ports actually in use at
the same time. (I blame this on lack of actual hardware using
that feature.) Now after locating a system using both ports,
add necessary fix to make both ports come up.
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina
Signed-off-by: Linus Walleij
---
drivers/net/ethernet/cortina/gemini.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/cortina/gemini.c
b/drivers/net/ethernet/cortina/gemini.c
index 8d192fcd51c8..79324bbfd768 100644
--- a/drivers/ne
The GPIO MDIO driver now needs only
so cut the legacy and
includes that are no longer used.
Signed-off-by: Linus Walleij
---
drivers/net/phy/mdio-gpio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 4e4c8daf44c3
ly configuration
from device tree.
Cc: Antti Seppälä
Cc: Roman Yeryomin
Cc: Colin Leitner
Cc: Gabor Juhos
Cc: Florian Fainelli
Signed-off-by: Linus Walleij
---
ChangeLog RFCv1->RFCv2:
- Create the internal MDIO bus from the new MDIO node in
the device tree
- Support disabling all LEDs a
is similar to how we handle
interrupt controllers inside PCI bridges etc.
Cc: Antti Seppälä
Cc: Roman Yeryomin
Cc: Colin Leitner
Cc: Gabor Juhos
Cc: Florian Fainelli
Cc: devicet...@vger.kernel.org
Signed-off-by: Linus Walleij
---
ChangeLog RFCv1->RFCv2:
- Switch to Andrew's suggestion to h
DSA router driver that
is wrong.
I did try this hardware with the present OpenWRT driver
(not DSA) and that failed too.
Anyways check out the new DT bindings etc.
Linus Walleij (4):
net: phy: realtek: Support RTL8366RB variant
net: dsa: Add bindings for Realtek SMI DSAs
net: dsa: realtek-smi: A
from the switch chip.
Cc: Antti Seppälä
Cc: Roman Yeryomin
Cc: Colin Leitner
Cc: Gabor Juhos
Cc: Florian Fainelli
Signed-off-by: Linus Walleij
---
ChangeLog RFCv1->RFCv2:
- No real changes.
---
drivers/net/phy/realtek.c | 32
1 file changed, 32 inserti
This adds the Ethernet and Realtek switch device to the
D-Link DIR-685 Gemini-based device.
Signed-off-by: Linus Walleij
---
ChangeLog RFCv1->RFCv2
- Rebased, use the new DT bindings
---
arch/arm/boot/dts/gemini-dlink-dir-685.dts | 153 -
1 file changed, 152 insertions(+)
eturning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Thanks for fixing this!
Linus Walleij
On Thu, Apr 19, 2018 at 1:02 AM, Andrew Lunn <and...@lunn.ch> wrote:
> This patchset is inspired by a previous version by Linus Walleij
>
> It reworks the mdio-gpio code to make use of gpio descriptors instead
> of gpio numbers. However compared to the previous version, it
On Mon, Mar 19, 2018 at 7:40 AM, Igor Pylypiv <igor.pyly...@gmail.com> wrote:
> cppcheck report:
> [drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab
>
> Signed-off-by: Igor Pylypiv <igor.pyly...@gmail.com>
Acked-by: Linus Walleij <linus.wall..
On Tue, Feb 27, 2018 at 3:00 PM, Florian Fainelli <f.faine...@gmail.com> wrote:
> On 02/25/2018 04:51 AM, Linus Walleij wrote:
>> This kills off the platform data support from the bitbanged
>> GPIO-based MDIO driver and moves it over to using GPIO
>> descriptors exclusiv
On Sun, Feb 25, 2018 at 8:08 PM, Andrew Lunn <and...@lunn.ch> wrote:
> On Sun, Feb 25, 2018 at 01:51:27PM +0100, Linus Walleij wrote:
>> This kills off the platform data support from the bitbanged
>> GPIO-based MDIO driver and moves it over to using GPIO
>> descriptor
.
If bitbanged GPIOs need to set up reset() callbacks these
should be done in the device tree using proper bindings.
If bitbanged GPIOs need to handle IRQs, these should be
done in the device tree using the proper bindings.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/n
This driver can now only be created using the device tree.
Remove the platform data probe path and require OF_MDIO
in Kconfig.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/phy/Kconfig | 2 +-
drivers/net/phy/mdio-gpio.c | 21 ++---
2 files c
-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/phy/mdio-gpio.c | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 6d669f24c0e6..d95bb45eb67b 100644
--- a/drivers/n
use GPIO descriptors
and is completely decoupled from the old GPIO API.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/phy/mdio-gpio.c | 81 +
1 file changed, 23 insertions(+), 58 deletions(-)
diff --git a/drivers/net/ph
this and make the MDIO GPIO driver more
self-contained by starting to move this struct into the driver.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
MAINTAINERS | 1 -
drivers/net/phy/mdio-gpio.c | 19 ++-
include/linux/platfor
be out-of-tree platforms, and
those are not the concern of the kernel community. They need
to move to use device tree (or ACPI etc) like everyone else.
This was tested on the bit-banged GPIO MDIO on the D-Link
DNS-313 and works fine for me.
Linus Walleij (5):
net: mdio-gpio: Localize platform data
-by: kbuild test robot <fengguang...@intel.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/ethernet/cortina/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cortina/Kconfig
b/drivers/net/ethernet/cortina/Kconfig
index
linux build tree
> make ARCH=um
depends on HAS_IOMEM right?
Yeah UM is a real special case.
I'll send a patch.
Yours,
Linus Walleij
.@gmail.com>
Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Changes from v10:
- Fix module compile error caused by the driver using two
module_platform_driver() initcalls: this call has the
limitiation that you can o
dvo...@gmail.com>
Cc: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Reviewed-by: Rob Herring <r...@kernel.org>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v10->v11:
- Resend with the driver.
ChangeLog v9->v10:
- Resend with the driver.
ChangeLog v8->v9:
the zeroday build servers, my own machines
just don't suffice.
Yours,
Linus Walleij
.@gmail.com>
Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Changes from v9:
- Get rid of dma_to_pfn() when looking up pages from their
physical address.
- Replace the freeq_page_tab with a linear array of pag
dvo...@gmail.com>
Cc: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Reviewed-by: Rob Herring <r...@kernel.org>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v9->v10:
- Resend with the driver.
ChangeLog v8->v9:
- Collect Rob's ACK.
ChangeLog v7->v8:
- Use et
On Mon, Dec 18, 2017 at 3:54 PM, Russell King - ARM Linux
<li...@armlinux.org.uk> wrote:
> On Mon, Dec 18, 2017 at 03:48:17PM +0100, Michał Mirosław wrote:
>> On Mon, Dec 18, 2017 at 02:57:37PM +0100, Linus Walleij wrote:
>> > On Sat, Dec 16, 2017 at 8:39 PM, L
On Sat, Dec 16, 2017 at 8:39 PM, Linus Walleij <linus.wall...@linaro.org> wrote:
> The Gemini ethernet has been around for years as an out-of-tree
> patch used with the NAS boxen and routers built on StorLink
> SL3512 and SL3516, later Storm Semiconductor, later Cortina
> Sy
On Mon, Dec 11, 2017 at 8:16 PM, David Miller <da...@davemloft.net> wrote:
> From: Linus Walleij <linus.wall...@linaro.org>
>> +if NET_VENDOR_CORTINA
>> +
>> +config GEMINI_ETHERNET
>> + tristate "Gemini Gigabit Ethernet support"
.@gmail.com>
Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Changes from v8:
- Remove dependency guards in Kconfig to get a wider compile
coverage for the driver to detect broken APIs etc.
Changes from v7:
- Dr
dvo...@gmail.com>
Cc: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Reviewed-by: Rob Herring <r...@kernel.org>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v8->v9:
- Collect Rob's ACK.
ChangeLog v7->v8:
- Use ethernet-port@0 and ethernet-port@1 with unit
} };
>> +
>> + mc_filter[1] = mc_filter[0] = 0;
>
> Looks like this should be = ~0u (IFF_ALLMULTI case).
Yeah it's some error compared to the (horrible) vendor code
here. The vendor tree explicitly checks for both promiscuous
and multicast and sets the masks to ~0 in both cases
explicitly, else leave it as default 0 with the funky
algorithm to set up the mask bit by bit.
I rewrote this piece of code to do the same.
Yours,
Linus Walleij
t...@andestech.com>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
efinitions), tell me and I can fix that too, whatever you like.
Yours,
Linus Walleij
On Thu, Nov 30, 2017 at 12:26 AM, Florian Fainelli <f.faine...@gmail.com> wrote:
> On 11/29/2017 03:19 PM, Linus Walleij wrote:
>> Or are there in pracice things such that reg is different
>> on the port and the PHY connected to it? Then it makes
>> much sense to put an
.
Gemini is the common codename used for all the SoCs using
this IP. An earlier codename was "Lepus".
Cc: Tobias Waldvogel <tobias.waldvo...@gmail.com>
Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
-
dvo...@gmail.com>
Cc: Michał Mirosław <mirq-li...@rere.qmqm.pl>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
.../bindings/net/cortina,gemini-ethernet.txt | 92 ++
1 file changed, 92 insertions(+)
create mode 100644
Documentation/devicetree/bindings/
.cpumask = cpu_all_mask,
> + },
> +
> + .of_irq = {
> + .handler = atcpit100_timer_interrupt,
> + .flags = IRQF_TIMER | IRQF_IRQPOLL,
> + },
I would add:
.of_clk = {
.name = "PCLK",
};
To be explicit on what we use.
(I hope I understand this OF timer right.)
Otherwise it looks good!
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
? "PCLK" is
"peripheral clock" (I hope) and that comes from the bus.
Consider also adding an optional "EXTCLK" already now, since it is
evident from the driver that this is also supported.
Yours,
Linus Walleij
s you
say.
I can take a stab at fixing that if that is what we want.
Yours,
Linus Walleij
d "ifconfig" are used on a typical
say home router.
Yours,
Linus Walleij
This is not supported anymore, devices needing a MAC address
just assign one at random, it's just a driver pecularity.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Documentation/networking/dsa/dsa.txt | 5 -
1 file changed, 5 deletions(-)
diff --git a/Documentation/netw
You have most of the code already for implementing the MDIO bus. The
> rest you can probably borrow from the mv88e6xxx driver.
I have a working MDIO bus coming out directly from the SDA core,
so that part is fine. I also patched in the corresponding PHY driver
(a Realtek derivative for this DSA only, so just a few lines add
in the Realtek PHY driver) and it works fine.
I will repost the series as a non-RFC when I have all parts working
and illustrate with a few examples so you see how I set it up.
I hope I didn't turn the entire subsystem on its head or something...
Yours,
Linus Walleij
ting the DSA device present an irqchip
that the PHY can pick an IRQ from and it works like a charm.
Yours,
Linus Walleij
n one vendor
is using it so it's not a one-off. This Realtek is a RTK-specific thing plus
I don't think they are doing it anymore.
It's very confusing since they are using the MDIO electrical specification
and signal names but a totally different custom SMI wire protocol on top.
Yours,
Linus Walleij
in <ro...@advem.lv>
Cc: Colin Leitner <colin.leit...@googlemail.com>
Cc: Gabor Juhos <juh...@openwrt.org>
Cc: Florian Fainelli <f.faine...@gmail.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
net/dsa/slave.c | 8
1 file changed, 8 insertions(+)
di
googlemail.com>
Cc: Gabor Juhos <juh...@openwrt.org>
Cc: Florian Fainelli <f.faine...@gmail.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/dsa/Kconfig | 12 +
drivers/net/dsa/Makefile |2 +
drivers/net/dsa/realtek-smi.c | 436
e...@gmail.com>
Cc: devicet...@vger.kernel.org
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
.../devicetree/bindings/net/dsa/realtek-smi.txt| 104 +
1 file changed, 104 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
d
from the switch chip.
Cc: Antti Seppälä <a.sepp...@gmail.com>
Cc: Roman Yeryomin <ro...@advem.lv>
Cc: Colin Leitner <colin.leit...@googlemail.com>
Cc: Gabor Juhos <juh...@openwrt.org>
Cc: Florian Fainelli <f.faine...@gmail.com>
Signed-off-by: Linus Walleij <linus.wal
8366RB 3 Edge dsa-0.0:03
41: 0 RTL8366RB 4 Edge dsa-0.0:04
Plugged some cables in/out. Hooray, no polling needed.
Linus Walleij (4):
RFC: net/dsa: Allow DSA PHYs to define link IRQs
RFC: net: phy: realtek: Support RTL8366RB variant
RFC: net: dsa: Add bindings for R
t take the old switchdev-based
SMI-driver and convert it to DSA.
I bet I can do that :D
Well, I will try. Because it's blocking me to work on the Gemini
ethernet driver.
Yours,
Linus Walleij
Top posting and resending since netdev@vger.kernel.org
is the right mail address for this. Mea culpa.
Linus Walleij
On Sat, Oct 14, 2017 at 11:35 AM, Linus Walleij
<linus.wall...@linaro.org> wrote:
> On Thu, Oct 5, 2017 at 11:16 AM, Razvan Stefanescu
> <razvan.stefane...
On Sat, Sep 9, 2017 at 1:18 AM, Florian Fainelli <f.faine...@gmail.com> wrote:
> On 09/08/2017 04:13 PM, Linus Walleij wrote:
>> On Sat, Sep 9, 2017 at 12:38 AM, Florian Fainelli <f.faine...@gmail.com>
>> wrote:
>>
>>> This reverts commit 95b80bf3d
ect GPIOLIB on any platform these days
and get the right APIs, this used to not be the case but I fixed
it a while back.
Alternatively we can depend on GPIOLIB but it's simpler to just
select it I think, it's like a library this code uses and so that's
it.
Yours,
Linus Walleij
Remove unneeded gpiod NULL check")
> Reported-by: Woojung Huh <woojung@microchip.com>
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
Yeah I guess you don't wanna have these messages spewing
in the console. :/
But what about simply doing this:
>From 150e4f3c1f227c
e one by having it probed from a module)
or does it mean the platform can never have it?
If it calls the APIs, it is using it.
Yours,
Linus Walleij
IOLIB
in Kconfig. The whole optional thing is mainly a leftover from when it
was possible to have a local implementation of the GPIOLIB API in
some custom header file, noone sane should be doing that anymore,
and if they do, they can very well face the warnings.
If someone is facing a lot of WARN_ON() messages to this, it is a clear
indication that they need to fix their Kconfig and in that case it is proper.
Yours,
Linus Walleij
optional
> way so document this in bindings.
>
> Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
Reviewed-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
, and may be
switched off in case noone else is using it.
Fix this by returning silently on deferred probe and let the
system work it out.
Cc: Jeremy Linton <jeremy.lin...@arm.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/ethernet/smsc/smsc911x.c | 9 +
ry.
>
> Signed-off-by: Neil Armstrong <narmstr...@baylibre.com>
Looks good to me. Tell me when I may apply it, it looks orthogonal
to the rest of the patches.
Yours,
Linus Walleij
>
This driver has pretty much the same issues as the two others
I reviewed yesterday. Please address the same comments
and repost and I will look at it again!
Yours,
Linus Walleij
(IS_ERR(desc)) {
> + ret = PTR_ERR(desc);
> + goto error;
> + }
> + if (flags & GPIOF_DIR_IN) {
> + ret = gpiod_direction_input(desc);
> + if (ret)
> +
, it is just not
very often routed.
Both these lines are routed to the SoC on the Qualcomm APQ8060
Dragonboard and thus needs to be bound in the device tree.
Cc: devicet...@vger.kernel.org
Cc: Jeremy Linton <jeremy.lin...@arm.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Linton <jeremy.lin...@arm.com>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v2->v3:
- Specify in the commit message that the component has an internal
pull-up that will act if the RESET line is not connected.
- Specify in the commit message that the
out.)
Yours,
Linus Walleij
On Wed, Aug 31, 2016 at 5:08 PM, Jeremy Linton <jeremy.lin...@arm.com> wrote:
> On 08/24/2016 07:59 AM, Linus Walleij wrote:
>>
>> On some systems (such as the Qualcomm APQ8060 Dragonboard) the
>> RESET signal of the SMSC911x is not pulled up by a resistor but
>
nd in case that is present,
we register an interrupt handler to respons to this,
and flag the device and this interrupt as a wakeup.
Cc: Sudeep Holla <sudeep.ho...@arm.com>
Cc: Tony Lindgren <t...@atomide.com>
Cc: Florian Fainelli <f.faine...@gmail.com>
Signed-off-by: Linus Walle
be used on such targets.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v1->v2:
- Use devm_gpiod_request_optiona() and request the line with
GPIOD_OUT_LOW so it is deasserted immediately if active.
---
drivers/net/ethernet/smsc/smsc911x.c | 9 +
1 file c
, it is just not
very often routed.
Both these lines are routed to the SoC on the Qualcomm APQ8060
Dragonboard and thus needs to be bound in the device tree.
Cc: devicet...@vger.kernel.org
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
ChangeLog v1->v2:
- Document for "int
Wysocki <r...@rjwysocki.net>
Cc: John Stultz <john.stu...@linaro.org>
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Added some wakeup people at CC who can (hopefully) tell me if
I'm doing this right or not.
---
drivers/net/ethernet/smsc/smsc911x.c | 48 ++
be used on such targets.
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
drivers/net/ethernet/smsc/smsc911x.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c
b/drivers/net/ethernet/smsc/smsc911x.c
index 8af25563f627..125d58
, it is just not
very often routed.
Both these lines are routed to the SoC on the Qualcomm APQ8060
Dragonboard and thus needs to be bound in the device tree.
Cc: devicet...@vger.kernel.org
Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
---
Documentation/devicetree/bindings/net/smsc91
On Thu, May 26, 2016 at 9:00 PM, Uwe Kleine-König
<u.kleine-koe...@pengutronix.de> wrote:
> On Thu, May 26, 2016 at 11:00:55AM +0200, Linus Walleij wrote:
>> On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König
>> <u.kleine-koe...@pengutronix.de> wrote:
>>
On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König
<u.kleine-koe...@pengutronix.de> wrote:
> [added Linus Walleij to Cc, there is a question for you/him below]
(...)
>> +void mdio_device_reset(struct mdio_device *mdiodev, int value)
>> +{
>&g
...@free.fr
I bet I already ACKed this but anyways:
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
only forward to gpiolib.
On the drivers side we only have 13 occurences of '#include
asm/gpio.h' left, mostly in drivers used on ARM SoC.
So the work left to phase out the legacy GPIO is really not that much
anymore.
Very good job being done here.
Reviewed-by: Linus Walleij linus.wall
On Mon, Aug 3, 2015 at 9:23 AM, Ralf Baechle r...@linux-mips.org wrote:
On Mon, Aug 03, 2015 at 09:13:27AM +0200, Linus Walleij wrote:
Very good job being done here.
Reviewed-by: Linus Walleij linus.wall...@linaro.org
I guess this better go in through the MIPS tree.
Given all the OpenWRT
. This works for all simple cascading GPIO-with-IRQ
controllers with a local mask register. (Not when the system intcon
and GPIO is mashed up though.)
But no hurry with that.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
.
Signed-off-by: Alban Bedel al...@free.fr
This is exactly what the kernel needs. Enjoy my:
Reviewed-by: Linus Walleij linus.wall...@linaro.org
And feel free to merge this through the MIPS tree.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body
1 - 100 of 101 matches
Mail list logo
