d-but-set-variable]
>
> There should check the validity of 'slave_dev'.
>
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
>
> Signed-off-by: YueHaibing
> ---
> v2: use WARN_ON_ONCE as Liran Alon suggested
> ---
> drivers/net/net_failover.c | 3 +++
>
> On 1 Sep 2018, at 6:06, YueHaibing wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
> drivers/net/net_failover.c:598:35: warning:
> variable 'primary_dev' set but not used [-Wunused-but-set-variable]
>
>
On 20/03/18 20:51, valdis.kletni...@vt.edu wrote:
On Tue, 20 Mar 2018 18:39:47 +0200, Liran Alon said:
What is your opinion in regards if it's OK to put the flag enabling this
"fix" in /proc/sys/net/core? Do you think it's sufficient?
Umm.. *which* /proc/sys/net/core? These co
On 20/03/18 18:24, ebied...@xmission.com wrote:
I don't believe the current behavior is a bug.
I looked through the history. Basically skb_scrub_packet
started out as the scrubbing needed for crossing network
namespaces.
Then tunnels which needed 90% of the functionality started
calling
On 20/03/18 18:34, David Miller wrote:
From: Liran Alon <liran.a...@oracle.com>
Date: Tue, 20 Mar 2018 18:11:49 +0200
1. Do we want to make a flag for every bug that is user-space visible?
I think there is place for consideration on a per-case basis. I still
don't see how a user can u
On 20/03/18 18:00, David Miller wrote:
From: Liran Alon <liran.a...@oracle.com>
Date: Tue, 20 Mar 2018 17:34:38 +0200
I personally don't understand why we should maintain
backwards-comparability to this behaviour.
The reason is because not breaking things is a cornerstone of Linux
On 20/03/18 16:47, David Miller wrote:
From: Liran Alon <liran.a...@oracle.com>
Date: Tue, 13 Mar 2018 17:07:22 +0200
Before this commit, dev_forward_skb() always cleared packet's
per-network-namespace info. Even if the packet doesn't cross
network namespaces.
There was a lot of disc
- shmulik.ladk...@gmail.com wrote:
> On Thu, 15 Mar 2018 09:35:51 -0700 (PDT) Liran Alon
> <liran.a...@oracle.com> wrote:
> > - shmulik.ladk...@gmail.com wrote:
> >
> > > On Thu, 15 Mar 2018 08:01:03 -0700 (PDT) Liran Alon
> > > <liran.a...@
- shmulik.ladk...@gmail.com wrote:
> On Thu, 15 Mar 2018 08:01:03 -0700 (PDT) Liran Alon
> <liran.a...@oracle.com> wrote:
> >
> > I still think that default behavior should be to zero skb->mark only
> when skb
> > cross netdevs in different netns.
>
- dan...@iogearbox.net wrote:
> On 03/15/2018 03:35 PM, Roman Mashak wrote:
> > Liran Alon <liran.a...@oracle.com> writes:
> > [...]
> >>> Overall I think it might be nice to not need scrubbing skb in
> such
> >>> cases,
> >>> a
- m...@mojatatu.com wrote:
> Liran Alon <liran.a...@oracle.com> writes:
>
>
> [...]
>
> >> Overall I think it might be nice to not need scrubbing skb in such
> >> cases,
> >> although my concern would be that this has potential to break
- dan...@iogearbox.net wrote:
> On 03/15/2018 10:21 AM, Shmulik Ladkani wrote:
> > Regarding the premise of this commit, this "reduces" the
> > ipvs/orphan/mark scrubbing in the following *non* xnet situations:
> >
> > 1. mac2vlan port xmit to other macvlan ports in Bridge Mode
> > 2.
- shmulik.ladk...@gmail.com wrote:
> Hi,
>
> On Tue, 13 Mar 2018 17:07:22 +0200 Liran Alon <liran.a...@oracle.com>
> wrote:
> > Before this commit, dev_forward_skb() always cleared packet's
> > per-network-namespace info. Even if the packet doesn'
r this change, "skb->mark 1337!" will be printed as necessary.
Signed-off-by: Liran Alon <liran.a...@oracle.com>
Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com>
Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com>
---
include/linux/netdevice.h | 2 +-
net/co
14 matches
Mail list logo
