[PATCH] uapi: use wildcards to list files

/pr.h linux/wil6210_uapi.h linux/nilfs2_ondisk.h linux/hash_info.h linux/seg6_genl.h linux/seg6_hmac.h linux/batman_adv.h linux/nsfs.h linux/qrtr.h linux/btrfs_tree.h linux/coresight-stm.h linux/dma-buf.h linux/module.h linux/lightnvm.h linux/nilfs2_api.h Signed-off-by: Nicolas Dichtel

Re: [PATCH ipsec-next 6/8] xfrm: policy: only use rcu in xfrm_sk_policy_lookup

e patch solves my problem. You can add my 'tested-by' tag in the formal submission. Tested-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

Le 17/11/2016 à 07:32, Cong Wang a écrit : [snip] > since Nicolas' patch doesn't even compile... It's always surprising how agressive you are, really :( Can you show me the compilation error of this patch (we are talking about the v2 patch here)?

Re: [Patch net] net: check dead netns for peernet2id_alloc()

eath of the current netns as early as we can in > peernet2id_alloc(). > > For net-next we can consider to avoid sending rtmsg totally, > it is a good optimization for netns teardown path. > > Fixes: 0c7aecd4bde4 ("netns: add rtnl cmd to add and get peer netns ids") > Reported-b

Re: [PATCH net v2] net: nsid cannot be allocated for a dead netns

Le 17/11/2016 à 05:17, David Miller a écrit : [snip] > Indeed, this looks cleaner, Nicolas? Yes, I agree. Cong already sent a v3 of my patch, let's apply it.

Re: [PATCH ipsec-next 6/8] xfrm: policy: only use rcu in xfrm_sk_policy_lookup

Le 11/08/2016 à 15:17, Florian Westphal a écrit : > Don't acquire the readlock anymore and rely on rcu alone. > > In case writer on other CPU changed policy at the wrong moment (after we > obtained sk policy pointer but before we could obtain the reference) > just repeat the lookup. > >

[PATCH net v2] net: nsid cannot be allocated for a dead netns

x1ff/0x660 [] worker_thread+0x4e/0x480 There is no reason to try to allocate an nsid for a netns which is dying. Fixes: 0c7aecd4bde4 ("netns: add rtnl cmd to add and get peer netns ids") Reported-by: Andrei Vagin <ava...@gmail.com> Signed-off-by: Nicolas Dichtel <nicolas.di

Re: [PATCH net] net: nsid cannot be allocated for a dead netns

Le 16/11/2016 à 10:10, kbuild test robot a écrit : > Hi Nicolas, > > [auto build test ERROR on net/master] And I finally send the wrong version of the patch :(

Re: [PATCH net] net: nsid cannot be allocated for a dead netns

Le 16/11/2016 à 09:41, Nicolas Dichtel a écrit : > Andrei reports the following kmemleak error: > unreferenced object 0x91badb543950 (size 2096): > comm "kworker/u4:0", pid 6, jiffies 4295152553 (age 28.418s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 0

[PATCH net] net: nsid cannot be allocated for a dead netns

x1ff/0x660 [] worker_thread+0x4e/0x480 There is no reason to try to allocate an nsid for a netns which is dying. Reported-by: Andrei Vagin <ava...@gmail.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Thank you for the report. Can you test this patch? Regar

Re: [Patch net] net: saving irq context for peernet2id()

Le 20/10/2016 à 08:52, Cong Wang a écrit : > A kernel warning inside __local_bh_enable_ip() was reported by people > running SELinux, this is caused due to some SELinux functions > (indirectly) call peernet2id() with IRQ disabled in process context, > when we re-enable BH with IRQ disabled kernel

Re: [PATCH net] conntrack: perform a full scan in gc

Le 18/10/2016 à 12:06, Nicolas Dichtel a écrit : > Le 18/10/2016 à 10:47, Florian Westphal a écrit : >> Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >>> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove >>> timed-out entries&qu

Re: Useless debug warning "netlink: 16 bytes leftover after parsing attributes"

Le 18/10/2016 à 07:06, Marcel Holtmann a écrit : > Hi, > > so lately I am seeing a bunch of these warnings: > > netlink: 16 bytes leftover after parsing attributes.. > > While they give you the process name, they are still useless to track down > the message that causes them. I find them even

[PATCH net] conntrack: restart gc immediately if GC_MAX_EVICTS is reached

When the maximum evictions number is reached, do not wait 5 seconds before the next run. CC: Florian Westphal <f...@strlen.de> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/netfilter/nf_conntrack_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH net] conntrack: perform a full scan in gc

Le 18/10/2016 à 10:47, Florian Westphal a écrit : > Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove >> timed-out entries"), netlink conntrack deletion events may be sent

[PATCH net] conntrack: perform a full scan in gc

full scan of conntrack entries after a period of inactivity (no conntrack lookup). CC: Florian Westphal <f...@strlen.de> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Here is another proposal to try to fix the problem. Comments are welcomed, Nicolas net/netfilter/nf

Re: [PATCH net 2/2] conntrack: enable to tune gc parameters

Le 13/10/2016 à 22:43, Florian Westphal a écrit : > Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >> Le 10/10/2016 à 16:04, Florian Westphal a écrit : >>> Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >>>> After commit b87a2f9199ea (&quo

[PATCH net] ipv6: correctly add local routes when lo goes up

m> CC: Balakumaran Kannan <balakumaran.kan...@ap.sony.com> CC: Maruthi Thotad <maruthi.tho...@ap.sony.com> CC: Sabrina Dubroca <s...@queasysnail.net> CC: Hannes Frederic Sowa <han...@stressinduktion.org> CC: Weilong Chen <chenweil...@huawei.com> CC: Gao feng <gao

Re: [PATCH net 2/2] conntrack: enable to tune gc parameters

Le 10/10/2016 à 16:04, Florian Westphal a écrit : > Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >> After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove >> timed-out entries"), netlink conntrack deletion events may be sent with a >>

[PATCH net 0/2] conntrack update

The first patch is a small documentation fix. The second patch adds more flexibility to configure the conntrack gc. I target it specifically to net and not net-next because the removal of the conntrack timer has just land into net. Documentation/networking/nf_conntrack-sysctl.txt | 35

[PATCH net 1/2] conntrack: remove obsolete sysctl (nf_conntrack_events_retry_timeout)

This entry has been removed in commit 9500507c6138. Fixes: 9500507c6138 ("netfilter: conntrack: remove timer from ecache extension") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/networking/nf_conntrack-sysctl.txt | 18 -- 1

[PATCH net 2/2] conntrack: enable to tune gc parameters

e> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/networking/nf_conntrack-sysctl.txt | 17 +++ include/net/netfilter/nf_conntrack_core.h| 5 net/netfilter/nf_conntrack_core.c| 17 +-- net/netfilter/nf_conntrack_stan

[PATCH net] vti6: flush x-netns xfrm cache when vti interface is removed

netns del secure CC: Lance Richardson <lrich...@redhat.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/ip6_vti.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c index 5bd3afdcc77

[PATCH net v2] i40e: fix call of ndo_dflt_bridge_getlink()

es: 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink") CC: Carolyn Wyborny <carolyn.wybo...@intel.com> Signed-off-by: Huaibin Wang <huaibin.w...@6wind.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- v1 -> v2 - remove CC - reb

Re: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

Le 23/09/2016 à 23:37, Jeff Kirsher a écrit : [snip] > Yes, it needs to go through my tree. Please send it to intel-wired-lan@li > sts.osuosl.org mailing list, that way I can track it through our patchwork Ok, will do. I didn't send it to this list the first time because this list is marked as

Re: [PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

Le 19/09/2016 à 18:14, Nicolas Dichtel a écrit : > From: Huaibin Wang <huaibin.w...@6wind.com> > > Order of arguments is wrong. > The wrong code has been introduced by commit 7d4f8d871ab1, but is compiled > only since commit 9df70b66418e. > > Note that this may brea

Re: [PATCH v3] iproute2: build nsid-name cache only for commands that need it

0m3.859s > user0m0.132s > sys0m3.205s > > Signed-off-by: Anton Aksola <aa...@iki.fi> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

Re: [PATCH iproute2] ipmonitor: fix ip monitor can't work when NET_NS is not enabled

to dump and monitor nsid") > Signed-off-by: Liping Zhang <liping.zh...@spreadtrum.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

[PATCH net] i40e: fix call of ndo_dflt_bridge_getlink()

es: 7d4f8d871ab1 ("switchdev; add VLAN support for port's bridge_getlink") CC: Scott Feldman <sfel...@gmail.com> CC: Carolyn Wyborny <carolyn.wybo...@intel.com> CC: Catherine Sullivan <catherine.sulli...@intel.com> Signed-off-by: Huaibin Wang <huaibin.w...@6wind.co

[PATCH net] vti6: fix input path

_key") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/xfrm.h | 4 +++- net/ipv6/ip6_vti.c | 4 +--- net/ipv6/xfrm6_input.c | 16 +++- net/ipv6/xfrm6_tunnel.c | 2 +- 4 files changed, 16 insertions(+), 10 deletions(-) diff --git a/incl

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

Le 16/09/2016 à 15:18, Anton Aksola a écrit : [snip] > Nicolas, > This seems to be caused by netns_add calling unshare(CLONE_NEWNET). > If we initialize the socket for nsid after that it doesn't seem to work. > > Unfortunately I'm not an expert in these details. Should we separate the > socket

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

Le 16/09/2016 à 11:23, Vadim Kochan a écrit : [snip] > Would it be useful to add test for this case into testsuite/ ? Yes, it's a good idea. Regards, Nicolas

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

Le 16/09/2016 à 09:22, Anton Aksola a écrit : > The calling of netns_map_init() before command parsing introduced > a performance issue with large number of namespaces. > > As commands such as add, del and exec do not need to iterate through > /var/run/netns it would be good not no build the

Re: [PATCH] iproute2: build nsid-name cache only for commands that need it

Le 15/09/2016 à 10:23, Anton Aksola a écrit : [snip] > --- a/ip/ipnetns.c > +++ b/ip/ipnetns.c > @@ -775,8 +775,6 @@ static int netns_monitor(int argc, char **argv) > > int do_netns(int argc, char **argv) > { > - netns_map_init(); > - > if (argc < 1) > return

Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue

Le 08/09/2016 à 13:02, Ilpo Järvinen a écrit : [snip] > Acked-By: Ilpo Järvinen Also nitpicking: the end of the email address is missing ;-)

Re: [RFC 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

Le 01/09/2016 à 15:21, David Lebrun a écrit : > On 08/29/2016 05:31 PM, Roopa Prabhu wrote: >> This looks fine. But, i am just trying to see if this can be rtnetlink. >> Have you considered it already ?. >> We would like to keep the API consistent or abstracted to accommodate >> SR-MPLS in the >>

Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id

Le 02/09/2016 à 19:24, Cong Wang a écrit : > On Fri, Sep 2, 2016 at 9:39 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Fri, Sep 2, 2016 at 1:12 AM, Nicolas Dichtel >> <nicolas.dich...@6wind.com> wrote: >>> Le 02/09/2016 à 06:53, Cong Wang a écrit : &

Re: [Patch net-next 1/2] vxlan: call peernet2id() in fdb notification

Le 02/09/2016 à 06:53, Cong Wang a écrit : > netns id should be already allocated each time we change > netns, that is, in dev_change_net_namespace() (more precisely > in rtnl_fill_ifinfo()). It is safe to just call peernet2id() here. > > Cc: Nicolas Dichtel <nicolas.dich...@6

Re: [Patch net-next 2/2] netns: avoid disabling irq for netns id

Le 02/09/2016 à 06:53, Cong Wang a écrit : > We never read or change netns id in hardirq context, > the only place we read netns id in softirq context > is in vxlan_xmit(). So, it should be enough to just > disable BH. Are you sure? Did you audit all part of the code? peernet2id() is called from

Re: [RFC 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

Le 01/09/2016 à 15:11, David Lebrun a écrit : > On 08/31/2016 04:51 PM, Nicolas Dichtel wrote: [snip] >>> +config IPV6_SEG6 >>> + bool "IPv6: Segment Routing support" >>> + depends on IPV6 >>> + ---help--- >>> + Experime

Re: [RFC 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

Le 26/08/2016 à 17:52, David Lebrun a écrit : [snip] > +#define SEG6_VERSION_MAJOR 0 > +#define SEG6_VERSION_MINOR 30 nit: This kind of macros are not used anymore upstream. The git sha1 or the linux version perfectly identifies the version.

Re: [RFC 2/9] ipv6: sr: add code base for control plane support of SR-IPv6

Le 29/08/2016 à 17:31, Roopa Prabhu a écrit : > On 8/26/16, 8:52 AM, David Lebrun wrote: >> This patch adds the necessary hooks and structures to provide support >> for SR-IPv6 control plane, essentially the Generic Netlink commands >> that will be used for userspace control over the Segment

Re: [RFC 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

Le 26/08/2016 à 17:52, David Lebrun a écrit : > Implement minimal support for processing of SR-enabled packets > as described in > https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-01. > > This patch implements the following operations: > - Intermediate segment endpoint:

[PATCH net v2 1/2] ipv6: add missing netconf notif when 'all' is updated

The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- v2: fix a typo in the variable old_dflt net/ipv6/addrconf.c | 7 +++ 1 file chang

[PATCH net v2 2/2] netconf: add a notif when settings are created

All changes are notified, but the initial state was missing. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- v2: no change net/ipv4/devinet.c | 11 +++ net/ipv6/addrconf.c | 9 - 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/net/ipv4/dev

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Le 30/08/2016 à 04:51, YOSHIFUJI Hideaki a écrit : > > > Nicolas Dichtel wrote: [snip] >> +int old_dftl = net->ipv6.devconf_dflt->forwarding; > > dflt, not dftl? Good catch!

Re: [PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

Le 29/08/2016 à 15:00, Sergei Shtylyov a écrit : [snip] >> if (p == >ipv6.devconf_all->forwarding) { >> +int old_dftl = net->ipv6.devconf_dflt->forwarding; >> + >> net->ipv6.devconf_dflt->forwarding = newf; >> +if ((!newf) ^ (!old_dftl)) > >IIUC, !'s are not

[PATCH net 2/2] netconf: add a notif when settings are created

All changes are notified, but the initial state was missing. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv4/devinet.c | 11 +++ net/ipv6/addrconf.c | 9 - 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/net/ipv4/devinet.c b/ne

[PATCH net 1/2] ipv6: add missing netconf notif when 'all' is updated

The 'default' value was not advertised. Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding status") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/addrconf.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/ipv6/addrc

Re: [iproute PATCH v4 0/5] Big C99 style initializer rework

Le 13/07/2016 20:47, Phil Sutter a écrit : > This is v4 of my C99-style initializer related patch series. It compiles successfully with my gcc 4.4.7. Regards, Nicolas

Re: [iproute PATCH 0/2] Netns performance improvements

Le 08/07/2016 19:18, Rick Jones a écrit : > On 07/08/2016 01:01 AM, Nicolas Dichtel wrote: [snip] >> Do you have a script or something else to easily reproduce this problem? > > Do you mean for my much older, slightly different stuff done in HP Public > Cloud, > or for w

Re: [iproute PATCH 0/2] Netns performance improvements

Le 07/07/2016 18:16, Rick Jones a écrit : > On 07/07/2016 08:48 AM, Phil Sutter wrote: >> On Thu, Jul 07, 2016 at 02:59:48PM +0200, Nicolas Dichtel wrote: >>> Le 07/07/2016 13:17, Phil Sutter a écrit : >>> [snip] >>>> The issue came up during Ope

Re: [PATCH net-next] ipv6: do not abuse GFP_ATOMIC in inet6_netconf_notify_devconf()

n ip6mr (we hold RTNL there) > > > Fixes: d67b8c616b48 ("netconf: advertise mc_forwarding status") > Fixes: f3a1bfb11ccb ("rtnl/ipv6: use netconf msg to advertise forwarding > status") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Nicolas Dichtel

Re: [PATCH net-next] ipv4: do not abuse GFP_ATOMIC in inet_netconf_notify_devconf()

> > Fixes: edc9e748934c ("rtnl/ipv4: use netconf msg to advertise forwarding > status") > Fixes: 9e5511106f99 ("rtnl/ipv4: add support of RTM_GETNETCONF") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Nicolas Dichtel <nicolas.dich...@6wind.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Nice catch, thank you!

Re: [iproute PATCH 0/2] Netns performance improvements

Le 07/07/2016 13:17, Phil Sutter a écrit : [snip] > The issue came up during OpenStack Neutron testing, see this ticket for > reference: > > https://bugzilla.redhat.com/show_bug.cgi?id=1310795 Access to this ticket is not public :(

Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

initialized properly. > > We can fix this by setting cb->args[0] only after we've processed the > first element and checking this before calling xfrm_state_walk_done(). > > Fixes: d3623099d3 ("ipsec: add support of limited SA dump") > Cc: Nicolas Dichtel <nic

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

Le 23/06/2016 19:34, Phil Sutter a écrit : > This is v3 of my C99-style initializer related patch series. The changes > since v2 are: Compile-tested with a gcc 4.4.7. Regards, Nicolas

Re: [iproute PATCH 1/3] Use C99 style initializers everywhere

Le 17/06/2016 18:46, Daniel Borkmann a écrit : > On 06/17/2016 06:34 PM, Stephen Hemminger wrote: >> On Fri, 17 Jun 2016 16:09:20 + >> Daniel Borkmann wrote: >> >>> Please have a look at commit 8f80d450c3cb ("tc: fix compilation with old gcc >>> (< 4.6)") ... >>> >>>

[PATCH net v2 4/4] ovs/geneve: fix rtnl notifications on iface deletion

is set to RTNL_LINK_INITIALIZED. Fixes: e305ac6cf5a1 ("geneve: Add support to collect tunnel metadata.") CC: Pravin B Shelar <pshe...@nicira.com> CC: Jesse Gross <je...@nicira.com> CC: Thomas Graf <tg...@suug.ch> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wi

[PATCH net v2 2/4] ovs/vxlan: fix rtnl notifications on iface deletion

she...@nicira.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/net/vxlan.c | 58 +++-- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index f999db2f97b4..b3b

[PATCH net v2 3/4] ovs/gre: fix rtnl notifications on iface deletion

is set to RTNL_LINK_INITIALIZED. Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of vport") CC: Thomas Graf <tg...@suug.ch> CC: Pravin B Shelar <pshe...@nicira.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv4/ip_gre.c | 4

[PATCH net v2 0/4] ovs: fix rtnl notifications on interface deletion

There was no rtnl notifications for interfaces (gre, vxlan, geneve) created by ovs. This problem is fixed by adjusting the creation path. v1 -> v2: - add patch #1 and #4 - rework error handling in patch #2 drivers/net/geneve.c | 14 ++--- drivers/net/vxlan.c | 58

[PATCH net v2 1/4] ovs/gre,geneve: fix error path when creating an iface

After ipgre_newlink()/geneve_configure() call, the netdev is registered. Fixes: 7e059158d57b ("vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices") CC: David Wragg <david@weave.works> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- dri

Re: [PATCH net 1/2] ovs/vxlan: fix rtnl notifications on iface deletion

Le 10/06/2016 19:50, pravin shelar a écrit : [snip] > Patch looks good except the error handling code. earlier call to > vxlan_dev_configure() registers the net-device and add the device to > vxlan device list. it needs to be undone before freeing the device. > Ok, will fix it (and also for

Re: [net v3] veth: advertise peer link once both links are tied together

Le 08/06/2016 22:30, Lance Richardson a écrit : [snip] > I've been pondering how to fix this very problem off-and-on for a few months > now, without having arrived at any solution that was particularly satisfying. > > The main constraints I've been trying to meet are: >- User-space should be

[PATCH net 2/2] ovs/gre: fix rtnl notifications on iface deletion

is set to RTNL_LINK_INITIALIZED. Fixes: b2acd1dc3949 ("openvswitch: Use regular GRE net_device instead of vport") CC: Thomas Graf <tg...@suug.ch> CC: Pravin B Shelar <pshe...@nicira.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv4/ip_gre.c | 4

[PATCH net 1/2] ovs/vxlan: fix rtnl notifications on iface deletion

is set to RTNL_LINK_INITIALIZED. Fixes: dcc38c033b32 ("openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN") CC: Thomas Graf <tg...@suug.ch> CC: Pravin B Shelar <pshe...@nicira.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/net/vxlan.c | 6 ++ 1 f

Re: [PATCH net] net_sched: add missing paddattr description

g: No description found for parameter > 'padattr' > > > Fixes: 9854518ea04d ("sched: align nlattr properly when needed") > Signed-off-by: Eric Dumazet <eduma...@google.com> > Reported-by: kbuild test robot <fengguang...@intel.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Thanks Eric.

Re: [net v3] veth: advertise peer link once both links are tied together

Le 31/05/2016 08:29, Vincent Bernat a écrit : > ❦ 30 mai 2016 18:27 CEST, Nicolas Dichtel <nicolas.dich...@6wind.com> : > >>>> + >>>> + rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL); >>> >>> Maybe ~0U would be better than hijack

Re: [net v3] veth: advertise peer link once both links are tied together

Le 30/05/2016 18:01, Vincent Bernat a écrit : > ❦ 30 mai 2016 17:58 CEST, Vincent Bernat : > >> + >> +rtmsg_ifinfo(RTM_NEWLINK, peer, IFF_SLAVE, GFP_KERNEL); > > Maybe ~0U would be better than hijacking IFF_SLAVE? IFF_SLAVE is wrong. It's a flag here, that will be put in

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 17:26, Vincent Bernat a écrit : > ❦ 30 mai 2016 17:19 CEST, Nicolas Dichtel <nicolas.dich...@6wind.com> : > >>>>> priv = netdev_priv(peer); >>>>> rcu_assign_pointer(priv->peer, dev); >>>>> + >&g

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 12:13, Vincent Bernat a écrit : > When the peer link is created, its "iflink" information is not > advertised through netlink. If a user is maintaining a cache from all > updates, it will miss this information: > > 2: veth0@NONE: mtu 1500 qdisc noop state

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 30/05/2016 12:11, Vincent Bernat a écrit : > ❦ 30 mai 2016 11:23 CEST, Nicolas Dichtel <nicolas.dich...@6wind.com> : > >>> @@ -466,6 +462,10 @@ static int veth_newlink(struct net *src_net, struct >>> net_device *dev, >>> >>> priv = ne

Re: [PATCH] veth: delay peer link configuration after interfaces are tied

Le 29/05/2016 13:17, Vincent Bernat a écrit : [snip] > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index f37a6e61d4ad..9726c4dbf659 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -432,10 +432,6 @@ static int veth_newlink(struct net *src_net, struct > net_device *dev,

[PATCH net] uapi glibc compat: fix compilation when !__USE_MISC in glibc

orb <m...@waldemar-brodkorb.de> CC: Gabriel Laskar <gabr...@lse.epita.fr> CC: Mikko Rapeli <mikko.rap...@iki.fi> Fixes: 4a91cb61bb99 ("uapi glibc compat: fix compile errors when glibc net/if.h included before linux/if.h") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wi

[PATCH net-next] netlink: kill nla_put_u64()

This function is not used anymore. nla_put_u64_64bit() should be used instead. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- I'm asking myself if it's better to rename nla_put_u64_64bit() to nla_put_u64(). Because there is a lot of users, the change will be huge, so

[PATCH net-next] ipv6: fix 4in6 tunnel receive path

Protocol for 4in6 tunnel is IPPROTO_IPIP. This was wrongly changed by the last cleanup. CC: Tom Herbert <t...@herbertland.com> Fixes: 0d3c703a9d17 ("ipv6: Cleanup IPv6 tunnel receive path") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/ip6_t

Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

Le 10/05/2016 11:40, Lars Ellenberg a écrit : > On Tue, May 10, 2016 at 11:09:53AM +0200, Nicolas Dichtel wrote: >> Le 09/05/2016 15:15, Lars Ellenberg a écrit : >>> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: >> [snip] >>>&g

[PATCH net-next v2] ila: ipv6/ila: fix nlsize calculation for lwtunnel

t;ipv6: use nla_put_u64_64bit()") Fixes: 90bfe662db13 ("ila: add checksum neutral ILA translations") Reported-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Signed-off-by: Tom Herbert <t...@herbertland.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6win

Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages

Le 09/05/2016 15:15, Lars Ellenberg a écrit : > On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote: [snip] >> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_' >> could be interesting so that new module won't use it. What is your >> opinion? &

[PATCH net-next v3] block/drbd: align properly u64 in nl messages

The attribute 0 is never used in drbd, so let's use it as pad attribute in netlink messages. This minimizes the patch. Note that this patch is only compile-tested. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Signed-off-by: Lars Ellenberg <lars.ellenb...@linbit.com> -

Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

Le 04/05/2016 11:05, Lars Ellenberg a écrit : [snip] > We don't have an "alignment problem" there, btw. > Last time I checked, we did work fine without this alignment magic, > we already take care of that, yes, even on affected architectures. The code adds several consecutive u64 attributes. The

Re: [PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

Le 03/05/2016 12:06, Lars Ellenberg a écrit : > On Tue, May 03, 2016 at 11:39:18AM +0200, Nicolas Dichtel wrote: >> Two new handlers have been defined in genl_magic_ headers: >> - __field2: the corresponding nla_put() function (nla_put_flag()) takes >> only tw

[PATCH net-next v2] block/drbd: use nla_put_u64_64bit()

__unspec_field for padding attribute. __field4 allows us to update the definition of __u64_field: the pad attribute should now be specified. Note that this patch is only compile-tested. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- v1 -> v2: rework the patch to handle

Re: [PATCH net-next] block/drbd: use nla_put_u64_64bit()

Le 03/05/2016 10:50, Nicolas Dichtel a écrit : > I had to define an intermediate function (nla_magic_put_flag()) because > handlers in genl_magic_struct.h expect a function with three arguments. > > Note that this patch is only compile-tested. > > Signed-off-by: Nicolas Dic

[PATCH net-next] block/drbd: use nla_put_u64_64bit()

I had to define an intermediate function (nla_magic_put_flag()) because handlers in genl_magic_struct.h expect a function with three arguments. Note that this patch is only compile-tested. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/block/drbd/drbd_nl.c

[PATCH net v1] ipv6/ila: fix nlsize calculation for lwtunnel

The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") CC: Tom Herbert <t...@herbertland.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- RFC -> v1: - rebase on las

Re: [RFC PATCH net] ipv6/ila: fix nlsize calculation for lwtunnel

Le 28/04/2016 18:07, Tom Herbert a écrit : > On Wed, Apr 27, 2016 at 12:20 PM, David Miller <da...@davemloft.net> wrote: >> From: Nicolas Dichtel <nicolas.dich...@6wind.com> >> Date: Fri, 22 Apr 2016 17:58:02 +0200 >> >>> The handler 'ila_fill_encap_

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Le 28/04/2016 17:54, David Miller a écrit : [snip] > You can say whatever you want, but the facilities you are adding to > this driver enables proprietary userland SDK components. > > And this is precisely what we are trying to avoid by having a clean, > fully featured switch device model in the

Re: [PATCH net-next] ila: ipv6/ila: fix nlsize calculation for lwtunnel

ing module") > Reported-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > Signed-off-by: Tom Herbert <t...@herbertland.com> > --- > net/ipv6/ila/ila_lwt.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/net/ipv6/ila/ila_l

Re: [PATCH net-next] vxlan: fix ethernet address initialization

Le 28/04/2016 12:04, Nicolas Dichtel a écrit : > Since commit 0c867c9bf84c, when the user specifies an ethernet address with > IFLA_ADDRESS, it's overridden by vxlan_ether_setup() (rtnl_link_ops->setup > is called in rtnetlink.c before handling IFLA_ADDRESS). > > To test it:

Re: [PATCH net-next] vxlan: fix initialization with custom link parameters

type yet at that point, > and changed to the correct interface type later. > > Fixes: 0c867c9bf84c ("vxlan: move Ethernet initialization to a separate > function") > Reported-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > Signed-off-by: Jiri Benc <jb...@redhat.com> Tested-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

Re: [PATCH net-next 00/17] net: snmp: update SNMP methods

Le 28/04/2016 14:00, Eric Dumazet a écrit : [snip] > Hi Nicolas, thanks for testing. > > Oh right, I shouldn't have changed the BH disabling of 64bit stats on > 32bit arches, of course. > > Can you double check this will fix the problem ? Thanks ! Thank you for the quick fix!

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Le 27/04/2016 19:07, Stephen Hemminger a écrit : [snip] > Also it has a bunch of device specific generic netlink which was > a red flag for me. > Ok, I will rework this part.

Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Le 27/04/2016 18:55, David Miller a écrit : > From: Jiri Pirko [snip] >> The difference is that it this tries to allow userspace crap to mirror >> setting user does for bridge/ovs. Basically this looks to me like an >> attempt to enable userspace SDKs and such. > > +1 I don't

[PATCH net-next] vxlan: fix ethernet address initialization

oup 239.0.0.10 dev eth0 CC: Jiri Benc <jb...@redhat.com> Fixes: 0c867c9bf84c ("vxlan: move Ethernet initialization to a separate function") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/net/vxlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c

nested attributes. Fixes: a3baf649ca9c ("[PATCH] per-task-delay-accounting: documentation") Fixes: 80df554275c2 ("taskstats: use the libnl API to align nlattr on 64-bit") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/accounting/getdelays.c

[PATCH net-next v2] taskstats: fix nl parsing in accounting/getdelays.c

nested attributes. Fixes: a3baf649ca9c ("[PATCH] per-task-delay-accounting: documentation") Fixes: 80df554275c2 ("taskstats: use the libnl API to align nlattr on 64-bit") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/accounting/getdelays.c |

Re: [PATCH net-next] taskstats: fix nl parsing in accounting/getdelays.c

Le 27/04/2016 17:47, Nicolas Dichtel a écrit : > The type TASKSTATS_TYPE_NULL should always be ignored. > > When jumping to the next attribute, only the length of the current > attribute should be added, not the length of all nested attributes. > This last bug was not visibl

Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

Le 27/04/2016 14:29, Balbir Singh a écrit : [snip] > Please try > > https://www.kernel.org/doc/Documentation/accounting/getdelays.c A patch follows this mail to fix that. > > iotop uses it as well. My concern is ABI breakage of user space. My test is ok here, I didn't see a problem. Code review

<    1   2   3   4   5   6   >