Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Le 27/04/2016 17:14, Jiri Pirko a écrit : > Wed, Apr 27, 2016 at 11:56:15AM CEST, f...@strlen.de wrote: >> Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: >>> This patch adds the support of the 6WIND SHULTI switch. It is a software >>> switch doing L2 forwa

[PATCH net-next] drivers/net: add 6WIND SHULTI support

and FDB ageing. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- MAINTAINERS|9 + drivers/net/ethernet/6wind/Kconfig | 20 + drivers/net/ethernet/6wind/Makefile|6 + drivers/net/ethernet/6wind/

Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

Le 27/04/2016 03:14, Balbir Singh a écrit : > > > On 23/04/16 01:31, Nicolas Dichtel wrote: >> Goal of this patch is to use the new libnl API to align netlink attribute >> when needed. >> The layout of the netlink message will be a bit different after the pa

Re: [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()

Le 26/04/2016 13:08, Jan Kara a écrit : > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote: >> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> > > OK, so I somewhat miss a description of what will this do to the netlink > message so that I can judge wh

[PATCH net-next 4/8] sock_diag: align nlattr properly when needed

I also fix the value of INET_DIAG_MAX. It's wrong since commit 8f840e47f190 which is only in net-next right now, thus I didn't make a separate patch. Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- in

[PATCH net-next 2/8] drivers/wireless: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/net/wireless/mac80211_hwsim.c | 2 +- drivers/net/wireless/mac80211_hwsim.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_h

[PATCH net-next 1/8] macsec: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/net/macsec.c | 121 ++--- include/uapi/linux/if_link.h | 1 + include/uapi/linux/if_macsec.h | 6 ++ 3 files changed, 95 insertions(+), 33 deletions(-) diff --git a/d

[PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- fs/quota/netlink.c | 12 +++- include/uapi/linux/quota.h | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/quota/netlink.c b/fs/quota/netlink.c index d07a2f91d858..8b252673d454 100644 --

[PATCH net-next 0/8] netlink: align attributes when needed (patchset #3)

This is the continuation (series #3) of the work done to align netlink attributes when these attributes contain some 64-bit fields. It's the last patchset from what I've seen. The last user of nla_put_u64() is block/drbd. This module does not use standard netlink API (see all the stuff in

[PATCH net-next 8/8] sched: align nlattr properly when needed

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/networking/gen_stats.txt | 6 -- include/net/gen_stats.h | 6 -- include/uapi/linux/gen_stats.h | 1 + include/uapi/linux/pkt_cls.h| 2 ++ include/uapi/linux/rtnet

[PATCH net-next 7/8] neigh: align nlattr properly when needed

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/core/neighbour.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 6a395d440228..29dd8cc22bbf 100644 --- a/net/core/neighbour.c +++ b/net/core/neigh

[PATCH net-next 6/8] rtnl: align nlattr properly when needed

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 9efc1f34ef3b..5503dfe6a050 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnet

[PATCH net-next 5/8] ovs: align nlattr properly when needed

I also fix commit 8b32ab9e6ef1: use nla_total_size_64bit() for OVS_FLOW_ATTR_USED in ovs_flow_cmd_msg_size(). Fixes: 8b32ab9e6ef1 ("ovs: use nla_put_u64_64bit()") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/openvswitch.h | 2 ++ net/openvs

Re: [PATCH net-next 9/9] wireless: use nla_put_u64_64bit()

Hi Johannes, Le 26/04/2016 09:39, Johannes Berg a écrit : > Hi Nicholas, > > Thanks for doing this. > > I'll also add a fix for the macro-generated nla_put_64() in > nl80211_send_station(), unless there was a particular reason you didn't > take that one? > > I suspect you just missed it while

[PATCH net-next 6/9] l2tp: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/l2tp.h | 1 + net/l2tp/l2tp_netlink.c | 80 --- 2 files changed, 49 insertions(+), 32 deletions(-) diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/

[PATCH net-next 0/9] netlink: align attributes when needed (patchset #2)

This is the continuation (series #2) of the work done to align netlink attributes when these attributes contain some 64-bit fields. In patch #3, I didn't modify the function ila_encap_nlsize(). I was waiting feedback for this patch: http://patchwork.ozlabs.org/patch/613766/ If it's approved,

[PATCH net-next 7/9] ieee802154: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/linux/nl802154.h | 2 ++ net/ieee802154/nl-mac.c | 17 +++-- net/ieee802154/nl802154.c | 3 ++- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/include/linux/nl802154.h b/include/linux/nl

[PATCH net-next 2/9] sched: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/pkt_sched.h | 3 +++ net/sched/sch_htb.c| 6 -- net/sched/sch_netem.c | 3 ++- net/sched/sch_tbf.c| 6 -- 4 files changed, 13 insertions(+), 5 deletions(-) diff

[PATCH net-next 3/9] ipv6: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/ila.h | 1 + net/ipv6/ila/ila_lwt.c | 3 ++- net/ipv6/ila/ila_xlat.c | 15 +-- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/ila.h b/include/uapi/linux

[PATCH net-next 5/9] bridge: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/if_link.h | 2 ++ net/bridge/br_netlink.c | 62 +--- 2 files changed, 38 insertions(+), 26 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi

[PATCH net-next 8/9] netfilter/ipvs: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/ip_vs.h | 1 + net/netfilter/ipvs/ip_vs_ctl.c | 36 2 files changed, 25 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/ip_vs.h b/include/uapi/linux/i

[PATCH net-next 4/9] ovs: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/openvswitch.h | 1 + net/openvswitch/datapath.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h index 0358f9

[PATCH net-next 9/9] wireless: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/nl80211.h | 4 ++ net/wireless/nl80211.c | 91 ++-- 2 files changed, 59 insertions(+), 36 deletions(-) diff --git a/include/uapi/linux/nl80211.h b/include/uapi

[PATCH net-next 1/9] rtnl: use nla_put_u64_64bit()

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/if_link.h | 1 + net/core/rtnetlink.c | 36 ++-- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_

Re: [PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

Le 23/04/2016 19:28, Alexander Aring a écrit : Hi, On 04/23/2016 07:05 PM, Alexander Aring wrote: ... if this is really needed, then nla_put_u64/be64/etc need to be changed also, Okay, I found PATCH 3/9 do it for be64, but what's about u64? It's also planned. I will send several "small"

[RFC PATCH net] ipv6/ila: fix nlsize calculation for lwtunnel

The handler 'ila_fill_encap_info' adds one attribute: ILA_ATTR_LOCATOR. Fixes: 65d7ab8de582 ("net: Identifier Locator Addressing module") CC: Tom Herbert <t...@herbertland.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Tom, when I read the commen

[PATCH net-next 7/9] libnl: add nla_put_u64_64bit() helper

With this function, nla_data() is aligned on a 64-bit area. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/net/netlink.h b/include/net/netlink.h index 113b483b6ee8..e589cb

[PATCH net-next 4/9] libnl: nla_put_net64(): align on a 64-bit area

nla_data() is now aligned on a 64-bit area. The temporary function nla_put_be64_32bit() is removed in this patch. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/linux/netfilter/ipset/ip_set.h | 9 ++--- include/net/netlink.h

[PATCH net-next 5/9] libnl: nla_put_s64(): align on a 64-bit area

nla_data() is now aligned on a 64-bit area. In fact, there is no user of this function. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/net/netlink.h b/inclu

[PATCH net-next 3/9] libnl: nla_put_be64(): align on a 64-bit area

nla_data() is now aligned on a 64-bit area. A temporary version (nla_put_be64_32bit()) is added for nla_put_net64(). This function is removed in the next patch. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h

[PATCH net-next 1/9] libnl: fix help of _64bit functions

Fix typo and describe 'padattr'. Fixes: 089bf1a6a924 ("libnl: add more helpers to align attributes on 64-bit") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- lib/nlattr.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/nlattr.c b/li

[PATCH net-next 8/9] xfrm: align nlattr properly when needed

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/xfrm.h | 1 + net/xfrm/xfrm_user.c | 10 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h index 2cd9e608d0d1..143338978b48

[PATCH net-next 6/9] libnl: nla_put_msecs(): align on a 64-bit area

nla_data() is now aligned on a 64-bit area. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h| 11 +++ include/uapi/linux/l2tp.h| 1 + include/uapi/linux/neighbour.h | 2 ++ include/uapi/linux/tcp_metrics.h | 1 + ne

[PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit

Goal of this patch is to use the new libnl API to align netlink attribute when needed. The layout of the netlink message will be a bit different after the patch, because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested attribute instead of before it. Signed-off-by: Nicolas Dichtel

[PATCH net-next 2/9] libnl: nla_put_le64(): align on a 64-bit area

nla_data() is now aligned on a 64-bit area. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h | 8 +--- include/net/nl802154.h| 6 ++ net/ieee802154/nl802154.c | 13 - 3 files changed, 19 insertions(+), 8 deletions(-) diff

[PATCH net-next 0/9] netlink: align attributes when needed (patchset #1)

This is the continuation of the work done to align netlink attributes when these attributes contain some 64-bit fields. David, if the third patch is too big (or maybe the series), I can split it. Just tell me what you prefer. include/linux/netfilter/ipset/ip_set.h | 9 ++--

Re: [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute

Le 21/04/2016 20:28, David Miller a écrit : From: Nicolas Dichtel <nicolas.dich...@6wind.com> Date: Thu, 21 Apr 2016 18:58:23 +0200 Here is a proposal to add more helpers in the libnetlink to manage 64-bit alignment issues. Note that this series was only tested on x86 by tw

[PATCH net-next v2 4/4] ip6mr: align RTA_MFC_STATS on 64-bit

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/ip6mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index a10e77103c88..bf678324fd52 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -2268,7 +

[PATCH net-next v2 2/4] rtnl: use the new API to align IFLA_STATS*

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/core/rtnetlink.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 4a47a9aceb1d..5ec059d52823 100644 --- a/net/core/rtnetlink.c +++

[PATCH net-next v2 3/4] ipmr: align RTA_MFC_STATS on 64-bit

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/rtnetlink.h | 1 + net/ipv4/ipmr.c| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index cc885c

[PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute

Here is a proposal to add more helpers in the libnetlink to manage 64-bit alignment issues. Note that this series was only tested on x86 by tweeking CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS and adding some traces. The first patch adds helpers for 64bit alignment and other patches use them. We

[PATCH net-next v2 1/4] libnl: add more helpers to align attributes on 64-bit

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h | 39 +++- lib/nlattr.c | 99 +++ 2 files changed, 130 insertions(+), 8 deletions(-) diff --git a/include/net/netlink.h b/inclu

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

Le 20/04/2016 11:57, Eric Dumazet a écrit : On Wed, 2016-04-20 at 11:44 +0200, Nicolas Dichtel wrote: Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. You certainly can test this, by tweaking

Re: [PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

Le 20/04/2016 11:33, Eric Dumazet a écrit : [snip] How have you tested your patch exactly ? As stated in the cover letter, I didn't test it. I guess David should have copied his original comment here. -* The nlattr header is 4 bytes in size, that's why we test -* if the

[PATCH net-next 3/4] ipmr: align RTA_MFC_STATS on 64-bit

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/uapi/linux/rtnetlink.h | 1 + net/ipv4/ipmr.c| 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index ca764b

[PATCH net-next 0/4] libnl: enhance API to ease 64bit alignment for attribute

Here is a proposal to add more helpers in the libnetlink to manage 64-bit alignment issues. Note that this series was only tested on x86. The first patch is a fix (bug seen by code review only unless I've missed something). The second patch adds helpers and uses it for IFLA_STATS64. The last two

[PATCH net-next 2/4] libnl: add more helpers to align attribute on 64-bit

Add use it to align IFLA_STATS64. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/net/netlink.h | 8 lib/nlattr.c | 107 ++ net/core/rtnetlink.c | 9 + 3 files changed, 117 insertions(+), 7 del

[PATCH net-next 4/4] ip6mr: align RTA_MFC_STATS on 64-bit

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/ip6mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index a10e77103c88..bf678324fd52 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -2268,7 +

[PATCH net-next 1/4] netlink: fix test alignment in nla_align_64bit()

IS_ALIGN() returns true when the alignment is as expected. The pad attribute should be added only when the alignment is not 8. Fixes: 35c5845957c7 ("net: Add helpers for 64-bit aligning netlink attributes.") Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include/n

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

Le 19/04/2016 20:47, Eric Dumazet a écrit : On Tue, 2016-04-19 at 14:31 -0400, David Miller wrote: +#ifndef HAVE_EFFICIENT_UNALIGNED_ACCESS + /* IF necessary, add a zero length NOP attribute so that the +* nla_data() of the IFLA_STATS64 will be 64-bit aligned. +* +

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

+ selinux maintainers Le 18/04/2016 23:10, Roopa Prabhu a écrit : [snip] diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c index 8495b93..1714633 100644 --- a/security/selinux/nlmsgtab.c +++ b/security/selinux/nlmsgtab.c @@ -76,6 +76,8 @@ static struct nlmsg_perm

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

Le 19/04/2016 05:41, David Miller a écrit : [snip] I just tested out a clever idea, where for architectures where unaligned accesses is a problem, we insert a zero length NOP attribute before the 64-bit stats. This makes it properly aligned. A quick hack patch just passed testing on my sparc64

Re: [PATCH] ip6_tunnel: set rtnl_link_ops before calling register_netdevice

before calling register_netdevice fixes that. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@redhat.com> Fixes: 0b112457229d ("ip6tnl: add support of link creation via rtnl") Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com>

[PATCH iproute2] iplink: display IFLA_PHYS_PORT_NAME

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- ip/ipaddress.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 3998d8cec4ab..b21c69a7d6ea 100644 --- a/ip/ipaddress.c +++ b/ip/ipaddress.c @@ -813,6 +813,10 @@ int print_linkinfo

[PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()

Size of the attribute IFLA_PHYS_PORT_NAME was missing. Fixes: db24a9044ee1 ("net: add support for phys_port_name") CC: David Ahern <dsah...@gmail.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/core/rtnetlink.c | 1 + 1 file changed, 1 insertion(+)

[PATCH net] switchdev: fix typo in comments/doc

Two minor typo. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- Documentation/networking/switchdev.txt | 2 +- net/switchdev/switchdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documen

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

Le 14/03/2016 18:57, Mahesh Bandewar a écrit : On Sun, Mar 13, 2016 at 8:53 PM, David Miller wrote: [snip] Furthermore, when you walk across the ns boundary, that old device has to disappear. That's why that is the device assigned to skb->dev. The layer boundaries are

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

Le 15/03/2016 07:30, roopa a écrit : On 3/14/16, 8:00 AM, Nicolas Dichtel wrote: Le 13/03/2016 02:56, Roopa Prabhu a écrit : [snip] diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h index ca764b5..2bbb300 100644 --- a/include/uapi/linux/rtnetlink.h +++ b/include

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

Le 13/03/2016 02:56, Roopa Prabhu a écrit : From: Roopa Prabhu This patch adds a new RTM_GETSTATS message to query link stats via netlink from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK returns a lot more than just stats and is expensive in some

Re: [PATCH next v2 6/7] xfrm: Use l3_dev for xfrm policy checks.

+ Steffen Le 09/03/2016 22:50, Mahesh Bandewar a écrit : From: Mahesh Bandewar IPsec, whether it's tunnel mode or transport mode, is still a function of L3 so all the decisions should be based on the L3 device. Signed-off-by: Mahesh Bandewar CC: Eric

Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing

Le 09/03/2016 22:49, Mahesh Bandewar a écrit : From: Mahesh Bandewar One of the major request (for enhancement) that I have received from various users of IPvlan in L3 mode is its inability to handle IPtables. While looking at the code and how we handle ingress, the

Re: [PATCH next 3/3] net: Use l3_dev instead of skb->dev for L3 processing

+ Eric B. Le 08/03/2016 06:37, Cong Wang a écrit : On Fri, Mar 4, 2016 at 2:12 PM, Mahesh Bandewar wrote: Unfortunately we don't have a way to switch to ns after L3 processing. I am totally aware of this, this is exactly why I said this might not be easy. The question

[PATCH net-next v3 1/4] uapi: define DIV_ROUND_UP for userland

a common definition in uapi and use it everywhere. Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting") CC: Kan Liang <kan.li...@intel.com> Suggested-by: Ben Hutchings <b...@decadent.org.uk> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6win

[PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition

The inital goal was to consolidate ethtool.h uapi header. But I took the opportunity to remove all duplicate definitions of DIV_ROUND_UP. v3: add patch #2 and #3 v2: split the patch define DIV_ROUND_UP in uapi .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 +++-

[PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland

<= INT_MAX || speed == SPEED_UNKNOWN ^ Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0 and INT_MAX") CC: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- include

[PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP

Let's use __KERNEL_DIV_ROUND_UP, which is defined in uapi/linux/kernel.h. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/g

[PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP

om include/linux/module.h:9, from drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:16: include/linux/kernel.h:67:0: note: this is the location of the previous definition #define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP ^ Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- drivers/s

[PATCH net-next v2 1/2] uapi: define DIV_ROUND_UP for userland

a common definition in uapi and use it everywhere. Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting") CC: Kan Liang <kan.li...@intel.com> Suggested-by: Ben Hutchings <b...@decadent.org.uk> Signed-off-by: Nicolas Dichtel <nicolas.dich...@

[PATCH net-next v2 2/2] ethtool.h: define INT_MAX for userland

<= INT_MAX || speed == SPEED_UNKNOWN ^ Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0 and INT_MAX") CC: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- v2: s

[PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland

quot;net/ethtool: introduce a new ioctl for per queue setting") Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0 and INT_MAX") CC: Nikolay Aleksandrov <niko...@cumulusnetworks.com> CC: Kan Liang <kan.li...@intel.com> Signed-off-by: Nicolas

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

Le 24/02/2016 23:05, Eric W. Biederman a écrit : [snip] In the general case the current behavior is random and not something applications can count on, and we would do well to fix it so it is less random. In particular consider the case of an application in a non-initial network namespace

Re: Scaling the Number of Network Interfaces on Linux

Le 10/02/2016 12:59, David Ahern a écrit : On 2/10/16 12:15 PM, Nicolas Dichtel wrote: [snip] Instead of removing completly the sysctl entries, another idea could be to manage a group of interfaces which will share the same subtree. This come out from a side conversation as well

Scaling the Number of Network Interfaces on Linux

David, Roopa, to follow your talk at nedev11, I already proposed some times ago a patch to remove sysctl, which was rejected. You can see the thread here: http://thread.gmane.org/gmane.linux.network/285840 Instead of removing completly the sysctl entries, another idea could be to manage a group

[RESEND PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

Commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") was reverted to ease the merge of the net-next branch. Here is the new version. Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> Signed-off-by: Daniel Borkmann <dan...@iogearbox.net&

Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'

or all NETLINK_LISTEN_ALL_NSID: Protocol not available After: $ip monitor all [NEIGH]Deleted 10.0.0.1 dev eth1 lladdr c4:54:44:4f:b2:dd STALE Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns") Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> Acked-by: Nicolas

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6) (bis)

Le 02/02/2016 10:08, Daniel Borkmann a écrit : On 02/02/2016 05:51 AM, Stephen Hemminger wrote: On Tue, 19 Jan 2016 11:01:45 + Nicolas Dichtel <nicolas.dich...@6wind.com> wrote: diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c index 42c8841869f5..219ffa582c1a 100644 --- a/tc/tc_bpf.c ++

Re: [PATCH net] net: Allow flow dissector to handle non 4-byte aligned headers

Le 01/02/2016 01:39, Florian Fainelli a écrit : Le 31/01/2016 16:24, Eric Dumazet a écrit : On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote: Call get_unaligned_be32 when we access 32-bit fields in __skb_flow_dissect. At the beginning check for unlikely case of 1-byte aligned packet. Note

Re: regression kernel 4.4: stops routing packets with a GRE-payload

Le 20/01/2016 15:00, Wolfgang Walter a écrit : Hello, we tried 4.4 on our routers. We found one problem: 4.4 stops routing GRE packets (ipv4 in GRE/ipv4) here. 4.4.15 works fine. 4.4.15 does not exist. Is it 4.1.15?

[PATCH iproute2] tc: fix compilation with old gcc (< 4.6)

..@6wind.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- tc/tc_bpf.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c index 276871a5c0a5..47993bad81ca 100644 --- a/tc/tc_bp

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6)

Le 07/01/2016 14:56, Daniel Borkmann a écrit : Btw, for iproute2's net-next branch there're couple of other occasions as well. Stephen, how do you prefer to handle this? Should a separate patch be done against net-next branch to reduce merge conflicts? Thank you Daniel for noticing it. -- To

Re: [PATCH net-next 1/2] Support outside netns for tunnels.

Le 04/01/2016 19:45, Saurabh Mohan a écrit : This patch enchances a tunnel interface, like gre, to have the tunnel encap/decap be in the context of a network namespace that is different from the namespace of the tunnel interface. From userspace this feature may be configured using the new

Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()

Le 24/12/2015 05:37, Pravin Shelar a écrit : On Wed, Dec 23, 2015 at 6:57 PM, David Miller wrote: From: Pravin B Shelar Date: Wed, 23 Dec 2015 15:52:03 -0800 } else { - err_stats->tx_dropped++; + struct net_device_stats

Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()

Le 24/12/2015 00:52, Pravin B Shelar a écrit : [snip] @@ -83,22 +84,12 @@ int ip6_tnl_get_iflink(const struct net_device *dev); static inline void ip6tunnel_xmit(struct sock *sk, struct sk_buff *skb, struct net_device *dev) { - struct net_device_stats

Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()

Le 24/12/2015 00:52, Pravin B Shelar a écrit : [snip] diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 6af78c6..d63a911 100644 --- a/net/tipc/udp_media.c +++ b/net/tipc/udp_media.c @@ -182,15 +182,9 @@ static int tipc_udp_send_msg(struct net *net, struct sk_buff *skb,

Re: [PATCH net-next v2] ip_tunnel: Move stats update to iptunnel_xmit()

Le 24/12/2015 13:46, Thadeu Lima de Souza Cascardo a écrit : On Thu, Dec 24, 2015 at 10:21:27AM +0100, Nicolas Dichtel wrote: Le 24/12/2015 00:52, Pravin B Shelar a écrit : [snip] diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index 6af78c6..d63a911 100644 --- a/net/tipc/udp_media.c

Re: [PATCH net-next] ip_tunnel: Move stats update to iptunnel_xmit()

Le 22/12/2015 01:34, Pravin B Shelar a écrit : By moving stats update into iptunnel_xmit(), we can simplify iptunnel_xmit() usage. With this change there is no need to call another function (iptunnel_xmit_stats()) to update stats in tunnel xmit code path. Signed-off-by: Pravin B Shelar

Re: [PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header

calcualation so that the mac addresses are copied correctly. Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off) CC: Nicolas Dichtel <nicolas.dich...@6wind.com> CC: Patrick McHardy <ka...@trash.net> Signed-off-by: Vladislav Yasevich <vyasev...@gmail.

Re: [PATCH 1/1] net: bonding: remove redudant brackets

Le 12/12/2015 02:03, David Miller a écrit : From: From: yzhu1 Signed-off-by: yzhu1 Does not apply to the net-next tree. Also three different emails ... -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off

Le 16/11/2015 21:43, Vladislav Yasevich a écrit : When we have multiple stacked vlan devices all of which have turned off REORDER_HEADER flag, the untag operation does not locate the ethernet addresses correctly for nested vlans. The reason is that in case of REORDER_HEADER flag being off, the

[PATCH net] gre6: allow to update all parameters via rtnl

Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- net/ipv6/ip6_gre.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index 3c7b9310b33f..e5ea177d34c6 100644 --- a/net/ipv6/ip6_gre.c +++ b/net/ipv6/ip6_gre.c @@ -1571,13 +1

[PATCH iproute2] libnetlink: don't confuse variables in rtnl_talk()

size argument to rtnl_talk") Reported-by: Thomas Faivre <thomas.fai...@6wind.com> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- lib/libnetlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libnetlink.c b/lib/libnetlink.c index 922ec2d9f87

Re: [RFC PATCH net] Revert "ipv6: ndisc: inherit metadata dst when creating ndisc requests"

Le 30/11/2015 12:20, Jiri Benc a écrit : On Fri, 27 Nov 2015 18:17:05 +0100, Nicolas Dichtel wrote: This reverts commit ab450605b35caa768ca33e86db9403229bf42be4. In IPv6, we cannot inherit the dst of the original dst. ndisc packets are IPv6 packets and may take another route than the original

[RFC PATCH net] Revert "ipv6: ndisc: inherit metadata dst when creating ndisc requests"

vxlan1. The encapsulated packet triggers an NS which cannot be sent because of the wrong route. CC: Jiri Benc <jb...@redhat.com> CC: Thomas Graf <tg...@suug.ch> Signed-off-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- I know that this is not the right fix, it's why I've

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

Le 21/10/2015 19:12, Hannes Frederic Sowa a écrit : Hello, On Wed, Oct 21, 2015, at 17:56, David Miller wrote: From: Jiri Benc Date: Wed, 21 Oct 2015 17:25:02 +0200 On Wed, 21 Oct 2015 08:32:14 -0700 (PDT), David Miller wrote: As you say the apps are broken, so file a bug

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

Le 22/10/2015 17:00, Jiri Benc a écrit : On Thu, 22 Oct 2015 16:52:13 +0200, Nicolas Dichtel wrote: With the proposed scenario: 1. create netns 'new_netns' 2. in root netns, move the interface with ifindex 2 to new_netns 3. in new_netns, delete the interface with ifindex 2 4. in new_netns

Re: [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

<ro...@cumulusnetworks.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- I am not sure if it is too late for this change. But, sending this patch out because it only affects ip monitor output Seems reasonable to me, but I let Stephen speaking at this. -- To unsubscribe from

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit : [sni] This sysctl is on my list to be enabled soon by default by any systemd based distribution. For that reason, could you maybe remove all the I'm not sure to understand why we add a sysctl then. Or at least, why the linux default value is

Re: [PATCH net-next 0/3] net: Pass net into defragmentation

, and nf_ct_frag6_gather. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk

Le 07/10/2015 22:39, Eric W. Biederman a écrit : Nicolas Dichtel <nicolas.dich...@6wind.com> writes: Le 06/10/2015 20:53, Eric W. Biederman a écrit : It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket

Re: [PATCH net-next 00/16] net: Pass net through the output path v2

in passing sock_net(sk) from the socket a packet locally originates on to the dst->output function. LGTM. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel

<    1   2   3   4   5   6   >