from include/linux/module.h:9,
from drivers/scsi/cxgbi/cxgb4i/cxgb4i.c:16:
include/linux/kernel.h:67:0: note: this is the location of the previous
definition
#define DIV_ROUND_UP __KERNEL_DIV_ROUND_UP
^
Signed-off-by: Nicolas Dichtel
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
et's add a common definition in uapi and use it everywhere.
Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting")
CC: Kan Liang
Suggested-by: Ben Hutchings
Signed-off-by: Nicolas Dichtel
---
v2: split the patch
define DIV_ROUND_UP in uapi
include
tion)
return speed <= INT_MAX || speed == SPEED_UNKNOWN
^
Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0
and INT_MAX")
CC: Nikolay Aleksandrov
Signed-off-by: Nicolas Dichtel
---
v2: split the patch
define DIV_ROUND_UP in uapi
^
Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting")
Fixes: e02564ee334a ("ethtool: make validate_speed accept all speeds between 0
and INT_MAX")
CC: Nikolay Aleksandrov
CC: Kan Liang
Signed-off-by: Nicolas Dichtel
---
include/uapi/li
Le 24/02/2016 23:05, Eric W. Biederman a écrit :
[snip]
In the general case the current behavior is random and not something
applications can count on, and we would do well to fix it so it is less
random. In particular consider the case of an application in a
non-initial network namespace creati
Le 10/02/2016 12:59, David Ahern a écrit :
On 2/10/16 12:15 PM, Nicolas Dichtel wrote:
[snip]
Instead of removing completly the sysctl entries, another idea could be to
manage a group of interfaces which will share the same subtree.
This come out from a side conversation as well -- for
David, Roopa,
to follow your talk at nedev11, I already proposed some times ago a patch to
remove sysctl, which was rejected. You can see the thread here:
http://thread.gmane.org/gmane.linux.network/285840
Instead of removing completly the sysctl entries, another idea could be to
manage a group
Commit 8f80d450c3cb ("tc: fix compilation with old gcc (< 4.6)") was reverted
to ease the merge of the net-next branch.
Here is the new version.
Signed-off-by: Nicolas Dichtel
Signed-off-by: Daniel Borkmann
---
tc/tc_bpf.c | 58 +---
.
Before:
$ip monitor all
NETLINK_LISTEN_ALL_NSID: Protocol not available
After:
$ip monitor all
[NEIGH]Deleted 10.0.0.1 dev eth1 lladdr c4:54:44:4f:b2:dd STALE
Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns")
Signed-off-by: Roopa Prabhu
Acked-by: Nicolas Dichtel
Le 02/02/2016 10:08, Daniel Borkmann a écrit :
On 02/02/2016 05:51 AM, Stephen Hemminger wrote:
On Tue, 19 Jan 2016 11:01:45 +
Nicolas Dichtel wrote:
diff --git a/tc/tc_bpf.c b/tc/tc_bpf.c
index 42c8841869f5..219ffa582c1a 100644
--- a/tc/tc_bpf.c
+++ b/tc/tc_bpf.c
@@ -49,6 +49,10
Le 01/02/2016 01:39, Florian Fainelli a écrit :
Le 31/01/2016 16:24, Eric Dumazet a écrit :
On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
Call get_unaligned_be32 when we access 32-bit fields in
__skb_flow_dissect. At the beginning check for unlikely case of
1-byte aligned packet.
Note
Le 20/01/2016 15:00, Wolfgang Walter a écrit :
Hello,
we tried 4.4 on our routers. We found one problem: 4.4 stops routing GRE
packets (ipv4 in GRE/ipv4) here. 4.4.15 works fine.
4.4.15 does not exist. Is it 4.1.15?
Le 07/01/2016 14:56, Daniel Borkmann a écrit :
Btw, for iproute2's net-next branch there're couple of other occasions
as well. Stephen, how do you prefer to handle this? Should a separate
patch be done against net-next branch to reduce merge conflicts?
Thank you Daniel for noticing it.
--
To uns
From: Julien Floret
gcc < 4.6 does not handle C11 syntax for the static initialization of
anonymous struct/union, hence the following error:
tc_bpf.c:260: error: unknown field map_type specified in initializer
Signed-off-by: Julien Floret
Signed-off-by: Nicolas Dichtel
---
tc/tc_bpf.c |
Le 04/01/2016 19:45, Saurabh Mohan a écrit :
This patch enchances a tunnel interface, like gre, to have the tunnel
encap/decap be in the context of a network namespace that is different from
the namespace of the tunnel interface.
From userspace this feature may be configured using the new 'one
Le 24/12/2015 13:46, Thadeu Lima de Souza Cascardo a écrit :
On Thu, Dec 24, 2015 at 10:21:27AM +0100, Nicolas Dichtel wrote:
Le 24/12/2015 00:52, Pravin B Shelar a écrit :
[snip]
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 6af78c6..d63a911 100644
--- a/net/tipc/udp_media.c
Le 24/12/2015 00:52, Pravin B Shelar a écrit :
[snip]
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 6af78c6..d63a911 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -182,15 +182,9 @@ static int tipc_udp_send_msg(struct net *net, struct
sk_buff *skb,
Le 24/12/2015 00:52, Pravin B Shelar a écrit :
[snip]
@@ -83,22 +84,12 @@ int ip6_tnl_get_iflink(const struct net_device *dev);
static inline void ip6tunnel_xmit(struct sock *sk, struct sk_buff *skb,
struct net_device *dev)
{
- struct net_device_stats *
Le 24/12/2015 05:37, Pravin Shelar a écrit :
On Wed, Dec 23, 2015 at 6:57 PM, David Miller wrote:
From: Pravin B Shelar
Date: Wed, 23 Dec 2015 15:52:03 -0800
} else {
- err_stats->tx_dropped++;
+ struct net_device_stats *err_stats = &dev->stats;
+
+
Le 22/12/2015 01:34, Pravin B Shelar a écrit :
By moving stats update into iptunnel_xmit(), we can simplify
iptunnel_xmit() usage. With this change there is no need to
call another function (iptunnel_xmit_stats()) to update stats
in tunnel xmit code path.
Signed-off-by: Pravin B Shelar
---
[sn
calcualation so that the mac addresses are
copied correctly.
Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with
REORDER_HEADER off)
CC: Nicolas Dichtel
CC: Patrick McHardy
Signed-off-by: Vladislav Yasevich
Thank you for the fix. A bit late, but for the record:
Tested-by: Nicolas
Le 16/11/2015 21:43, Vladislav Yasevich a écrit :
When we have multiple stacked vlan devices all of which have
turned off REORDER_HEADER flag, the untag operation does not
locate the ethernet addresses correctly for nested vlans.
The reason is that in case of REORDER_HEADER flag being off,
the ou
Le 12/12/2015 02:03, David Miller a écrit :
From:
From: yzhu1
Signed-off-by: yzhu1
Does not apply to the net-next tree.
Also three different emails ...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More major
)
Signed-off-by: Nicolas Dichtel
---
net/ipv6/ip6_gre.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 3c7b9310b33f..e5ea177d34c6 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -1571,13 +1571,11 @@ static int ip
quot;libnetlink: add size argument to rtnl_talk")
Reported-by: Thomas Faivre
Signed-off-by: Nicolas Dichtel
---
lib/libnetlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index 922ec2d9f872..165821447b2d 100644
--- a/lib/libne
Le 30/11/2015 12:20, Jiri Benc a écrit :
On Fri, 27 Nov 2015 18:17:05 +0100, Nicolas Dichtel wrote:
This reverts commit ab450605b35caa768ca33e86db9403229bf42be4.
In IPv6, we cannot inherit the dst of the original dst. ndisc packets
are IPv6 packets and may take another route than the original
vxlan1. The encapsulated packet triggers an NS
which cannot be sent because of the wrong route.
CC: Jiri Benc
CC: Thomas Graf
Signed-off-by: Nicolas Dichtel
---
I know that this is not the right fix, it's why I've put RFC ;-)
Should the right fix only do a copy of dst metadata in t
Le 22/10/2015 17:00, Jiri Benc a écrit :
On Thu, 22 Oct 2015 16:52:13 +0200, Nicolas Dichtel wrote:
With the proposed scenario:
1. create netns 'new_netns'
2. in root netns, move the interface with ifindex 2 to new_netns
3. in new_netns, delete the interface with ifindex 2
4. in
Le 21/10/2015 19:12, Hannes Frederic Sowa a écrit :
Hello,
On Wed, Oct 21, 2015, at 17:56, David Miller wrote:
From: Jiri Benc
Date: Wed, 21 Oct 2015 17:25:02 +0200
On Wed, 21 Oct 2015 08:32:14 -0700 (PDT), David Miller wrote:
As you say the apps are broken, so file a bug and have them fixe
Le 15/10/2015 20:47, Roopa Prabhu a écrit :
From: Roopa Prabhu
It helps to grep for one string "Deleted" when monitoring all events.
Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed")
Signed-off-by: Roopa Prabhu
Acked-by: Nicolas Dichtel
---
I
Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit :
[sni]
This sysctl is on my list to be enabled soon by default by any systemd
based distribution. For that reason, could you maybe remove all the
I'm not sure to understand why we add a sysctl then. Or at least, why the linux
default value is di
nf_ct_frag6_gather.
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ucceeds in passing sock_net(sk) from the
socket a packet locally originates on to the dst->output function.
LGTM.
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More
Le 07/10/2015 22:39, Eric W. Biederman a écrit :
Nicolas Dichtel writes:
Le 06/10/2015 20:53, Eric W. Biederman a écrit :
It is confusing and silly hiding a paramater so modify all of
the callers to pass in the appropriate socket or skb->sk if
no socket is known.
Signed-off-by: &quo
Le 06/10/2015 20:53, Eric W. Biederman a écrit :
It is confusing and silly hiding a paramater so modify all of
the callers to pass in the appropriate socket or skb->sk if
no socket is known.
Signed-off-by: "Eric W. Biederman"
---
[snip]
@@ -456,7 +456,7 @@ packet_routed:
skb->priority
Le 06/10/2015 20:53, Eric W. Biederman a écrit :
In the rare case where sk != skb->sk ip_local_out_sk arranges
to call dst->output differently if the skb is queued or not.
This is a bug.
Fix this bug by passing the sk parameter of ip_local_out_sk through
from ip_local_out_sk to __ip_local_out_sk
Le 01/10/2015 18:03, Eric W. Biederman a écrit :
Nicolas Dichtel writes:
Le 30/09/2015 23:25, Eric W. Biederman a écrit :
[snip]
+ struct net *net = read_pnet(&dp->net);
nit: add an empty line after variables declaration.
__be16 et
ipv4 and ipv6 are converted and then
temporary helper functions are removed.
Some minors comments (see other emails).
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
Le 30/09/2015 23:25, Eric W. Biederman a écrit :
When struct net starts being passed through the ipv4 and ipv6 fragment
routines ovs_vport_output will need to take a net parameter.
Prepare ovs_vport_output before that is needed and introduce
ovs_vport_output_skk for the call sites that still need
Le 30/09/2015 23:25, Eric W. Biederman a écrit :
In preparation for the ipv4 and ipv6 fragmentation code taking a net
parameter pass a struct net into ovs_fragment where the v4 and v6
fragmentation code is called.
Signed-off-by: "Eric W. Biederman"
---
[snip]
@@ -748,6 +748,7 @@ static void d
Le 30/09/2015 23:25, Eric W. Biederman a écrit :
Signed-off-by: Eric W. Biederman
---
[snip]
diff --git a/net/ipv6/xfrm6_output.c b/net/ipv6/xfrm6_output.c
index 0c3e9ffcf231..335066a64b45 100644
--- a/net/ipv6/xfrm6_output.c
+++ b/net/ipv6/xfrm6_output.c
@@ -131,6 +131,12 @@ int xfrm6_output_
.
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 21/09/2015 07:37, David Miller a écrit :
From: David Miller
Date: Sun, 20 Sep 2015 22:35:13 -0700 (PDT)
After the patch:
$ ping -c1 192.168.0.121 ; ip -s l ls dev gre1
PING 192.168.0.121 (192.168.0.121) 56(84) bytes of data.
64 bytes from 192.168.0.121: icmp_req=1 ttl=64 time=2.95 ms
--- 1
GTM.
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 18/09/2015 18:13, Eric W. Biederman a écrit :
[snip]
It appears I forgot to hit send. The patches should show up any time now.
Yes, thank you.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo in
Le 18/09/2015 17:06, Eric W. Biederman a écrit :
This is the next installment of my work to pass struct net through the
output path so the code does not need to guess how to figure out which
network namespace it is in, and ultimately routes can have output
devices in another network namespace.
eported-by: Julien Meunier
Signed-off-by: Nicolas Dichtel
---
net/ipv4/ip_tunnel_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
index 29ed6c5a5185..9b97204b8c81 100644
--- a/net/ipv4/ip_tunnel_core.c
+++
dropped carrier collsns
84 10 0 0 0
Signed-off-by: Nicolas Dichtel
---
include/net/ip6_tunnel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h
index 65c2a9397b3c..fa915fa0f703 100644
Le 18/09/2015 00:24, Eric W. Biederman a écrit :
[snip]
Thanks for review. I have added an extra patch for the missing blank
lines that are still missing after the entire series. As they affect
neither code correctness nor bisectability I don't think there is any
point respinning the indivdual
available and trivially usable.
LGTM (except some minor comments).
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 16/09/2015 03:04, Eric W. Biederman a écrit :
Pass a network namespace parameter into the netfilter hooks. At the
call site of the netfilter hooks the path a packet is taking through
the network stack is well known which allows the network namespace to
be easily and reliabily.
This allows th
Le 16/09/2015 03:04, Eric W. Biederman a écrit :
Keep net in a local variable so I can use it in NF_HOOK_COND
when I pass struct net to all of the netfilter hooks.
Signed-off-by: "Eric W. Biederman"
---
net/ipv6/ip6_output.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
Le 16/09/2015 03:04, Eric W. Biederman a écrit :
Signed-off-by: "Eric W. Biederman"
---
net/ipv6/ip6mr.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
index e95f6b6281de..3e3085b37a91 100644
--- a/net/ipv6/ip6mr.c
+++ b/net/ipv6/i
Le 17/09/2015 02:54, Rick Jones a écrit :
On 09/16/2015 05:46 PM, Ani Sinha wrote:
Hi guys
just a stupid question. Is it possible to get a list of all active
network namespaces in the kernel through /proc or some other
interface?
Presumably you could copy what "ip netns" does, which appears t
Le 13/09/2015 19:18, Roopa Prabhu a écrit :
From: Roopa Prabhu
This patch adds NLM_F_REPLACE flag to ipv6 route replace notifications.
This makes nlm_flags in ipv6 replace notifications consistent
with ipv4.
Signed-off-by: Roopa Prabhu
Acked-by: Nicolas Dichtel
--
To unsubscribe from this
route replacement")
Signed-off-by: Roopa Prabhu
LGTM
Acked-by: Nicolas Dichtel
v1 - v2 : fix leak
v2 - v3: fix 'Fixes' tag and warn msg (feedback from nicolas)
resending against net
v3 - v4: reword warn msg (feedback from nicolas). I still print the
nexthops in the
Le 08/09/2015 02:42, roopa a écrit :
On 9/6/15, 1:46 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent ne
Le 08/09/2015 02:01, roopa a écrit :
On 9/7/15, 5:03 AM, Nicolas Dichtel wrote:
[snip]
yes, i had submitted the patch you mention above to fix a slightly different
problem that existed then..which
was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath
(ECMP)&
Le 06/09/2015 22:46, Roopa Prabhu a écrit :
From: Roopa Prabhu
I've sent you some comments about the v2, so please keep me in CC for the next
versions.
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nex
+ Michal Kubecek
Le 06/09/2015 22:46, roopa a écrit :
On 9/4/15, 1:12 AM, Nicolas Dichtel wrote:
Le 03/09/2015 01:44, Roopa Prabhu a écrit :
[snip]
Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL
flags support, warn about missing CREATE flag")
ECMP was
Le 03/09/2015 01:44, Roopa Prabhu a écrit :
From: Roopa Prabhu
Problem:
The ecmp route replace support for ipv6 in the kernel, deletes the
existing ecmp route too early, ie when it installs the first nexthop.
If there is an error in installing the subsequent nexthops, its too late
to recover th
Le 02/09/2015 01:23, James Loosli a écrit :
I seem to have an issue with using namespace-specific hosts files.
Here's an example.
I have different entries for foo.com in my hosts file for the
namespace and the system-wide hosts file;
root@server-01 Tue Sep 01 04:15:02pm
cat /etc/netns/nsXX-XXX
t;)
Signed-off-by: Daniel Borkmann
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t;gre: Support GRE over IPv6")
Signed-off-by: huaibin Wang
Signed-off-by: Nicolas Dichtel
---
net/ipv6/ip6_gre.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index a38d3ac0f18f..69f4f689f06a 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
Hi,
since commit ca7c7b9059e3 ("skbuff: Do not scrub skb mark within the same name
space", backport of upstream commit 213dd74aee76), the following three upstream
commits need also to be backported in the 3.18 branch:
- cd5279c194f8 ("ip_vti/ip6_vti: Do not touch skb->mark on xmit")
- 049f8e2e2
Le 22/08/2015 19:47, David Miller a écrit :
From: Nicolas Dichtel
Date: Sat, 22 Aug 2015 18:10:20 +0200
This patch renames the recently added vrf driver. 'VRF' term is very
generic and there is no clear definition of it.
For example, someone may expect more isolation and us
This patch also enlightens the fact that this driver is not *the* way to
implement VRF in linux, but *a* tool among others.
CC: Shrijeet Mukherjee
CC: David Ahern
Signed-off-by: Nicolas Dichtel
---
drivers/net/Kconfig | 8 +-
drivers/net/Makefile | 2 +-
drivers/net/mrf.c
Le 20/08/2015 13:53, Jiri Benc a écrit :
On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote:
Probably better to introduce veth netlink attribute then, something like
IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID.
I'd prefer IFLA_PEER. More generic attribute will be helpful shou
Le 19/08/2015 14:48, Vincent Bernat a écrit :
❦ 19 août 2015 14:38 +0200, Jiri Benc :
That's the main goal of this patch: advertising the peer link as
IFLA_LINK attribute triggers an infinite loop in userland software when
they follow iflink to discover network devices topology. iflink has
a
Le 29/07/2015 17:20, Eric Dumazet a écrit :
On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote:
This patch takes advantage of the newly added lwtunnel framework to
allow the user to set routes that point to a peer netns.
Packets are injected to the peer netns via the loopback device. It
5 via dev lo
The goal is to be scalable when the number of netns is high (10k or more).
Which this patch, we can save two interfaces (veth) per netns, which helps
to to reduce memory consumption and the time needed to create a netns.
Signed-off-by: Nicolas Dichtel
---
v3: fix skb use aft
Le 24/07/2015 17:19, David Ahern a écrit :
In this case you are knowingly dropping packets. Would be nice to have a counter
showing that.
Ok.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
Le 24/07/2015 17:39, Eric Dumazet a écrit :
On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote:
This patch takes advantage of the newly added lwtunnel framework to
allow the user to set routes that point to a peer netns.
Packets are injected to the peer netns via the loopback device. It
Le 24/07/2015 16:28, David Ahern a écrit :
On 7/23/15 8:22 AM, Nicolas Dichtel wrote:
static netdev_tx_t loopback_xmit(struct sk_buff *skb,
struct net_device *dev)
{
+int nsid = skb_lwt_netns_info(skb);
struct pcpu_lstats *lb_stats;
int len;
+if (nsid
5 via dev lo
Signed-off-by: Nicolas Dichtel
---
v2: rework loopback handling part (update stats and call skb_dst_force())
fix ipv6 processing
check lwtunnel type before converting data to a nsid
drivers/net/loopback.c| 33 +--
include/net/lwtunnel.h
Le 24/07/2015 15:50, roopa a écrit :
On 7/24/15, 5:24 AM, Nicolas Dichtel wrote:
Sure, but my goal was to not create a new .h file just for these two helpers.
It's related to lwtunnel, thus I was thinking they can go here.
ok..., since your lwt namespace functions went into net_namespace
Le 23/07/2015 17:50, roopa a écrit :
On 7/23/15, 8:25 AM, Nicolas Dichtel wrote:
Le 23/07/2015 17:01, roopa a écrit :
On 7/23/15, 7:22 AM, Nicolas Dichtel wrote:
[snip]
+static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate)
+{
+return (u32 *)lwtstate->data;
+}
+
+sta
opa Prabhu
Signed-off-by: Nicolas Dichtel
---
include/net/lwtunnel.h | 16 +++-
net/ipv4/fib_semantics.c | 9 -
net/ipv4/route.c | 9 ++---
net/ipv6/ip6_fib.c | 2 +-
net/ipv6/route.c | 8 ++--
5 files changed, 20 insertions(+), 24 deletion
We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc()
use ip6_rt_copy_init() to build a dst).
CC: Thomas Graf
CC: Roopa Prabhu
Fixes: 19e42e451506 ("ipv6: support for fib route lwtunnel encap attributes")
Signed-off-by: Nicolas Dichtel
---
net/ipv6/route.c | 4 ++
This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set.
The check is already done in IPv4.
CC: Thomas Graf
CC: Roopa Prabhu
Fixes: 74a0f2fe8ed5 ("ipv6: rt6_info output redirect to tunnel output")
Signed-off-by: Nicolas Dichtel
---
net/ipv6/route.c | 3 ++-
1 file
Le 23/07/2015 17:01, roopa a écrit :
On 7/23/15, 7:22 AM, Nicolas Dichtel wrote:
[snip]
+static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate)
+{
+return (u32 *)lwtstate->data;
+}
+
+static inline int skb_lwt_netns_info(struct sk_buff *skb)
+{
+if (skb->protocol ==
5 via dev lo
Signed-off-by: Nicolas Dichtel
---
drivers/net/loopback.c| 16 +
include/net/lwtunnel.h| 23 +++
include/uapi/linux/lwtunnel.h | 1 +
net/core/net_namespace.c | 52 +++
4 files changed, 92
Note also that include/linux/lwtunnel.h is not needed.
CC: Thomas Graf
CC: Roopa Prabhu
Fixes: 499a24256862 ("lwtunnel: infrastructure for handling light weight
tunnels like mpls")
Signed-off-by: Nicolas Dichtel
---
include/linux/lwtunnel.h | 6 --
include/uapi/linux/Kbuil
homas Graf
Fixes: 614732eaa12d ("openvswitch: Use regular VXLAN net_device device")
Signed-off-by: Nicolas Dichtel
---
net/openvswitch/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig
index 1119f46b80b4..6ed1d2da9fcd 100644
-
on to use the secure version of getenv, thus let's
simply use getenv().
CC: Daniel Borkmann
Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
Signed-off-by: Nicolas Dichtel
---
v2: rework the fix to use getenv() instead of secure_getenv()
examples
Le 22/07/2015 15:05, Daniel Borkmann a écrit :
On 07/22/2015 02:29 PM, Nicolas Dichtel wrote:
Error was:
f_bpf.o: In function `bpf_parse_opt':
f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
m_bpf.o: In function `parse_bpf':
m_bpf.c:(.text+0x587): undefin
s: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
Signed-off-by: Nicolas Dichtel
---
configure | 49 +++--
tc/Makefile | 6 ++
tc/tc_bpf.h | 9 +
3 files changed, 62 insertions(+), 2 deletions(-)
diff --git
Acked-by: Jiri Pirko
Acked-by: Roopa Prabhu
Acked-by: Nicolas Dichtel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 16/07/2015 10:04, sfel...@gmail.com a écrit :
From: Scott Feldman
Just before queuing skb for xmit on port, check if skb has been marked by
switchdev port driver as already fordwarded by device. If so, drop skb. A
non-zero skb->offload_fwd_mark field is set by the switchdev port
driver/dev
stian Evensen
Signed-off-by: Nicolas Dichtel
---
net/core/rtnetlink.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 24d3242f0e01..c522f7a00eab 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2229,9 +2229,6 @@ void r
Le 13/07/2015 16:11, Kristian Evensen a écrit :
Hello,
I have a quick question about this patch.
On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel
wrote:
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 837d30b5ffed..7b25f1ef3d75 100644
--- a/net/core/rtnetlink.c
+++ b/net/core
Le 13/07/2015 16:11, Kristian Evensen a écrit :
Hello,
I have a quick question about this patch.
On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel
wrote:
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 837d30b5ffed..7b25f1ef3d75 100644
--- a/net/core/rtnetlink.c
+++ b/net/core
e contains net-next, not net.
Signed-off-by: Andy Gospodarek
Suggested-by: Nicolas Dichtel
Acked-by: Nicolas Dichtel
---
I realize two of these changes result in lines >80 chars, but this is to
keep the coding-style used by the surrounding code.
There are multiple ways to resolve this,
Le 06/07/2015 19:53, Shrijeet Mukherjee a écrit :
No no problem,
Just trying to get the functional aspects worked out. the global
search replace will be easy.
Was hoping to see some more responses on the naming suggestions here
from the community. If there is not disagreement we can spin patche
Le 06/07/2015 17:03, David Ahern a écrit :
This driver borrows heavily from IPvlan and teaming drivers.
Routing domains (VRF-lite) are created by instantiating a device
and enslaving all routed interfaces that participate in the domain.
As part of the enslavement, all local routes pointing to en
Le 08/07/2015 10:37, Nicolas Dichtel a écrit :
[snip]
Also, why calling this '_MASTER', is there a notion of SLAVE?
Ok, just got it in the next patch ;-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kerne
Le 06/07/2015 17:03, David Ahern a écrit :
Add a VRF_MASTER flag for interfaces and helper functions for determining
if a device is a VRF_MASTER.
Also, add link attribute for passing VRF_TABLE id.
Both are used in the following patch that adds a VRF device driver.
Signed-off-by: Shrijeet Mukhe
Le 06/07/2015 20:21, Andy Gospodarek a écrit :
This kernel patch exports the value of the new
ignore_routes_with_linkdown via netconf.
Signed-off-by: Andy Gospodarek
Suggested-by: Nicolas Dichtel
---
You need also to patch devinet_conf_proc() so that a netlink message is
sent when the user
This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c.
The side effect of this commit is to add a '@NONE' after each virtual
interface name with a 'ip link'. It may break existing scripts.
Reported-by: Oliver Hartkopp
Signed-off-by: Nicolas Dichtel
Tested-by: Oliv
Le 06/07/2015 17:03, David Ahern a écrit :
In the context of internet scale routing a requirement that always
comes up is the need to partition the available routing tables into
disjoint routing planes. A specific use case is the multi-tenancy
problem where each tenant has their own unique routin
501 - 600 of 653 matches
Mail list logo
