On 29-May-18 2:05 AM, Jakub Kicinski wrote:
Hi Jakub,
Hi Nogah!
On Mon, 28 May 2018 18:49:51 +0300, Nogah Frankel wrote:
+static int
+nfp_abm_red_replace(struct net_device *netdev, struct nfp_abm_link *alink,
+ struct tc_red_qopt_offload *opt)
+{
+ struct nfp_port
#x27;t reject it).
You might maybe use max = min+1, because in real life it will probably
act the same but without this problem.
Nogah Frankel
(from a new mail address)
+ nfp_warn(alink->abm->app->cpp,
+"RED offload failed - unsupported param
er indication for it. ("invisible" qdisc are not being shown by default).
> > This patch sets a band to the default qdisc, rather then the noop qdisc, on
> > delete operation.
> >
> > Signed-off-by: Nogah Frankel
>
> Like Cong, I'm worried this will b
are not being shown by default).
This patch sets a band to the default qdisc, rather then the noop qdisc, on
delete operation.
Signed-off-by: Nogah Frankel
---
net/sched/sch_prio.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/net/sched/sch_prio.c b/net/sc
> -Original Message-
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
> Sent: Monday, January 15, 2018 6:01 AM
> To: da...@davemloft.net; j...@resnulli.us; Nogah Frankel
>
> Cc: netdev@vger.kernel.org; oss-driv...@netronome.com;
> xiyou.wangc...@gmail.com
> > > > > > Hm. You you need this just because you didn't add the backlog
> > > > > > pointer to destroy? AFAIK on destroy we are free to reset
> > > > > > stats as well, thus simplifying your driver... Let me know
> > > > > > if I misunderstand.
> >
> > The problem of doing it in destroy is whe
> -Original Message-
> From: Yuval Mintz
> Sent: Friday, January 12, 2018 10:47 AM
> To: Jakub Kicinski
> Cc: Jiri Pirko ; netdev@vger.kernel.org; Nogah Frankel
> ; da...@davemloft.net; Ido Schimmel
> ; mlxsw ; j...@mojatatu.com;
> xiyou.wangc...@gmail.com
> S
> -Original Message-
> From: Yuval Mintz
> Sent: Friday, January 12, 2018 2:05 AM
> To: Jakub Kicinski
> Cc: Jiri Pirko ; netdev@vger.kernel.org; Nogah Frankel
> ; da...@davemloft.net; Ido Schimmel
> ; mlxsw ; j...@mojatatu.com;
> xiyou.wangc...@gmail.com
> S
> -Original Message-
> From: Jakub Kicinski [mailto:jakub.kicin...@netronome.com]
> Sent: Thursday, January 04, 2018 10:19 PM
> To: john.fastab...@gmail.com; j...@resnulli.us; xiyou.wangc...@gmail.com;
> Nogah Frankel ; Yuval Mintz
>
> Cc: netdev@vger.kernel.org; oss-
Replacing the RED offload flag (TC_RED_OFFLOADED) with the generic one
(TCQ_F_OFFLOADED) deleted some of the logic behind it. This patchset fixes
this problem.
Nogah Frankel (2):
net_sch: red: Fix the new offload indication
net: sched: Move offload check till after dump call
net/sched
Move the check of the offload state to after the qdisc dump action was
called, so the qdisc could update it if it was changed.
Fixes: 7a4fa29106d9 ("net: sched: Add TCA_HW_OFFLOAD")
Signed-off-by: Nogah Frankel
Reviewed-by: Yuval Mintz
---
net/sched/sch_api.c | 5 ++---
1 file
its location, a qdisc can be offloaded and un-offloaded by graft
calls, that doesn't effect the qdisc itself.
Fixes: 428a68af3a7c ("net: sched: Move to new offload indication in RED"
Signed-off-by: Nogah Frankel
Reviewed-by: Yuval Mintz
---
net/sched/sch_red.c | 26 ++
Add some input validation checks to RED qdisc.
Nogah Frankel (2):
net_sched: red: Avoid devision by zero
net_sched: red: Avoid illegal values
include/net/red.h | 13 -
net/sched/sch_choke.c | 3 +++
net/sched/sch_gred.c | 3 +++
net/sched/sch_red.c | 2 ++
net/sched
Check the qmin & qmax values doesn't overflow for the given Wlog value.
Check that qmin <= qmax.
Fixes: a783474591f2 ("[PKT_SCHED]: Generic RED layer")
Signed-off-by: Nogah Frankel
---
include/net/red.h | 11 +++
net/sched/sch_choke.c | 3 +++
net/sched/sch
Do not allow delta value to be zero since it is used as a divisor.
Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM")
Signed-off-by: Nogah Frankel
---
include/net/red.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/red.h b/include/net/red.h
ind
> -Original Message-
> From: Roman Mashak [mailto:m...@mojatatu.com]
> Sent: Monday, October 30, 2017 2:47 PM
> To: Jiri Pirko
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Nogah Frankel
> ;
> j...@mojatatu.com; xiyou.wangc...@gmail.com; mlxsw ;
> and
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Monday, October 30, 2017 2:20 PM
> To: j...@resnulli.us
> Cc: netdev@vger.kernel.org; Nogah Frankel ;
> j...@mojatatu.com;
> xiyou.wangc...@gmail.com; mlxsw ; and...@l
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, February 03, 2017 8:07 PM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com;
> jb...@redhat.com; sergei.shtyl...@cogent
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, January 30, 2017 6:34 AM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com;
> jb...@redhat.com; sergei.shtyl...@cogent
7;
(or any shorten of it as 'cpu' or simply 'c')
For example:
ifstat -x c
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 9467119..a853ee6 100644
.
The extension can be called by its name or any shorten of it. If there is
more than one matched, the first one will be picked.
To get the extended stats the flag -x is used.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 160
Add documentation about the extended statistics to the ifstat man page.
Add ifstat man age to the man8 Makefile
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
man/man8/Makefile | 3 ++-
man/man8/ifstat.8 | 12 +++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff
Reorder the includes in misc/ifstat.c to match convention.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 92d67b0..5bcbcc8 100644
--- a/misc/ifstat.c
+++ b/misc
TSTATS always to using it only for extended
stats.
- Add 64bits extended stats type.
Nogah Frankel (4):
ifstat: Includes reorder
ifstat: Add extended statistics to ifstat
ifstat: Add "sw only" extended statistics to ifstat
ifstat: Add xstat to ifstat man page
man/man8/Make
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, January 19, 2017 9:11 PM
> To: Roopa Prabhu
> Cc: Nogah Frankel ; netdev@vger.kernel.org;
> roszenr...@gmail.com; Jiri Pirko ; Ido Schimmel
> ; Elad Raz ; Yota
> -Original Message-
> From: Nogah Frankel
> Sent: Sunday, January 15, 2017 3:55 PM
> To: 'Stephen Hemminger'
> Cc: netdev@vger.kernel.org; roszenr...@gmail.com; ro...@cumulusnetworks.com;
> Jiri
> Pirko ; Ido Schimmel ; Elad Raz
> ; Yotam Gigi ; O
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, January 13, 2017 3:44 AM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; roszenr...@gmail.com; ro...@cumulusnetworks.com;
> Jiri
> Pirko ; Ido Schimmel ; Elad Ra
> -Original Message-
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> Sent: Friday, January 13, 2017 12:11 PM
> To: Nogah Frankel ; netdev@vger.kernel.org
> Cc: step...@networkplumber.org; roszenr...@gmail.com;
> ro...@cumulusnetworks.com; Jiri Pi
them as an extended stats.
It is read with filter type IFLA_STATS_LINK_64 and no sub type.
It is under the name 64bits
(or any shorten of it as "64")
For example:
ifstat -x 64bit
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 inser
.
The extension can be called by its name or any shorten of it. If there is
more than one matched, the first one will be picked.
To get the extended stats the flag -x is used.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 160
7;
(or any shorten of it as 'cpu' or simply 'c')
For example:
ifstat -x c
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 3478f0a..5b6a36b 100644
ys to using it only for extended
stats.
- Add 64bits extended stats type.
Nogah Frankel (4):
ifstat: Includes reorder
ifstat: Add extended statistics to ifstat
ifstat: Add 64 bits based stats to extended statistics
ifstat: Add "sw only" extended statistics to
Reorder the includes order in misc/ifstat.c to match convention.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 92d67b0..5bcbcc8 100644
--- a/misc/ifstat.c
> -Original Message-
> From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
> Sent: Thursday, December 22, 2016 11:10 PM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; step...@networkplumber.org; roszenr...@gmail.com;
> Or
> Gerlitz ; Jiri Pirko ; Elad Raz
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, December 22, 2016 8:59 PM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com;
> Or
> Gerlitz ; Jiri Pirko ; Elad Raz
.
The extension can be called by its name or any shorten of it. If there is
more than one matched, the first one will be picked.
To get the extended stats the flag -x is used.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 161
them as an extended stats.
It is read with filter type IFLA_STATS_LINK_64 and no sub type.
It is under the name 64bits
(or any shorten of it as "64")
For example:
ifstat -x 64bit
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 inser
Reorder the includes order in misc/ifstat.c to match convention.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 92d67b0..5bcbcc8 100644
--- a/misc/ifstat.c
r includes in misc/ifstat.c
- patch 2/4: (previously 1/3)
- fix typos.
- change error print to use fprintf.
v1->v2:
- change from using RTM_GETSTATS always to using it only for extended
stats.
- Add 64bits extended stats type.
Nogah Frankel (4):
ifstat: Includes reorder
ifst
7;
(or any shorten of it as 'soft' or simply 's')
For example:
ifstat -x s
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 8325ac7..79c0dba 100644
> -Original Message-
> From: Rami Rosen [mailto:roszenr...@gmail.com]
> Sent: Friday, December 16, 2016 5:21 PM
> To: Nogah Frankel
> Cc: Stephen Hemminger ; netdev@vger.kernel.org;
> ro...@cumulusnetworks.com; Jiri Pirko ; Elad Raz
> ; Yotam Gigi ; Ido Schimmel
>
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, December 15, 2016 7:33 PM
> To: Nogah Frankel
> Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; Jiri Pirko
> ; Elad Raz ; Yotam Gigi
> ; Ido Schimmel ; Or Ger
s to using it only for extended
stats.
- Add 64bits extended stats type.
Nogah Frankel (3):
ifstat: Add extended statistics to ifstat
ifstat: Add 64 bits based stats to extended statistics
ifstat: Add "sw only" extended statistics to ifsta
7;
(or any shorten of it as 'soft' or simply 's')
For example:
ifstat -x s
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index ac99d04..62f1f2b 100644
.
The extension can be called by its name or any shorten of it. If there is
more than one matched, the first one will be picked.
To get the extended stats the flag -x is used.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 161
them as an extended stats.
It is read with filter type IFLA_STATS_LINK_64 and no sub type.
It is under the name 64bits
(or any shorten of it as "64")
For example:
ifstat -x 64bit
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 inser
ifstat used to get it data from the kernel with RTM_GETLINK.
Change the interface to get this data to RTM_GETSTATS that supports more
stats type beside the default one. It also change the default stats to be
64 bits based.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c
f.
The extension can be called by its name or any shorten of it. If there is
more then one matched, the first one will be picked.
To get the extended stats the flag -x is used.
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 88 ++
patchset change ifstat to the new method, add it the ability to
choose an extended type of statistic, and add the extended type of SW
stats for packets that hit cpu.
Nogah Frankel (3):
ifstat: Change interface to get stats
ifstat: Add extended statistics to ifstat
ifstat: Add "sw only"
7;
(or any shorten of it as 'soft' or simply 's').
For example:
ifstat -x s
Signed-off-by: Nogah Frankel
Reviewed-by: Jiri Pirko
---
misc/ifstat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/misc/ifstat.c b/misc/ifstat.c
index 90aeeaa..7825a3a 100644
> -Original Message-
> From: Nikolay Aleksandrov [mailto:niko...@cumulusnetworks.com]
> Sent: Friday, September 09, 2016 4:39 PM
> To: Nikolay Aleksandrov
> Cc: Jiri Pirko ; Linux Kernel Network Developers
> ; David S. Miller
> ; Nogah Frankel ; Ido Schimmel
> ;
> From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
> Sent: Tuesday, September 06, 2016 6:20 PM
> To: Jiri Pirko
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Nogah Frankel
> ; Ido Schimmel ; Elad Raz
> ; Yotam Gigi ; Or Gerlitz
> ; niko...@cumulusnetworks.com;
>
> -Original Message-
> From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com]
> Sent: Wednesday, August 10, 2016 9:09 AM
> To: Jiri Pirko
> Cc: netdev@vger.kernel.org; da...@davemloft.net; Nogah Frankel
> ; Ido Schimmel ; Elad
> Raz ; Yotam Gigi ; Or
> Gerlitz ; nik
53 matches
Mail list logo
