[iproute PATCH 12/51] iproute_lwtunnel: csum_mode value checking was ineffective

ila_csum_name2mode() returning -1 on error but being declared as returning __u8 doesn't make much sense. Change the code to correctly detect this issue. Checking for __u8 overruns shouldn't be necessary though since ila_csum_name2mode() return values are well-defined. Signed-off-by: Phil Sutter

[iproute PATCH 44/51] tipc/bearer: Fix resource leak in error path

Signed-off-by: Phil Sutter <p...@nwl.cc> --- tipc/bearer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tipc/bearer.c b/tipc/bearer.c index 810344f672af1..c3d4491f8f6ef 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -163,6 +163,7 @@ static int nl_add_udp_enable_opts(struct nl

[iproute PATCH 46/51] tipc/node: Fix socket fd check in cmd_node_get_addr()

socket() returns -1 on error, not 0. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tipc/node.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tipc/node.c b/tipc/node.c index 201fe1a4df3bd..fe085aec9b4ac 100644 --- a/tipc/node.c +++ b/tipc/node.c @@ -109,7 +109,8 @@

[iproute PATCH 43/51] tc/tc_filter: Make sure filter name is not empty

The later check for 'k[0] != 0' requires a non-empty filter name, otherwise NULL pointer dereference in 'q' might happen. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/tc_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tc/tc_filter.c b/tc/tc_filter.c index b13fb91

[iproute PATCH 15/51] ipvrf: Fix error path of vrf_switch()

Apart from trying to close(-1), this also leaked memory. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipvrf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 92e2db98ca7d7..75cc026d072b8 100644 --- a/ip/ipvrf.c +++ b/ip/i

[iproute PATCH 06/51] iplink_vrf: Complain if main table is not found

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iplink_vrf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ip/iplink_vrf.c b/ip/iplink_vrf.c index 917630e853375..809eda5de8f6e 100644 --- a/ip/iplink_vrf.c +++ b/ip/iplink_vrf.c @@ -131,7 +131,10 @@ __u32 ipvrf_get

[iproute PATCH 07/51] ipmaddr: Avoid accessing uninitialized data

Looks like this can only happen if /proc/net/igmp is malformed, but better be sure. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipmaddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipmaddr.c b/ip/ipmaddr.c index 4f726fdd976f1..85a69e779563d 100644 --

[iproute PATCH 42/51] tc/q_netem: Don't dereference possibly NULL pointer

Assuming 'opt' might be NULL, move the call to RTA_PAYLOAD to after the check since it dereferences its parameter. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/q_netem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tc/q_netem.c b/tc/q_netem.c index 0975ae1

[iproute PATCH 17/51] lib/bpf: Don't leak fp in bpf_find_mntpt()

If fopen() succeeded but len != PATH_MAX, the function leaks the open FILE pointer. Fix this by checking len value before calling fopen(). Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/bpf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib/bpf.c

[iproute PATCH 37/51] netem/maketable: Check return value of fscanf()

Signed-off-by: Phil Sutter <p...@nwl.cc> --- netem/maketable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netem/maketable.c b/netem/maketable.c index ad660e7d457f0..ccb8f0c68b062 100644 --- a/netem/maketable.c +++ b/netem/maketable.c @@ -38,8 +38,8 @@ readdouble

[iproute PATCH 18/51] lib/fs: Fix format string in find_fs_mount()

A field width of 4096 allows fscanf() to store that amount of characters into the given buffer, though that doesn't include the terminating NULL byte. Decrease the value by one to leave space for it. Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/fs.c | 2 +- 1 file changed, 1 insertion

[iproute PATCH 19/51] lib/fs: Fix and simplify make_path()

Calling stat() before mkdir() is racey: The entry might change in between. Also, the call to stat() seems to exist only to check if the directory exists already. So simply call mkdir() unconditionally and catch only errors other than EEXIST. Signed-off-by: Phil Sutter <p...@nwl.cc> --- li

[iproute PATCH 16/51] xfrm_state: Make sure alg_name is NULL-terminated

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/xfrm_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/xfrm_state.c b/ip/xfrm_state.c index e11c93bf1c3b5..7c0389038986e 100644 --- a/ip/xfrm_state.c +++ b/ip/xfrm_state.c @@ -125,7 +125,8 @@ static int xfrm_algo

[iproute PATCH 14/51] ipvrf: Don't try to close an invalid fd

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipvrf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ip/ipvrf.c b/ip/ipvrf.c index 0094cf8557cd7..92e2db98ca7d7 100644 --- a/ip/ipvrf.c +++ b/ip/ipvrf.c @@ -268,7 +268,7 @@ static int vrf_configure_cgroup(cons

[iproute PATCH 50/51] Check user supplied interface name lengths

being looked up using ll_name_to_index(), so if_nametoindex() will perform the necessary checks already. Signed-off-by: Phil Sutter <p...@nwl.cc> --- include/utils.h | 1 + ip/ip6tunnel.c | 6 -- ip/ipl2tp.c | 1 + ip/iplink.c | 27 --- ip/ipmaddr.c

[iproute PATCH 08/51] ipntable: No need to check and assign to parms_rta

This variable is initialized at declaration and nowhere else does any assignment to it happen, so just drop the check. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipntable.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ip/ipntable.c b/ip/ipntable.c index 879626ee4f491..1837909

[iproute PATCH 04/51] ipaddress: Avoid accessing uninitialized variable lcl

If no address was given, ipaddr_modify() accesses uninitialized data when assigning to req.ifa.ifa_prefixlen. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 3c9decb

[iproute PATCH 33/51] ss: Don't leak fd in tcp_show_netlink_file()

Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 4d2f75b571ea6..cda5e3b6a2d6f 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -2687,41 +2687,44 @@ stat

[iproute PATCH 34/51] ss: Make sure scanned index value to unix_state_map is sane

Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index cda5e3b6a2d6f..667b8faad6528 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3150,7 +3150,8 @@ static int unix_show(struct fil

[iproute PATCH 28/51] nstat: Avoid passing negative fd to fdopen()

Introduce a wrapper which does the sanity checking and returns NULL in case fd is invalid. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/nstat.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/misc/nstat.c b/misc/nstat.c index 23e1569d7872b..c1e7dde

[iproute PATCH 30/51] ss: Skip useless check in parse_hostcond()

The passed 'addr' parameter is dereferenced by caller before and in parse_hostcond() multiple times before this check, so assume it is always true. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/mis

[iproute PATCH 41/51] tc/q_multiq: Don't pass garbage in TCA_OPTIONS

multiq_parse_opt() doesn't change 'opt' at all. So at least make sure it doesn't fill TCA_OPTIONS attribute with garbage from stack. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/q_multiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/q_multiq.c b/tc/q_multiq.c

[iproute PATCH 40/51] tc/m_xt: Fix for potential string buffer overflows

would overwrite the previously NULL'ed 'k[15]'. Also, the sanitization has to happen if 'tname' is exactly 16 bytes long as well. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/m_xt.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tc/m_xt.c b/tc/

[iproute PATCH 39/51] tc/m_gact: Drop dead code

remaining checks for 'ok != 0' can be dropped. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/m_gact.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tc/m_gact.c b/tc/m_gact.c index 1a2583372c34e..df143c9e0953e 100644 --- a/tc/m_gact.c +++ b/tc/m_gact.c @@

[iproute PATCH 03/51] ipaddress: Make buffer for filter.flushb static

The buffer is accessed outside of the function defining it, so make it static. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipaddress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index 4d37c5e045071..3c9decb51b412 100644 --

[iproute PATCH 45/51] tipc/bearer: Prevent NULL pointer dereference

Signed-off-by: Phil Sutter <p...@nwl.cc> --- tipc/bearer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tipc/bearer.c b/tipc/bearer.c index c3d4491f8f6ef..0598328ab1f1b 100644 --- a/tipc/bearer.c +++ b/tipc/bearer.c @@ -438,8 +438,8 @@ static int cmd_bearer_

[iproute PATCH 00/51] Fix potential issues detected by Coverity tool

Covscan really wasn't amused (indicated by the number of patches in this series). Try to make it happy. Phil Sutter (51): devlink: Check return code of strslashrsplit() devlink: No need for this self-assignment ipaddress: Make buffer for filter.flushb static ipaddress: Avoid accessing

[iproute PATCH 20/51] lib/inet_proto: Make sure destination buffers are NULL-terminated

Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/inet_proto.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/inet_proto.c b/lib/inet_proto.c index ceda082b12a2e..87ed4769fc3da 100644 --- a/lib/inet_proto.c +++ b/lib/inet_proto.c @@ -35,8 +35,10 @@ cons

[iproute PATCH 36/51] netem/maketable: Check return value of fstat()

Otherwise info.st_size may contain garbage. Signed-off-by: Phil Sutter <p...@nwl.cc> --- netem/maketable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netem/maketable.c b/netem/maketable.c index 6aff927be7040..ad660e7d457f0 100644 --- a/netem/maketable.c +++ b

[iproute PATCH 23/51] ifstat: Fix memleak in error case

Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ifstat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ifstat.c b/misc/ifstat.c index a853ee6d7e3b3..8fa354265a9a1 100644 --- a/misc/ifstat.c +++ b/misc/ifstat.c @@ -143,8 +143,10 @@ static int get_nlmsg_ex

[iproute PATCH 47/51] examples: Some shell fixes to cbq.init

"integer expression expected" instead of "too many arguments". - Use -print0/-0 when piping from find to xargs to allow for filenames which contain whitespace. - Quote arguments to 'eval' to prevent word-splitting. Signed-off-by: Phil Sutter <p...@nwl.cc> --- exa

[iproute PATCH 09/51] ipntable: Make sure filter.name is NULL-terminated

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipntable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipntable.c b/ip/ipntable.c index 1837909fa42e7..30907146e85a3 100644 --- a/ip/ipntable.c +++ b/ip/ipntable.c @@ -631,7 +631,8 @@ static int ipntable_show(in

[iproute PATCH 11/51] iproute: Check mark value input

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iproute.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 89caac124f489..5fe8a3a75d5b7 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1495,7 +1495,8 @@ stat

[iproute PATCH 10/51] iproute: Fix for missing 'Oifs:' display

Covscan complained about dead code but after reading it, I assume the author's intention was to prefix the interface list with 'Oifs: '. Initializing first to 1 and setting it to 0 after above prefix was printed should fix it. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iproute

[iproute PATCH 05/51] iplink_can: Prevent overstepping array bounds

can_state_names array contains at most CAN_STATE_MAX fields, so allowing an index to it to be equal to that number is wrong. While here, also make sure the array is indeed that big so nothing bad happens if CAN_STATE_MAX ever increases. Signed-off-by: Phil Sutter <p...@nwl.cc> -

[iproute PATCH 48/51] ifcfg: Quote left-hand side of [ ] expression

This prevents word-splitting and therefore leads to more accurate error message in case 'grep -c' prints something other than a number. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ifcfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/ifcfg b/ip/ifcfg

[iproute PATCH 13/51] iproute_lwtunnel: Argument to strerror must be positive

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iproute_lwtunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c index 398ab5e077ed8..1a3dc4d4c0ed9 100644 --- a/ip/iproute_lwtunnel.c +++ b/ip/iproute_lwtunnel.c @@ -643,7

[iproute PATCH 01/51] devlink: Check return code of strslashrsplit()

This function shouldn't fail because all callers of __dl_argv_handle_port() make sure the passed string contains enough slashes already, but better make sure if this changes in future the function won't access uninitialized data. Signed-off-by: Phil Sutter <p...@nwl.cc> --- devlink/dev

[iproute PATCH 38/51] tc/em_ipset: Don't leak sockfd on error path

Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/em_ipset.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tc/em_ipset.c b/tc/em_ipset.c index fab975f5ea563..b59756515d239 100644 --- a/tc/em_ipset.c +++ b/tc/em_ipset.c @@ -84,6 +84,7 @@ static int get_version(unsigned int *v

[iproute PATCH 26/51] lnstat_util: Simplify alloc_and_open() a bit

Relying upon callers and using unsafe strcpy() is probably not the best idea. Aside from that, using snprintf() allows to format the string for lf->path in one go. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/lnstat_util.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions

[iproute PATCH 27/51] nstat: Fix for potential NULL pointer dereference

If the string at 'p' contains neither space not newline, 'p' will become NULL. Make sure this isn't the case before dereferencing it. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/nstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/nstat.c b/misc/nstat.c

[iproute PATCH 25/51] ifstat: Fix memleak in dump_kern_db() for json output

Looks like this was forgotten when converting to common json output formatter. Fixes: fcc16c2287bf8 ("provide common json output formatter") Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ifstat.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/misc

[iproute PATCH 31/51] ss: Drop useless assignment

After '*b = *a', 'b->next' already has the same value as 'a->next'. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 1 - 1 file changed, 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 5ea388fbf1c1a..d767b1103ea81 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -14

[iproute PATCH 35/51] ss: Fix potential memleak in unix_stats_print()

Fixes: 2d0e538f3e1cd ("ss: Drop list traversal from unix_stats_print()") Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 667b8faad6528..7d84b83c8ad71 100644 --- a/misc/ss.c

[iproute PATCH 51/51] lib/bpf: Check return value of write()

This is merely to silence the compiler warning. If write to stderr failed, assume that printing an error message will fail as well so don't even try. Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/bpf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bpf.c b/lib

[iproute PATCH 29/51] ss: Use C99 initializer in netlink_show_one()

This has the additional benefit of initializing st.ino to zero which is used later in is_sctp_assoc() function. Signed-off-by: Phil Sutter <p...@nwl.cc> --- misc/ss.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index f0d1c22

[iproute PATCH 21/51] lib/libnetlink: Don't pass NULL parameter to memcpy()

Both addattr_l() and rta_addattr_l() may be called with NULL data pointer and 0 alen parameters. Avoid calling memcpy() in that case. Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/libnetlink.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/libnetlink.c

[iproute PATCH 22/51] lib/rt_names: Drop dead code in rtnl_rttable_n2a()

Since 'id' is 32bit unsigned, it can never exceed RT_TABLE_MAX (which is defined to 0x). Therefore drop that never matching conditional. Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/rt_names.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/rt_names.c b/lib/rt_n

[iproute PATCH] tc-simple: Fix documentation

- CONTROL has to come last, otherwise 'index' applies to gact and not simple itself. - Man page wasn't updated to reflect syntax changes. Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-simple.8 | 29 ++--- tc/m_simple.c| 4 ++-- 2 files chang

[iproute PATCH] bpf: Make bytecode-file reading a little more robust

random content on a second line, like e.g.: | 4,40 0 0 12,21 0 1 2048,6 0 0 262144,6 0 0 0 | foobar Cc: Daniel Borkmann <dan...@iogearbox.net> Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/bpf.c | 32 1 file changed, 24 insertions(+), 8 deletions(-)

[iproute PATCH] iplink: Notify user if EEXIST error might be spurious

in userspace for this dilemma as far as I can tell, so try to detect whether a user might have run into this and notify that the given error message might be irrelevant. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iplink.c | 35 ++- 1 file changed, 34 inse

[iproute PATCH] Really fix get_addr() and get_prefix() error messages

Reported-by: Jaroslav Aster <jas...@redhat.com> Fixes: 334af76143368 ("fix get_addr() and get_prefix() error messages") Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/utils.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/utils.c b/lib/ut

Re: [PATCH v3] ss: Enclose IPv6 address in brackets

On Tue, Aug 01, 2017 at 12:05:13PM +0200, Florian Lehner wrote: [...] > @@ -114,9 +114,13 @@ int addr64_n2a(__u64 addr, char *buff, size_t len); > int af_bit_len(int af); > int af_byte_len(int af); > > -const char *format_host_r(int af, int len, const void *addr, > -

Re: [PATCH v2] ss: Enclose IPv6 address in brackets

On Mon, Jul 31, 2017 at 09:50:04PM +0200, Florian Lehner wrote: > This updated patch adds support for RFC2732 IPv6 address format with > brackets for the tool ss. Resolved hostnames will not be enclosed in > brackets, therefore the global variable resolve_hosts is initialized and > checked. > >

Re: [PATCH] ss: Enclose IPv6 address in brackets

On Mon, Jul 31, 2017 at 09:27:55AM -0700, Stephen Hemminger wrote: > On Mon, 31 Jul 2017 12:30:10 +0200 > Phil Sutter <p...@nwl.cc> wrote: > > > On Sat, Jul 29, 2017 at 02:29:10PM +0200, Florian Lehner wrote: > > > This patch adds support for RFC2732 IPv

Re: [PATCH] ss: Enclose IPv6 address in brackets

On Sat, Jul 29, 2017 at 02:29:10PM +0200, Florian Lehner wrote: > This patch adds support for RFC2732 IPv6 address format with brackets > for the tool ss. So output for ss changes from > 2a00:1450:400a:804::200e:443 to [2a00:1450:400a:804::200e]:443 for IPv6 > addresses with attached port number.

Re: [PATCHv2 iproute2] utils: return default family when rtm_family is not RTNL_FAMILY_IPMR/IP6MR

56e3eb4c3400 ("ip: route: fix multicast route dumps") > Signed-off-by: Hangbin Liu <liuhang...@gmail.com> Acked-by: Phil Sutter <p...@nwl.cc>

Re: [PATCH iproute2] utils: also check AF_INET family when rtm_type is RTN_MULTICAST

Hi Hangbin, On Thu, Jul 27, 2017 at 05:01:49PM +0800, Hangbin Liu wrote: [...] > diff --git a/lib/utils.c b/lib/utils.c > index e77bd30..0479e00 100644 > --- a/lib/utils.c > +++ b/lib/utils.c > @@ -1215,5 +1215,6 @@ int get_real_family(int rtm_type, int rtm_family) > if (rtm_type !=

Re: TC-pedit man page examples error

Hi Tyler, On Wed, Jul 26, 2017 at 09:47:51AM -0700, Tyler Bautista wrote: > Thank you for taking my message. I have gotten a solution working so > feel free to ignore the rest of this email. By vanilla iproute2 do you > mean the latest package through the yum or apt repository? All I can > tell

Re: TC-pedit man page examples error

Hi Tyler, On Tue, Jul 25, 2017 at 08:33:40AM -0700, Tyler Bautista wrote: > To whom it may concern, > I recently attempted to use simple tc action pedit commands on the man > page and I ran into some errors. The following is some information > about my version of iproute and my machine: >

[PATCH] lib: test_rhashtable: Fix KASAN warning

I forgot one spot when introducing struct test_obj_val. Fixes: e859afe1ee0c5 ("lib: test_rhashtable: fix for large entry counts") Reported by: kernel test robot <fengguang...@intel.com> Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/test_rhashtable.c | 4 +++- 1 file

[PATCH] lib: test_rhashtable: fix for large entry counts

t;m...@skelett.io> Signed-off-by: Phil Sutter <p...@nwl.cc> --- lib/test_rhashtable.c | 53 +++ 1 file changed, 32 insertions(+), 21 deletions(-) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 64e899b633371..16949d219291a

Re: [PATCH v2] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

Hi Matteo, I don't think git-am understands the subject change semantics you use here, so please drop the '(was: ...)' part from it. On Thu, Jul 20, 2017 at 12:36:32AM +0200, Matteo Croce wrote: > v2: reword commit message In my opinion, this belongs to patch meta info (below the three-dashes

Re: [iproute PATCH] ip netns: Make sure netns name is sane

On Wed, Jul 12, 2017 at 09:38:34AM -0700, Stephen Hemminger wrote: > On Mon, 10 Jul 2017 13:19:12 +0200 > Phil Sutter <p...@nwl.cc> wrote: > > > +static bool is_basename(const char *name) > > +{ > > + char *name_dup = strdup(name); > > + bool

Re: [iproute PATCH] ip netns: Make sure netns name is sane

On Mon, Jul 10, 2017 at 08:17:02AM -0700, Stephen Hemminger wrote: > On Mon, 10 Jul 2017 13:19:12 +0200 > Phil Sutter <p...@nwl.cc> wrote: > > > +static bool is_basename(const char *name) > > +{ > > + char *name_dup = strdup(name); > > + bool

Re: net-next STATUS page

On Tue, Jul 11, 2017 at 05:05:06PM +0200, Jiri Pirko wrote: > Tue, Jul 11, 2017 at 04:24:16PM CEST, da...@davemloft.net wrote: > > > >It has gotten to the point that even casually walking around > >Faro, Portugal last week, random German tourists would stop > >me in the street and ask if net-next

Re: [PATCH] netns: avoid directory traversal (was: ip netns: Make sure netns name is sane)

Hi Matteo, On Mon, Jul 10, 2017 at 02:08:31PM +0200, Matteo Croce wrote: > I noticed that your patch still leaves an uncovered scenario, the one where > the > namespace name is "." or "..". > Calling 'ip netns del ..' will remove /var/run which is a symlink to /run on > most systems causing some

[iproute PATCH] ip netns: Make sure netns name is sane

| # mount | grep foobar | nsfs on /tmp/foobar type nsfs (rw) Prevent this by making sure basename() does not see a need to alter the given netns name. Fixes: 0dc34c7713bb7 ("iproute2: Add processless network namespace support") Signed-off-by: Phil Sutter <p...@nwl.cc> --- i

[iproute PATCH] man: Collect names of man pages automatically

Fixes: e1b7f883e50de ("man: add documentation for IPv6 SR commands") Fixes: 1949f82cdf62c ("Introduce ip vrf command") Fixes: 535194a172d23 ("tipc: add peer remove functionality") Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man3/Makefile |

[iproute PATCH] tc: m_xt: Prevent a segfault in libipt

From: Phil Sutter <psut...@redhat.com> This happens with NAT targets, such as SNAT, DNAT and MASQUERADE. These are still not usable with this patch, but at least tc doesn't crash anymore when one tries to use them. Signed-off-by: Phil Sutter <p...@nwl.cc> --- tc/m_xt.c | 5 - 1

Re: iproute2 ss outputs duplicate tcp sockets info on kernel 3.10.105

Hi, Cc'ing Cyrill who wrote the code in question. Maybe he has an idea what's going wrong here. Cheers, Phil On Mon, May 08, 2017 at 06:56:04PM -0700, Li Er wrote: > i'm using v4.11.0 release of iproute2 and kernel 3.10.105, simply > running > > $ ss > Netid State Recv-Q

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

Hi, On Thu, May 04, 2017 at 09:43:56AM -0700, Stephen Hemminger wrote: > On Thu, 04 May 2017 10:41:03 -0400 (EDT) > David Miller wrote: > > > From: David Ahern > > Date: Thu, 4 May 2017 08:27:35 -0600 > > > > > On 5/4/17 3:36 AM, Daniel Borkmann wrote:

[iproute PATCH] man: ip.8: Document -brief flag

Brief output is especially useful for new users, so at least mention it's existence in ip man page. Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/ip.8 | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/man/man8/ip.8 b/man/man8/ip.8 index 1c5a741

[iproute PATCH] man: ip-rule.8: Further clarify how to interpret priority value

Despite the past changes, users seemed to get confused by the seemingly contradictory relation of priority value and actual rule priority. Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/ip-rule.8 | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/man/man8/i

Re: [iproute PATCH] ip-route: Prevent some other double spaces in output

On Wed, Apr 05, 2017 at 07:10:26PM +0200, Timothy Redaelli wrote: > Print spaces only after text. > > CC: Phil Sutter <p...@nwl.cc> > Signed-off-by: Timothy Redaelli <tredae...@redhat.com> Acked-by: Phil Sutter <p...@nwl.cc> > Fixed all the problems reporte

Re: [PATCH iproute2] man: fix man page warnings

On Sun, Mar 26, 2017 at 09:11:14PM +0200, Alexander Alemayhu wrote: > While generating PDFs from the man pages, I saw the warning below from > several files. Compared the tc-matchall.8 with bridge.8 and used .RI > instead of .R. It should have no effect on the man page rendering. > > `R' is a

[iproute PATCH] man: ip-link: Specify min/max values for bridge slave priority and cost

The values are parsed as u16/u32, but kernel limits allowed values. Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/ip-link.8.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 3f5d57c28885f..12ec330a9c38e

[iproute PATCH 1/4] ip: link: bond: Fix whitespace in help text

Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iplink_bond.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_bond.c b/ip/iplink_bond.c index fe83479a091a8..772b05fd89eaf 100644 --- a/ip/iplink_bond.c +++ b/ip/iplink_bond.c @@ -133,7 +133,7 @@ stati

[iproute PATCH 4/4] ip: link: Add missing link type help texts

These are basically stubs: The types which lacked their own help text simply don't accept any options (yet). Still it might be a bit confusing to users if they are presented with the generic 'ip link' help text instead of something saying there are no type specific options. Signed-off-by: Phil

[iproute PATCH 3/4] ip: link: Unify link type help functions a bit

ry options first. link_veth.c is intentionally left untouched because it's 'peer' option eats all kinds of generic link options and the help text points this out without duplicating all the options there again. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/ipli

[iproute PATCH 0/4] Smaller link type help review

'. Phil Sutter (4): ip: link: bond: Fix whitespace in help text ip: link: macvlan: Add newline to help output ip: link: Unify link type help functions a bit ip: link: Add missing link type help texts ip/Makefile | 3 ++- ip/iplink_bond.c| 2 +- ip/iplink_dummy.c | 16

[iproute PATCH 2/4] ip: link: macvlan: Add newline to help output

A newline between synopsis and variable definition looks nice and is consistent with others. Signed-off-by: Phil Sutter <p...@nwl.cc> --- ip/iplink_macvlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ip/iplink_macvlan.c b/ip/iplink_macvlan.c index b9a146f271186..662eb6ff9507c

[iproute PATCH] man: ss.8: Add missing protocols to description of -A

The list was missing dccp and sctp protocols. Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/ss.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ss.8 b/man/man8/ss.8 index 4ef11523b4268..81de69de8042e 100644 --- a/man/man8/ss.8 +++ b/man/man8/ss.8 @@

Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

On Sat, Feb 25, 2017 at 10:29:17PM +0100, Jiri Kosina wrote: > From: Jiri Kosina > > Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking > kernel to perform 'full qdisc dump', as for historical reasons some of the > default qdiscs are being hidden by the

Re: [PATCH] iproute2: hide devices starting with period by default

On Thu, Feb 23, 2017 at 05:31:14PM -0800, Stephen Hemminger wrote: > On Thu, 23 Feb 2017 18:07:07 -0700 > David Ahern wrote: > > > On 2/23/17 5:30 PM, Stephen Hemminger wrote: > > > On Thu, 23 Feb 2017 16:39:52 -0700 > > > David Ahern wrote: >

[iproute PATCH v2 1/2] testsuite: Generate nlmsg blob at runtime

two VFs instead of the full list before. Yet this is sufficient, as it triggers the crash with iproute versions prior to commit 8c29ae7cc2494 ("ip link: Fix crash on older kernels when show VF dev"). Signed-off-by: Phil Sutter <p...@nwl.cc> --- Changes since v1: - Dropped the pre

[iproute PATCH v2 0/2] Two minor testsuite fixes

While playing around with testsuite, I noticed two minor nits which this series attempts to fix. Changes since v1: - Replaced patch1 completely. Phil Sutter (2): testsuite: Generate nlmsg blob at runtime testsuite: Search kernel config in modules dir also .gitignore

[iproute PATCH v2 2/2] testsuite: Search kernel config in modules dir also

At least in Fedora there is no /proc/config.gz but instead /lib/modules/`uname -r`/config, so use that as a fallback. Signed-off-by: Phil Sutter <p...@nwl.cc> --- testsuite/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/testsuite/Makefile b/testsuite/Makefile

Re: [iproute PATCH 1/2] testsuite: skip link show test on big endian systems

On Tue, Feb 07, 2017 at 03:12:49PM -0800, Stephen Hemminger wrote: > On Wed, 8 Feb 2017 00:04:21 +0100 > Phil Sutter <p...@nwl.cc> wrote: > > > Netlink protocol is in host byte order, so the provided binary netlink > > message buffer being in little endian format

[iproute PATCH 2/2] testsuite: Search kernel config in modules dir also

At least in Fedora there is no /proc/config.gz but instead /lib/modules/`uname -r`/config, so use that as a fallback. Signed-off-by: Phil Sutter <p...@nwl.cc> --- testsuite/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/testsuite/Makefile b/testsuite/Makefile

[iproute PATCH 1/2] testsuite: skip link show test on big endian systems

Netlink protocol is in host byte order, so the provided binary netlink message buffer being in little endian format will cause the test to fail on big endian systems. Signed-off-by: Phil Sutter <p...@nwl.cc> --- .gitignore| 1 + testsuite/Ma

[iproute PATCH 0/2] Two minor testsuite fixes

While playing around with testsuite, I noticed two minor nits which this series attempts to fix. Phil Sutter (2): testsuite: skip link show test on big endian systems testsuite: Search kernel config in modules dir also .gitignore| 1 + testsuite/Makefile

[iproute PATCH] man: ip-route.8: Fix 'expires' indenting

Descriptions of each route sub-command's arguments are enclosed in .RS/.RE pairs. For 'replace' sub-command, '.RE' was incorrectly put before the last argument ('expires'). Fixes: 3fbe7ca847367 ("iproute2: ip-route.8.in: Add expires option for ip route") Signed-off-by: Phil Sutter &l

[iproute PATCH v2] man: tc-csum.8: Fix example

tti <dcara...@redhat.com> Signed-off-by: Phil Sutter <p...@nwl.cc> --- Changes since v1: - Instead of using potentially valid IP addresses, use RFC 5737 ones. --- man/man8/tc-csum.8 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/man/man8/tc-csum.8 b/ma

Re: [iproute PATCH] man: tc-csum.8: Fix example

On Fri, Jan 27, 2017 at 09:49:58PM +0100, Guillaume Nault wrote: > On Fri, Jan 27, 2017 at 12:15:01PM +0100, Phil Sutter wrote: > > +# tc filter add dev eth0 prio 1 protocol ip parent : \\ > > u32 match ip src 192.168.1.100/32 flowid :1 \\ > > - action pedit munge

Re: [PATCH iproute2 1/1] tc: distinguish Add/Replace action operations.

On Sun, Jan 22, 2017 at 08:55:33AM -0500, Roman Mashak wrote: > Signed-off-by: Roman Mashak <m...@mojatatu.com> > Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com> Acked-by: Phil Sutter <p...@nwl.cc>

[iproute PATCH] man: tc-csum.8: Fix example

tti <dcara...@redhat.com> Signed-off-by: Phil Sutter <p...@nwl.cc> --- man/man8/tc-csum.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8 index 3a64c82f09ba8..43561d9f90a8e 100644 --- a/man/man8/tc-csum.8 +++ b/man/man8/tc

[net-next PATCH v7] net: dummy: Introduce dummy virtual functions

mmy bus type is being registered which implements the 'num_vf()' callback. Additionally, a dummy parent device common to all dummy devices is registered which sits on the above dummy bus. Joint work with Sabrina Dubroca. Signed-off-by: Sabrina Dubroca <s...@queasysnail.net> Signed-off-by: Ph

Re: [net-next PATCH 0/3] Retrieve number of VFs in a bus-agnostic way

On Fri, Jan 20, 2017 at 11:43:46AM -0500, David Miller wrote: > From: Phil Sutter <p...@nwl.cc> > Date: Wed, 18 Jan 2017 14:04:36 +0100 > > > Previously, it was assumed that only PCI NICs would be capable of having > > virtual functions - with my proposed enha

[net-next PATCH 0/3] Retrieve number of VFs in a bus-agnostic way

this callback for PCI bus and finally adjusting rtnetlink to make use of the generalized infrastructure. Phil Sutter (3): device: bus_type: Introduce num_vf callback PCI: implement num_vf bus type callback device: Implement a bus agnostic dev_num_vf routine drivers/pci/pci-driver.c | 6 ++ include

<    1   2   3   4   5   6   7   8   9   10   >