Re: [patch net-next v5 5/8] switchdev: introduce possibility to defer obj_add/del

On Wed, Oct 14, 2015 at 10:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Similar to the attr usecase, the caller knows if he is holding RTNL and is > in atomic section. So let the called to decide the correct call variant. > > This allows drivers to sleep

Re: [PATCH net-next] Adding switchdev ageing notification on port bridged

On Mon, Oct 19, 2015 at 5:37 AM, Elad Raz <el...@mellanox.com> wrote: > Configure ageing time to the HW for newly bridged device > > CC: Scott Feldman <sfel...@gmail.com> > CC: Jiri Pirko <j...@resnulli.us> > Signed-off-by: Elad Raz <el...@mellanox.com> Ack

Re: [patch net-next v5 3/8] switchdev: allow caller to explicitly request attr_set as deferred

On Fri, Oct 16, 2015 at 1:23 AM, Jiri Pirko wrote: > Thu, Oct 15, 2015 at 05:21:22PM CEST, john.fastab...@gmail.com wrote: >>On 15-10-14 10:40 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Caller should know if he can call attr_set directly (when holding

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot wrote: > On Oct. Wednesday 14 (42) 09:14 AM, Ido Schimmel wrote: >> Tue, Oct 13, 2015 at 05:32:26PM IDT, vivien.dide...@savoirfairelinux.com >> wrote: >> >On Oct. Tuesday 13 (42) 11:31 AM, Ido Schimmel wrote: >>

Re: [patch net-next v5 3/8] switchdev: allow caller to explicitly request attr_set as deferred

On Wed, Oct 14, 2015 at 10:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Caller should know if he can call attr_set directly (when holding RTNL) > or if he has to defer the att_set processing for later. > > This also allows drivers to sleep inside attr_set

Re: [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

On Tue, Oct 13, 2015 at 9:46 AM, Vivien Didelot <vivien.dide...@savoirfairelinux.com> wrote: > Implement the port_fdb_dump DSA operation. > > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Scott Feldman <sfel...@gmail.com> -- To unsub

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

include "br_private.h" >>> >>> @@ -249,6 +250,8 @@ static void del_nbp(struct net_bridge_port *p) >>> list_del_rcu(>list); >>> >>> br_fdb_delete_by_port(br, p, 0, 1); >>> + switchdev_flush_deferred(); >

Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

changes. Is this two patches? > > I removed ROCKER_OP_FLAG_NOWAIT from attr_set. But here in > rocker_port_fdb_flush, which is called from attr_set, we call > rocker_port_fdb_learn with spin lock. Therefore I had to put > ROCKER_OP_FLAG_NOWAIT here. Before ROCKER_OP_FLAG_NOWAIT removal from > attr_set this was there already. Gotcha. Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: >>On 15-10-12 10:44 PM, Jiri Pirko wrote: >>> Tue, Oct 13, 2015 at 04:52:42AM CEST, sfel...@gmail.com wrote: On Mon, Oct 12, 2015 at 11:03 AM, Jiri

Re: [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one

On Mon, Oct 12, 2015 at 10:51 AM, Ido Schimmel wrote: > Mon, Oct 12, 2015 at 02:41:09PM IDT, ra...@blackwall.org wrote: >>From: Nikolay Aleksandrov >> >>As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is >>unnecessary (and

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

On Tue, Oct 13, 2015 at 12:30 AM, Jiri Pirko wrote: > Tue, Oct 13, 2015 at 08:53:45AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 12, 2015 at 11:21 PM, Jiri Pirko wrote: >>> Tue, Oct 13, 2015 at 08:03:46AM CEST, john.fastab...@gmail.com wrote: On 15-10-12

Re: [PATCH net-next] bridge: fix gc_timer mod/del race condition

t; + if (!rtnl_trylock()) > + return restart_syscall(); > + > + ret = br_set_ageing_time(br, val); > + rtnl_unlock(); > + > + return ret; > } Looks good, thanks Nikolay. The other option would have been to simply not restart gc_ti

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

On Mon, Oct 12, 2015 at 10:36 AM, Vivien Didelot wrote: > Hi guys, > > On Oct. Monday 12 (42) 02:01 PM, Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> We shouldn't allow BRIDGE_VLAN_INFO_PVID flag in VLAN ranges. >>

Re: [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Caller should know if he can call attr_set directly (when holding RTNL) > or if he has to defer the att_set processing for later. > > This also allows drivers to sleep inside attr_set

Re: [patch net-next v4 1/7] switchdev: introduce switchdev workqueue

On Mon, Oct 12, 2015 at 10:54 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > This is going to be used for deferred operations. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com>

Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects

ne else. So rather do local copy of the value. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org M

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Since spinlock is held here, defer the switchdev operation. > > Signed-off-by: Jiri Pirko > --- > net/bridge/br_fdb.c | 5 - > net/bridge/br_if.c | 3 +++ > 2

Re: [PATCH net] switchdev: check if the vlan id is in the proper vlan range

4095 cannot > be passed either. > > Fixes: 47f8328bb1a4 ("switchdev: add new switchdev bridge setlink") > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the li

Re: [patch net-next v4 4/7] switchdev: introduce possibility to defer obj_add/del

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Similar to the attr usecase, the caller knows if he is holding RTNL and is > in atomic section. So let the called to decide the correct call variant. > > This allows drivers to sleep

Re: [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks.

On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: > From: Jiri Pirko > > No need to avoid sleeping in switchdev callbacks now, as the switchdev > core allows it. > > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/rocker/rocker.c

Re: [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn

On Mon, Oct 12, 2015 at 8:31 PM, John Fastabend <john.fastab...@gmail.com> wrote: > On 15-10-12 08:28 PM, Scott Feldman wrote: >> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko <j...@resnulli.us> wrote: >>> From: Jiri Pirko <j...@mellanox.com> >>> >>

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

On Sat, Oct 10, 2015 at 8:56 AM, Vivien Didelot wrote: > Scott, didn't you have a plan to add a struct device for the parent of > switchdev ports? I had sent out a rough RFC for a switch device in the last window. I have continued working on it, and I plan

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

; Premkumar Jonnala; step...@networkplumber.org; >>>> ro...@cumulusnetworks.com; and...@lunn.ch; f.faine...@gmail.com; >>>> vivien.dide...@savoirfairelinux.com >>>> Subject: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time >>>> down >&

Re: switchdev and VLAN ranges

On Sun, Oct 11, 2015 at 5:13 PM, Nikolay Aleksandrov wrote: > On 10/12/2015 12:41 AM, Vivien Didelot wrote: >> On Oct. Sunday 11 (41) 09:12 AM, Jiri Pirko wrote: >>> Sat, Oct 10, 2015 at 12:36:26PM CEST, niko...@cumulusnetworks.com wrote: On 10/10/2015 09:49 AM,

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

On Sat, Oct 10, 2015 at 9:03 AM, Vivien Didelot <vivien.dide...@savoirfairelinux.com> wrote: > On Oct. Friday 09 (41) 08:20 PM, Scott Feldman wrote: >> On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot >> <vivien.dide...@savoirfairelinux.com> wrote: >> > Hi Jiri,

Re: [patch net-next RFC 3/3] switchdev: introduce deferred variants of obj_add/del helpers

On Thu, Oct 8, 2015 at 6:25 AM, Jiri Pirko wrote: > Thu, Oct 08, 2015 at 03:21:44PM CEST, gerlitz...@gmail.com wrote: >>On Thu, Oct 8, 2015 at 4:09 PM, Jiri Pirko wrote: >>> Thu, Oct 08, 2015 at 10:28:58AM CEST, j...@resnulli.us wrote: Thu, Oct 08, 2015 at

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

On Fri, Oct 9, 2015 at 7:36 AM, Jiri Pirko wrote: > Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote: >>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote: >>>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrote: Tue, Oct 06, 2015 at

Re: [patch net-next RFC 2/3] switchdev: allow caller to explicitly use deferred attr_set version

On Thu, Oct 8, 2015 at 11:46 PM, Jiri Pirko wrote: > Fri, Oct 09, 2015 at 06:39:41AM CEST, sfel...@gmail.com wrote: >>On Thu, Oct 8, 2015 at 1:26 AM, Jiri Pirko wrote: >>> Thu, Oct 08, 2015 at 08:03:35AM CEST, sfel...@gmail.com wrote: On Wed, Oct 7, 2015

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

vemloft.net; j...@resnulli.us; siva.mannem@gmail.com; >> Premkumar Jonnala; step...@networkplumber.org; >> ro...@cumulusnetworks.com; and...@lunn.ch; f.faine...@gmail.com; >> vivien.dide...@savoirfairelinux.com >> Subject: [PATCH net-next v3 3/4] bridge: push bridge

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

hen adding/deleting vlan id. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> > Signed-off-by: Ido Schimmel <ido...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: switchdev and VLAN ranges

On Fri, Oct 9, 2015 at 4:30 PM, Vivien Didelot wrote: > Hi All, > > I understand that specifying a VLAN range on the command line is nice > for the user, and it makes no big deal for software implementation. [Adding Roopa, since she did the original vlan

Re: [PATCH net-next] ipv6 route: use err pointers instead of returning pointer by reference

On Thu, Oct 8, 2015 at 10:26 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch makes ip6_route_info_create return err pointer instead of > returning the rt pointer by reference as suggested by Dave > > Signed-off-by: Roopa Prabhu

Re: [patch net-next] bridge: try switchdev op first in __vlan_vid_add/del

On Fri, Oct 9, 2015 at 3:44 PM, Vivien Didelot wrote: > Hi Jiri, > > On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Some drivers need to implement both switchdev vlan ops and >> vid_add/kill ndos. For that to

Re: [PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device

On Thu, Oct 8, 2015 at 10:38 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch enables adding of fdb entries pointing to the bridge device. > This can be used to propagate mac address of vlan interfaces > configured on top of the

Re: [PATCH net-next 5/6] net: dsa: push prepare phase in port_fdb_add

On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot <vivien.dide...@savoirfairelinux.com> wrote: > Now that the prepare phase is pushed down to the DSA drivers, propagate > it to the port_fdb_add function. > > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com

Re: [PATCH net-next 6/6] net: dsa: use switchdev obj in port_fdb_del

On Wed, Oct 7, 2015 at 4:48 PM, Vivien Didelot <vivien.dide...@savoirfairelinux.com> wrote: > For consistency with the FDB add operation, propagate the > switchdev_obj_port_fdb structure in the DSA drivers. > > Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com

Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare

delot <vivien.dide...@savoirfairelinux.com> Reviewed-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next RFC 2/3] switchdev: allow caller to explicitly use deferred attr_set version

On Wed, Oct 7, 2015 at 10:39 PM, Jiri Pirko wrote: > Thu, Oct 08, 2015 at 06:27:07AM CEST, sfel...@gmail.com wrote: >>On Wed, Oct 7, 2015 at 11:30 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Caller should know if he can call attr_set

Re: [PATCH net-next v2 1/4] switchdev: add bridge attributes

On Thu, Oct 8, 2015 at 1:39 AM, Jiri Pirko <j...@resnulli.us> wrote: > Thu, Oct 08, 2015 at 08:04:40AM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman <sfel...@gmail.com> >> >>Setting the stage to push bridge-level attributes down to port driver so >>

Re: [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev

On Thu, Oct 8, 2015 at 7:40 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > 2015-10-08 19:23 GMT-07:00 <sfel...@gmail.com>: >> From: Scott Feldman <sfel...@gmail.com> >> >> Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't >

Re: [patch net-next RFC 2/3] switchdev: allow caller to explicitly use deferred attr_set version

On Thu, Oct 8, 2015 at 1:26 AM, Jiri Pirko wrote: > Thu, Oct 08, 2015 at 08:03:35AM CEST, sfel...@gmail.com wrote: >>On Wed, Oct 7, 2015 at 10:39 PM, Jiri Pirko wrote: >>> Thu, Oct 08, 2015 at 06:27:07AM CEST, sfel...@gmail.com wrote: On Wed, Oct 7, 2015

Re: [patch net-next RFC 2/3] switchdev: allow caller to explicitly use deferred attr_set version

On Wed, Oct 7, 2015 at 11:30 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Caller should know if he can call attr_set directly (when holding RTNL) > or if he has to use deferred version of this function. > > This also allows drivers to sleep inside attr_set

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

On Tue, Oct 6, 2015 at 11:14 PM, Jiri Pirko wrote: > Wed, Oct 07, 2015 at 03:50:08AM CEST, sfel...@gmail.com wrote: > > > >> >>> Also I wonder how this works when a pkt ingresses a port in mode A and >>> egresses a port in mode B? What fib/fdb tables does it cross when this >>>

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko wrote: > Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote: >>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko wrote: >>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote: On Mon, Oct 5, 2015

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

On Tue, Oct 6, 2015 at 2:25 PM, John Fastabend wrote: > [...] > Using void * in these ops is unacceptable, I can't agree to this patch. There is a much cleaner way to architect this. If you look at the ops defined, they're mostly duplicates of

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

On Tue, Oct 6, 2015 at 9:15 AM, Jiri Pirko wrote: > Tue, Oct 06, 2015 at 06:06:45PM CEST, sfel...@gmail.com wrote: >>On Tue, Oct 6, 2015 at 12:51 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This is another step on the way to

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

On Tue, Oct 6, 2015 at 12:51 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This is another step on the way to per-world clean cut. Introduce world > ops hooks which each world can implement in world-specific way. > Also introduce world infrastructure including

Re: [patch net-next v3 06/14] rocker: introduce worlds infrastructure

On Tue, Oct 6, 2015 at 9:19 AM, John Fastabend <john.fastab...@gmail.com> wrote: > On 15-10-06 09:06 AM, Scott Feldman wrote: >> On Tue, Oct 6, 2015 at 12:51 AM, Jiri Pirko <j...@resnulli.us> wrote: >>> From: Jiri Pirko <j...@mellanox.com> >>> >>&

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko wrote: > Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> This patchset allows new rocker worlds to

Re: [patch net-next v2 13/13] rocker: move OF-DPA stuff into separate file

On Mon, Oct 5, 2015 at 10:44 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Carve out OF-DPA would specific code from the common file to the world > file. This change required struct rocker and struct rocker_port split > into world specific struct ofdpa and

Re: [patch net-next 00/14] rocker: add support for multiple worlds

On Mon, Oct 5, 2015 at 9:58 AM, John Fastabend wrote: > On 15-10-05 09:30 AM, Jiri Pirko wrote: >> Mon, Oct 05, 2015 at 05:41:38PM CEST, john.fastab...@gmail.com wrote: >>> On 15-10-04 02:25 PM, Jiri Pirko wrote: From: Jiri Pirko This

Re: [patch net-next 05/14] rocker: implement set settings mode command

On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Introduce a helper to ask HW for change of the port mode (world). > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel.

Re: [patch net-next v2 01/13] rocker: remove unused rocker_port param from alloc funcs and shorten their names

m removal, shorten the name of the functions since they now > has nothing to do with rocker port. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [patch net-next v2 03/13] rocker: rename rocker.c to rocker_main.c

". Multiple code > parts are going to be cut from "rocker_main.c" later on. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 06/13] rocker: introduce worlds infrastructure

On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This is another step on the way to per-world clean cut. Introduce world > ops hooks which each world can implement in world-specific way. > Also introduce world infrastructure including

Re: [patch net-next v2 02/13] rocker: rename rocker.h to rocker_hw.h

gned-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 04/13] rocker: push tlv processing into separate files

On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Carve out TLV processing helpers into separate files. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.c

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset allows new rocker worlds to be easily added in future (like eBPF > based one I have been working on). The main part of the patchset is the OF-DPA > carve-out. It resuts in

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

On Mon, Oct 5, 2015 at 9:50 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 06:37:20PM CEST, sfel...@gmail.com wrote: >>On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: >>> Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: On Sun, Oct 4, 2015 at

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce a stub for allowing user to change rocker port world/mode. > This is implemented using rtnl changelink op. > > Signed-off-by: Jiri Pirko [cut] > diff

Re: [patch net-next 09/14] rocker: add rtnl ops for port mode [gs]etting

On Mon, Oct 5, 2015 at 8:53 AM, Jiri Pirko wrote: > Mon, Oct 05, 2015 at 05:41:29PM CEST, sfel...@gmail.com wrote: >>On Sun, Oct 4, 2015 at 2:25 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Introduce a stub for allowing user to change

Re: [patch net-next v2 3/6] switchdev: rename switchdev_obj_vlan to switchdev_obj_port_vlan

On Thu, Oct 1, 2015 at 2:03 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Make the struct name in sync with object id name. > > Suggested-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > Signed-off-by: Jiri Pirko

Re: [patch net-next v2 2/6] switchdev: rename SWITCHDEV_ATTR_* enum values to SWITCHDEV_ATTR_ID_*

On Thu, Oct 1, 2015 at 2:03 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > To be aligned with obj. > > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this

Re: [patch net-next v2 5/6] switchdev: bring back switchdev_obj and use it as a generic object param

gt; > --- > v1->v2: > * align object structure getter name with structure name as suggested by > Vivien > --- Acked-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 1/6] switchdev: rename SWITCHDEV_OBJ_* enum values to SWITCHDEV_OBJ_ID_*

On Thu, Oct 1, 2015 at 2:03 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Suggested-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sf

Re: [patch net-next v2 6/6] switchdev: push object ID back to object structure

On Thu, Oct 1, 2015 at 2:03 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Suggested-by: Scott Feldman <sfel...@gmail.com> > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman <sfel...@gmail.com&

Re: [patch net-next v2 4/6] switchdev: rename switchdev_obj_fdb to switchdev_obj_port_fdb

On Thu, Oct 1, 2015 at 2:03 AM, Jiri Pirko <j...@resnulli.us> wrote: > From: Jiri Pirko <j...@mellanox.com> > > Make the struct name in sync with object id name. > > Suggested-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> > Signed-off-by: Jiri Pirko

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

On Wed, Sep 30, 2015 at 11:56 AM, Vivien Didelot <vivien.dide...@savoirfairelinux.com> wrote: > Hi all, > > On Sep. Friday 25 (39) 11:03 AM, Vivien Didelot wrote: >> On Sep. Thursday 24 (39) 10:55 PM, David Miller wrote: >> > From: Scott Feldman <sfel...@gmail.co

Re: [patch net-next] switchdev: bring back switchdev_obj and use it as a generic object param

On Wed, Sep 30, 2015 at 9:00 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Replace "void *obj" with a generic structure. Introduce couple of > helpers along that. > > Signed-off-by: Jiri Pirko Looks good to me, except for the macro/enum

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

On Wed, Sep 30, 2015 at 3:36 AM, Jiri Pirko wrote: > Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >>Now that switchdev and its drivers directly use specific switchdev_obj_* >>structures, move them out of the switchdev_obj union and get rif

Re: [patch net-next v3 00/10] switchdev: transaction item queue and cleanup

net/ethernet/rocker/rocker.c | 308 > ++--- > include/net/switchdev.h| 40 +++-- > net/dsa/slave.c| 31 ++-- > net/switchdev/switchdev.c | 125 ++++++--- > 5 files changed, 296 insertions(+), 227 deletio

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Thu, 24 Sep 2015 13:59:26 -0700 > sfel...@gmail.com wrote: > >> From: Scott Feldman <sfel...@gmail.com> >> >> Push bridge-level attributes down to sw

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

On Thu, Sep 24, 2015 at 6:23 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 24/09/15 13:59, sfel...@gmail.com wrote: >> From: Scott Feldman <sfel...@gmail.com> >> >> Push bridge-level attributes down to switchdev drivers. This patchset >>

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

On Thu, Sep 24, 2015 at 9:36 PM, Vivien Didelot wrote: > Hi Jiri, > > On Sep. Thursday 24 (39) 10:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Now, the memory allocation in prepare/commit state is done separatelly >> in each driver

Re: [patch net-next v2 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

On Wed, Sep 23, 2015 at 12:57 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Now, the memory allocation in prepare/commit state is done separatelly > in each driver (rocker). Introduce the similar mechanism in generic > switchdev code, in form of queue. That

Re: [PATCH net-next] rtnl_fdb_dump: catch errors from ndo_fdb_dump and ndo_dflt_fdb_dump

n Kok <w...@cumulusnetworks.com> > Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> Reviewed-by: Scott Feldman <sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch net-next 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

index df5a544..55a8411 100644 > --- a/net/switchdev/switchdev.c > +++ b/net/switchdev/switchdev.c > @@ -1,6 +1,6 @@ > /* > * net/switchdev/switchdev.c - Switch device API > - * Copyright (c) 2014 Jiri Pirko <j...@resnulli.us> > + * Copyright (c) 2014-2015 Jiri Pirko <

Re: [patch net-next 00/10] switchdev: transaction item queue and cleanup

On Tue, Sep 22, 2015 at 6:53 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Jiri Pirko (10): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction item queue for attr_set and obj_add > switchdev: move transaction phase enum under

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: > Jiri Pirko (6): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction infrastructure for attr_set and > obj_add > rocker: switch to local transaction phase enum > switchdev: move transaction

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

On Mon, Sep 21, 2015 at 1:09 AM, Jiri Pirko wrote: > Mon, Sep 21, 2015 at 09:23:24AM CEST, sfel...@gmail.com wrote: >>On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: >>> Jiri Pirko (6): >>> switchdev: rename "trans" to "trans_ph". >>> switchdev:

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

On Sun, Sep 20, 2015 at 7:24 AM, roopa <ro...@cumulusnetworks.com> wrote: > On 9/19/15, 7:21 PM, Scott Feldman wrote: >> >> Yes, your switch driver is in user-space so you have to use NTF_USE to >> refresh the entry since you cannot use the kernel driver model to

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

On Sat, Sep 19, 2015 at 6:21 PM, roopa <ro...@cumulusnetworks.com> wrote: > On 9/18/15, 12:55 PM, sfel...@gmail.com wrote: >> >> From: Scott Feldman <sfel...@gmail.com> >> >> Signed-off-by: Scott Feldman <sfel...@gmail.com> >> ---

Re: [PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries

On Fri, Sep 18, 2015 at 11:30 PM, Jiri Pirko <j...@resnulli.us> wrote: > Fri, Sep 18, 2015 at 09:55:47PM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman <sfel...@gmail.com> >> >>Follow-up patcheset will allow user to change ageing_time, but for now >

Re: [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko <j...@resnulli.us> wrote: > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman <sfel...@gmail.com> >> >>Signed-off-by: Scott Feldman <sfel...@gmail.com> >>--- >> incl

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: > Jiri Pirko (6): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction infrastructure for attr_set and > obj_add > rocker: switch to local transaction phase enum > switchdev: move transaction

Re: [RFC PATCH net-next 1/3] net: switchdev: extract switchdev_obj_vlan

On Tue, Sep 8, 2015 at 1:47 PM, Vivien Didelot wrote: > Move the switchdev_obj_vlan structure out of the switchdev_obj union. > > This lightens the switchdev_obj structure and allows drivers to access > the object transaction and callback directly from a

Re: [RFC PATCH net-next 0/3] net: switchdev: extract specific object structures

On Tue, Sep 8, 2015 at 1:47 PM, Vivien Didelot wrote: > Hi! > > Current implementations of .switchdev_port_obj_add and > .switchdev_port_obj_dump > must pass the generic switchdev_obj structure instead of a specific one (e.g. > switchdev_obj_fdb) to the

Re: [patch net] switchdev: fix return value of switchdev_port_fdb_dump in case of error

dd support for fdb add/del/dump via > switchdev_port_obj ops.") > Signed-off-by: Jiri Pirko <j...@mellanox.com> Acked-by: Scott Feldman<sfel...@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger

Re: [PATCH v2 net-next 0/3] ipv4: Hash-based multipath routing

On Sat, Aug 29, 2015 at 1:46 PM, David Miller da...@davemloft.net wrote: From: Peter Nørlund p...@ordbogen.com Date: Sat, 29 Aug 2015 22:31:15 +0200 On Sat, 29 Aug 2015 13:14:29 -0700 (PDT) David Miller da...@davemloft.net wrote: From: p...@ordbogen.com Date: Fri, 28 Aug 2015 22:00:47

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

On Thu, Aug 27, 2015 at 2:06 AM, Andrew Lunn and...@lunn.ch wrote: On Thu, Aug 27, 2015 at 01:42:24AM -0700, Scott Feldman wrote: On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn and...@lunn.ch wrote: I don't know about how this overlaps with DSA platform_class. Florian? There is some

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

On Wed, Aug 26, 2015 at 10:43 PM, Jiri Pirko j...@resnulli.us wrote: Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko j...@resnulli.us wrote: From: Jiri Pirko j...@mellanox.com Add this helper so code can easily figure out if netdev is

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

On Thu, Aug 27, 2015 at 12:27 AM, Jiri Pirko j...@resnulli.us wrote: Thu, Aug 27, 2015 at 09:16:44AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com In the switchdev model, we use netdevs to represent switchdev ports, but we have no representation for the switch itself. So

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

On Thu, Aug 27, 2015 at 12:36 AM, John Fastabend john.fastab...@gmail.com wrote: On 15-08-27 12:16 AM, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com In the switchdev model, we use netdevs to represent switchdev ports, but we have no representation for the switch itself. So

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

On Wed, Aug 26, 2015 at 11:30 PM, Jiri Pirko j...@resnulli.us wrote: Thu, Aug 27, 2015 at 08:23:13AM CEST, sfel...@gmail.com wrote: On Wed, Aug 26, 2015 at 10:43 PM, Jiri Pirko j...@resnulli.us wrote: Wed, Aug 26, 2015 at 07:43:18PM CEST, sfel...@gmail.com wrote: On Wed, Aug 26, 2015 at 9:36 AM,

Re: [RFC PATCH net-next 0/2] Add new switchdev device class

On Thu, Aug 27, 2015 at 12:45 AM, Andrew Lunn and...@lunn.ch wrote: I don't know about how this overlaps with DSA platform_class. Florian? There is some overlap with DSA, but the current DSA model, with respect to probing, is broken. So this might be interesting as a way towards fix that.

Re: [patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

On Wed, Aug 26, 2015 at 10:49 AM, David Miller da...@davemloft.net wrote: From: Jiri Pirko j...@resnulli.us Date: Wed, 26 Aug 2015 09:37:57 +0200 I don't think that are much more cases like this. Therefore I think that for this cases, debugfs might be a good way to expose debugging stats.

Re: [patch net-next 0/6] rocker: make master change handling nicer

On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko j...@resnulli.us wrote: From: Jiri Pirko j...@mellanox.com Jiri Pirko (6): net: introduce change upper device notifier change info net: add netif_is_bridge_master helper net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

Re: [patch net-next 6/6] rocker: use change upper info

(current code does not distinguish between master and non-master upper device). Signed-off-by: Jiri Pirko j...@mellanox.com Acked-by: Scott Feldman sfel...@gmail.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: [patch net-next 5/6] rocker: use new helper to figure out master kind

On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko j...@resnulli.us wrote: From: Jiri Pirko j...@mellanox.com Looking at rtnl kind string is kind of ugly. So use new helpers to do this in nicer way. Signed-off-by: Jiri Pirko j...@mellanox.com Acked-by: Scott Feldman sfel...@gmail.com

Re: [patch net-next 3/6] net: add netif_is_ovs_master helper with IFF_OPENVSWITCH private flag

On Wed, Aug 26, 2015 at 9:36 AM, Jiri Pirko j...@resnulli.us wrote: From: Jiri Pirko j...@mellanox.com Add this helper so code can easily figure out if netdev is openswitch. Signed-off-by: Jiri Pirko j...@mellanox.com --- include/linux/netdevice.h| 8

  1   2   3   >