On Wed, 6 Feb 2019 16:09:13 -0200
Marcos Antonio Moraes wrote:
> As /sys/class/net//speed indicates a value in Mbits/sec, the
> transformation is necessary to create the correct limitations.
Not sure, if this is correct or not could you give an example?
This patch needs a signed-off-by and a a
If value passed to parse_percent was not valid, it would
leak the dynamic allocation from sscanf.
Fixes: 927e3cfb52b5 ("tc: B.W limits can now be specified in %.")
Signed-off-by: Stephen Hemminger
---
tc/tc_util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
On Thu, 24 Jan 2019 16:41:07 -0800
Yonghong Song wrote:
> The issue is discovered for bpf selftest test_skb_cgroup.sh.
> Currently we have,
> $ ./test_skb_cgroup_id.sh
> Wait for testing link-local IP to become available ... OK
> Object has unknown BTF type: 13!
> [PASS]
>
> In the above
On Fri, 25 Jan 2019 17:09:17 +
Ido Schimmel wrote:
> While iproute2 correctly uses ifinfomsg struct as the ancillary header
> when requesting an FDB dump on old kernels, it sets the message type to
> RTM_GETLINK. This results in wrong reply being returned.
>
> Fix this by using RTM_GETNEIGH
On Fri, 25 Jan 2019 10:37:07 +
Chris Mi wrote:
> Without this fix, the VF info can't be showed using command
> "ip link".
>
> 146: ens1f0: mtu 1500 qdisc mq state UP
> mode DEFAULT group default qlen 1000
> link/ether 24:8a:07:ad:78:52 brd ff:ff:ff:ff:ff:ff
> vf 0 MAC 02:25:d0:12:0
On Fri, 25 Jan 2019 00:33:30 -0200
Marcelo Ricardo Leitner wrote:
> +/*
> + * m_ct.cConnection Tracking target module
> + *
> + * This program is free software; you can distribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * a
On Thu, 31 Jan 2019 18:58:09 +0100
Davide Caratti wrote:
> + print_uint(PRINT_ANY, "code", "%hu ", ops[i].code);
> + print_uint(PRINT_ANY, "jt", "%hhu ", ops[i].jt);
> + print_uint(PRINT_ANY, "jf", "%hhu ", ops[i].jf);
Did you know that print_uint promotes the
On Thu, 31 Jan 2019 08:28:29 -0800
Roopa Prabhu wrote:
> On Thu, Jan 31, 2019 at 4:46 AM Stefano Brivio wrote:
> >
> > On Wed, 30 Jan 2019 14:30:59 -0800
> > Roopa Prabhu wrote:
> >
> > > On Sun, Jan 27, 2019 at 11:57 PM Stefano Brivio
> > > wrote:
> > > >
> > > > They can't replace brctl
On Thu, 24 Jan 2019 22:03:47 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip l add dev tun type gretap external
> ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
>
> For gretap example when the command set the id but don't set the
> TUNNEL_KEY flags. There is no key field in t
Any error output should go to standard error.
Signed-off-by: Stephen Hemminger
---
tc/f_matchall.c | 2 +-
tc/m_connmark.c | 2 +-
tc/m_csum.c | 2 +-
tc/m_gact.c | 2 +-
tc/m_ife.c | 2 +-
tc/m_mirred.c | 2 +-
tc/m_nat.c | 2 +-
tc/m_sample.c | 2 +-
tc/m_skbedit.c | 2
The kernel (and iproute2) don't use the if (NULL == x) style
and instead prefer if (!x)
Signed-off-by: Stephen Hemminger
---
tc/m_action.c | 2 +-
tc/m_ipt.c| 3 +--
tc/m_xt_old.c | 3 +--
tc/tc_util.c | 2 +-
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/tc/m_actio
On Wed, 23 Jan 2019 22:02:31 +0100
Hans Dedecker wrote:
> XATTR_SIZE_MAX requires the usage of linux/limits.h; let's include it
>
> Signed-off-by: Hans Dedecker
Applied
On Thu, 24 Jan 2019 22:03:47 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip l add dev tun type gretap external
> ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
>
> For gretap example when the command set the id but don't set the
> TUNNEL_KEY flags. There is no key field in t
On Thu, 17 Jan 2019 13:18:55 -0800
Cong Wang wrote:
>
> + if (tb[TCA_MATCHALL_PCNT]) {
> + if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) {
> + print_string(PRINT_FP, NULL, "Broken perf counters\n",
> NULL);
This the wrong way to print an error mess
On Tue, 22 Jan 2019 22:41:45 -0800
Cong Wang wrote:
> + if (tb[TCA_BASIC_PCNT]) {
> + if (RTA_PAYLOAD(tb[TCA_BASIC_PCNT]) < sizeof(*pf)) {
> + fprintf(f, "Broken perf counters\n");
> + return -1;
Errors should go to stderr not f (which is
Unless there is any objection, I intend to close this bug
as "that is the way Linux works, we can't break userspace"
Begin forwarded message:
Date: Mon, 21 Jan 2019 04:11:06 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202355] New: UDP does not re
Begin forwarded message:
Date: Thu, 17 Jan 2019 00:43:53 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202309] New: Possible regression kernel null ptr deref in receive
path
https://bugzilla.kernel.org/show_bug.cgi?id=202309
Bug ID:
Is this still present in net-next?
Begin forwarded message:
Date: Tue, 15 Jan 2019 19:20:22 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202297] New: No longer able to add multiple tc filters. RTNETLINK
answers: No space left on device
https://bu
On Wed, 16 Jan 2019 21:04:21 +0800
wangyunjian wrote:
> if (unlikely(netpoll_tx_running(to->br->dev))) {
> + skb_push(skb, ETH_HLEN);
> if (!is_skb_forwardable(skb->dev, skb)) {
> kfree_skb(skb);
>
Begin forwarded message:
Date: Tue, 15 Jan 2019 16:18:13 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202287] New: netfilter/iptales prevents Tor Browser from closing
cleanly
https://bugzilla.kernel.org/show_bug.cgi?id=202287
Bug I
uld be if the tests looked at the JSON output of the tc
command which is less likely to change?
Acked-by: Stephen Hemminger
On Sat, 12 Jan 2019 12:54:06 -0800
Jakub Kicinski wrote:
> Kernel ignores the RTM_F_LOOKUP_TABLE flag for all families
> but IPv4. Don't set it, otherwise it may fall foul of
> strict checking policies.
>
> Signed-off-by: Jakub Kicinski
Doing the right thing is a good idea, but really I can't
This problem was not reported previously. Looks like ss hitting bug in
raw_diag.c
Begin forwarded message:
Date: Sun, 13 Jan 2019 09:52:12 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202249] New: WARNING: CPU: 1 PID: 3904 at net/ipv4/raw_diag.c:2
This looks like it is related to some of the recent discussion in netdev
around skb->tstamp (fq) or neighbor cache
Begin forwarded message:
Date: Fri, 11 Jan 2019 22:58:45 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 202235] New: regression: physica
On Tue, 8 Jan 2019 23:10:04 +0100
Ian Kumlien wrote:
> On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote:
> >
> > [Sorry for the repost, screwed up the netdev address...]
> >
> > Hi,
> >
> > Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s.
> >
> > My firewall (which also r
On Mon, 7 Jan 2019 14:55:51 -0800
David Ahern wrote:
> +int iplink_parse(int argc, char **argv, struct iplink_req *req, char **type,
> + bool *name_change);
Not a real fan of adding another by reference return value flag.
It makes the logic flow more complex.
Is there another way?
On Mon, 7 Jan 2019 14:55:52 -0800
David Ahern wrote:
> + idx = ll_link_get(name);
> + if (idx == 0)
> + idx = if_nametoindex(name);
What is advantage of using netlink, other than not having to open
a socket.
On Tue, 8 Jan 2019 01:37:15 +0300
"Dmitry V. Levin" wrote:
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
> Signed-off-by: Dmitry V. Levin
> ---
Applied
On Mon, 7 Jan 2019 12:41:30 -0800
David Ahern wrote:
> From: David Ahern
>
> ip route uses ll_name_to_index to convert the user given device name to an
> index. At the moment ll_name_to_index uses if_nametoindex which is ioctl
> based and does not cache the result. When using a batch file this
On Mon, 7 Jan 2019 12:37:41 -0800
Benedict Wong wrote:
> Noted. Should I wait until xfrm is converted to JSON output formatting?
>
> Or if there are no structural and stylistic issues, should I re-send
> this as a patch?
>
No the patch should go in now.
int left delimiter for columns
testsuite: ss: Fix spacing in expected output for ssfilter.t
Stephen Hemminger (37):
uapi: update headers to 4.20-rc1
uapi: sctp header change
testsuite: colorize test result output
testsuite: drop old kernel configs
lib/ll_addr: whitespac
On Fri, 4 Jan 2019 15:19:10 -0800
Benedict Wong wrote:
> ip xfrm state show currently dumps keys unconditionally. This limits its
> use in logging, as security information can be leaked.
>
> This patch adds a nokeys option to ip xfrm ( state show | monitor ), which
> prevents the printing of ke
Signed-off-by: Stephen Hemminger
---
testsuite/lib/generic.sh | 1 +
testsuite/tests/ip/link/add_type_xfrm.t | 1 +
testsuite/tests/ip/link/new_link.t| 1 +
testsuite/tests/ip/link/show_dev_wo_vf_rate.t | 1 +
testsuite/tests/ip/netns/set_nsid.t
On Tue, 1 Jan 2019 21:27:15 +0800
we...@ucloud.cn wrote:
> + if (flags & TUNNEL_KEY)
> + print_string(PRINT_ANY, "key", "%s ", "key");
> + if (flags & TUNNEL_CSUM)
> + print_string(PRINT_ANY, "csum", "%s ", "csum");
> + i
On Mon, 24 Dec 2018 16:49:44 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip rule add from all iif gretap tun_id 2000 lookup 200
>
> Signed-off-by: wenxu
Applied, thanks for fixing man page as well.
On Fri, 28 Dec 2018 10:32:11 -0500
Matt Ellison wrote:
> Support for new (4.19+) xfrm virtual interfaces.
>
> Interfaces take a 'if_id' which is an interface id which can be set on
> an xfrm policy as its interface lookup key (XFRMA_IF_ID).
>
> Signed-off-by: Matt Ellison
Wanted to apply this
On Thu, 27 Dec 2018 15:18:51 +0200
Firas Khalil Khana wrote:
I want to take this patch, but it is missing the Signed-Off-by: required
for this project.
Also please add:
Fixes: 377a09902a57 ("configure: Minor code cleanup")
On Fri, 21 Dec 2018 22:53:35 -0800
Eric Dumazet wrote:
> A recent change reduced max line length from 4096 to 2048 bytes,
> but we already have lines above the 2048 threshold, and we keep
> adding more SNMP counters in linux.
>
> Switch to getline() and do not worry about future kernel changes.
On Fri, 21 Dec 2018 16:18:54 +0800
we...@ucloud.cn wrote:
> +
> + if (tb[LWTUNNEL_IP_FLAGS]) {
> + flags = rta_getattr_u16(tb[LWTUNNEL_IP_FLAGS]);
> + if (flags & TUNNEL_KEY)
> + print_string(PRINT_ANY, NULL, "%s ", "key");
> + if (flags
On Sun, 30 Dec 2018 18:03:47 -0700
David Ahern wrote:
> On 12/30/18 10:14 AM, Ido Schimmel wrote:
> > Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
> > socket") iproute2 uses strict checking on kernels that support it. This
> > causes FDB dumping to fail [1], as iproute2 us
On Thu, 27 Dec 2018 16:13:29 -0500
charles cross wrote:
> The kernel is v3.10.0 from upstream RHEL 7.5. Can anyone offer advice before
> I proceed down the stack to look for the root cause? The behavior (failure
> under load but recovery after the load is removed) suggests contention for
> res
On Tue, 18 Dec 2018 20:29:04 +0100
Petr Vorel wrote:
> bash and dash require for escape sequence to use 'echo -e' or printf
> (but working on zsh). Choosing printf as it's implementation is IMHO
> more portable than echo implementations.
> dash also require to use \033[0; as escape sequence inste
On Thu, 20 Dec 2018 08:17:27 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip l add dev tun type gretap external
> ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
>
> For gretap example when the command set the id but don't set the
> TUNNEL_KEY flags. There is no key field in t
On Wed, 5 Dec 2018 19:13:41 +0100
Paolo Abeni wrote:
> This avoids an indirect call in the receive path for TCP and UDP
> packets. TCP takes precedence on UDP, so that we have a single
> additional conditional in the common case.
>
> v1 -> v2:
> - adapted to INDIRECT_CALL_ changes
>
> Signed-
On Thu, 20 Dec 2018 15:39:39 -0800
Stephen Hemminger wrote:
> From: Stephen Hemminger
>
> This mapping table is not used anywhere in current code and
> causes warning if kernel is built with W=1
>
> Signed-off-by: Stephen Hemminger
> ---
> fs/cifs/netmisc.c | 4 -
From: Stephen Hemminger
This mapping table is not used anywhere in current code and
causes warning if kernel is built with W=1
Signed-off-by: Stephen Hemminger
---
fs/cifs/netmisc.c | 4
1 file changed, 4 deletions(-)
diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index fdd908e4a26b
Don't need extern prefix before function prototypes.
Checkpatch has complained about this for a couple of years.
Signed-off-by: Stephen Hemminger
---
include/linux/netlink.h | 48 -
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/in
On Wed, 19 Dec 2018 22:00:38 +0200
Serhey Popovych wrote:
> Stephen Hemminger wrote:
>
> > The argument to print_0xhex is converted to unsigned long long
> > so the format string give for normal printout has to be some
> > variant of %llx. Otherwise, bogus values will
On Wed, 19 Dec 2018 08:36:43 +0100
Jesper Dangaard Brouer wrote:
> On Tue, 18 Dec 2018 18:27:06 -0800
> Stephen Hemminger wrote:
>
> > This is the result of a conversation about monitoring of link
> > state changes with BPF.
>
> If you want to use this fro
=eno1 event=PRE_UP ret=1
ip-3195 [011] 78.279038: net_dev_notifier_entry:
dev=eno1 event=UP
ip-3195 [011] 78.279065: net_dev_notifier:
dev=eno1 event=UP ret=1
Signed-off-by: Stephen Hemminger
---
include/trace/
On Sat, 15 Dec 2018 19:00:38 +0100
Petr Vorel wrote:
> ip/rtpr mentioned in man as bash script is actually posix shell script
> (doesn't require to use bash).
>
> Signed-off-by: Petr Vorel
Applied whole series (with removal of cls-testbed.t change).
On Sat, 15 Dec 2018 19:00:39 +0100
Petr Vorel wrote:
> diff --git a/testsuite/tests/tc/cls-testbed.t
> b/testsuite/tests/tc/cls-testbed.t
> index d5c21e5c..cf34dd63 100755
> --- a/testsuite/tests/tc/cls-testbed.t
> +++ b/testsuite/tests/tc/cls-testbed.t
This script is unrunnable dead code, and
The classifier testbed test never worked and was always being
skipped. It depended on some files it tests/cls which never made
it into the iproute2 git repository.
Signed-off-by: Stephen Hemminger
---
testsuite/tests/tc/cls-testbed.t | 73
1 file changed, 73
On Tue, 18 Dec 2018 17:53:33 +0800
we...@ucloud.cn wrote:
> From: wenxu
>
> ip l add dev tun type gretap external
> ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
>
> For gretap example when the command set the id but don't set the
> TUNNEL_KEY flags. There is no key field in t
Cleanup from scrub script.
Signed-off-by: Stephen Hemminger
---
testsuite/tests/ip/tunnel/add_tunnel.t | 1 -
testsuite/tests/tc/cls-testbed.t | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/testsuite/tests/ip/tunnel/add_tunnel.t
b/testsuite/tests/ip/tunnel
Run whitespace scrubbing script to remove unnecessary trailing
blanks at end of line and end of file.
Signed-off-by: Stephen Hemminger
---
README.iproute2+tc | 2 +-
README.lnstat | 15 +++---
doc/actions/actions-general | 99 ++---
doc
On Sat, 15 Dec 2018 12:14:41 +0800 (CST)
tenys <15667082...@163.com> wrote:
> it looks like a pointer stored without holding a reference
> for the source code in kernel version v4.14.88, and the fuction is :
> ipxitf_insert_socket
>
> static void ipxitf_insert_socket(struct ipx_interface *intrf
On Wed, 12 Dec 2018 20:04:07 +0800
Syrone Wong wrote:
> > So iiuc there's some other LDFLAG coming after -lxtables on some
> > platform? sorry about that..
>
> Issue found when compiling iproute2 4.17 for OpenWrt
>
> https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg42783.html
>
On Tue, 11 Dec 2018 17:33:19 +
Leon Romanovsky wrote:
> On Mon, Dec 10, 2018 at 02:10:20PM -0800, Stephen Hemminger wrote:
> > It appears that RDMA is broken on 32 bit platforms.
> > Sure you don't run on 32bit, but iproute2 needs to build everywhere.
> >
>
On Thu, 13 Dec 2018 13:30:50 +
Jan Petrous wrote:
> Hi,
>
> am I understand it right that I can not use NAPI-powered design in case
> when there is only one rx queue and one tx queue (only two
> dma channels) usable for data transfer with the ethernet controller for
> all interfaces (2 ports
On Thu, 13 Dec 2018 01:20:48 +0200
Risto Pajula wrote:
> Hello.
>
> I'm not able reproduce the actual problem anymore which was the high
> ping latency from the internal network.
>
> This starts to sound like some sort of voodoo, but...
>
> I tested replacing the switch to another brand where
just keep to the old version of iproute2.
Signed-off-by: Stephen Hemminger
---
Makefile | 3 --
README.decnet | 33 --
README.lnstat | 2 +-
include/utils.h| 3 --
ip/ip.c| 2 +-
ip/iproute.c | 2 +-
lib
The argument to print_0xhex is converted to unsigned long long
so the format string give for normal printout has to be some
variant of %llx. Otherwise, bogus values will be printed on
32 bit platforms.
Reported-by: Hans Dedecker
Signed-off-by: Stephen Hemminger
---
bridge/link.c| 2
It appears that RDMA is broken on 32 bit platforms.
Sure you don't run on 32bit, but iproute2 needs to build everywhere.
The issue is that you are assuming a C enum can hold 64 bits.
The standard says enum only has to hold "int" values.
So it breaks on 32bit.
The issue is deeper than just a triv
Function was not used unlesss HAVE_ELF causing:
bpf.c:105:13: warning: ‘bpf_map_offload_neutral’ defined but not used
[-Wunused-function]
Signed-off-by: Stephen Hemminger
---
lib/bpf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/bpf.c b/lib/bpf.c
index
,
Resolve by computing length as size_t first.
Signed-off-by: Stephen Hemminger
---
ip/ipmacsec.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c
index 9b991065e483..54cd2b8c97e4 100644
--- a/ip/ipmacsec.c
+++ b/ip/ipmacsec.c
@@ -640
Using unsigned long is sufficient no need to be more
verbose and use unsigned long int.
Signed-off-by: Stephen Hemminger
---
include/json_print.h | 6 +++---
include/json_writer.h | 8
lib/json_print.c | 4 ++--
lib/json_writer.c | 8
lib/utils.c | 2 +-
5
Begin forwarded message:
Date: Sat, 08 Dec 2018 18:20:01 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201933] New: r8169 hangs with Oops/null pointer deref on shutdown
https://bugzilla.kernel.org/show_bug.cgi?id=201933
Bug ID: 20193
On Thu, 6 Dec 2018 11:36:05 +0100
Andrew Lunn wrote:
> +void dsa_master_set_mtu(struct net_device *dev, struct dsa_port *cpu_dp)
> +{
> + unsigned int mtu = ETH_DATA_LEN + cpu_dp->tag_ops->overhead;
> + int err;
> +
> + rtnl_lock();
> + if (mtu <= dev->max_mtu) {
> +
On Mon, 3 Dec 2018 12:13:06 +0100
Emeric Dupont wrote:
> When performing make install in iproute2 (current git master),
> if $(HAVE_MNL) is not selected, some Makefiles try to call
> install with an empty target, which causes a non-critical make error.
>
> Signed-off-by: Emeric Dupont
On Tue, 4 Dec 2018 16:07:41 +
Petr Machata wrote:
> When no error is reported in the first iov, do not prematurely return,
> but process further iovs. This fixes batch processing.
>
> Fixes: c60389e4f9ea ("libnetlink: fix leak and using unused memory on error")
> Signed-off-by: Petr Machata
ad) {
> + q->t_head = skb->next;
> + if (!q->t_head)
> + q->t_tail = NULL;
> + } else
> + rb_erase(&skb->rbnode, &q->t_root);
Checkpatch wants both sides of if/else to have brackets.
Personally, don't care.
Reviewed-by: Stephen Hemminger
On Thu, 29 Nov 2018 13:20:37 +0100
Phil Sutter wrote:
> When fixing for shift/reduce conflicts, possibility to invert the last
> expression by prefixing with '!' or 'not' was accidentally removed.
>
> Fix this by allowing for expr to be an inverted expr so that any
> reference to it in exprlist
On Fri, 30 Nov 2018 05:57:02 -0800
Eric Dumazet wrote:
> When a rate estimator is active, "tc -s qd" displays
> something like :
>
> rate 12616bit 11ppsbacklog 0b 0p requeues 2
>
> instead of :
>
> rate 12616bit 11pps backlog 0b 0p requeues 2
>
> Fixes: 4fcec7f3665b ("tc: jsonify stats2")
> S
On Sat, 01 Dec 2018 16:55:40 -0800 (PST)
David Miller wrote:
> Stephen please actually read the reports your forward here.
>
> This is a report about arch/x86/lib/inat.c which is a set of CPU
> instruction attributes and has nothing to do with networkig.
Yes, bug moved to x86 platform.
On Mon, 03 Dec 2018 13:19:20 -0800
Jeff Kirsher wrote:
> On Fri, 2018-11-30 at 15:26 -0800, Stephen Hemminger wrote:
> > On my box with Debian testing, I see a new problem with
> > suspend/resume of wired network device.
> > Using stock Debian kernel 4.18.0-2-amd64
> >
More checksum changes fallout?
Begin forwarded message:
Date: Mon, 03 Dec 2018 04:23:36 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201849] New: hw csum failure - reproducible error
https://bugzilla.kernel.org/show_bug.cgi?id=201849
Begin forwarded message:
Date: Sat, 01 Dec 2018 17:20:33 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201829] New: Failed build kernel with nat
https://bugzilla.kernel.org/show_bug.cgi?id=201829
Bug ID: 201829
Summary: Fa
On Fri, 30 Nov 2018 23:51:53 -0500
Qian Cai wrote:
> + weight,
> + !strchr(dev->name, '%') ? dev->name : "unknown"
Agree with Joe, use netdev_err_once or use netdev_name().
d-off-by: Jouke Witteveen
Makes sense. I am also working on tracepoints for netdev changes.
Reviewed-by: Stephen Hemminger
On my box with Debian testing, I see a new problem with suspend/resume of wired
network device.
Using stock Debian kernel 4.18.0-2-amd64
After suspend/resume cycle, IP address is lost.
Device Info:
$ /sbin/ethtool -i enp12s0
driver: igb
version: 5.4.0-k
firmware-version: 0. 6-1
expansion-rom-ve
On Fri, 30 Nov 2018 20:22:35 +0100
Alexis Vachette wrote:
> Hi Stephen,
>
> Thanks for your kind reply.
>
> It's sad to hear that, I am aware of your concern too.
>
> But it's not the best behavior for a network engineer.
>
> Is it possible to add a new option or everything is stone graved ?
On Fri, 30 Nov 2018 14:33:49 +0100
Alexis Vachette wrote:
> When using:
>
> - ip -s link
>
> I think it should be better to print errors stats without adding -s
> option twice.
>
> This option print stats for each network interfaces and we want to see
> if something is off and especially timer
On Thu, 29 Nov 2018 02:27:54 -0800
Eric Dumazet wrote:
> Wei Wang added these fields in linux-4.19
>
> Tested:
>
> ss -ti ...
>
> ts sack cubic wscale:8,8 rto:7 rtt:2.678/0.267 mss:1428 pmtu:1500
> rcvmss:536 advmss:1428 cwnd:91 ssthresh:65
> (*) bytes_sent:17470606104 bytes_retrans:
On Mon, 26 Nov 2018 14:29:53 -0800
Eric Dumazet wrote:
> Kernel support was added in linux-4.18 in commit feb5f2ec6464
> ("tcp: export packets delivery info")
>
> Tested:
>
> ss -ti
> ...
> ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646
> [2607:f8b0:8099:e18::]:38953
>ts sack cu
On Tue, 27 Nov 2018 18:02:52 -0800
Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> broke previous use of -c to represent compressvlans. This restores
> previous use of -c to represent compressvlans. Understand the origina
On Mon, 26 Nov 2018 18:58:31 +0100
Phil Sutter wrote:
> All rdma-related man pages list each other in SEE ALSO section, only
> rdma-resource.8 is missing. Add it for the sake of consistency.
>
> Signed-off-by: Phil Sutter
Applied
On Mon, 26 Nov 2018 17:56:10 -0800
"Nambiar, Amritha" wrote:
> On 11/26/2018 4:43 PM, David Ahern wrote:
> > On 11/26/18 5:23 PM, Nambiar, Amritha wrote:
> >>> Can tc flower use something similar to ip ru with single port or port
> >>> range handled like this?
> >>>
> >>> },{
> >>>
On Sat, 24 Nov 2018 17:12:48 -0700
David Ahern wrote:
> IPX was moved to staging at the end of last year. Can decnet follow
> suit? git log seems to indicate no active development in a very long time.
>
> David
I have no problem with dropping decnet support from iproute first.
Presumably anyone
On Tue, 31 Oct 2017 16:28:20 -0700
Cong Wang wrote:
> On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger
> wrote:
> >
> > IPPROTO_MH comes from include/uapi/linux/in6.h
> > Maybe it is trying to use old kernel headers from libc.
>
> So newer iproute2 is n
On Sun, 25 Nov 2018 10:12:45 +0200
Nikolay Aleksandrov wrote:
> On 24/11/2018 18:46, niko...@cumulusnetworks.com wrote:
> > On 24 November 2018 18:25:41 EET, Andrew Lunn wrote:
> >> On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com
> >> wrote:
> >>> On 24 November 2018 18
Could be a bug, or just how it works?
Begin forwarded message:
Date: Thu, 22 Nov 2018 22:51:12 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201773] New: IP_FREEBIND doesn’t counteract global
https://bugzilla.kernel.org/show_bug.cgi?id=201773
On Wed, 21 Nov 2018 10:44:27 +0100
Nicolas Dichtel wrote:
> Don't confuse the user, nsid is a signed integer, this kind of command
> should return an error: 'ip netns set foo 0x'.
>
> Also, a valid value is a positive value. To let the kernel chooses a value,
> the keyword 'auto' must be
On Tue, 20 Nov 2018 01:26:27 +
Quentin Monnet wrote:
> In order to compare BPF map symbol type correctly in regard to the
> latest LLVM, commit 7a04dd84a7f9 ("bpf: check map symbol type properly
> with newer llvm compiler") compares map symbol type to both NOTYPE and
> OBJECT. To do so, it fi
Begin forwarded message:
Date: Tue, 20 Nov 2018 07:09:26 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201735] New: serial8250: too much work for irq4
https://bugzilla.kernel.org/show_bug.cgi?id=201735
Bug ID: 201735
Summa
On Mon, 19 Nov 2018 15:03:29 -0800
Jakub Kicinski wrote:
> Add helpers for printing char-size values.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Quentin Monnet
> ---
> include/json_print.h | 1 +
> include/json_writer.h | 2 ++
> lib/json_print.c | 1 +
> lib/json_writer.c
On Fri, 16 Nov 2018 11:17:40 -0800
yupeng wrote:
> +* TcpInSegs
> +Defined in `RFC1213 tcpInSegs`_
> +
> +.. _RFC1213 tcpInSegs: https://tools.ietf.org/html/rfc1213#page-48
> +
> +The number of packets received by the TCP layer. As mentioned in
> +RFC1213, it includes the packets received in erro
Trivial spelling errors found by codespell.
Signed-off-by: Stephen Hemminger
---
include/uapi/linux/ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index c8f8e2455bf3..17be76aeb468 100644
--- a/include
Make functions only used in ipxfrm.c static.
Signed-off-by: Stephen Hemminger
---
ip/ipxfrm.c | 11 ++-
ip/xfrm.h | 9 -
ip/xfrm_monitor.c | 2 +-
3 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c
index 17ab4abef4be
Several functions only used inside utils.c
Signed-off-by: Stephen Hemminger
---
rdma/rdma.h | 11 ---
rdma/utils.c | 12 ++--
2 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/rdma/rdma.h b/rdma/rdma.h
index c3b7530b6cc7..05c3c69b07fd 100644
--- a/rdma/rdma.h
601 - 700 of 6298 matches
Mail list logo
