RE: [PATCH net] qed: off by one in qed_parse_mcp_trace_buf()

2018-07-04 Thread Tayar, Tomer
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, July 04, 2018 12:53 PM > If format_idx == s_mcp_trace_meta.formats_num then we read one element > beyond the end of the s_mcp_trace_meta.formats[] array. > > Fixes: 50bc60cb155c ("qed*: Utilize FW 8.33.11.0") > Signed-off-by:

RE: [PATCH] qed: Use zeroing memory allocator than allocator/memset

2018-01-01 Thread Tayar, Tomer
From: Himanshu Jha [mailto:himanshujha199...@gmail.com] Sent: Saturday, December 30, 2017 5:37 PM > Use dma_zalloc_coherent and vzalloc for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by:

RE: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tayar, Tomer
From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, December 26, 2017 8:08 PM > Subject: Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0 > > > This says "0/3" and then a 4 patch series shows up... Sorry, my bad. Will send a fixed series.

RE: [PATCH] qed: Delete redundant check on dcb_app priority

2017-10-08 Thread Tayar, Tomer
> dcb_app priority is unsigned thus checking whether it is less than zero > is redundant. > > Signed-off-by: Christos Gkekas Thanks Acked-By: Tomer Tayar

RE: [RFC] endianness issues in drivers/net/ethernet/qlogic/qed

2017-09-24 Thread Tayar, Tomer
> "qed: Utilize FW 8.10.3.0" has attempted some endianness annotations > in that driver; unfortunately, either annotations are BS or the driver is > genuinely > broken on big-endian hosts. [...] > Is that driver intended to be used on big-endian hosts at all? Thanks for taking the time to

RE: [PATCH] qed: Fix a memory allocation failure test in 'qed_mcp_cmd_init()'

2017-08-07 Thread Tayar, Tomer
> We allocate 'p_info->mfw_mb_cur' and 'p_info->mfw_mb_shadow' but we > check > 'p_info->mfw_mb_addr' instead of 'p_info->mfw_mb_cur'. > > 'p_info->mfw_mb_addr' is never 0, because it is initiliazed a few lines > above in 'qed_load_mcp_offsets()'. > > Update the test and check the result of the

RE: [PATCH -next] qed: Add a missing error code

2017-04-04 Thread Tayar, Tomer
> We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The > current code returns success. > > Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") > Signed-off-by: Dan Carpenter Thanks Acked-by: Tomer Tayar