Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Russell King - ARM Linux [181207 19:27]: > You mentioned that edge mode didn't work as well as level mode on > duovero smsc controller, I think this may help to solve the same > issue but for edge IRQs - we need a mask_ack_irq function to avoid > acking while the edge interrupt is masked. Let

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
* Tony Lindgren [181207 18:14]: > Hi, > > * Russell King - ARM Linux [181207 18:01]: > > Hi Tony, > > > > You know most of what's been going on from IRC, but here's the patch > > which gets me: > > > > 1) working interrupts for netw

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-07 Thread Tony Lindgren
Hi, * Russell King - ARM Linux [181207 18:01]: > Hi Tony, > > You know most of what's been going on from IRC, but here's the patch > which gets me: > > 1) working interrupts for networking > 2) solves the stuck-wakeup problem > > It also contains some of the debug bits I added. This is

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-06 Thread Tony Lindgren
* Russell King - ARM Linux [181206 18:08]: > reverted, the problem is still there. Revert: > > ec0daae685b2 ("gpio: omap: Add level wakeup handling for omap4 based SoCs") > > on top, and networking returns to normal. So it appears to be this > last commit causing the issue. > > With that and

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-06 Thread Tony Lindgren
Hi, * Russell King - ARM Linux [181206 13:23]: > It looks very much like a receive problem - in that the board is not > always aware of a packet having been received until it attempts to > transmit (eg, in the case of TFTP, when it re-sends the ACK after a > receive timeout, it _then_ notices

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-30 Thread Tony Lindgren
* Grygorii Strashko [180830 17:08]: > On 08/29/2018 07:47 PM, Tony Lindgren wrote: > > In general, it seems cpsw is just an interconnect instance > > (L4_FAST) with a control module (CPSW_WR) and a pile of > > independent other modules. That's described nicely in > > a

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-29 Thread Tony Lindgren
* Grygorii Strashko [180830 00:12]: > Hi Tony, > > On 08/29/2018 10:00 AM, Tony Lindgren wrote: > > The current cpsw usage for cpsw-phy-sel is undocumented but is used for > > all the boards using cpsw. And cpsw-phy-sel is not really a child of > > the cpsw device, it

[PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel

2018-08-29 Thread Tony Lindgren
also update the binding documentation accordingly. Cc: devicet...@vger.kernel.org Cc: Andrew Lunn Cc: Grygorii Strashko Cc: Ivan Khoronzhuk Cc: Mark Rutland Cc: Murali Karicheri Cc: Rob Herring Signed-off-by: Tony Lindgren --- drivers/net/ethernet/ti/cpsw-phy-sel.c | 9 ++--- 1 file

[PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-08-29 Thread Tony Lindgren
instead of a child device for it. That way we can properly describe the hardware in dts files for things like genpd. Cc: devicet...@vger.kernel.org Cc: Andrew Lunn Cc: Grygorii Strashko Cc: Ivan Khoronzhuk Cc: Mark Rutland Cc: Murali Karicheri Cc: Rob Herring Signed-off-by: Tony Lindgren

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-09 Thread Tony Lindgren
* Tony Lindgren [180808 13:52]: > * Andrew Lunn [180808 12:02]: > > > > Do you need to handle EPROBE_DEFER here? The phandle points to a > > device which has not yet been loaded? I'm not sure exactly where it > > will be returned, maybe it is bus_find_device(), b

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-08 Thread Tony Lindgren
* Andrew Lunn [180808 12:02]: > > +++ b/Documentation/devicetree/bindings/net/cpsw.txt > > @@ -19,6 +19,9 @@ Required properties: > > - slaves : Specifies number for slaves > > - active_slave : Specifies the slave to use for time stamping, > > ethtool

[PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-08 Thread Tony Lindgren
missing the related binding documentation, so let's also update the binding documentation accordingly. Cc: devicet...@vger.kernel.org Cc: Grygorii Strashko Cc: Ivan Khoronzhuk Cc: Mark Rutland Cc: Murali Karicheri Cc: Rob Herring Signed-off-by: Tony Lindgren --- Documentation/devicetree

Re: Fwd: DA850-evm MAC Address is random

2017-08-28 Thread Tony Lindgren
* Adam Ford [170828 13:33]: > On Mon, Aug 28, 2017 at 1:54 PM, Grygorii Strashko > wrote: > > Cc: Sekhar > > > > On 08/28/2017 10:32 AM, Adam Ford wrote: > >> > >> The davinvi_emac MAC address seems to attempt a call to > >> ti_cm_get_macid in

Re: [RFC/RFT PATCH 4/4] [debug] ARM: am335x: illustrate hwstamp

2017-06-13 Thread Tony Lindgren
3 at 1493259036.381161765 > event index 3 at 1493259037.381731909 Cool :) Acked-by: Tony Lindgren <t...@atomide.com>

Re: phy: cpcap-usb: Add CPCAP PMIC USB support

2017-06-06 Thread Tony Lindgren
* Colin Ian King [170605 10:58]: > Hi Tony, > > While running static analysis on linux-next, CoverityScan picked up a > NULL pointer deference on ddata->pins when calling pinctrl_lookup_state: > > 466ddata->pins = devm_pinctrl_get(ddata->dev); > >1.

Re: [PATCH] [4.11 regression] cpsw/netcp: refine cpts dependency

2017-04-28 Thread Tony Lindgren
* Arnd Bergmann <a...@arndb.de> [170428 08:06]: > Tony Lindgren reports a kernel oops that resulted from my compile-time > fix on the default config. This shows two problems: > > a) configurations that did not already enable PTP_1588_CLOCK will >now miss the cpts dri

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
* Arnd Bergmann <a...@arndb.de> [170424 11:14]: > On Mon, Apr 24, 2017 at 7:44 PM, Tony Lindgren <t...@atomide.com> wrote: > > * Arnd Bergmann <a...@arndb.de> [170424 10:38]: > >> On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren <t...@atomide.com> wrote:

Re: cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
* Arnd Bergmann <a...@arndb.de> [170424 10:38]: > On Mon, Apr 24, 2017 at 6:51 PM, Tony Lindgren <t...@atomide.com> wrote: > > Hi, > > > > Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") > > in mainline started tr

cpsw regression in mainline with "cpsw/netcp: cpts depends on posix_timers"

2017-04-24 Thread Tony Lindgren
Hi, Looks like commit 07fef3623407 ("cpsw/netcp: cpts depends on posix_timers") in mainline started triggering the following oops at least on j5eco-evm. Adding CONFIG_PTP_1588_CLOCK to .config solves it, but the oops hints something is wrong with the dependencies.. CONFIG_TI_CPTS defaults to N

Re: [PATCH 0/2] ARM: am335x-icev2: Add ethernet support

2017-04-04 Thread Tony Lindgren
* Roger Quadros [170330 05:37]: > Hi Tony & Dave, > > On 13/03/17 15:42, Roger Quadros wrote: > > Hi, > > > > This series adds ethernet support to am335x-icev2 board. > > > > The ethernet PHYs on the board need an explicit GPIO reset pulse > > to ensure they bootstrap to the

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

2017-03-19 Thread Tony Lindgren
* Bjørn Mork <bj...@mork.no> [170319 10:23]: > Tony Lindgren <t...@atomide.com> writes: > > And the v3.8 kernel also has drivers/usb/serial/mdm6600.c: > > > > +static const struct usb_device_id mdm6600_id_table[] = { > > + { USB_DEVICE_AND_INTERFAC

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

2017-03-19 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [170319 10:05]: > * Bjørn Mork <bj...@mork.no> [170319 09:33]: > > This is a bit unusual, so I'd like to verify that it is correct. Do you > > happen to have a "lsusb -v" or /sys/kernel/debug/usb/devices dump for > > th

Re: [PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

2017-03-19 Thread Tony Lindgren
* Bjørn Mork <bj...@mork.no> [170319 09:33]: > Tony Lindgren <t...@atomide.com> writes: > > > This gets qmicli working with the MDM6600 modem. > > > > Cc: Bjørn Mork <bj...@mork.no> > > Reviewed-by: Sebastian Reichel <s...@kernel.org> > &g

[PATCH] net: qmi_wwan: Add USB IDs for MDM6600 modem on Motorola Droid 4

2017-03-19 Thread Tony Lindgren
This gets qmicli working with the MDM6600 modem. Cc: Bjørn Mork <bj...@mork.no> Reviewed-by: Sebastian Reichel <s...@kernel.org> Tested-by: Sebastian Reichel <s...@kernel.org> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/net/usb/qmi_wwan.c | 4 1 fi

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-31 Thread Tony Lindgren
* Kalle Valo <kv...@codeaurora.org> [170130 22:36]: > Tony Lindgren <t...@atomide.com> writes: > > > * Pavel Machek <pa...@ucw.cz> [170127 11:41]: > >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > >> > Pali Rohár <pali.ro...@gmail.com>

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

2017-01-30 Thread Tony Lindgren
* Pavel Machek [170127 11:41]: > On Fri 2017-01-27 17:23:07, Kalle Valo wrote: > > Pali Rohár writes: > > > > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: > > >> Pali Rohár writes: > > >> > > >> > 2) It was already tested

Re: [PATCH] ARM: dts: am57xx-beagle-x15: implement errata "Ethernet RGMII2 Limited to 10/100 Mbps"

2017-01-12 Thread Tony Lindgren
* Grygorii Strashko [170112 09:15]: > According to errata i880 description the speed of Ethernet port 1 on AM572x > SoCs rev 1.1 shuld be limited to 10/100Mbps, because RGMII2 Switching > Characteristics are not compatible with 1000 Mbps operation [1]. > The issue is

Re: [PATCH 2/2] ARM: dts: dra72-evm-revc: enable irqs for dp83867 eth phys

2017-01-12 Thread Tony Lindgren
* Grygorii Strashko <grygorii.stras...@ti.com> [170109 11:26]: > > > On 01/06/2017 03:54 PM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.stras...@ti.com> [170106 12:56]: > > > TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ

Re: [PATCH 2/2] ARM: dts: dra72-evm-revc: enable irqs for dp83867 eth phys

2017-01-06 Thread Tony Lindgren
* Grygorii Strashko [170106 12:56]: > TI DRA72-EVM Rev C has two DP83867 ethernet phys which support IRQ > generation in case of phy/link status changes. The INT/PWDN lines from both > DP83867 phys are wired to DRA7 gpio6.16, so reflect the same in DT. Hmm not seeing

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Tony Lindgren
* Kalle Valo <kv...@codeaurora.org> [161220 09:12]: > Tony Lindgren <t...@atomide.com> writes: > > > * Kalle Valo <kv...@codeaurora.org> [161220 03:47]: > >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: > >> > >> >

Re: wl1251 & mac address & calibration data

2016-12-20 Thread Tony Lindgren
* Kalle Valo [161220 03:47]: > Arend Van Spriel writes: > > > On 18-12-2016 13:09, Pali Rohár wrote: > > > >> File wl1251-nvs.bin is provided by linux-firmware package and contains > >> default data which should be overriden by model specific

Re: wl1251 & mac address & calibration data

2016-12-05 Thread Tony Lindgren
* Pali Rohár [161126 09:21]: > On Thursday 24 November 2016 19:46:01 Aaro Koskinen wrote: > > Hi, > > > > On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > > > Proprietary, signed and closed bootloader NOLO does not support DT. > > > So for booting you need to

Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517

2016-10-28 Thread Tony Lindgren
* Jeroen Hofstee <jhofs...@victronenergy.com> [161028 11:19]: > Hello Tony, > > On 28-10-16 17:52, Tony Lindgren wrote: > > * Jeroen Hofstee <jhofs...@victronenergy.com> [161028 08:33]: > > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move

Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517

2016-10-28 Thread Tony Lindgren
* Jeroen Hofstee [161028 08:33]: > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") did not only move the code for an am3517, it also > added the slave parameter, resulting in an invalid (all zero) mac address > being

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161021 02:31]: > Aaah, lets wait a sec. I just saw there is another user of this function, > so above is simply not true > > if (of_machine_is_compatible("ti,dra7")) > return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee <jhofs...@victronenergy.com> [161021 00:37]: > Hello Tony, > > On 21-10-16 08:38, Tony Lindgren wrote: > > * Jeroen Hofstee <jhofs...@victronenergy.com> [161020 12:57]: > > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move

Re: [PATCH] net: cpsw: fix obtaining mac address for am3517

2016-10-21 Thread Tony Lindgren
* Jeroen Hofstee [161020 12:57]: > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac > id to common file") did not only move the code for an am3517, it also > added the slave parameter, resulting in a invalid (all zero) mac address > being

Re: [PATCH] davinci_emac: fix setting the mac from DT

2016-10-20 Thread Tony Lindgren
device tree. > This patch makes sure the mac from DT is preserved. > > On a am3517 this address is incorrectly read as all zeros, making it > impossible to set a valid mac address without this patch. OK, at least I don't have better ideas for fixing this: Acked-by: Tony Lindgren <t...@atomide.com>

Re: [PATCH 3/3 v2] net: smsc911x: add wake-up event interrupt support

2016-08-26 Thread Tony Lindgren
code in the RTC > subsystem. > > The code looks for an additional interrupt - apart from the > ordinary device interrupt - and in case that is present, > we register an interrupt handler to respons to this, > and flag the device and this interrupt as a wakeup. > > Cc:

Re: [PATCH 3/3] RFC: net: smsc911x: add wake-up event interrupt support

2016-07-11 Thread Tony Lindgren
* Linus Walleij [160708 02:10]: > The SMSC911x have a line out of the chip called "PME", > Power Management Event. When connected to an asynchronous > interrupt controller this is able to wake the system up > from sleep in response to certain network events. Cool, so

Re: [PATCH 15/15] ARM: dts: am335x/am437x/dra7: use new "ti,cpsw-mdio" compat string

2016-06-21 Thread Tony Lindgren
not cause merge conflicts, please feel free to merge along with the other CPSW driver patches after the pending comments are dealt with: Acked-by: Tony Lindgren <t...@atomide.com>

Re: NFSroot hangs with bad unlock balance in Linux next

2016-05-09 Thread Tony Lindgren
* Al Viro <v...@zeniv.linux.org.uk> [160509 08:41]: > On Mon, May 09, 2016 at 08:21:38AM -0700, Tony Lindgren wrote: > > > Looks like with both patches applied I still also get this eventually: > > > > = > > [ BUG: bad unlo

Re: NFSroot hangs with bad unlock balance in Linux next

2016-05-09 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [160509 08:15]: > * Eric Dumazet <eduma...@google.com> [160509 07:16]: > > On Mon, May 9, 2016 at 12:32 AM, Al Viro <v...@zeniv.linux.org.uk> wrote: > > > On Sun, May 08, 2016 at 03:16:29PM +0100, Al Viro wrote: > >

Re: NFSroot hangs with bad unlock balance in Linux next

2016-05-09 Thread Tony Lindgren
* Eric Dumazet [160509 07:16]: > On Mon, May 9, 2016 at 12:32 AM, Al Viro wrote: > > On Sun, May 08, 2016 at 03:16:29PM +0100, Al Viro wrote: > > > >> Very strange. We grab that rwsem at the entry into nfs_call_unlink() > >> and then either release

Re: [PATCH net v3 0/5] drivers: net: cpsw: phy-handle fixes

2016-04-28 Thread Tony Lindgren
c mode, but with 2 PHYs using phy-handle properties [1]. > > Nicolas Chauvet reported testing v2 on an HP t410 (dm8148). > > Markus Brunner reported testing v1 on the following [2]: > - emac0 with phy_id and emac1 with fixed phy > - emac0 with phy-handle and emac1 with fixed phy

Re: [PATCH v2] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-21 Thread Tony Lindgren
h dedicated linux-omap list. > > > > Also add Mugunthan as maintainer and myself as the reviewer. > > > > Cc: "David S. Miller" <da...@davemloft.net> > > Cc: Tony Lindgren <t...@atomide.com> > > Cc: Mugunthan V N <mugunthan...@ti.com&

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Tony Lindgren
* Grygorii Strashko <grygorii.stras...@ti.com> [160420 09:19]: > On 04/20/2016 05:23 PM, Tony Lindgren wrote: > > * Grygorii Strashko <grygorii.stras...@ti.com> [160420 04:26]: > >> Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > >> (am33/am43/a

Re: Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
* Hannes Frederic Sowa <han...@stressinduktion.org> [160420 08:24]: > Hi, > > On 20.04.2016 17:01, Tony Lindgren wrote: > > Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for > > sock_owned_by_user") in next causes a regression at least

Re: [PATCH 1/1] Revert "Prevent NUll pointer dereference with two PHYs on cpsw"

2016-04-20 Thread Tony Lindgren
; data->slaves. Missing Signed-off-by? This gets cpsw boards working in next for me again: Tested-by: Tony Lindgren <t...@atomide.com>

Re: Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
* Tony Lindgren <t...@atomide.com> [160420 08:02]: > Hi, > > Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for > sock_owned_by_user") in next causes a regression at least for > smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following >

Regression in next for smsc911x with tigthen lockdep checks

2016-04-20 Thread Tony Lindgren
Hi, Looks like commit fafc4e1ea1a4 ("sock: tigthen lockdep checks for sock_owned_by_user") in next causes a regression at least for smsc911x with CONFIG_LOCKDEP. It keeps spamming with the following message. Any ideas? Regards, Tony 8< WARNING: CPU: 0 PID: 0 at

Re: [PATCH] MAINTAINERS: net: add entry for TI Ethernet Switch drivers

2016-04-20 Thread Tony Lindgren
* Grygorii Strashko [160420 04:26]: > Add record for TI Ethernet Switch Driver CPSW/CPDMA/MDIO HW > (am33/am43/am57/dr7/davinci) to ensure that related patches > will go through dedicated linux-omap list. > > Also add Mugunthan as maintainer and myself as the reviewer.

[PATCH] net: cpsw: Fix ethernet regression for dm814x

2015-11-18 Thread Tony Lindgren
han...@ti.com> Signed-off-by: Tony Lindgren <t...@atomide.com> --- drivers/net/ethernet/ti/cpsw-common.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/ti/cpsw-common.c +++ b/drivers/net/ethernet/ti/cpsw-common.c @@ -78,6 +78,9 @@ static int cpsw_am33xx_cm_get_macid(s

Re: [PATCH] net: davinci_emac: Add support for fixed-link PHY

2015-09-22 Thread Tony Lindgren
> Ethernet works for me with this patch: Tested-by: Tony Lindgren <t...@atomide.com> > --- > drivers/net/ethernet/ti/davinci_emac.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/davinci_emac.c > b/drivers/net/

Re: [net-next PATCH v3] drivers: net: cpsw: Add support to drive gpios for ethernet to be functional

2015-09-08 Thread Tony Lindgren
and ethernet becomes functional. > Verified this on DRA72x with pcf as module and ramdisk. > > Signed-off-by: Mugunthan V N <mugunthan...@ti.com> Acked-by: Tony Lindgren <t...@atomide.com> > --- > > Changes from v2: > * Used mode-gpios, so that the driver is generic e

Re: [net-next PATCH v2] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-03 Thread Tony Lindgren
* Mugunthan V N [150902 23:05]: > In DRA72x EVM, by default slave 1 is connected to the onboard > phy, but slave 2 pins are also muxed with video input module > which is controlled by pcf857x gpio and currently to select slave > 0 to connect to phy gpio hogging is used, but

Re: [net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy

2015-09-01 Thread Tony Lindgren
* Mugunthan V N [150901 04:28]: > --- a/Documentation/devicetree/bindings/net/cpsw.txt > +++ b/Documentation/devicetree/bindings/net/cpsw.txt > @@ -26,6 +26,9 @@ Optional properties: > - dual_emac : Specifies Switch to act as Dual EMAC > - syscon :

[PATCH] net/smsc911x: Fix deferred probe for interrupt

2015-08-28 Thread Tony Lindgren
The interrupt handler may not be available when smsc911x probes if the interrupt handler is a GPIO controller for example. Let's fix that by adding handling for -EPROBE_DEFER. Cc: Steve Glendinning steve.glendinn...@shawell.net Signed-off-by: Tony Lindgren t...@atomide.com --- drivers/net

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
* Guenter Roeck li...@roeck-us.net [150826 11:37]: On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node. device_get_phy_mode() is called unconditionally, and if there is no

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
* Jeremy Linton jeremy.lin...@arm.com [150826 10:35]: On 08/26/2015 12:04 PM, Tony Lindgren wrote: * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes Looks like this change makes at least omap boards using smsc911x fail

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
* Guenter Roeck li...@roeck-us.net [150826 10:40]: Hi Tony, On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional

Re: [PATCH -next v2 2/2] smsc911x: Ignore error return from device_get_phy_mode()

2015-08-26 Thread Tony Lindgren
. Thanks this fixes smsc911x regression in Linux next for me with FDT: Tested-by: Tony Lindgren t...@atomide.com drivers/net/ethernet/smsc/smsc911x.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

2015-08-26 Thread Tony Lindgren
* Guenter Roeck li...@roeck-us.net [150826 13:58]: Hi Tony, On 08/26/2015 01:16 PM, Tony Lindgren wrote: [ ... ] We may need two separate patches, one to fix up device_property_read_u32() to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error from

Re: [net-next PATCH 2/3] ARM: dts: dra7: update cpsw compatible

2015-08-13 Thread Tony Lindgren
: Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/dra7.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 8f1e25b..b4fdd10 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7

Re: [net-next PATCH 3/3] ARM: dts: am33xx: update cpsw compatible

2015-08-13 Thread Tony Lindgren
* Mugunthan V N mugunthan...@ti.com [150812 02:56]: CPSW driver has been updated with compatibles for enabling errata workarounds. So updating cpsw compatibles. Signed-off-by: Mugunthan V N mugunthan...@ti.com This too: Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts