Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

On Fri, Sep 16, 2016 at 2:21 PM, Anton Aksola <aa...@iki.fi> wrote: > Ok, I will post a new patch version. Should tests be posted in a separate > patch? > > 2016-09-16 12:44 GMT+03:00 Nicolas Dichtel <nicolas.dich...@6wind.com>: >> >> Le 16/09/2016 à 11

Re: [PATCH v2] iproute2: build nsid-name cache only for commands that need it

> --- > There is still some differences: > $ cat test.batch > netns add foo > netns set foo 1234 > netns list-id > > Before your patch: > $ ip -b test.batch > nsid 1234 (iproute2 netns name: foo) > > After your patch: > $ ip -b test.batch > nsid 1234 Would it be useful to add test for this case into testsuite/ ? Regards, Vadim Kochan

Re: [iproute PATCH] ipaddress: Allow listing addresses by type

addr' too. > Cc: Vadim Kochan <vadi...@gmail.com> > Signed-off-by: Phil Sutter <p...@nwl.cc> > --- > ip/ipaddress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/ipaddress.c b/ip/ipaddress.c > index df363b070d5de..1b5ee838ef3fe 100644

Re: ss filter problem

net' to 'src inet:*' and pass everything ANDed together to > ssfilter_parse(). Or maybe that would make things even worse. ;) > > Cheers, Phil I thought I fixed & tested well ss filter, but seems it would be good to have good automation testing. Regards, Vadim Kochan

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

On Thu, Oct 15, 2015 at 08:13:23PM -0700, roopa wrote: > On 10/15/15, 7:38 PM, David Ahern wrote: > > Hi Roopa: > > > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: > >> From: Roopa Prabhu > >> > >> replace exit with return -2 on rtnl_talk failure > >> > >> Signed-off-by:

[PATCH iproute2] man tc-htb: Fix HRB -> HTB typo

From: Vadim Kochan <vadi...@gmail.com> Changed HRB -> HTB. Signed-off-by: Vadim Kochan <vadi...@gmail.com> --- man/man8/tc-htb.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/tc-htb.8 b/man/man8/tc-htb.8 index d196ecd..95f25de 100644 --- a/man/man8

[PATCH iproute2] configure: Check for Berkeley DB for arpd compilation

From: Vadim Kochan <vadi...@gmail.com> Add check for Berkeley DB header & lib before compile arpd util. Signed-off-by: Vadim Kochan <vadi...@gmail.com> --- configure | 29 +++-- misc/Makefile | 6 +- 2 files changed, 32 insertions(+), 3 deletion

Re: iproute2 tunnel name parsing

> the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Hi Wilhelm, You can use 'name' before 'hel' like: $ ip tun add name hel mode sit remote 10.200.0.2 local 10.200.1.2 ttl 255 and it should work, actually I just

[PATCH iproute2] man ip-link: Fix wording in VLAN reorder_hdr explanation

From: Vadim Kochan <vadi...@gmail.com> Signed-off-by: Vadim Kochan <vadi...@gmail.com> --- man/man8/ip-link.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index 1896eb6..4928249 100644 --- a/man/man8/ip-link.8.

Re: [PATCH] man ip-link: Add more explanation about vlan reordering

On Wed, Aug 26, 2015 at 04:27:48PM +0100, Jeremy Harris wrote: > On 17/08/15 20:22, Vadim Kochan wrote: > > +.BR reorder_hdr " is " on > > +then VLAN header will be not inserted immediately but only before passing > > to the > > +physical device (if this de

[PATCH] man ip-link: Add little explanations about VLAN qos map

From: Vadim Kochan vadi...@gmail.com Add little more info about how to manually set priority by iptables, and some little clarifications about ingress/egress QoS mapping. Signed-off-by: Vadim Kochan vadi...@gmail.com --- man/man8/ip-link.8.in | 27 --- 1 file changed, 24

Re: iproute2: Behavioural Bug?

UTC 2015 x86_64 GNU/Linux Regards, Vadim Kochan -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] man ip-link: Add more explanation about vlan reordering

From: Vadim Kochan vadi...@gmail.com Add more explanation about VLAN reordering and what it affects. Signed-off-by: Vadim Kochan vadi...@gmail.com --- man/man8/ip-link.8.in | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/man/man8/ip-link.8.in b

[PATCH iproute2] man ss: Fix explanation when no options specified

From: Vadim Kochan vadi...@gmail.com Really by default ss dumps not only TCP sockets but any kind of socket which is in ESTABLISHED state (TCP/UDP/UNIX). Signed-off-by: Vadim Kochan vadi...@gmail.com Reported-by: Miha Marolt mi...@beyondsemi.com --- man/man8/ss.8 | 2 +- 1 file changed, 1

[PATCH iproute2 v2] ss: Fix crash when dump stats from /proc with '-p'

From: Vadim Kochan vadi...@gmail.com It really partially reverts: ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct) but adds few fields (name peer_name) from removed unixstat to sockstat struct to easy return original code. Fixes: ec4d0d8a9def35 (ss: Replace unixstat

[PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'

From: Vadim Kochan vadi...@gmail.com It really partially reverts: ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct) but adds few fields (name peer_name) from removed unixstat to sockstat struct to easy return original code. Fixes: ec4d0d8a9def35 (ss: Replace unixstat

Re: [PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'

On Mon, Jul 20, 2015 at 01:43:40PM -0700, Stephen Hemminger wrote: On Mon, 20 Jul 2015 22:46:23 +0300 Vadim Kochan vadi...@gmail.com wrote: + if (s-name) + free(s-name); Please don't add unnecessary conditional. free(NULL) is defined to do nothing. OK, I

Re: ss -p segfaults

On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote: On Jul 15, 2015, at 9:49 AM, Rustad, Mark D mark.d.rus...@intel.com wrote: On Jul 15, 2015, at 8:12 AM, Vadim Kochan vadi...@gmail.com wrote: Would you please check this fix ? diff --git a/misc/ss.c b/misc/ss.c index

Re: ss -p segfaults

On Wed, Jul 15, 2015 at 09:57:51PM +0300, Vadim Kochan wrote: On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote: On Jul 15, 2015, at 9:49 AM, Rustad, Mark D mark.d.rus...@intel.com wrote: On Jul 15, 2015, at 8:12 AM, Vadim Kochan vadi...@gmail.com wrote: Would you

Re: ss -p segfaults

On Wed, Jul 15, 2015 at 04:09:03PM +0200, Marc Dietrich wrote: Hi, ss -p segfaults here with some kind of memory corruption: *** Error in `/work/iproute2/misc/ss': free(): invalid pointer: 0x00623000 *** === Backtrace: = /lib64/libc.so.6(+0x71c6d)[0x77885c6d]

Re: ss -p segfaults

On Wed, Jul 15, 2015 at 04:09:03PM +0200, Marc Dietrich wrote: Hi, ss -p segfaults here with some kind of memory corruption: *** Error in `/work/iproute2/misc/ss': free(): invalid pointer: 0x00623000 *** === Backtrace: = /lib64/libc.so.6(+0x71c6d)[0x77885c6d]

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

On Fri, Jul 10, 2015 at 09:09:46AM +0200, Miha Marolt wrote: On 07/09/2015 05:15 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote: On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote: On 07/09/2015 04:55 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 04

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

On Thu, Jul 09, 2015 at 05:09:27PM +0200, Miha Marolt wrote: On 07/09/2015 04:57 PM, Nikolay Aleksandrov wrote: On 07/09/2015 04:55 PM, Vadim Kochan wrote: On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

On Thu, Jul 09, 2015 at 04:50:06PM +0200, Nikolay Aleksandrov wrote: On 07/09/2015 04:13 PM, Miha Marolt wrote: Hi! I hope this is the right place to reports bugs. I apologize if it isn't. I have written a C program (see below for source code) that opens a raw socket on CentOS 7.1

Re: [BUG] $ ss -a incorrectly displays raw sockets as udp sockets

On Thu, Jul 09, 2015 at 05:21:10PM +0200, Eric Dumazet wrote: On Thu, 2015-07-09 at 17:14 +0200, Eric Dumazet wrote: If I checkout iproute2 tree to db08bdb816d337102c5486744008db9c9faa43bf (before buggy commit) we indeed had this result : # ./ss -an | grep 127.0.0.1 rawUNCONN

[PATCH iproute2] tests: Add output testing

From: Vadim Kochan vadi...@gmail.com Added possibility to check command output by grep from the testing script. Now TMP_OUT TMP_ERR are passed from Makefile and changed to STD_ERR STD_OUT. Also changed some existing tests to make output testing. Signed-off-by: Vadim Kochan vadi...@gmail.com

Re: Possible issue in iproute2 package

Hi Jose, On Thu, May 28, 2015 at 09:12:15PM +, Guzman Mosqueda, Jose R wrote: Hi all I'm Jose Guzman from a security team at Intel. We're using iproute2 in a GNU-Linux project and I'm analyzing the code to try to find possible issues/gaps/risks. Since I'm not too familiar with the

[PATCH iproute2] configure: Check for libmnl

From: Vadim Kochan vadi...@gmail.com Indicate existence of libmnl which is required by tipc. Signed-off-by: Vadim Kochan vadi...@gmail.com --- configure | 16 1 file changed, 16 insertions(+) diff --git a/configure b/configure index f1325df..1605464 100755 --- a/configure

[PATCH iproute2] ss: Fix allocation of cong control alg name

From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 347e3a1..a719466 100644 --- a/misc/ss.c

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

On Fri, May 29, 2015 at 04:04:05AM -0700, Eric Dumazet wrote: On Fri, 2015-05-29 at 13:30 +0300, Vadim Kochan wrote: From: Vadim Kochan vadi...@gmail.com Use strdup instead of malloc, and get rid of bad strcpy. Signed-off-by: Vadim Kochan vadi...@gmail.com --- misc/ss.c | 3

[PATCH iproute2 v2] ss: Fix allocation of cong control alg name

From: Vadim Kochan vadi...@gmail.com Used 16 char array for cong alg name instead of malloc. Fixes: 8250bc9ff4e5 (ss: Unify inet sockets output) Reported-by: Jose R. Guzman Mosqueda jose.r.guzman.mosqu...@intel.com Signed-off-by: Vadim Kochan vadi...@gmail.com --- v2: Used 16 byte array

[PATCH iproute2] man ip-link: Remove extra GROUP explanation

From: Vadim Kochan vadi...@gmail.com Remove double explanation of GROUP option from 'ip link set' section. Signed-off-by: Vadim Kochan vadi...@gmail.com --- man/man8/ip-link.8.in | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link

[PATCH iproute2 1/2] tests: Run each test in network namespace

From: Vadim Kochan vadi...@gmail.com Changed to forcely running each test in network namespace to do not affect on current network setup. Signed-off-by: Vadim Kochan vadi...@gmail.com --- testsuite/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/testsuite

Re: iproute2 regression -- ss -u returns an empty list

On Tue, Apr 28, 2015 at 03:22:33AM +0200, Mihai Moldovan wrote: Hi, Following up a bug report I received at http://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=799 it looks like the current version iproute2's ss utility always returns an empty result set whenever specifying the -u flag. The

Re: iproute2 regression -- ss -u returns an empty list

On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can be in the CONNECTED state on the Linux, UDP can be in a CONNECTED state... kay. That's probably a conntrack

Re: iproute2 regression -- ss -u returns an empty list

On Tue, Apr 28, 2015 at 07:07:56AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:47 AM, Vadim Kochan wrote: On Tue, Apr 28, 2015 at 06:33:18AM +0200, Mihai Moldovan wrote: On 28.04.2015 06:05 AM, Vadim Kochan wrote: So by default ss prints socket with CONNECTED state and even UDP can

[PATCH iproute2] tc util: Fix possible buffer overflow when print class id

From: Vadim Kochan vadi...@gmail.com Use correct handle buffer length. Signed-off-by: Vadim Kochan vadi...@gmail.com --- tc/tc_util.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tc/tc_util.c b/tc/tc_util.c index 1d3153d..dc2b70f 100644 --- a/tc