Re: [PATCH 11/12] [IPSEC]: Reinject packet instead of calling netfilter directly on input

2007-10-16 Thread YOSHIFUJI Hideaki /
Herbert, I think with this change, we parse extension headers, twice. We really do not want to do this. --yoshfuji In article [EMAIL PROTECTED] (at Tue, 16 Oct 2007 22:33:19 +0800), Herbert Xu [EMAIL PROTECTED] says: [IPSEC]: Reinject packet instead of calling netfilter directly on input

Re: [PATCH 3/3] [IPV6]: Replace sk_buff ** with sk_buff * in input handlers

2007-10-14 Thread YOSHIFUJI Hideaki /
Herbert, I really appreciate this work. Thank you! --yoshfuji In article [EMAIL PROTECTED] (at Sun, 14 Oct 2007 22:49:05 +0800), Herbert Xu [EMAIL PROTECTED] says: [IPV6]: Replace sk_buff ** with sk_buff * in input handlers With all the users of the double pointers removed from the IPv6

[PATCH] IPROUTE2: Support IPv4/IPv6 Tunnel

2007-10-12 Thread YOSHIFUJI Hideaki /
Based on patch from Yasuyuki KOZAKAI [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git a/ip/ip6tunnel.c b/ip/ip6tunnel.c index 6468d99..cbbdf9d 100644 --- a/ip/ip6tunnel.c +++ b/ip/ip6tunnel.c @@ -52,6 +52,7 @@ static void usage(void)

Re: IPUtils and uClibc

2007-10-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 30 Jul 2007 00:50:39 +0200), Rafał Bilski [EMAIL PROTECTED] says: Today I was trying to update my router based on Gentoo and uClibc. Unfortunatly build fails because of b* functions. Linker can't find them later. At first gcc is complaining that b*

Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493

2007-10-10 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 10 Oct 2007 16:42:56 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: David Stevens [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 14:48:38 -0700 But anyway, I made the comment; I think some form of it should go in. :-) If you like the original

Re: [PATCH] [IPV6] Defer IPv6 device initialization until a valid qdisc is specified

2007-10-09 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 10 Oct 2007 09:32:35 +0800), Herbert Xu [EMAIL PROTECTED] says: Mitsuru Chinen [EMAIL PROTECTED] wrote: To judge the timing for DAD, netif_carrier_ok() is used. However, there is a possibility that dev-qdisc stays noop_qdisc even if

Re: [RFC][IPv6] Export userland ND options through netlink (RDNSS support)

2007-10-01 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Sat, 29 Sep 2007 19:47:20 +0200), Pierre Ynard [EMAIL PROTECTED] says: As discussed before, this patch provides userland with a way to access relevant options in Router Advertisements, after they are processed and validated by the kernel. Extra options

Re: Removing DAD in IPv6

2007-10-01 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 01 Oct 2007 11:53:27 +0800), Xia Yang [EMAIL PROTECTED] says: I would like to ask for help on how to remove or disable the DAD process properly, as long as the node can send, receive and forward packets immediately after a new IPv6 address is generated.

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

2007-10-01 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Sat, 29 Sep 2007 10:04:48 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: In article [EMAIL PROTECTED] (at Fri, 28 Sep 2007 17:50:38 -0700), David Stevens [EMAIL PROTECTED] says: Brian, A multicast address should never

Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address

2007-09-28 Thread YOSHIFUJI Hideaki /
Dave, Brian, Let me double check this patch. Regards, --yoshfuji In article [EMAIL PROTECTED] (at Fri, 28 Sep 2007 17:50:38 -0700), David Stevens [EMAIL PROTECTED] says: Brian, A multicast address should never be the target of a neighbor discovery request; the sender should use

Re: [PATCH 5/7] CAN: Add virtual CAN netdevice driver

2007-09-25 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Tue, 25 Sep 2007 14:20:34 +0200), Urs Thuermann [EMAIL PROTECTED] says: Index: net-2.6.24/drivers/net/can/vcan.c === --- /dev/null 1970-01-01 00:00:00.0 + +++

Re: [PATCH] 2.6.22.6 NETWORKING [IPV4]: Always use source addr in skb to reply packet

2007-09-17 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 17 Sep 2007 19:20:44 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: lepton [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 10:16:17 +0800 Hi, In some situation, icmp_reply and ip_send_reply will send out packet with the wrong source addr,

2.6.23-rc regression: bcm43xx does not work after commit 4cf92a3c

2007-09-16 Thread YOSHIFUJI Hideaki /
Hello. With latest git tree, bcm43xx driver does not work. By bisect, I've found the commit 4cf92a3c is the first bad commit. [PATCH] softmac: Fix ESSID problem Victor Porton reported that the SoftMAC layer had random problem when setting the ESSID :

[PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.

2007-09-12 Thread YOSHIFUJI Hideaki /
Also applicable for stable releases. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index a58459a..fc5cb83 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -858,11 +858,10 @@ back_from_confirm:

[PATCH 2/4] [IPV6]: Fix oops during flushing corked datagrams.

2007-09-12 Thread YOSHIFUJI Hideaki /
When we corking sub-datagrams, we do not clone skb-dst for sub-datagrams other than the first one, so we get oops if we have multiple sub-datagrams here. One possible way to fix this is to clone skb-dst for all sub-datagrams, but we do not take this approach because skb-dst is not used in other

[PATCH 3/4] [IPV6]: Just increment OutDatagrams once per a datagram.

2007-09-12 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 4210951..c347f3e 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -555,6 +555,8 @@ static int udp_v6_push_pending_frames(struct sock *sk) out: up-len = 0; up-pending = 0; +

[PATCH 4/4] [IPV4]: Just increment OutDatagrams once per a datagram.

2007-09-12 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index facb7e2..ccb67f3 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -504,6 +504,8 @@ send: out: up-len = 0; up-pending = 0; + if (!err) +

Re: [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM.

2007-09-12 Thread YOSHIFUJI Hideaki /
| [PATCH 1/4] [IPV6]: Fix unbalanced socket reference with MSG_CONFIRM. Ah, I should say, socket locking, probably... Anyway, lock_sock() and release_sock() are not paired approriately. --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH][2/2] Add ICMPMsgStats MIB (RFC 4293)

2007-09-11 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 10 Sep 2007 20:27:03 -0600), David Stevens [EMAIL PROTECTED] says: These patches remove (but not really) the existing counters, and replace them with the ICMPMsgStats tables for v4 and v6. It includes the named counters in the /proc places they were, but

Re: [IPv6] BUG: NULL pointer dereference in(?) ip6_flush_pending_frames

2007-09-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 10 Sep 2007 00:24:00 +0200), Bernhard Schmidt [EMAIL PROTECTED] says: I'm running a public Teredo relay (IPv4-to-IPv6 migration protocol) using Miredo. Every once in a while (a few minutes to days after daemon restart) it becomes unusable and I see the

Re: [IPv6] Add v4mapped address inline

2007-08-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 23 Aug 2007 14:14:35 -0400), Brian Haley [EMAIL PROTECTED] says: YOSHIFUJI Hideaki / wrote: Please put this just after ipv6_addr_any(), not after ipv6_addr_diff(). Ok, updated patch attached. -Brian Add v4mapped address inline to avoid

Re: [IPv6] Add v4mapped address inline

2007-08-23 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Thu, 23 Aug 2007 12:40:54 -0400), Brian Haley [EMAIL PROTECTED] says: diff --git a/include/net/ipv6.h b/include/net/ipv6.h index 9059e0e..c2b6c11 100644 --- a/include/net/ipv6.h +++ b/include/net/ipv6.h @@ -418,6 +418,12 @@ static inline int

Re: [PATCH] IPv6: Fix kernel panic while send SCTP data with IP fragments

2007-08-19 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 20 Aug 2007 09:28:27 +0800), Wei Yongjun [EMAIL PROTECTED] says: If ICMP6 message with Packet Too Big is received after send SCTP DATA, kernel panic will occur when SCTP DATA is send again. This is because of a bad dest address when call to

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary sysctl names for a function that works with proc. - In neighbour.c reorder the table to put the

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 09 Aug 2007 18:49:21 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 10:47:10 +0900 (JST) I disagree. It is bad to remove existing interface. Ditto for other patches. I

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 09 Aug 2007 18:56:09 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: - In ipv6 ndisc_ifinfo_syctl_change so it doesn't depend on binary sysctl names for a function that works with proc. : Well, retrans_time_ms and base_reachable_time_ms supercedes

Re: [PATCH 04/10] sysctl: Fix neighbour table sysctls.

2007-08-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 09 Aug 2007 20:23:16 -0600), [EMAIL PROTECTED] (Eric W. Biederman) says: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] writes: Would you explain why it does not work properly for those cases? Mostly no appropriate strategy routine was setup

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-26 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 25 Jul 2007 17:12:03 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: Contrarily, there may be ipv6_addr_type() call sites that really do want to reject rfc4193 addresses. I do not think we have such users. --yoshfuji - To unsubscribe from this list:

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-26 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 25 Jul 2007 19:49:09 -0400), Dave Johnson [EMAIL PROTECTED] says: ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range. Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] I

Re: [PATCH][RFC] network splice receive v3

2007-07-19 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 11 Jul 2007 11:19:27 +0200), Jens Axboe [EMAIL PROTECTED] says: @@ -835,6 +835,7 @@ const struct proto_ops inet_stream_ops = { .recvmsg = sock_common_recvmsg, .mmap = sock_no_mmap, .sendpage =

[GIT PULL] [NET]: Whitespace fixes

2007-07-18 Thread YOSHIFUJI Hideaki /
Dave, Please consider pulling the following commits from net-2.6-20070719-whitespace-20070719 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git. Thanks. HEADLINES - [NET] AX25: Fix whitespace errors. [NET] BLUETOOTH: Fix whitespace errors.

Re: [PATCH]: Can not set the IPV6_PKTINFO option

2007-07-16 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 13:41:23 +0100), Gerrit Renker [EMAIL PROTECTED] says: [IPv6]: Can not set the IPV6_PKTINFO option The Linux manpage of ipv6(7) mentions the IPV6_PKTINFO option (and it is defined in header files), but there is no setsockopt support for

Re: [PATCH]: Can not set the IPV6_PKTINFO option

2007-07-16 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 21:56:05 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 13:41:23 +0100), Gerrit Renker [EMAIL PROTECTED] says: [IPv6]: Can not set the IPV6_PKTINFO option The Linux

Re: [PATCH]: Can not set the IPV6_PKTINFO option

2007-07-16 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 22:02:29 +0800), Herbert Xu [EMAIL PROTECTED] says: Gerrit Renker [EMAIL PROTECTED] wrote: Manpage date says 1999-06-29 but in fact manpages are from up-to-date lenny/sid. I think Yoshifuji-san's point is not that your manpages

Re: [PATCH]: Can not set the IPV6_PKTINFO option

2007-07-16 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 15:14:06 +0100), Gerrit Renker [EMAIL PROTECTED] says: | That is, someone needs to send a patch to the upstream manpages | maintainer and fix the documentation to actually describe what the | code does. | If it is simply replacing

[**RFC**] [IPV6]: Support RFC3542 IPV6_PKTINFO socket option.

2007-07-16 Thread YOSHIFUJI Hideaki /
Hello. This patch is just a tentative implementation of RFC3542 IPV6_PKTINFO sticky option, and is NOT intended to be applied so far. We need to check if this is okay in RFC POV, anyway. --- [RFC] [IPV6]: Support RFC3542 IPV6_PKTINFO socket option. Signed-off-by: YOSHIFUJI Hideaki [EMAIL

Re: [**RFC**] [IPV6]: Support RFC3542 IPV6_PKTINFO socket option.

2007-07-16 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 16 Jul 2007 11:31:28 -0400), Vlad Yasevich [EMAIL PROTECTED] says: YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. This patch is just a tentative implementation of RFC3542 IPV6_PKTINFO sticky option, and is NOT intended to be applied so far. We need

Re: [PATCH try#5] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-16 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Tue, 17 Jul 2007 00:49:02 +0800), Bryan Wu [EMAIL PROTECTED] says: +static void bf537mac_set_multicast_list(struct net_device *dev) +{ + u32 sysctl; + + if (dev-flags IFF_PROMISC) { + printk(KERN_INFO %s: set to promisc mode\n,

[PATCH] ARM/ETHER3: Handle multicast frames.

2007-07-16 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/drivers/net/arm/ether3.c b/drivers/net/arm/ether3.c index da71350..a7cac69 100644 --- a/drivers/net/arm/ether3.c +++ b/drivers/net/arm/ether3.c @@ -464,7 +464,7 @@ static void ether3_setmulticastlist(struct net_device *dev)

[PATCH] NI5010: Handle multicast frames.

2007-07-16 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/drivers/net/ni5010.c b/drivers/net/ni5010.c index 3d5b423..22a3b3d 100644 --- a/drivers/net/ni5010.c +++ b/drivers/net/ni5010.c @@ -670,14 +670,10 @@ static void ni5010_set_multicast_list(struct net_device *dev)

[PATCH] NS83820: Handle multicast frames.

2007-07-16 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/drivers/net/ns83820.c b/drivers/net/ns83820.c index 104aab3..ea80e6c 100644 --- a/drivers/net/ns83820.c +++ b/drivers/net/ns83820.c @@ -1582,7 +1582,7 @@ static void ns83820_set_multicast(struct net_device *ndev) else

[PATCH] SAA9730: Handle multicast frames.

2007-07-16 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/drivers/net/saa9730.c b/drivers/net/saa9730.c index 451486b..7dae4d4 100644 --- a/drivers/net/saa9730.c +++ b/drivers/net/saa9730.c @@ -940,15 +940,14 @@ static void lan_saa9730_set_multicast(struct net_device *dev)

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 10 Jul 2007 21:11:17 +0300), Remi Denis-Courmont [EMAIL PROTECTED] says: ICMPv6 Router Advertisements may now contain informations that is mostly of interest to userland. This currently mostly consists of recursive DNS server addresses (though one should

[GIT PATCH] Updates for RH0 deprecation.

2007-07-09 Thread YOSHIFUJI Hideaki /
Hello. This is take 2 of updates for deprecating RH0 for linux-2.6.22 (or net-2.6.23). Note: sorry, previous patches introduced a linkage error. Though it is not a good idea to disable RH2, we retain the knob for it so far for backward compatibility. Changesets are available at

Re: [GIT PATCH] Updates for RH0 deprecation.

2007-07-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 09 Jul 2007 14:28:30 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Tue, 10 Jul 2007 02:29:01 +0900 (JST) Changesets are available at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6

Re: [PATCH] Fix handling of IPv6 RH with 0 segments left

2007-07-07 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sat, 7 Jul 2007 17:34:59 +0300), Rémi Denis-Courmont [EMAIL PROTECTED] says: Fix handling of IPv6 Routing Headers with zero segments left. In that case, we should ignore the extension header and continue with the next one, rather than return a Paramater

Re: [PATCH 2.6.22-rc5] TCP: Make TCP_RTO_MAX a variable

2007-06-27 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 25 Jun 2007 22:09:39 +0900 (JST)), OBATA Noboru [EMAIL PROTECTED] says: Please note that this is effective in IPv6 as well. Of course, I'm happy with this. --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] Age Entry For IPv4 Route Table

2007-06-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 25 Jun 2007 10:28:38 +0530), Varun Chandramohan [EMAIL PROTECTED] says: According to the RFC 4292 (IP Forwarding Table MIB) there is a need for an age entry for all the routes in the routing table. The entry in the RFC is inetCidrRouteAge and oid is

[IPV6] NDISC: Fix thinko to control Router Preference support.

2007-06-22 Thread YOSHIFUJI Hideaki /
Bug reported by Haruhito Watanabe [EMAIL PROTECTED]. This is also appropriate for -stable releases. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- net/ipv6/ndisc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index

[PATCH] [IPV6 0/3] Deprecate IPv6 Routing Header Type 0.

2007-06-18 Thread YOSHIFUJI Hideaki /
Hello. I think the IETF community is reaching consensus on deprecation of RH0 (Routing Header Type 0). RH0 is now handled as unknown RH type, e.g, accept it if segleft == 0, or send ICMPv6 Parameter Problem to the sender. [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing.

[PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing.

2007-06-18 Thread YOSHIFUJI Hideaki /
The fix for emerging security threat was overkill and it broke basic semantic of IPv6 routing header processing. We should assume RT0 (or even RT2, depends on configuration) as unknown RH type so that we - silently ignore the routing header if segleft == 0 - send ICMPv6 Parameter Problem message

[PATCH 2/3] [IPV6]: Do not send RH0 anymore.

2007-06-18 Thread YOSHIFUJI Hideaki /
Based on draft-ietf-ipv6-deprecate-rh0-00.txt. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- Documentation/networking/ip-sysctl.txt |3 +- include/linux/ipv6.h |4 +- net/ipv6/datagram.c|3 +- net/ipv6/exthdrs.c |

[PATCH 3/3] [IPV6]: Make IPV6_{RECV,2292}RTHDR boolean options.

2007-06-18 Thread YOSHIFUJI Hideaki /
Because reversing RH0 is no longer supported by deprecation of RH0, let's make IPV6_{RECV,2292}RTHDR boolean options. Boolean are more appropriate from standard POV. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- include/linux/ipv6.h |4 ++-- net/ipv6/ipv6_sockglue.c |8

Re: [PATCH] [IPV6 0/3] Deprecate IPv6 Routing Header Type 0.

2007-06-18 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sun, 17 Jun 2007 23:17:49 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: [PATCH 1/3] [IPV6]: Restore semantics of Routing Header processing. [PATCH 2/3] [IPV6]: Do not send RH0 anymore. [PATCH 3/3] [IPV6]: Make IPV6_{RECV,2292}RTHDR boolean options.

Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-05-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 25 May 2007 15:32:20 +1000), Herbert Xu [EMAIL PROTECTED] says: On Fri, May 25, 2007 at 01:23:23PM +0900, [EMAIL PROTECTED] wrote: diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 1e53520..c9f895f 100644 --- a/include/net/xfrm.h +++

Re: TCP_MD5 and Intel e1000

2007-05-22 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 22 May 2007 10:57:38 +0200), Eric Dumazet [EMAIL PROTECTED] says: I have tried to set up quagga with tcp-md5 support from kernel. All seems ok with a intel e100 NIC, but as i testetd with a intel e1000 NIC the tcp packets have an invalid md5 digest.

[IPV6] ADDRCONF: Fix conflicts in DEVCONF_xxx constant.

2007-05-20 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h index 09ea01a..648bd1f 100644 --- a/include/linux/ipv6.h +++ b/include/linux/ipv6.h @@ -209,9 +209,8 @@ enum { DEVCONF_RTR_PROBE_INTERVAL,

Re: [FIX][PATCH] ipv6 addrconf.c : wrong handling of non-ipv6 hardware since 2.6.21

2007-05-17 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 17 May 2007 18:53:03 +0200), Oliver Hartkopp [EMAIL PROTECTED] says: +static int ipv6_hwtype(struct net_device *dev) +{ +if ((dev-type == ARPHRD_ETHER) || +(dev-type == ARPHRD_LOOPBACK) || +#if defined(CONFIG_IPV6_SIT) ||

[PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread YOSHIFUJI Hideaki /
The fix for emerging security threats was overkill and it broke basic semantic of IPv6 routing header processing. We should assume RT0 (or even RT2, depends on configuration) as unknown RH type so that we - silently ignore the routing header if segleft == 0 - or, send ICMPv6 Parameter Problem

[PATCH net-2.6] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread YOSHIFUJI Hideaki /
The fix for emerging security threats was overkill and it broke basic semantic of IPv6 routing header processing. We should assume RT0 (or even RT2, depends on configuration) as unknown RH type so that we - silently ignore the routing header if segleft == 0, - or, send ICMPv6 Parameter Problem

[PATCH 2.6.16-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread YOSHIFUJI Hideaki /
The fix for emerging security threats was overkill and it broke basic semantic of IPv6 routing header processing. We should assume RT0 as unknown RH type so that we - silently ignore the routing header if segleft == 0 - or, send ICMPv6 Parameter Problem message back to the sender, otherwise.

Re: [PATCH 6/6] [IPV4] SNMP: Display new statistics at /proc/net/snmp

2007-05-11 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sat, 12 May 2007 01:10:04 +0900), Mitsuru Chinen [EMAIL PROTECTED] says: [IPV4] SNMP: Display new statistics at /proc/net/netstat This displays the statistics specified in the updated IP-MIB RFC (RFC4293) in /proc/net/netstat. The reason why these are not

Re: [stable] [PATCH 2.6.21-stable] [IPV6]: Restore semantics of Routing Header processing.

2007-05-11 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 11 May 2007 09:22:43 -0700), Chris Wright [EMAIL PROTECTED] says: * YOSHIFUJI Hideaki / 吉藤英明 ([EMAIL PROTECTED]) wrote: The fix for emerging security threats was overkill and it broke basic semantic of IPv6 routing header processing. We should assume

[IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread YOSHIFUJI Hideaki /
We need to assign rt6i_idev for ip6_{prohibit,blk_hole}_entry as well as we are doing for ip6_null_entry. 2.6.20-stable also needs this. Closes: Bug#8450 Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 452a82c..d1a9827 100644 ---

Re: [IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 09 May 2007 01:13:33 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Wed, 09 May 2007 17:05:50 +0900 (JST) We need to assign rt6i_idev for ip6_{prohibit,blk_hole}_entry as well as we are doing

[PATCH] [IPV6]: Do no rely on skb-dst before it is assigned.

2007-05-09 Thread YOSHIFUJI Hideaki /
Because skb-dst is assigned in ip6_route_input(), it is really bad to use it in hop-by-hop option handler(s). This fix is also needed for -stable. Closes: Bug #8450 (Eric Sesterhenn [EMAIL PROTECTED]) Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] diff --git a/net/ipv6/exthdrs.c

[IPV6] ROUTE: Assign rt6i_idev for ip6_{prohibit,blk_hole}_entry.

2007-05-09 Thread YOSHIFUJI Hideaki /
I think this is less critical, but is also suitable for -stable release. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 452a82c..d1a9827 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -4060,6 +4060,10 @@ int __init

Re: many sockets, slow sendto

2007-04-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 30 Apr 2007 00:26:43 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Eric, I've applied this, thanks again. Could I trouble you to cook up an ipv6 version of this patch? Here's my tentative version.

Re: [RFC, PATCH] IPV6 : add 64 bits components in struct in6_addr to speedup ipv6_addr_equal() ipv6_addr_any()

2007-04-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 30 Apr 2007 16:28:51 +0200), Eric Dumazet [EMAIL PROTECTED] says: On 64bit arches, we can speedup some IPV6 addresses compares, using 64 bits fields in struct in6_addr. I am not sure if this patch wont break some user ABI, maybe we should use some

Re: many sockets, slow sendto

2007-04-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 30 Apr 2007 14:47:15 +0200), Eric Dumazet [EMAIL PROTECTED] says: Also, I am not sure we need to use all 128 bits of IPV6 address, maybe the 64 low order bits are enough ? Well, maybe, but in IPv6, auto-configured addresses on an interface have the same

udp hash change and ipv6

2007-04-30 Thread YOSHIFUJI Hideaki /
Dave, Because I do not have enough time before depature to Lima via LAX, I cannot send a full fix for this, but anyway... In net-2.6, __udp_lib_get_port() touches inet_sk(sk)-rcv_saddr, which will break ipv6, I think. We probably need to add a extra function pointer to check is sk has wildcard

Re: IPV6 source routing patch is still broken?

2007-04-27 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 27 Apr 2007 02:08:05 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: then the function proceeds to use the largest of 'accept_source_route' and 'idev-cnf.accept_source_route' for further checks. Smallest: if (accept_source_route

Re: IPV6 source routing patch is still broken?

2007-04-26 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 26 Apr 2007 19:10:56 -0400), Chuck Ebbert [EMAIL PROTECTED] says: Another question: is it a good idea to even be shipping release kernels with Mobile IPV6 enabled? Unfortunately, experimental isn't enough to go by... Well, we have still 2 missing pieces

[GIT PATCH] [net-2.6.22] IPv6, IPv4 Updates

2007-04-25 Thread YOSHIFUJI Hideaki /
Dave, Please consider pulling following commits available on net-2.6.22-20070425a-inet6-cleanup-20070425 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git. HEADLINES - [IPV6] SIT: Unify code path to get hash array index. [IPV4] IPIP: Unify

[net-2.6.22] [TCP]: Fix linkage errors.

2007-04-24 Thread YOSHIFUJI Hideaki /
Recent ktime_t changes had introduced linkage errors. | WARNING: __divdi3 [net/ipv4/tcp_veno.ko] undefined! | WARNING: __divdi3 [net/ipv4/tcp_vegas.ko] undefined! | WARNING: __divdi3 [net/ipv4/tcp_lp.ko] undefined! | WARNING: __divdi3 [net/ipv4/tcp_illinois.ko] undefined! Signed-off-by:

Re: [net-2.6.22] [TCP]: Fix linkage errors.

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 17:53:24 +0200), Adrian Bunk [EMAIL PROTECTED] says: On Wed, Apr 25, 2007 at 12:17:43AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Recent ktime_t changes had introduced linkage errors. | WARNING: __divdi3 [net/ipv4/tcp_veno.ko] undefined

Re: [net-2.6.22] [TCP]: Fix linkage errors.

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 00:58:45 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 17:53:24 +0200), Adrian Bunk [EMAIL PROTECTED] says: On Wed, Apr 25, 2007 at 12:17:43AM +0900, YOSHIFUJI Hideaki / 吉藤

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 24 Apr 2007 10:04:20 -0700), Stephen Hemminger [EMAIL PROTECTED] says: Yoshifuji-san had the right idea, but ktime_to_us needs to be defined in a way that works on both 64 and 32bit platforms. No, this does not cure. +#define ktime_to_us(kt)

Re: [PATCH] Fix build errors on 32bit platforms with new ktime

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 00:15:15 +0200), Thomas Gleixner [EMAIL PROTECTED] says: On Tue, 2007-04-24 at 14:57 -0700, Stephen Hemminger wrote: On Wed, 25 Apr 2007 06:55:39 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: In article [EMAIL

Re: [net-2.6.22] [IPV4]: Fix build without procfs.

2007-04-24 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 12:35:49 +1000), Herbert Xu [EMAIL PROTECTED] says: This makes no sense. Why should we include all these proc operations when PROC_FS is turned off? How about this as a fix (on top of the above patch): [IPV4]: Move snmp_mib_init

Re: [1/2] [IPV4]: Consolidate common SNMP code

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:04:09 +1000), Herbert Xu [EMAIL PROTECTED] says: [IPV4]: Consolidate common SNMP code Signed-off-by: Herbert Xu [EMAIL PROTECTED] Acked-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --yoshfuji - To unsubscribe from this list: send the line

Re: [2/2] [IPV6]: Consolidate common SNMP code

2007-04-24 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 25 Apr 2007 14:06:37 +1000), Herbert Xu [EMAIL PROTECTED] says: Hi: [IPV6]: Consolidate common SNMP code This patch moves the non-proc SNMP code into addrconf.c and reuses IPv4 SNMP code where applicable. : Signed-off-by: Herbert Xu [EMAIL

[GIT PATCH]

2007-04-19 Thread YOSHIFUJI Hideaki /
Hello. Please consider pulling following changesets for supporting exporting stats information via netlink, on top of net-2.6.22. Statistics values are exported as u64. Correspoinding draft patch for iproute2 can be found at

[GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-19 Thread YOSHIFUJI Hideaki /
Hello. (Sorry for resending..., I failed to put an appropriate subject line...) Please consider pulling following changesets for supporting exporting stats information via netlink, on top of net-2.6.22. Statistics values are exported as u64. Correspoinding draft patch for iproute2 can be found

[RFC] [GIT PATCH net-2.6.23] IPV6: Configurable IPv6 address selection policy table (RFC3484)

2007-04-19 Thread YOSHIFUJI Hideaki /
Hello. This is RFC(*) for supporting configurable IPv6 address selection policy table, which is described in RFC3484. Corresponding userspace tool is available at http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=/gitroot/ip6aspctl.git;a=summary. We store labels only in kernel, and leave

Re: [GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-19 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 19 Apr 2007 10:44:12 +0200), Thomas Graf [EMAIL PROTECTED] says: * YOSHIFUJI Hideaki [EMAIL PROTECTED] 2007-04-19 15:42 Please consider pulling following changesets for supporting exporting stats information via netlink, on top of net-2.6.22. The

Re: [GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-19 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 19 Apr 2007 17:58:55 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: In article [EMAIL PROTECTED] (at Thu, 19 Apr 2007 10:44:12 +0200), Thomas Graf [EMAIL PROTECTED] says: * YOSHIFUJI Hideaki [EMAIL PROTECTED] 2007-04-19 15:42

Re: [GIT PATCH] Exporting IPv6 statistics via netlink.

2007-04-19 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 19 Apr 2007 13:24:12 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 21:04:54 +0900 (JST) net-2.6.22-20070417-stats-20070419 I tried to pull this but I killed it before

[PATCH] KEY: Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx.

2007-04-17 Thread YOSHIFUJI Hideaki /
From: Kazunori MIYAZAWA [EMAIL PROTECTED] Subject: [PATCH] KEY: Fix conversion between IPSEC_MODE_xxx and XFRM_MODE_xxx. We should not blindly convert between IPSEC_MODE_xxx and XFRM_MODE_xxx just by incrementing / decrementing because the assumption is not true any longer. Signed-off-by:

[PATCH] [IPV6] SNMP: Fix {In,Out}NoRoutes statistics.

2007-04-13 Thread YOSHIFUJI Hideaki /
A packet which is being discarded because of no routes in the forwarding path should not be counted as OutNoRoutes but as InNoRoutes. Additionally, on this occasion, a packet whose destinaion is not valid should be counted as InAddrErrors separately. Based on patch from Mitsuru Chinen [EMAIL

Re: [PATCH 0/2] [iputils] MTU discovery changes

2007-04-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 23 Mar 2007 20:46:25 -0400), John Heffner [EMAIL PROTECTED] says: These add some changes that make tracepath a little more useful for diagnosing MTU issues. The length flag helps distinguish between MTU black holes and other types of black holes by

Re: [PATCH] [iputils] Add documentation for the -l flag.

2007-04-08 Thread YOSHIFUJI Hideaki /
Applied two documentation patches. Thanks. In article [EMAIL PROTECTED] (at Tue, 3 Apr 2007 13:51:07 -0400), John Heffner [EMAIL PROTECTED] says: --- doc/tracepath.sgml | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/doc/tracepath.sgml

Re: [PATCH 1/2] [iputils] Fix asymm messages.

2007-04-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 3 Apr 2007 14:20:34 -0400), John Heffner [EMAIL PROTECTED] says: We should only print the asymm messages in tracepath/6 when you receive a TTL expired message, because this is the only time when we'd expect the same number of hops back as our TTL was set

Re: [PATCH 2/2] [iputils] Re-probe at same TTL after MTU reduction.

2007-04-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 3 Apr 2007 14:20:35 -0400), John Heffner [EMAIL PROTECTED] says: This fixes a bug that would miss a hop after an ICMP packet too big message, since it would continue increase the TTL without probing again. Applied, thanks. --yoshfuji - To unsubscribe

Re: [PATCH 1/4] [IPv6] Add link and site-local scope inline

2007-04-06 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 06 Apr 2007 02:37:52 -0400), Brian Haley [EMAIL PROTECTED] says: static inline int ipv6_addr_scope_linklocal(const struct in6_addr *a) { return ((a-s6_addr32[0] htonl(0xFFC0)) == htonl(0xFE80) || ((a-s6_addr32[0] htonl(0xFF00)) ==

Re: ping6 to own link-local address

2007-04-06 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 28 Mar 2007 01:45:33 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: [IPV6] ROUTE: Do not route packets to link-local address on other device.

Re: [PATCH net-2.6.22 TAKE 2] [IPV6] FIB6RULE: Find source address during looking up route.

2007-04-06 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 28 Mar 2007 13:08:08 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: When looking up route for destination with rules with source address restrictions, we may need to find a source address for the traffic if not given. Based on patch

Re: [PATCH 1/4] [IPv6] Add link and site-local scope inline

2007-04-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 05 Apr 2007 23:21:05 -0400), Brian Haley [EMAIL PROTECTED] says: Add link and site-local scope inline to avoid calls to ipv6_addr_type(). I disagree. Multicast scopes should also be handled appropriately. --yoshfuji - To unsubscribe from this list:

Re: [PATCH 2/4] [IPv6] Add multicast address type inline

2007-04-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 05 Apr 2007 23:21:16 -0400), Brian Haley [EMAIL PROTECTED] says: Add multicast address type inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley [EMAIL PROTECTED] --- include/net/ipv6.h|5 + net/ipv6/icmp.c | 12

Re: [PATCH 3/4] Add mapped address type inline

2007-04-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 05 Apr 2007 23:21:25 -0400), Brian Haley [EMAIL PROTECTED] says: Add mapped address type inline to avoid calls to ipv6_addr_type(). Signed-off-by: Brian Haley [EMAIL PROTECTED] --- include/net/ipv6.h |6 ++ net/ipv6/ip6_flowlabel.c |

<    1   2   3   4   5   >