Re: [PATCH 4/4] Add loopback address type inline

2007-04-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 05 Apr 2007 23:21:33 -0400), Brian Haley [EMAIL PROTECTED] says: Add loopback address type inline to avoid calls to ipv6_addr_type(). diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index f6aa338..7f1aabe 100644 --- a/net/ipv6/ip6_output.c

Re: [PATCH] [IPv6] Exclude truncated packets from InHdrErrors statistics

2007-04-04 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 3 Apr 2007 15:55:51 +0900), Mitsuru Chinen [EMAIL PROTECTED] says: Incoming trancated packets are counted as not only InTruncatedPkts but also InHdrErrors. They should be counted as InTruncatedPkts only. Signed-off-by: Mitsuru Chinen [EMAIL PROTECTED]

Re: [PATCH][IPv6]: Fix incorrect length check in rawv6_sendmsg()

2007-03-29 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 29 Mar 2007 14:26:44 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: From: Sridhar Samudrala [EMAIL PROTECTED] Date: Thu, 29 Mar 2007 14:17:28 -0700 The check for length in rawv6_sendmsg() is incorrect. As len is an unsigned int, (len 0) will

Re: ping6 to own link-local address

2007-03-28 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Mar 2007 00:26:09 +0100 (CET)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: In article [EMAIL PROTECTED] (at Tue, 20 Mar 2007 15:16:40 -0700), Sridhar Samudrala [EMAIL PROTECTED] says: On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英

Re: [PATCH]: Fix ipv6 round-robin locking

2007-03-28 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Sat, 24 Mar 2007 12:44:36 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: The fix for the most serious of them is below, and I'd appreciate any feedback if people spot any problems or holes in that approach. I hoped we could save some memory per

Re: IPv6: Connection reset/timeout under heavy load

2007-03-28 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 28 Mar 2007 10:48:27 +0200), Agoston Horvath [EMAIL PROTECTED] says: YOSHIFUJI Hideaki / 吉藤英明 wrote: Would you test with latest kernel, if possible, please? For the archive: switching to 2.6.20.4 fixed this problem. Thank you for your report. I guess

Re: IPv6: Connection reset/timeout under heavy load

2007-03-28 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 28 Mar 2007 02:26:24 -0700 (PDT)), David Miller [EMAIL PROTECTED] says: http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot/yoshfuji/linux-2.6-fix.git;a=commit;h=33a79bba0cc2f197b46cc54182f94c31ff6ad334 I hope this patch will go in 2.6.16-stable...

Re: IPv6: Connection reset/timeout under heavy load

2007-03-27 Thread YOSHIFUJI Hideaki /
Hello. (CC: netdev added.) In article [EMAIL PROTECTED] (at Tue, 27 Mar 2007 11:45:46 +0200), Agoston Horvath [EMAIL PROTECTED] says: I'm using kernel 2.6.16.29, libc is 2.3.2.ds1-22sarge5. However, same result was achieved using kernel version 2.6.13 on the same box. I'm out of further

[PATCH net-2.6.22] [IPV6] FIB6RULE: Find source address during looking up route.

2007-03-27 Thread YOSHIFUJI Hideaki /
When looking up route for destination with rules with source address restrictions, we may need to find a source address for the traffic if not given. Based on patch from Noriaki TAKAMIYA [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- include/linux/fib_rules.h |7

Re: [PATCH net-2.6.22] [IPV6] FIB6RULE: Find source address during looking up route.

2007-03-27 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 27 Mar 2007 16:25:19 +0200), Thomas Graf [EMAIL PROTECTED] says: * YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2007-03-27 22:45 When looking up route for destination with rules with source address restrictions, we may need to find a source

[PATCH net-2.6.22 TAKE 2] [IPV6] FIB6RULE: Find source address during looking up route.

2007-03-27 Thread YOSHIFUJI Hideaki /
When looking up route for destination with rules with source address restrictions, we may need to find a source address for the traffic if not given. Based on patch from Noriaki TAKAMIYA [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- include/linux/fib_rules.h | 11

Re: 2.6.20.3-rc1 / iproute2 hoplimit 2^32-1 vs 2^8-1

2007-03-20 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 20 Mar 2007 10:27:51 +0200 (EET)), Pekka Savola [EMAIL PROTECTED] says: On Mon, 19 Mar 2007, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 19 Mar 2007 16:27:29 +0100 Mhh actually this looks intentional: icmpv6_send and

ping6 to own link-local address

2007-03-20 Thread YOSHIFUJI Hideaki /
Hello. Recent 2.6.21-git kernels do not respond to ping6 queries to our own (local) link-local address. Now bisecting... --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: ping6 to own link-local address

2007-03-20 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 20 Mar 2007 15:16:40 -0700), Sridhar Samudrala [EMAIL PROTECTED] says: On Tue, 2007-03-20 at 10:19 +0100, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. Recent 2.6.21-git kernels do not respond to ping6 queries to our own (local) link-local address. Now

Re: [PATCH 10/12] [IPv6]: Use rtnl registration interface

2007-03-20 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Mar 2007 01:06:03 +0100), Thomas Graf [EMAIL PROTECTED] says: -static int -inet6_rtm_deladdr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) +static int nl_addr_del(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) { struct ifaddrmsg

Re: Fix for ipv6_setsockopt NULL dereference

2007-03-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 9 Mar 2007 15:15:54 +0100), Olaf Kirch [EMAIL PROTECTED] says: I came across this bug in http://bugzilla.kernel.org/show_bug.cgi?id=8155 : Fix NULL pointer derefence in ipv6_setsockopt, as described in bug #8155. Signed-off-by: [EMAIL PROTECTED]

Re: [PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 09 Mar 2007 16:15:06 -0800 (PST)), David Miller [EMAIL PROTECTED] says: on arch's that don't protect 0 copy_to_user like i386 does). Here's a simple fix ontop of yoshifuji's two changes. Hope that's it ;-) copy_to_user() will check it, actually, it

Re: IPV6: make ipv6_getsockopt_sticky honor user's buffer size

2007-03-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 08 Mar 2007 14:38:04 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: Chris Wright [EMAIL PROTECTED] Date: Wed, 7 Mar 2007 23:10:48 -0800 Make sure not to copy_to_user more than user's buffer can handle (we already checked the min, just use

[PATCH 1/2] [IPV6]: Return correct result for sticky options.

2007-03-08 Thread YOSHIFUJI Hideaki /
We returned incorrect result with IPV6_RTHDRDSTOPTS, IPV6_RTHDR and IPV6_DSTOPTS. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- net/ipv6/ipv6_sockglue.c | 27 +++ 1 files changed, 23 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c

[PATCH 2/2] [IPV6]: Ensure to truncate result and return full length for sticky options.

2007-03-08 Thread YOSHIFUJI Hideaki /
Bug noticed by Chris Wright [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- net/ipv6/ipv6_sockglue.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 44ccdf0..6ad8921 100644 ---

Re: IPv6 Davelopment Tree

2007-03-06 Thread YOSHIFUJI Hideaki /
Dave, In article [EMAIL PROTECTED] (at Tue, 06 Mar 2007 13:36:11 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 23 Feb 2007 12:53:01 +0900 (JST) I have cooked up new git tree for IPv6 development. It is available as branch named

[ATM] ENI: Convert to struct timeval to ktime_t.

2007-03-06 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 8fccf01..0d3a38b 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -536,7 +536,7 @@ static int rx_aal0(struct atm_vcc *vcc) return 0; }

[NET]: Use {htons,htonl,cpu_to_le16}() where appropriate.

2007-03-06 Thread YOSHIFUJI Hideaki /
Dave, Please consider pulling following changesets from the net-2.6.22-20070307a-byteorder-20070307 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git. Thank you. HEADLINES - [NET] 802: Use hton{s,l}() where appropriate. [NET] 8021Q: Use htons() where

[GIT PATCH (TAKE 2)] [NET]: Use {htons,htonl,cpu_to_le16}() where appropriate.

2007-03-06 Thread YOSHIFUJI Hideaki /
Dave, In article [EMAIL PROTECTED] (at Wed, 07 Mar 2007 14:58:07 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] says: Please consider pulling following changesets from the net-2.6.22-20070307a-byteorder-20070307 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git

[PATCH] NETLINK: convert NLMSG_GOODSIZE to constant expression.

2007-03-06 Thread YOSHIFUJI Hideaki /
This fixes the following error: : | CC [M] net/ipv4/netfilter/ipt_ULOG.o |net/ipv4/netfilter/ipt_ULOG.c:82: error: braced-group within expression allowed only inside a function |net/ipv4/netfilter/ipt_ULOG.c:82: error: syntax error before void |make[1]: *** [net/ipv4/netfilter/ipt_ULOG.o] Error

[PATCH] [USBNET] DM9501: Add Corega FEther USB-TXC support.

2007-02-28 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- drivers/usb/net/dm9601.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/usb/net/dm9601.c b/drivers/usb/net/dm9601.c index 4a932e1..c0bc52b 100644 --- a/drivers/usb/net/dm9601.c +++

[PATCH (RESEND)] [USBNET] DM9601: Add Corega FEther USB-TXC support.

2007-02-28 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- drivers/usb/net/dm9601.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/usb/net/dm9601.c b/drivers/usb/net/dm9601.c index 4a932e1..c0bc52b 100644 --- a/drivers/usb/net/dm9601.c +++

Re: [GIT PULL] IPv6 Updates for 2.6.21-rc1

2007-02-22 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 22 Feb 2007 00:12:45 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Thu, 22 Feb 2007 16:48:52 +0900 (JST) I think it's time to distribute all EXPORT_SYMBOL things in ipv6_syms.c to each file

Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

2007-02-22 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 22 Feb 2007 03:59:25 -0800), [EMAIL PROTECTED] says: From: Divy Le Ray [EMAIL PROTECTED] Clean up some private ioctls. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_ioctl.h | 21 -

Re: [PATCH 2/7] cxgb3 - private ioctl cleanup

2007-02-22 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 22 Feb 2007 04:34:34 -0800), Divy Le Ray [EMAIL PROTECTED] says: 1. Please do do change the values. 2. Explain why you are going to kill these ioctls. Jeff and Arjan have required that most of these ioctls go. Please read:

IPv6 Davelopment Tree

2007-02-22 Thread YOSHIFUJI Hideaki /
Hello. I have cooked up new git tree for IPv6 development. It is available as branch named 2.6.21-rc1-net-2.6-20070223-FOR_DAVEM-20070223 at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git. I will shift to new branch time to time (e.g. every -rc releases) in order to

Re: [GIT PULL] IPv6 Updates

2007-02-21 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 20 Feb 2007 23:15:45 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Thu, 15 Feb 2007 02:35:14 +0900 (JST) Please consider pulling the following changesets available on the

Re: [GIT PULL] IPv6 Updates

2007-02-21 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 00:06:13 -0800 (PST)), David Miller [EMAIL PROTECTED] says: Since this technically fixes a major usability bug, I'm happy to apply this with the ipv6 side for 2.6.21 It is up to Yoshifuji how to handle this. He can either add this patch to

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-21 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 00:02:22 -0800 (PST)), David Miller [EMAIL PROTECTED] says: So, I think it is ready. Here's my sign-off: Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] Neil, please keep this patch ready for the next merge window. Dave, Neil, I

[GIT PULL] IPv6 Updates for 2.6.21-rc1

2007-02-21 Thread YOSHIFUJI Hideaki /
Hello. Here's several fixes on top of 2.6.21-rc1. Changesets are available on the 2.6.21-rc1-inet6-20070222 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-fix.git. Regards, --- HEADLINES - [IPV6] ADDRCONF: Statically link __ipv6_addr_type() for

Re: [GIT PULL] IPv6 Updates for 2.6.21-rc1

2007-02-21 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 22:24:00 -0800 (PST)), David Miller [EMAIL PROTECTED] says: File net/ipv6/addrconf_core.c is still missing even in this updated pull, please fix this. I ran: git pull git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-fix.git

Re: [GIT PULL] IPv6 Updates for 2.6.21-rc1

2007-02-21 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 23:27:35 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: David Miller [EMAIL PROTECTED] Date: Wed, 21 Feb 2007 23:23:06 -0800 (PST) From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] Date: Thu, 22 Feb 2007 16:05:15 +0900 (JST

[GIT PULL] IPv6 Updates

2007-02-14 Thread YOSHIFUJI Hideaki /
Dave, Please consider pulling the following changesets available on the 2.6.20-net-2.6-20070214-FOR_DAVEM branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git (on top of commit 928ba4169dc1d82c83105831f5ddb5472379b440). Thank you. HEADLINES - [IPV6]

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-13 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 13 Feb 2007 15:45:15 -0500), Neil Horman [EMAIL PROTECTED] says: Signed-off-by: Neil Horman [EMAIL PROTECTED] I'm starting regression tests now. --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: Missing csum_fold() in ip6t_HL.c ?

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 15 Sep 2006 14:37:56 +0400), Alexey Dobriyan [EMAIL PROTECTED] says: It looks like diffs array is write-only. It also looks like ipv4 occurences use some csum_fold() trickery. Was is forgotten here? Should diffs be removed? Since we do not have checksum

Re: Missing csum_fold() in ip6t_HL.c ?

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 15:52:13 +0100), Patrick McHardy [EMAIL PROTECTED] says: This already is taken care of. I noticed our listmaster didn't approve any held messages for a couple of month and am currently going through the backlog (Alexey's mail is quite old).

[PATCH] [XFRM] AUDIT: Fix audit buffer leakage in error path.

2007-02-12 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index b7e537f..af85ac9 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c @@ -1999,7 +1999,7 @@ void xfrm_audit_log(uid_t auid, u32 sid, int type, int result,

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 8 Feb 2007 08:07:15 -0500), Neil Horman [EMAIL PROTECTED] says: I still have a question. Now, who will install the kernel route for the incoming packet? Can we get packet for our unicast address during optimistic DAD period? Not sure what you're

Re: [PATCH] [XFRM] AUDIT: Fix audit buffer leakage in error path.

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 15:23:17 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 13 Feb 2007 00:34:29 +0900 (JST) Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] Oh yes. I noticed this too while

[PATCH 2.6.20.y net-2.6] [IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index.

2007-02-12 Thread YOSHIFUJI Hideaki /
Tetsuo Handa [EMAIL PROTECTED] told me that connect(2) with TCPv6 socket almost always took a few minutes to return when we did not have any ports available in the range of net.ipv4.ip_local_port_range. The reason was that we used incorrect seed for calculating index of hash when we check

[PATCH 2.6.16.y] [IPV6] HASHTABLES: Use appropriate seed for caluculating ehash index.

2007-02-12 Thread YOSHIFUJI Hideaki /
Tetsuo Handa [EMAIL PROTECTED] told me that connect(2) with TCPv6 socket almost always took a few minutes to return when we did not have any ports available in the range of net.ipv4.ip_local_port_range. The reason was that we used incorrect seed for calculating index of hash when we check

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton [EMAIL PROTECTED] says: On Mon, 12 Feb 2007 20:10:13 -0500 (EST) Pete Clements [EMAIL PROTECTED] wrote: 2.6.20-git8 fails compile: CHK include/linux/compile.h UPD include/linux/compile.h

Re: 2.6.20-git8 fails compile -- net/built-in.o __ipv6_addr_type

2007-02-12 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 21:35:59 -0500 (EST)), Pete Clements [EMAIL PROTECTED] says: Quoting YOSHIFUJIHideaki/=?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= In article [EMAIL PROTECTED] (at Mon, 12 Feb 2007 18:12:16 -0800), Andrew Morton [EMAIL PROTECTED] says:

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 09 Feb 2007 10:31:34 +), David Howells [EMAIL PROTECTED] says: YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: This sockaddr_rxrpc{} should NOT include sockaddr_in{} directly. Please use sockaddr_storage{} (or sockaddr{}, maybe), and make it sure to

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-09 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 09 Feb 2007 12:31:23 +), David Howells [EMAIL PROTECTED] says: YOSHIFUJI Hideaki [EMAIL PROTECTED] wrote: and make it sure to align on 64-bit word. The first part of sockaddr_rxrpc is exactly 64 bits; then comes the transport address, so that's

[NET]: Fix whitespace errors

2007-02-09 Thread YOSHIFUJI Hideaki /
Hello. Please pull 2.6.20-net-2.6-20070209-whitespace branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove whitespace at the end of line. under net. Tree is on top of current

Re: [NET]: Fix whitespace errors

2007-02-09 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Fri, 9 Feb 2007 09:47:27 -0600), Kumar Gala [EMAIL PROTECTED] says: to fix trivial whitespace errors: - convert leading sequences of whitespace with tab(s). - remove whitespace at the end of line. under net. Tree is on top of current net-2.6

Re: [PATCH][IPSEC][0/6] fix conflict of device tunnels with the ipsec tunnel

2007-02-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 8 Feb 2007 17:03:24 +0900), Kazunori MIYAZAWA [EMAIL PROTECTED] says: We need this to use ipcomp with inter address family tunnel. [1/6] extending xfrm4_tunnel utility to support inter address family for sit [2/6] extending xfrm6_tunnel utility to

Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

2007-02-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 08 Feb 2007 16:32:11 +), David Howells [EMAIL PROTECTED] says: (2) A local address can optionally be bound: struct sockaddr_rxrpc srx = { .srx_family = AF_RXRPC, .srx_service= 0, /* we're a client */

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 8 Feb 2007 11:41:52 -0500), Neil Horman [EMAIL PROTECTED] says: diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 7b7bd44..07a5f4d 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -859,6 +859,40 @@ static int

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-07 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 7 Feb 2007 15:55:03 -0500), Neil Horman [EMAIL PROTECTED] says: diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 7b7bd44..8a1ea96 100644 --- a/net/ipv6/ip6_output.c +++ b/net/ipv6/ip6_output.c @@ -859,6 +859,34 @@ static int

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-07 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 7 Feb 2007 15:55:03 -0500), Neil Horman [EMAIL PROTECTED] says: @@ -559,7 +562,7 @@ void ndisc_send_ns(struct net_device *dev, struct neighbour *neigh, return; len = sizeof(struct icmp6hdr) + sizeof(struct in6_addr); -

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-02-06 Thread YOSHIFUJI Hideaki /
Dave, AFAIK, we have not heard objectsions and I finally agree on this. Please apply. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --yoshfuji In article [EMAIL PROTECTED] (at Wed, 3 Jan 2007 18:57:48 +0900), Masahide NAKAMURA [EMAIL PROTECTED] says: Add checksum default defines for

[IPROUTE2] tc build failure and netfilter headers.

2007-02-06 Thread YOSHIFUJI Hideaki /
Stephen, I think we should include include/linux/netfilter/{x_tables.h,xt_tcpudp.h} in iproute2 distribution to avoid compilation failure of tc. Regards, --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Mon, 5 Feb 2007 15:56:51 -0500), Neil Horman [EMAIL PROTECTED] says: if (ifp == NULL valid_lft) { int max_addresses = in6_dev-cnf.max_addresses; + u32 addr_flags = 0; + +#ifdef

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-02-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 05 Feb 2007 17:32:58 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 06 Feb 2007 10:24:05 +0900 (JST) @@ -498,7 +500,8 @@ static void ndisc_send_na(struct net_device *dev, struct neighbour

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 30 Jan 2007 16:55:12 +0900), Wei Dong [EMAIL PROTECTED] says: Hello, Mr yoshfuji Take ping6 for example. Asumming there is a router which has 2 NICs. eth0 on router has ipv6 addr fe80::20c:29ff:fe24:fa0a, eth1 on router has ipv6 addr

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 30 Jan 2007 08:02:08 -0500), Neil Horman [EMAIL PROTECTED] says: I do not think we should copy neighbor information from (one of) default routers, but use temporary neigh entry (or neigh in new state) for such datagrams in stead. We should aware that:

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 09:57:12 -0500), weidong [EMAIL PROTECTED] says: The following is the figure. : Host eth0: fe80::200:ff:fe00:100 Router eth0: fe80::20c:29ff:fe24:fa0a Router eth1: fe80::20c:29ff:fe24:fa14 Other network | | eth1 +++ |

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 23:51:45 -0500), weidong [EMAIL PROTECTED] says: Thanks for your patch. I think maybe we checking oif first is better, and WARN_ON in function rt6_score_route(). Please remove WARN_ON. Otherwise, I'm fine with it. --yoshfuji - To

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-29 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Mon, 29 Jan 2007 16:30:13 -0500), Neil Horman [EMAIL PROTECTED] says: Quick reality check here. In thinking about how best to go about this redirection of frames to the default router, based on Dave M.s input, I think that the best solution would be in

Re: [Patch][IPv6] Fix wrong routing mechanism for Link Local IPv6 packets

2007-01-29 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Wed, 21 Feb 2007 02:24:26 -0500), weidong [EMAIL PROTECTED] says: eth0: fe80::20c:29ff:fe24:fa0a | eth1: fe80::20c:29ff:fe24:fa14 | |

[USBNET] ASIX: Add IO-DATA ETG-US2 Support.

2007-01-26 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- drivers/usb/net/asix.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/usb/net/asix.c b/drivers/usb/net/asix.c index 896449f..4206df2 100644 --- a/drivers/usb/net/asix.c +++ b/drivers/usb/net/asix.c @@

[USBNET] PEGASUS: Fix typo in Corega products.

2007-01-26 Thread YOSHIFUJI Hideaki /
s/FEter/FEther/. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] --- drivers/usb/net/pegasus.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/net/pegasus.h b/drivers/usb/net/pegasus.h index 98f6898..c746782 100644 --- a/drivers/usb/net/pegasus.h +++

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-26 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 26 Jan 2007 09:27:30 -0500), Neil Horman [EMAIL PROTECTED] says: I'm looking for it at the moment, but I too had assumed that redirecting the outgoing packet to the default router would happen automatically within the routing code as a result of not

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-25 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 25 Jan 2007 14:45:00 -0500), Neil Horman [EMAIL PROTECTED] says: diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2a7e461..46f91ee 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -830,7 +830,8 @@ retry: ift =

Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

2007-01-23 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 24 Jan 2007 15:31:47 +1100), Herbert Xu [EMAIL PROTECTED] says: Masayuki Nakagawa [EMAIL PROTECTED] wrote: I suggest to use kfree_skb() instead of __kfree_skb(). I agree. In fact please do it for all paths in that function, i.e., just change

Re: [IPV6] RAW: Add checksum default defines for MH.

2007-01-23 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 24 Jan 2007 17:56:23 +1100), Herbert Xu [EMAIL PROTECTED] says: David Miller [EMAIL PROTECTED] wrote: Did a complete agreement occur that this patch is ok? My only concern is that we're putting an arbitrary list of protocols in the generic raw.c.

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Mon, 22 Jan 2007 13:15:28 -0500), Neil Horman [EMAIL PROTECTED] says: Reposted patch, with your suggestions/corrections incorporated. The only thing I left alone was your last comment regarding the checking of saddr for being a unicast address.

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-19 Thread YOSHIFUJI Hideaki /
Hello. In article [EMAIL PROTECTED] (at Fri, 19 Jan 2007 16:23:14 -0500), Neil Horman [EMAIL PROTECTED] says: Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection). In Good work. We will see if this would break core and basic ipv6 code. Dave, please hold on. Some quick

Re: [PATCH 0/12] L2 network namespace (v3)

2007-01-18 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 17 Jan 2007 18:51:14 +0300), Dmitry Mishin [EMAIL PROTECTED] says: === L2 network namespaces The most straightforward concept of network virtualization is complete separation of namespaces, covering device list, routing

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-18 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 19 Jan 2007 01:31:08 +0900 (JST)), Noriaki TAKAMIYA [EMAIL PROTECTED] says: Wed, 17 Jan 2007 13:33:22 +0100 [Subject: Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().] Patrick McHardy [EMAIL PROTECTED] wrote...

Re: [patch]IPv6: fix BUG of ndisc_send_redirect()

2007-01-14 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sat, 13 Jan 2007 17:12:40 +0800), Li Yewang [EMAIL PROTECTED] says: When I tested IPv6 redirect function about kernel 2.6.19.1, and found that the kernel can send redirect packets whose target address is global address, and the target is not the actual

[PATCH] [IPV6] MCAST: Fix joining all-node multicast group on device initialization.

2007-01-14 Thread YOSHIFUJI Hideaki /
[IPV6] MCAST: Fix joining all-node multicast group on device initialization. Join all-node multicast group after assignment of dev-ip6_ptr because it must be assigned when ipv6_dev_mc_inc() is called. This fixes Bug#7817, reported by [EMAIL PROTECTED]. Closes: 7817 Signed-off-by: YOSHIFUJI

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 4 Jan 2007 14:23:30 +0200), Craig Schlenter [EMAIL PROTECTED] says: On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: Hi, I made a patch below. With this patch, the ftp-transfer-stop problem does not happen. Therefore, I think this is not a

Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki /
Dave, please apply. Thank you. In article [EMAIL PROTECTED] (at Tue, 9 Jan 2007 07:11:39 +0200), Craig Schlenter [EMAIL PROTECTED] says: All credit goes to Komuro [EMAIL PROTECTED] for tracking this down. The patch is untested but it looks *cough* obviously correct. Signed-off-by: Craig

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-30 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sat, 30 Dec 2006 20:59:31 +0900), Komuro [EMAIL PROTECTED] says: Do you see similar issue with other simple application? sorry, I don't reproduce this problem on other application. Can you reproduce it with other ftp client and/or server? Anyway...

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2006-12-29 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Sat, 30 Dec 2006 18:50:43 +0900), Komuro [EMAIL PROTECTED] says: I investigated the ftp-file-transfer-stop problem by git-bisect method, and found this problem was introduced by [TCP]: MD5 Signature Option (RFC2385) support patch. Mr.YOSHIFUJI san, please

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-26 Thread YOSHIFUJI Hideaki /
Happy Holidays! In article [EMAIL PROTECTED] (at Sun, 10 Dec 2006 22:50:55 -0800 (PST)), David Miller [EMAIL PROTECTED] says: From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 05 Dec 2006 20:02:42 +0900 (JST) In article [EMAIL PROTECTED] (at Tue, 5 Dec 2006 19:03:27 +0900),

Re: [patch] use socklen_t in iputils rather than just int

2006-12-20 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 20 Dec 2006 10:00:32 -0500), Mike Frysinger [EMAIL PROTECTED] says: a bunch of places in iputils utilize int lengths when in reality they should be using socklen_t Patch applied. Thanks. Please add some prefix in subject, please; e.g. Subject:

Re: [patch] handle pktgen setup in newer kernels in iputils/ipg

2006-12-20 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 20 Dec 2006 10:09:03 -0500), Mike Frysinger [EMAIL PROTECTED] says: the ipg script only works with the old pg3 module and not the new pktgen module ... attached patch updates the ipg script to support both Applied. Thanks. --yoshfuji - To unsubscribe

[PATCH 2.6.20] [IPV6]: Repair IPv6 Fragments

2006-12-05 Thread YOSHIFUJI Hideaki /
Hello. The commit [IPV6]: Use kmemdup (commit-id: af879cc704372ef762584e916129d19ffb39e844) broke IPv6 fragments. Bug was spotted by Yasuyuki Kozakai [EMAIL PROTECTED]. Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED] -- diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 5 Dec 2006 19:03:27 +0900), Masahide NAKAMURA [EMAIL PROTECTED] says: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need to check RFC. --yoshfuji

Re: [PATCH 2/2] [IPV6] RAW: Add checksum default defines for mobility header.

2006-12-05 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 05 Dec 2006 10:04:14 -0500), Brian Haley [EMAIL PROTECTED] says: YOSHIFUJI Hideaki wrote: Add checksum default defines for mobility header(MH). As the result kernel's behavior is to handle MH checksum as default. I'd like to hold this on. I need

Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Fri, 17 Nov 2006 15:26:28 +0200), Ville Nuorvala [EMAIL PROTECTED] says: - dst_release(rt-u.dst); + if (rt) + dst_release(rt-u.dst); } I disagree. This does NOT fix any bugs. (void *)rt-u.dst is ever equal

[GIT PATCH 2.6.19] IPv6 Fixes

2006-11-16 Thread YOSHIFUJI Hideaki /
David, Please consider pulling from the 2.6.19-rc6-20061117-to-davem-20061117 branch at git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev/, which contains the following changesets: HEADLINES - [IPV6] ROUTE: Try to use router which is not known unreachable. [IPV6]

[GIT PULL 2.6.20] IPv6 Updates

2006-11-10 Thread YOSHIFUJI Hideaki /
Hello. Please consider pulling following changesets from 2.6.19-rc5-net-2.6.20-20061110-to-davem branch at: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git Regards, HEADLINES - [IPV6] ROUTE: Use macros to format /proc/net/ipv6_route. [IPV6] ROUTE: Use

Re: net-2.6.20 is up...

2006-11-08 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Wed, 08 Nov 2006 00:34:38 -0800 (PST)), David Miller [EMAIL PROTECTED] says: At: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git I guess you mean net-2.6.20.git; right? --yoshfuji - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [XFRM/IPV6] fix next header offset in decode_session

2006-11-07 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Tue, 7 Nov 2006 10:30:02 +0100), Jean-Philippe Andriot [EMAIL PROTECTED] says: The way to get the next protocol number of an IPv6 tunnel changes after introducing IP6CB, but I think we should go back to the previous version here. : struct ipv6_opt_hdr

Re: [PATCH 6/6] IPv6: Fix infinite loop if no matching IPv6 tunnel found

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:39:19 +0200), Ville Nuorvala [EMAIL PROTECTED] says: read_unlock(ip6ip6_lock); - return 1; - + icmpv6_send(skb, ICMPV6_DEST_UNREACH, + ICMPV6_ADDR_UNREACH, 0, skb-dev); discard: I'd argue this. We

Re: [PATCH 0/6] IPv6: IPv6 tunnel fixes

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:27:05 +0200), Ville Nuorvala [EMAIL PROTECTED] says: the following incremental patches contain several fixes to ip6_tunnel.c. They are in chronological order, so the most critical one is unfortunately last. Many thanks to Tero Kauppinen for

Re: [PATCH 1/6] IPv6: Fix SIOCCHGTUNNEL bug in IPv6 tunnels

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:29:31 +0200), Ville Nuorvala [EMAIL PROTECTED] says: From f9812eb0349f44f6374910ce38524f0c6f7ce8f4 Mon Sep 17 00:00:00 2001 From: Ville Nuorvala [EMAIL PROTECTED] Date: Thu, 2 Nov 2006 12:40:38 +0200 Subject: [PATCH 1/6] IPv6: Fix

Re: [PATCH 2/6] IPv6: Do mandatory IPv6 tunnel endpoint checks in realtime

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:31:34 +0200), Ville Nuorvala [EMAIL PROTECTED] says: From e60ed41fb11793d16ffcbfd56b889e0bbf04ea88 Mon Sep 17 00:00:00 2001 From: Ville Nuorvala [EMAIL PROTECTED] Date: Thu, 2 Nov 2006 12:43:50 +0200 Subject: [PATCH 2/6] IPv6: Do mandatory

Re: [PATCH 3/6] IPv6: Allow link-local tunnel endpoints

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:33:48 +0200), Ville Nuorvala [EMAIL PROTECTED] says: From de1ad3df949303a1454ae0cdee0a599c0fc95e45 Mon Sep 17 00:00:00 2001 From: Ville Nuorvala [EMAIL PROTECTED] Date: Thu, 2 Nov 2006 12:45:08 +0200 Subject: [PATCH 3/6] IPv6: Allow

Re: [PATCH 4/6] IPv6: Don't allocate memory for Tunnel Encapsulation Limit Option

2006-11-02 Thread YOSHIFUJI Hideaki /
In article [EMAIL PROTECTED] (at Thu, 02 Nov 2006 13:35:10 +0200), Ville Nuorvala [EMAIL PROTECTED] says: From b278633af228bcc986856f6492b02422c25656c7 Mon Sep 17 00:00:00 2001 From: Ville Nuorvala [EMAIL PROTECTED] Date: Thu, 2 Nov 2006 12:47:54 +0200 Subject: [PATCH 4/6] IPv6: Don't

<    1   2   3   4   5   >