Re: [1/4] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-27 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 27 May 2006 21:33:45 +1000), Herbert Xu <[EMAIL PROTECTED]> says: > As far as I can gather it's an attempt to guard against the removal of > the corresponding modules. Since neither module can be unloaded at all > we can leave it to whoever fixes up IPv6 u

[PATCH] [IPV6] ROUTE: Don't try less preferred routes for on-link routes.

2006-05-26 Thread YOSHIFUJI Hideaki /
David, In article <[EMAIL PROTECTED]> (at Fri, 26 May 2006 13:44:59 +0300 (EEST)), Meelis Roos <[EMAIL PROTECTED]> says: > >> The unreachable route works now but LAN routing still does not work. > >> Locally generated ICMPv6 packets that should go to LAN interface still > >> go to tun6to4. > > >

Re: ipv6 routing broken in 2.6.17-rc3,4

2006-05-26 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 26 May 2006 11:35:53 +0300 (EEST)), Meelis Roos <[EMAIL PROTECTED]> says: > The unreachable route works now but LAN routing still does not work. > Locally generated ICMPv6 packets that should go to LAN interface still > go to tun6to4. Please try this. -

Re: ipv6 routing broken in 2.6.17-rc3,4

2006-05-25 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 26 May 2006 02:24:19 +0300 (EEST)), Meelis Roos <[EMAIL PROTECTED]> says: > > (To YOSHIFUJI Hideaki: this is about the > http://comments.gmane.org/gmane.linux.network/35262 thread) > > Tracked it down to IPV6 merge at 2006-03-21: > commit cd85f6e2f5828218

Re: [PATCH] fix IP-over-ATM and ARP interaction.

2006-05-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 06 May 2006 17:13:29 +0100), Simon Kelley <[EMAIL PROTECTED]> says: > +void neigh_table_init(struct neigh_table *tbl) > +{ > + struct neigh_table *tmp; > + > + neigh_table_init_no_netlink(tbl); > + write_lock(&neigh_tbl_lock); > + for (tmp = neigh_table

Re: IPv6 connect() from site-local to global IPv6 address.

2006-05-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 06 May 2006 01:53:21 +0100), David Woodhouse <[EMAIL PROTECTED]> says: > There is a default route, because I believe that's the only thing that > radvd can do. I cannot advertise a route to _only_ fec0::/16, can I? Yes, you can, via Route Information optio

Re: [RFC PATCH] [IPV6] ADDRCONF: Convert addrconf_lock to RCU.

2006-05-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 05 May 2006 17:40:11 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 05 May 2006 12:24:52 +0900 (JST) > > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > > It is critical that w

Re: IPv6 connect() from site-local to global IPv6 address.

2006-05-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 05 May 2006 22:00:32 +0100), David Woodhouse <[EMAIL PROTECTED]> says: > Since updating the kernel to 2.6.16, I've got problems with external > connectivity to hosts which have both IPv4 and (Global) IPv6 addresses > in DNS. Glibc used to return the IPv4 ad

[RFC PATCH] [IPV6] ADDRCONF: Convert addrconf_lock to RCU.

2006-05-04 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/include/net/addrconf.h b/include/net/addrconf.h index 750e250..74dca37 100644 --- a/include/net/addrconf.h +++ b/include/net/addrconf.h @@ -127,20 +127,18 @@ extern int unregister_inet6addr_notifier static inline struct inet6_dev *

Re: VJ Channel API - driver level (PATCH)

2006-05-03 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 3 May 2006 22:07:40 +0400), Evgeniy Polyakov <[EMAIL PROTECTED]> says: > > Even if the hardware cannot fully implement netfilter rules > > there is still value in having an interface that documents > > exactly how much filtering a given piece of hardware c

[RFC PATCH] [IPV6]: Fix race in route selection.

2006-04-27 Thread YOSHIFUJI Hideaki /
Hello. We eliminated rt6_dflt_lock (to protect default router pointer) at 2.6.17-rc1, and introduced rt6_select() for general router selection. The function is called in the context of rt6_lock read-lock held, but this means, we have some race conditions when we do round-robin. Am I correct? If

Re: [PATCH 0/4]: Fix several errors in extension header handling.

2006-04-18 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 18 Apr 2006 14:49:14 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > All applied, and I agree with pushing 1-3 into -stable, > please send it. Done. Thanks. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netdev" in the

netdev@vger.kernel.org

2006-04-18 Thread YOSHIFUJI Hideaki /
[IPV6]: Ensure to have hop-by-hop options in our header of &sk_buff. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/exthdrs.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) 7bcedcc73a45a5577103422c33e01f1633173984 diff --git a/net/ipv6/exthdrs.c b/net

[PATCH 2/4] [IPV6] XFRM: Don't use old copy of pointer after pskb_may_pull().

2006-04-18 Thread YOSHIFUJI Hideaki /
[IPV6] XFRM: Don't use old copy of pointer after pskb_may_pull(). Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/xfrm6_policy.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) 83e25b9fb69b2c04ebfec2ee2b9fe95e5a7c0584 diff --git a/net/ipv6/xfrm6_policy.c b/net/i

[PATCH 3/4] [IPV6] XFRM: Fix decoding session with preceding extension header(s).

2006-04-18 Thread YOSHIFUJI Hideaki /
[IPV6] XFRM: Fix decoding session with preceding extension header(s). We did not correctly decode session with preceding extension header(s). This was because we had already pulled preceding headers, skb->nh.raw + 40 + 1 - skb->data was minus, and pskb_may_pull() failed. We now have IP6CB(skb)->

[PATCH 4/4] [IPV6]: Clean up hop-by-hop options handler.

2006-04-18 Thread YOSHIFUJI Hideaki /
[IPV6]: Clean up hop-by-hop options handler. - Removed unused argument (nhoff) for ipv6_parse_hopopts(). - Make ipv6_parse_hopopts() to align with other extension header handlers. - Removed pointless assignment (hdr), which is not used afterwards. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTEC

[PATCH 0/4]: Fix several errors in extension header handling.

2006-04-18 Thread YOSHIFUJI Hideaki /
Hello. Following changesets fix several errors in extension header handling. I'd propose to push them (except 4/4, maybe) to -stable. [PATCH 1/4] [IPV6]: Ensure to have hop-by-hop options in our header of &sk_buff. [PATCH 2/4] [IPV6] XFRM: Don't use old copy of pointer after pskb_may_pull(). [PAT

Re: How to retrieve kernel's IPv6 routing cache table?

2006-03-30 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Thu, 30 Mar 2006 16:39:14 +0200), Peter Bieringer <[EMAIL PROTECTED]> says: > IPv6: > # ip -6 route show table cache > ff02::1 via ff02::1 dev eth0 metric 0 > cache mtu 1280 advmss 1220 metric 10 4294967295 > ff02::1:ffea:7781 via ff02::1:ffea:7781

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 23 Mar 2006 16:34:12 +), Hugo Santos <[EMAIL PROTECTED]> says: >This patch fixes a soft lockup when encapsulated packets reach > ip6ip6_rcv() and there is no tunnel associated with it. The error > path returns a positive value (1) which will trigg

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-07 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 7 Mar 2006 11:26:13 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > What about sth. like this simple defensive patch instead > (against Linux 2.6.16-rc4)? I disagree again. Sorry. --yoshfuji - To unsubscribe from this list: send the line "unsubscribe netd

Re: IPv6: avoid dereference of null route entry in ipv6_del_addr()

2006-03-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 06 Mar 2006 21:50:33 +0100), Jean-Mickael Guerin <[EMAIL PROTECTED]> says: > Hi, > > This patch fixes potential null pointer dereference (I never experiment > such crash). > The patch is made for net-2.6.17. I disagree. It never happen, because (void *)

Re: remove useless test in ip6_append_data

2006-03-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 6 Mar 2006 02:34:16 -0500), Dave Jones <[EMAIL PROTECTED]> says: > We've already dereferenced 'np' a dozen > times at this point, so it's safe to say it's not null. > > Signed-off-by: Dave Jones <[EMAIL PROTECTED]> Agreed. --yoshfuji - To unsubscribe fro

Re: [PATCH] [IPV6]: fix ipv6_saddr_score struct element

2006-03-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 28 Feb 2006 15:03:31 -0500), Brian Haley <[EMAIL PROTECTED]> says: > The scope element in the ipv6_saddr_score struct used in > ipv6_dev_get_saddr() is an unsigned integer, but __ipv6_addr_src_scope() > returns a signed integer (and can return -1). > > S

Re: Poor performance with MTU 9000

2006-02-27 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 27 Feb 2006 22:34:48 -0500), John Zielinski <[EMAIL PROTECTED]> says: > I'm having a strange problem with my server machine. When I use an MTU > of 9000 I get a throughput of only 45-65Mbit/sec not counting TCP/IP > overhead. Receiving I get around 310M

Re: IPv6 setsockopt software MTU patch

2006-02-24 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Thu, 23 Feb 2006 17:10:18 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 24 Feb 2006 00:23:51 +0900 (JST) > > > David, please apply. Thank you. > > Can you please resend the patch w

[PATCH] [IPV6]: Ensure to join all-routers multicast address.

2006-02-22 Thread YOSHIFUJI Hideaki /
Hello. If net.ipv6.conf.default.forwarding is !0 when bringing up the interface, we failed to join all routers multicast address, while we join/leave if we enable/disable net.ipv6.conf.ethX.forwarding later. This is inconsistent because we assume that we join all routers multicast if and only if

Re: [Patch 1/6] IPSEC: core updates

2006-02-19 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 27 Jan 2006 08:05:23 -0500), jamal <[EMAIL PROTECTED]> says: > diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h > index 82fbb75..b54a129 100644 > --- a/include/linux/xfrm.h > +++ b/include/linux/xfrm.h : > @@ -235,6 +258,11 @@ struct xfrm_usersa_id

Re: (usagi-users 03611) Re: IPv6 setsockopt software MTU patch

2006-02-19 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 19 Feb 2006 15:54:13 +0100), [EMAIL PROTECTED] says: > Yes, Hugo Santos suggested me to use the minimum of both, the new > patch is available there : > > http://clarinet.u-strasbg.fr/~hoerdt/ip6_output.c.softfrag.patch2 Do you mean like this? Signed-off-

Re: IPv6 setsockopt software MTU patch

2006-02-19 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 19 Feb 2006 14:47:09 +0100), [EMAIL PROTECTED] says: > The fix is very simple, it only grab the value of frag_size and > use it in ip6_fragment file, could you please review the patch which > fix that problem at : > > http://clarinet.u-strasbg.fr/~hoerdt/i

[PATCH] [NET]: NETFILTER: remove duplicated operation and fix order in skb_clone().

2006-02-17 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Fri, 17 Feb 2006 11:38:42 +0100), Olivier MATZ <[EMAIL PROTECTED]> says: > in skb_clone(), the following code is done twice : > > #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE) > C(nfct_reasm); > nf_conntrack_get_rea

Re: [net-endian] ip_mc_list.mutliaddr

2006-02-14 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 15 Feb 2006 00:23:28 +), Al Viro <[EMAIL PROTECTED]> says: > In linux/igmp.h: > > struct ip_mc_list > { > struct in_device*interface; > unsigned long multiaddr; > struct ip_sf_list *sources; > > and AFAICS all

Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit) v2

2006-02-11 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Sat, 11 Feb 2006 17:37:18 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > From: Ingo Oeser <[EMAIL PROTECTED]> > > Here are some possible (and trivial) cleanups. > - use kzalloc() where possible > - remove unused label > - invert allocation failure test

Re: [PATCH] IPv6: Cleanups for net/ipv6/addrconf.c (kzalloc, early exit)

2006-02-09 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Thu, 9 Feb 2006 17:36:16 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > Here are some possible (and trivial) cleanups. : > - remove unused label > @@ -3193,7 +3190,6 @@ static int inet6_fill_ifinfo(struct sk_b > kfree(array); > return skb->l

Re: [PATCH] IPv6 address autoconfiguration does not work after device down/up cycle

2006-02-08 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 08 Feb 2006 15:59:31 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > > Good spot. Please drop {}, otherwise, I agree. Thank you. > > I'll take care of fixing that when I put in the fix. Okay, thanks. Acked-by: YOSHIFUJI Hideaki <[EMAIL PROT

Re: [PATCH] IPv6 address autoconfiguration does not work after device down/up cycle

2006-02-08 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Wed, 08 Feb 2006 17:17:24 +0200), Kristian Slavov <[EMAIL PROTECTED]> says: > During NETDEV_DOWN we clear IF_READY, and we don't set it back in > NETDEV_UP. While starting to perform DAD on the link-local address, we > notice that the device is not in

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-02-02 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 02 Feb 2006 20:09:44 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 03 Feb 2006 11:32:13 +0900 (JST) > > > BTW, David, would you mind sending your addrconf patches to me? > > I'd like to

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-02-02 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 3 Feb 2006 12:48:49 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > On Fri, Feb 03, 2006 at 10:31:58AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ > wrote: > > > > We SHALL do autoconf when we "up" an ipv6-capable device. > > It is the IPv6. > > I don't think

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-02-02 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 2 Feb 2006 23:42:25 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > On Thu, Feb 02, 2006 at 05:37:22AM -0700, Eric W. Biederman wrote: > > > > > Yes you are right. The locking/refcounting in addrconf.c is such > > > a mess. I've asked a number of times bef

Re: [PATCH RESEND] net: Move destructor from neigh->ops to neigh_params

2006-02-01 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 01 Feb 2006 17:28:10 -0800), Roland Dreier <[EMAIL PROTECTED]> says: > Sorry to distract everyone from the VJ channel discussion, but on the > other hand it looks like Dave is back... I'm resending this because > I'd really like to get this problem fixed bu

Re: IPv6: to take care of permanent routes

2006-01-26 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 26 Jan 2006 16:35:08 +0100), Jean-Mickael Guerin <[EMAIL PROTECTED]> says: > Following patch drops this flag. As you can see, it requires to set the > flag back to RTF_EXPIRES in ndisc_router_discovery(), because > rt6_add_dflt_router() asks a new route w

Re: [PATCH (ready to apply?)] Additional options forresettingpacket statistics

2006-01-25 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 20:25:56 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > Okey-dokey. > > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > --- x/net/packet/af_packet.c 2006-01-25 22:18:41.

Re: [PATCH (ready to apply?)] Additional options for resettingpacket statistics

2006-01-25 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 19:46:07 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > @@ -1399,6 +1423,17 @@ static int packet_getsockopt(struct sock > return -EINVAL; > > switch(optname) { > + case PACKET_ACCUMULATE_STATISTICS:

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 09:13:26 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > + > + case PACKET_ACCUMULATE_STATISTICS: > + { > + int val; > + > + if (optlen != sizeof(val)) > + return -EINVAL; I thi

Re: [PATCH] ipv6: addrconf_ifdown fix dst refcounting.

2006-01-25 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 25 Jan 2006 13:12:02 -0700), [EMAIL PROTECTED] (Eric W. Biederman) says: > By bringing down the routes before we bring down the addresses we leak > the dst cache entries held by the addresses. : > Fix this by simply moving rt6_ifdown where we flush the rout

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Tue, 24 Jan 2006 16:38:26 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > + if (optlen != sizeof val) sizeof(val) Please use "sizeof(foo)" instead of "sizeof foo". > --- x/include/linux/if_packet.h

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Sat, 7 Jan 2006 10:05:52 -0800), "Kris Katterjohn" <[EMAIL PROTECTED]> says: > PACKET_AUTO_STATISTICS is the default and the kernel will zero the packet > statistics when the PACKET_STATISTICS getsockopt() call is used. > + case PACKET_AUTO_STATISTI

Re: [patch] networking ipv4: remove total socket usage count from /proc/net/sockstat

2006-01-16 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 16 Jan 2006 17:33:59 -0500), Andy Gospodarek <[EMAIL PROTECTED]> says: > On 1/16/06, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > > > Maybe if you described "your current problem" someone could suggest a > > solution... > > > > Sure, I'd be glad to. If I

Re: 32 bit (socket layer) ioctl emulation for 64 bit kernels

2006-01-15 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 16 Jan 2006 16:59:20 +1100), Shaun Pereira <[EMAIL PROTECTED]> says: > If I understand correctly from your comments (thanks for that, they are > helpful) > copy_to_user acts like a memcopy for an 'array' of bytes and should not > be used to copy the timeval

Re: [PATCH] Use NIP6_FMT in kernel.h

2006-01-13 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 13 Jan 2006 14:29:24 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > > changes all code to use NIP6_FMT > > fixes net/ipv6/ip6_flowlabel.c : > This looks good, applied, thanks Joe. As I have commented in another mail, the original patch

Re: [PATCH] Use NIP6_FMT in kernel.h

2006-01-13 Thread YOSHIFUJI Hideaki /
Hello. Well, basic idea is okay. But... In article <[EMAIL PROTECTED]> (at Fri, 13 Jan 2006 14:14:48 -0800), Joe Perches <[EMAIL PROTECTED]> says: > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 7129d42..dfb4f14 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c >

Re: [NETFILTER 00/10]: Netfilter IPsec support

2006-01-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 7 Jan 2006 02:09:30 +0100 (MET)), Patrick McHardy <[EMAIL PROTECTED]> says: > following are the remaining patches for netfilter IPsec support. > They are missing the common-case optimization for inner transport mode > SAs on the input path, but since its j

[PATCH 1/3] [ECONET]: Use macro for spinlock_t definition.

2006-01-04 Thread YOSHIFUJI Hideaki /
Use macro for spinlock_t definition. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index 34fdac5..cefc26d 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -56,7 +56,7 @@ static struct net_device *net2dev_map[25

[PATCH 2/3] [IPV6]: Use macro for rwlock_t initialization.

2006-01-04 Thread YOSHIFUJI Hideaki /
Use macro for rwlock_t initialization. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index f829a4a..1cf305a 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -224,7 +224,7 @@ int ipv6_sock_mc_join(struct sock *sk, i mc_lst->i

[PATCH 3/3] [NETFILTER]: Use macro for spinlock_t/rwlock_t initializations/definition.

2006-01-04 Thread YOSHIFUJI Hideaki /
Use macro for spinlock_t/rwlock_t initializations/definition. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index c2c52af..f3e5ffb 100644 --- a/net/ipv6/netfilter/nf_conntrack_reasm.c +++ b/net/

[PATCH] IPV6: Fix one more dead lock...

2005-12-27 Thread YOSHIFUJI Hideaki /
Hello. Again, we need to fix one more dead lock... sorry.. We need to release idev->lcok before we call addrconf_dad_stop(). It calls ipv6_addr_del(), which will hold idev->lock. Bug spotted by Yasuyuki KOZAKAI <[EMAIL PROTECTED]>. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git

IPv6 regression in net-2.6.16

2005-12-27 Thread YOSHIFUJI Hideaki /
Hello. Chinen-san has run tests against current net-2.6.16 tree. We could run tests (Phase-1 for Host, Phase-2 Core for Host), we see some regression in IPv6 neighbor discovery. We have not tracked down closely yet. FYI, you can find the result (IPv6 Ready Logo Phase-2 Core (Host)) at: http://t

Re: [PATCH 2/2][INET_SOCK]: Move struct inet_sock & helper functions to net/inet_sock.h

2005-12-26 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 27 Dec 2005 02:35:52 -0200), Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> says: > diff --git a/drivers/net/sundance.c b/drivers/net/sundance.c > index 0ab9c38..8cdeb5c 100644 > --- a/drivers/net/sundance.c > +++ b/drivers/net/sundance.c > @@ -633,9 +633,13

[PATCH] IPV6: Fix Temporary Address Generation

2005-12-23 Thread YOSHIFUJI Hideaki /
From: Hiroyuki YAMAMORI <[EMAIL PROTECTED]> Since regen_count is stored in the public address, we need to reset it when we start renewing temporary address. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 510220f..745aa43 100644 -

[PATCH] [IPV6]: Fix dead lock.

2005-12-23 Thread YOSHIFUJI Hideaki /
Hello. Sorry, I introduced a dead-lock by the latest NETDEV_CHANGE patch. We need to relesae ifp->lock before we call addrconf_dad_stop(), which will hold ifp->lock. Please apply this. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c in

Re: [GIT PATCH 2.6.15-rc6] IPV6 Fixes

2005-12-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 22 Dec 2005 03:54:29 -0500), Jeff Garzik <[EMAIL PROTECTED]> says: > I'm not sure all drivers have been converted to use netif_carrier_ok(), > which would imply that IPv6 would now be broken on all drivers that do > not yet support it? I don't think so.

[GIT PATCH 2.6.15-rc6] IPV6 Fixes

2005-12-21 Thread YOSHIFUJI Hideaki /
Hello. I'm sorry for taking last minutes. Please pull the following changesets and push them to the 2.6.15 queue. These fix, basically, random "FAIL"s in IPv6 Ready Logo Phase-2 Self Test in IPv6 Core Protocols. Changesets are available at: git://git.skbuff.net/gitroot/yoshfuji/linux-2.6.1

Re: [PATCH] Fix IPv6 address deletion

2005-12-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 21 Dec 2005 14:28:25 +0200), Kristian Slavov <[EMAIL PROTECTED]> says: > If you add more than one IPv6 address belonging to the same prefix and > delete the address that was last added, routing table entry for that > prefix is also deleted. : > Signed-off

Re: [PATCH 06/13]: [IPV4/6]: Netfilter IPsec input hooks

2005-12-18 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 18 Dec 2005 23:59:35 +0100), Patrick McHardy <[EMAIL PROTECTED]> says: > YOSHIFUJI Hideaki wrote: : > > BTW, we're now using full of skb->cb > > (and we are even exceeding it w/ mobile-ipv6 extensions)... > > Not in mainline so far, so maybe we can fit yo

[PATCH] [IPV6]: Fix Route Lifetime

2005-12-18 Thread YOSHIFUJI Hideaki /
Hello. Please apply the following patch to 2.6.15 tree. Thank you. --- [IPV6]: Fix route lifetime. The route expiration time is stored in rt6i_expires in jiffies. The argument of rt6_route_add() for adding a route is not the expiration time in jiffies nor in clock_t, but the lifetime (or time le

Re: [PATCH 06/13]: [IPV4/6]: Netfilter IPsec input hooks

2005-12-18 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 18 Dec 2005 15:27:01 +0100), Patrick McHardy <[EMAIL PROTECTED]> says: > YOSHIFUJI Hideaki wrote: > > In article <[EMAIL PROTECTED]> (at Tue, 22 Nov 2005 02:14:26 +0100), > > Patrick McHardy <[EMAIL PROTECTED]> says: > > > > > >>The easiest way would be

Re: [PATCH RFC]: ipv6 addrconf async jobs

2005-12-13 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 13 Dec 2005 20:57:42 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Wed, 14 Dec 2005 13:03:55 +0900 (JST) > > > BTW, will you please capitalize labels in enums? > > Andi suggested using func

Re: [PATCH RFC]: ipv6 addrconf async jobs

2005-12-13 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 13 Dec 2005 18:20:08 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > So what I've done is move these operations into base context using > workqueues. Packet initiated events simply schedule a workqueue > event, and the actual processing occurs

Re: 2.6.14 (FC4) orinoco_cs issues and/with IPv6 addrconf

2005-12-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 9 Dec 2005 12:02:03 +0200 (EET)), Pekka Savola <[EMAIL PROTECTED]> says: > How do you differentiate between these two cases? One is valid while > the other is not, but both seem valid to me. > > default via fe80::20a:5eff:fe51:7d58 dev eth1 proto kernel

Re: 2.6.14 (FC4) orinoco_cs issues and/with IPv6 addrconf

2005-12-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 9 Dec 2005 11:45:04 +0200 (EET)), Pekka Savola <[EMAIL PROTECTED]> says: > 1) after reboot (card in slot), default route shows up, but does not > get renewed. After timer expiry, the expiry timer seems to wrap > around, and after a couple of seconds, the

Re: [IPv4] Fix issue reported by Coverity in net/ipv4/af_inet.c

2005-12-01 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 01 Dec 2005 18:04:30 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > net/ipv6/af_inet.c:inet6_create() has a similar problem and > it also is missing the module load logic the ipv4 counterpart > has. > > Anyone up for cooking up a fix for those

[PATCH] [IPV6]: Implement appropriate dummy rule 4 in ipv6_dev_get_saddr().

2005-11-28 Thread YOSHIFUJI Hideaki /
Hello. Ensure to update hiscore.rule in dummy rule 4 in ipv6_dev_get_saddr(). Pointed out by Yan Zheng <[EMAIL PROTECTED]>. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index a16064b..76ff9f4 100644 --- a/net/ipv6/addrconf.c +++ b/ne

Re: IPV6 PMTU processing logic error

2005-11-28 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 28 Nov 2005 18:14:48 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > I've implemented the necessary logic for TCP and UDP, but every other > possible legitimate receiver of PKT_TOOBIG messages (RAW, SCTP, DCCP, > AH6, ESP6, etc. etc. etc.) will

Re: [PATCH 06/13]: [IPV4/6]: Netfilter IPsec input hooks

2005-11-23 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Tue, 22 Nov 2005 02:14:26 +0100), Patrick McHardy <[EMAIL PROTECTED]> says: > The easiest way would be to store nhoff somewhere in the skb and > use it to continue at the next header. But I still hope there is > a way without keeping data in the skb. We

Re: [PATCH 00/13]: Netfilter IPsec support

2005-11-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 22 Nov 2005 14:34:38 -0800 (PST)), "David S. Miller" <[EMAIL PROTECTED]> says: > I want to do this so that Patrick doesn't have to repost > 13 or so patches every time one of the parts still under > discussion gets changed. > > Actually, it seems the only

Re: [PATCH 06/13]: [IPV4/6]: Netfilter IPsec input hooks

2005-11-21 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Mon, 21 Nov 2005 17:31:41 +0900), Kazunori Miyazawa <[EMAIL PROTECTED]> says: > Your ip_xfrm_transport_hook is a good idea, I think. > > We could call ip6_rcv_finish if the netfilter changed the addresses > or otherwise we can continue the loop to avoid

Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.

2005-11-17 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 18 Nov 2005 08:44:27 +0800), Yan Zheng <[EMAIL PROTECTED]> says: > I get follow message when switch to single user mode and the kernel version > is 2.6.15-rc1-git5. : > Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from > invalid conte

Re: [PATCH] [IPV4,IPV6] replace handmade list with hlist in IPv{4,6} reassembly

2005-11-16 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Thu, 17 Nov 2005 00:12:36 +0900 (JST)), Yasuyuki KOZAKAI <[EMAIL PROTECTED]> says: > [IPV4,IPV6] replace handmade list with hlist in IPv{4,6} reassembly > Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> Acked-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]

Re: [PATCH]small fix for __ipv6_addr_type(...)

2005-11-15 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 15 Nov 2005 17:20:50 -0500), Vlad Yasevich <[EMAIL PROTECTED]> says: > No, according to RFC 4007, loopback is considered a link-local > address. Agreed. RFC3484 also explicitly says that loopback is treated as link-local. --yoshfuji - To unsubscribe from

Re: [PATCH]IPv6: small fix for ipv6_dev_get_saddr(...)

2005-11-14 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 14 Nov 2005 18:42:30 +0800), Yan Zheng <[EMAIL PROTECTED]> says: > The "score.rule++" doesn't make any sense for me. > According to codes above, I think it should be "hiscore.rule++;" . Oops, you're right. > Signed-off-by: Yan Zheng<[EMAIL PROTECTED]> Ac

[GIT PATCH] RFC3484 compliant source address selection

2005-11-07 Thread YOSHIFUJI Hideaki /
Hello. David, this is what I promised before. Please pull the following changesets, which implement the source address selection algorythm described in RFC3484; e.g.: - avoid using daprecated address - prefer address in appropriate scope / on appropriate interface - (minimum support of) matc

Re: [PATCH 1/2] [IPV6]: Support several new sockopt / ancillary data in Advanced API (RFC3542).

2005-09-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 09 Sep 2005 23:31:32 +0200), Patrick McHardy <[EMAIL PROTECTED]> says: > > --- a/include/linux/in6.h > > +++ b/include/linux/in6.h > > > +#define IPV6_RECVHOPLIMIT 64 > > +#define IPV6_HOPLIMIT 65 > > 64 and 65 are already in use by ip6_tabl

[PATCH 2/2] [IPV6]: Support IPV6_{RECV,}TCLASS socket options / ancillary data.

2005-09-07 Thread YOSHIFUJI Hideaki /
Subject: [PATCH 2/2] [IPV6]: Support IPV6_{RECV,}TCLASS socket options / ancillary data. Based on patch from David L Stevens <[EMAIL PROTECTED]> Signed-off-by: David L Stevens <[EMAIL PROTECTED]> Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- include/linux/in6.h |2 -- incl

[PATCH 1/2] [IPV6]: Support several new sockopt / ancillary data in Advanced API (RFC3542).

2005-09-07 Thread YOSHIFUJI Hideaki /
Subject: [PATCH 1/2] [IPV6]: Support several new sockopt / ancillary data in Advanced API (RFC3542). Support several new socket options / ancillary data: IPV6_RECVPKTINFO, IPV6_PKTINFO, IPV6_RECVHOPOPTS, IPV6_HOPOPTS, IPV6_RECVDSTOPTS, IPV6_DSTOPTS, IPV6_RTHDRDSTOPTS, IPV6_RECVRTHDR, IPV6

[PATCH 0/2] [IPV6]: RFC3542 Support

2005-09-07 Thread YOSHIFUJI Hideaki /
Hello. Please pull the following patches from . [PATCH 1/2] [IPV6]: Support several new sockopt / ancillary data in Advanced API (RFC3542). [PATCH 2/2] [IPV6]: Support IPV6_{RECV,}TCLASS socket options / ancillary data. Thank you. -- YOSHIFUJI Hideaki @ USAGI Project <[EMAIL PROTECTED]> GPG-

Re: neighbour.c and NUD_IN_TIMER

2005-09-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 06 Sep 2005 13:05:16 -0700), Ben Greear <[EMAIL PROTECTED]> says: > neigh->nud_state = NUD_INCOMPLETE; > *** neigh_hold(neigh, NDRK_NEIGH_TIMER); > neigh->timer.expires = now + 1; >

Re: 2.6.13-git3: build failure: sysctl_optmem_max

2005-09-03 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 3 Sep 2005 11:27:56 +0100), Russell King <[EMAIL PROTECTED]> says: > While trying to build a kernel with CONFIG_SYSCTL disabled, the following > error occurs: > > CC net/ipv4/ip_sockglue.o > net/ipv4/ip_sockglue.c: In function `ip_setsockopt': > net

[PATCH] Repair Incoming Interface Handling for Raw Socket.

2005-09-01 Thread YOSHIFUJI Hideaki /
Hello. Due to changes to enforce checking interface bindings, sockets did not see loopback packets bound for our local address on our interface. e.g.) When we ping6 fe80::1%eth0, skb->dev points loopback_dev while IP6CB(skb)->iif indicates eth0. This patch fixes the issue by using appropriat

Re: [PATCHSET] cleanup of fib6_lookup()

2005-08-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 22 Aug 2005 13:08:28 +0200), Thomas Graf <[EMAIL PROTECTED]> says: > Collection of cleanups for fib6_lookup() that used to live in my tree > for a while now. > > Yoshfuji-san, what's the plan for CONFIG_IPV6_SUBTREES? Is MIPL > going to use it or can we re

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 16 Aug 2005 21:58:36 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > It also is a preferred change than your minimal version > because it makes the ip6 input path very similar to > the ipv4 variant, so it's easier to verify the two pieces > of c

Re: [IPV6]: Fix raw socket hardware checksum failures

2005-08-16 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 16 Aug 2005 21:04:10 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Wed, 17 Aug 2005 05:52:06 +0200 > > > David S. Miller wrote: > > > Applied to both net-2.6 and net-2.6.14 > > > > BTW, the I

Re: [PATCH 2/6][INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c

2005-08-12 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) says: > [INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c > > Doing this we allow tcp_diag to support IPV6 even if tcp_diag is compiled > statically and IP

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-07 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 07 Aug 2005 20:33:38 +0200), Balazs Scheidler <[EMAIL PROTECTED]> says: > Commit log says it all. > + xfrm_state_bydst = (struct list_head *) __get_free_pages(GFP_KERNEL, > get_order(sizeof(struct list_head) * XFRM_DST_HSIZE * 2)); Please check the

Re: IPv6 router alert and interface binding

2005-07-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 21 Jul 2005 21:44:43 +0100), Andrew McDonald <[EMAIL PROTECTED]> says: > I guess the fix would be a matter of changing: > > if (sk && ra->sel == sel) { > > to: > > if (sk && ra->sel == sel && > (!sk->sk_bound_dev_if || > sk->sk_bound_dev_if == s

Re: [PATCH RFC]: Killing skb->real_dev

2005-07-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 22 Jul 2005 14:12:27 -0700 (PDT)), "David S. Miller" <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > Date: Fri, 22 Jul 2005 17:06:38 -0400 (EDT) > > > No, please, please do not break binaries, whenever it is possible. > > It is de

Re: [PATCH RFC]: Killing skb->real_dev

2005-07-22 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 22 Jul 2005 22:55:14 +0200), Thomas Graf <[EMAIL PROTECTED]> says: > * Stephen Hemminger <[EMAIL PROTECTED]> 2005-07-22 13:48 > > I don't see how the ematch iproute2 stuff depends on SKB shrinking. > > The CVS repository has the latest ematch stuff, just te

Re: [PATCH 1/3] multicast API "join" issues

2005-07-04 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 1 Jul 2005 18:15:50 -0600), David Stevens <[EMAIL PROTECTED]> says: > This patch corrects a few problems with the IP_ADD_MEMBERSHIP > socket option: > 1) The existing code makes an attempt at reference counting joins when > using the ip_mreq

<    1   2   3   4   5