Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

On Sat, 19 Dec 2015 00:45:40 +0300 Dmitrii Shcherbakov wrote: > Phil, > > 18.12.2015, 19:55, "Phil Sutter" : > > On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > >>  > Dmitrii, did iproute2 without your change even print the overhead as

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: > > Dmitrii, did iproute2 without your change even print the overhead as set > > by you before? Looking at the code, I'd assume not. > > Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel > (also tag

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Phil, > Dmitrii, did iproute2 without your change even print the overhead as set > by you before? Looking at the code, I'd assume not. Tried building iproute2 (as of tag 4.2) and using the upstream linux kernel (also tag 4.2 - 64291f7db5bd8150a74ad2036f1037e6a0428df2): ~/src/iproute2/tc$ uname

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Phil, 18.12.2015, 19:55, "Phil Sutter" : > On Fri, Dec 18, 2015 at 07:39:25PM +0300, Dmitrii Shcherbakov wrote: >>  > Dmitrii, did iproute2 without your change even print the overhead as set >>  > by you before? Looking at the code, I'd assume not. >> >>  Tried building iproute2 (as

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

On Thu, Dec 17, 2015 at 12:45:33PM +0300, Dmitrii Shcherbakov wrote: > >I don't think your patch should contain this cleanup of "b4". > > It seems that b3 is only used for the legacy overhead part and if I remove > it, b3 is not going to be used. So I figured I remove b4 put b3 instead. No

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Jesper, Sorry, it seems that I accidentally sent out an unfinished e-mail. >I don't think your patch should contain this cleanup of "b4". It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead.

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

16.12.2015, 18:16, "Jesper Dangaard Brouer" : >  I don't think your patch should contain this cleanup of "b4". >  Submit another patch with that cleanup change, please. > >>    if (show_details) { >>   - fprintf(f, "burst %s/%u mpu %s overhead %s ", >>   +

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Phil, > Dmitrii, did iproute2 without your change even print the overhead as set by you before? Looking at the code, I'd assume not. I used an iproute2 provided by the distribution and an OpenVZ 3.10 kernel so there are differences there but I noticed the 'manual' overhead-related code is

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Hi Dmitrii, On Sat, 12 Dec 2015 14:09:39 +0300 Dmitrii Shcherbakov wrote: > I noticed a quite an old change which I have a few questions about so > maybe somebody could help me out. There are a few lines of code in > tc/q_htb.c which were committed originally back in

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

On Wed, Dec 16, 2015 at 04:15:58PM +0100, Jesper Dangaard Brouer wrote: > When trying to understand this code, keep in mind that we are trying > to keep backward compatible with older kernels. Thus, this printing > might be have been left here to keep compat with older kernels, but I > think we

[PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Hello, I noticed a quite an old change which I have a few questions about so maybe somebody could help me out. There are a few lines of code in tc/q_htb.c which were committed originally back in 2004 and have not changed since related to MPU (Minimum Packet Unit). I asked Stephen - this is