Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Greg
On Wed, 2016-08-31 at 11:32 -0700, Eric Dumazet wrote: > On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > > I'm not sure why this hasn't been done before because it seems obvious, > > so maybe there is some reason that memcpy is used instead of > > ether_addr_copy in this code. But let's try

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Eric Dumazet
On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > I'm not sure why this hasn't been done before because it seems obvious, > so maybe there is some reason that memcpy is used instead of > ether_addr_copy in this code. But let's try this anyway. > > Change memcpy to ether_addr_copy. ... >

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Joe Perches
On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > I'm not sure why this hasn't been done before because it seems obvious, > so maybe there is some reason that memcpy is used instead of > ether_addr_copy in this code.  But let's try this anyway. > > Change memcpy to ether_addr_copy. I looked

Re: [PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Greg
On Wed, 2016-08-31 at 09:41 -0700, Joe Perches wrote: > On Wed, 2016-08-31 at 09:32 -0700, Greg Rose wrote: > > I'm not sure why this hasn't been done before because it seems obvious, > > so maybe there is some reason that memcpy is used instead of > > ether_addr_copy in this code. But let's try

[PATCH] net/ethernet: Use ether_addr_copy rather than memcpy

2016-08-31 Thread Greg Rose
I'm not sure why this hasn't been done before because it seems obvious, so maybe there is some reason that memcpy is used instead of ether_addr_copy in this code. But let's try this anyway. Change memcpy to ether_addr_copy. Signed-off-by: Greg Rose --- net/ethernet/eth.c