RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

As a follow up on this thread: On 8/30/2016, Geert Uytterhoeven wrote: > > I just looked at the RZ/A1 register space and there seems to be dummy > > registers in the POST1-4 area. I can write to them and read back what I > > wrote...which is all that the sh_eth driver cares about. I bet when the

Re: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

Hi Chris, On Tue, Aug 30, 2016 at 4:16 PM, Chris Brandt wrote: > On Aug 29, 2016, Sergei Shtylyov wrote: >>SH7757 is not the only platform with TSU, there's e.g. R8A7740 ARM >> SoC which only has 1 GETHER channel... > > I don't have the R8A7740 manual (R-Mobile A1)

RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

Hello Sergei, On Aug 29, 2016, Sergei Shtylyov wrote: >SH7757 is not the only platform with TSU, there's e.g. R8A7740 ARM > SoC which only has 1 GETHER channel... I don't have the R8A7740 manual (R-Mobile A1) so I can't see. But even if it does not have the POST registers, it might not hurt

Re: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

Hello. On 08/29/2016 05:41 PM, Chris Brandt wrote: The RZ/A1 has a TSU, but since it only has one Ethernet port, it does not have POST registers. I'm not sure the reason is having one port... do you have the old SH manuals somewhere? :-) Yes, I used to support the SH7757. Good to

RE: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

On 08/28/2016, Sergei Shtylyov wrote: >> The RZ/A1 has a TSU, but since it only has one Ethernet port, it does >> not have POST registers. > >I'm not sure the reason is having one port... do you have the old SH > manuals somewhere? :-) Yes, I used to support the SH7757. It had dual ETHER

Re: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

Hello. Oh, and I'll have to correct your language and terminology. :-/ Should be "if they don't exist" in the subject. On 08/26/2016 11:01 PM, Chris Brandt wrote: The RZ/A1 has a TSU, but since it only has one Ethernet port, it does not have POST registers. Therefore, if you try to write

Re: [PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

Hello. On 08/26/2016 11:01 PM, Chris Brandt wrote: The RZ/A1 has a TSU, but since it only has one Ethernet port, it does not have POST registers. I'm not sure the reason is having one port... do you have the old SH manuals somewhere? :-) Therefore, if you try to write to register

[PATCH] net: ethernet: renesas: sh_eth: do not access POST registers if not exist

The RZ/A1 has a TSU, but since it only has one Ethernet port, it does not have POST registers. Therefore, if you try to write to register index TSU_POST1 (which will be because it does not exist), it will either panic or corrupt memory elsewhere. Reported-by: Daniel Palmer