On 02-01-2007 08:51, David Miller wrote:
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 00:55:51 +0100
On error we should start freeing resources at [i-1] not [i-2].
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
Patch applied, thanks Mariusz.
diff -upr
Hello David,
One could argue from a defensive programming perspective that
this bug comes from the fact that the ifb_init_one() loop
advances state before checking for errors ('i' is advanced before
the 'err' check due to the loop construct), and that's why the
error recovery code had to be
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 11:49:42 +0100
Hello David,
One could argue from a defensive programming perspective that
this bug comes from the fact that the ifb_init_one() loop
advances state before checking for errors ('i' is advanced before
the
Hello,
On error we should start freeing resources at [i-1] not [i-2].
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
drivers/net/ifb.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -upr linux-2.6.20-rc2-mm1-a/drivers/net/ifb.c
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 00:55:51 +0100
On error we should start freeing resources at [i-1] not [i-2].
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
Patch applied, thanks Mariusz.
diff -upr linux-2.6.20-rc2-mm1-a/drivers/net/ifb.c