Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-15 Thread Petr Vorel
Hi Mark, > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -1,6 +1,6 @@ > > -#!/bin/sh > > +#!/bin/bash > Funny - ^^^ choosing bash explicitly while > removing the bashism? Eh, this is really silly, sorry. I've sent a

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-13 Thread Rustad, Mark D
> On Oct 8, 2017, at 7:39 AM, Petr Vorel wrote: > > diff --git a/testsuite/tests/ip/route/add_default_route.t > b/testsuite/tests/ip/route/add_default_route.t > index e5ea6473..0b566f1f 100755 > --- a/testsuite/tests/ip/route/add_default_route.t > +++

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-11 Thread Randy Dunlap
On 10/11/17 11:01, Stephen Hemminger wrote: > On Sun, 8 Oct 2017 16:39:16 +0200 > Petr Vorel wrote: > >> Signed-off-by: Petr Vorel > > Ok, applied. But iproute2 is really limited to Linux and bash is lingua > franca on Linux > no French, please.

Re: [PATCH] tests: Remove bashisms (s/source/.)

2017-10-11 Thread Stephen Hemminger
On Sun, 8 Oct 2017 16:39:16 +0200 Petr Vorel wrote: > Signed-off-by: Petr Vorel Ok, applied. But iproute2 is really limited to Linux and bash is lingua franca on Linux

[PATCH] tests: Remove bashisms (s/source/.)

2017-10-08 Thread Petr Vorel
Signed-off-by: Petr Vorel --- testsuite/tests/ip/link/new_link.t| 2 +- testsuite/tests/ip/link/show_dev_wo_vf_rate.t | 2 +- testsuite/tests/ip/netns/set_nsid.t | 2 +- testsuite/tests/ip/netns/set_nsid_batch.t | 2 +-