Re: [PATCH 1/1]: SAs created although tmpl->optional set

2007-11-19 Thread Joy Latten
>Heh I made the same mistake when I first read this piece of >code too :) The optional flag isn't saying that it doesn't need >to be protected, but rather that the SA may not be present on >input. It's only used for IPComp where we may skip the IPComp >if the data is not compressible. > >In other

Re: [PATCH 1/1]: SAs created although tmpl->optional set

2007-11-19 Thread Herbert Xu
On Mon, Nov 19, 2007 at 02:53:50AM -0600, Joy Latten wrote: > Although tmpl->optional is set, kernel still attempts > to create a set of SAs. Heh I made the same mistake when I first read this piece of code too :) The optional flag isn't saying that it doesn't need to be protected, but rather tha

[PATCH 1/1]: SAs created although tmpl->optional set

2007-11-19 Thread Joy Latten
Although tmpl->optional is set, kernel still attempts to create a set of SAs. In xfrm_tmpl_resolve_one(), xfrm_state_find() is called to find an SA. First time, there won't be an SA, so an ACQUIRE will be sent and code then returns to xfrm_tmpl_resolv_one() who then checks tmpl->optional. Since