Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-27 Thread Vineet Gupta
On Monday 27 July 2015 01:08 PM, Kalle Valo wrote: >>> >> Per last discussion on this topic, Arend wanted to discuss abt this with >>> >> Hante. >>> >> I'm not taking it anyways so feel free to pick it up if you want ! >> > >> > Well, that was before your "timeline" clarification about the generic

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-27 Thread Kalle Valo
Arend van Spriel writes: > On 07/24/2015 07:22 PM, Vineet Gupta wrote: >> On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: >>> Vineet Gupta writes: >>> > There's already a generic implementation so use that instead. > --- > I'm not sure if the driver usage of atomic_or?() is correc

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-26 Thread Arend van Spriel
On 07/24/2015 07:22 PM, Vineet Gupta wrote: On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: Vineet Gupta writes: There's already a generic implementation so use that instead. --- I'm not sure if the driver usage of atomic_or?() is correct in terms of storage size of @val for 64 bit arches.

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-24 Thread Vineet Gupta
On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: > Vineet Gupta writes: > >> > There's already a generic implementation so use that instead. >> > --- >> > I'm not sure if the driver usage of atomic_or?() is correct in terms of >> > storage size of @val for 64 bit arches. >> > >> > Assuming LP64

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-24 Thread Kalle Valo
Vineet Gupta writes: > There's already a generic implementation so use that instead. > --- > I'm not sure if the driver usage of atomic_or?() is correct in terms of > storage size of @val for 64 bit arches. > > Assuming LP64 programming model for linux on say x86_64: atomic_or() > callers in this

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-10 Thread Arend van Spriel
On 07/10/2015 06:49 AM, Vineet Gupta wrote: On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already w

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Vineet Gupta
On Thursday 09 July 2015 11:55 PM, Arend van Spriel wrote: > On 07/09/2015 10:13 AM, Vineet Gupta wrote: >> > There's already a generic implementation so use that instead. > There is or there was? If there is now I am fine with this patch, but if > it already was there the author might have had a

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Peter Zijlstra
On Thu, Jul 09, 2015 at 08:31:16PM +0200, Arend van Spriel wrote: > >There is or there was? If there is now I am fine with this patch, but if > >it already was there the author might have had a reason for adding a > >local function and I would like to hear that reason. > > Nevermind. Just noticed

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 08:25 PM, Arend van Spriel wrote: On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding

Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Arend van Spriel
On 07/09/2015 10:13 AM, Vineet Gupta wrote: There's already a generic implementation so use that instead. There is or there was? If there is now I am fine with this patch, but if it already was there the author might have had a reason for adding a local function and I would like to hear that

[PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive

2015-07-09 Thread Vineet Gupta
There's already a generic implementation so use that instead. --- I'm not sure if the driver usage of atomic_or?() is correct in terms of storage size of @val for 64 bit arches. Assuming LP64 programming model for linux on say x86_64: atomic_or() callers in this driver use long (sana 64 bit) stora