Re: [PATCH 3/4] net: macb: Support specifying PHYs in a mdio container dts node

2018-08-20 Thread Andrew Lunn
> I've done so in part 4/4. Yes, i noticed that later. Ideally, it would be here, since this is the patch which actually changes the binding. Andrew

Re: [PATCH 3/4] net: macb: Support specifying PHYs in a mdio container dts node

2018-08-20 Thread Ahmad Fatoum
On 08/20/2018 03:42 PM, Andrew Lunn wrote: > On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote: > This is correct. But i would prefer the more readable > > struct device_node *node = of_get_child_by_name(np, "mdio"); > > if (!node) >

Re: [PATCH 3/4] net: macb: Support specifying PHYs in a mdio container dts node

2018-08-20 Thread Andrew Lunn
On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote: > To align macb DT entries with those of other MACs. > For backwards compatibility, the old way remains supported. > > Suggested-by: Andrew Lunn > Signed-off-by: Ahmad Fatoum > --- > drivers/net/ethernet/cadence/macb_main.c | 4 ++--

[PATCH 3/4] net: macb: Support specifying PHYs in a mdio container dts node

2018-08-20 Thread Ahmad Fatoum
To align macb DT entries with those of other MACs. For backwards compatibility, the old way remains supported. Suggested-by: Andrew Lunn Signed-off-by: Ahmad Fatoum --- drivers/net/ethernet/cadence/macb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git