Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-30 Thread Aviad Krawczyk
Hi, I saw that netif_err is more common in code, is it preferred on netdev_err? What is the preferred style, netif_ or netdev_? Best Regards, Aviad On 7/27/2017 1:33 AM, Andrew Lunn wrote: > On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: >> Hi Joe, >> >> I tried to be

Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-26 Thread Andrew Lunn
On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: > Hi Joe, > > I tried to be consistent with the comments before, that requested > that we will use dev_err exclude some special cases for use netif. > > We will replace the dev_err(>dev,.. to netdev_err in the > next fix.

Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-19 Thread Aviad Krawczyk
Hi Joe, I tried to be consistent with the comments before, that requested that we will use dev_err exclude some special cases for use netif. We will replace the dev_err(>dev,.. to netdev_err in the next fix. Thanks for review, Aviad On 7/19/2017 1:27 PM, Joe Perches wrote: > On Wed, 2017-07-19

Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 17:19 +0800, Aviad Krawczyk wrote: > Add ethtool operations and statistics operations. series trivia: > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c > b/drivers/net/ethernet/huawei/hinic/hinic_main.c [] > @@ -67,6 +67,178 @@ [] > +static int

[PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-19 Thread Aviad Krawczyk
Add ethtool operations and statistics operations. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 3 + drivers/net/ethernet/huawei/hinic/hinic_main.c | 218 -