From: Eric Dumazet
Date: Thu, 19 Nov 2015 13:43:45 -0800
> On Thu, 2015-11-19 at 16:06 -0500, Aaron Conole wrote:
>
>> >
>>
>> Would the following be an appropriate change in addition to the one
>> you've posted, then? If so I can repost as a formal patch, if you'd
>> like. At present, there's
On Thu, 2015-11-19 at 16:06 -0500, Aaron Conole wrote:
> >
>
> Would the following be an appropriate change in addition to the one
> you've posted, then? If so I can repost as a formal patch, if you'd
> like. At present, there's only one user of napi_frags_skb(), and your
> patch removes the NULL
Eric Dumazet writes:
> On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote:
>> Eric Dumazet writes:
>>
>> > How many times should we crash before napi_frags_skb() returns NULL ?
>> ..
>> > return NULL;
>>
>> Huh? Now I'm lost here, too.
>
>
> Well, Ethernet drivers sho
On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote:
> Eric Dumazet writes:
>
> > How many times should we crash before napi_frags_skb() returns NULL ?
> ..
> > return NULL;
>
> Huh? Now I'm lost here, too.
Well, Ethernet drivers should not feed GRO with frames with le
Eric Dumazet writes:
> How many times should we crash before napi_frags_skb() returns NULL ?
..
> return NULL;
Huh? Now I'm lost here, too.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
On Thu, 2015-11-19 at 11:54 -0800, Alexei Starovoitov wrote:
> On Thu, Nov 19, 2015 at 11:42:50AM -0800, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > Checking if skb is NULL in napi_gro_frags() is too late.
> >
> > If skb was NULL, we would crash earlier in napi_frags_skb()
> >
> > Driver
On Thu, Nov 19, 2015 at 11:42:50AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet
>
> Checking if skb is NULL in napi_gro_frags() is too late.
>
> If skb was NULL, we would crash earlier in napi_frags_skb()
>
> Drivers normally catch napi_get_frags() NULL return value
> before calling napi_gro
From: Eric Dumazet
Checking if skb is NULL in napi_gro_frags() is too late.
If skb was NULL, we would crash earlier in napi_frags_skb()
Drivers normally catch napi_get_frags() NULL return value
before calling napi_gro_frags()
Signed-off-by: Eric Dumazet
---
net/core/dev.c |3 ---
1 file
