Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Subash Abhinov Kasiviswanathan
+ priv = netdev_priv(rmnet_dev); + memset(priv, 0, sizeof(struct rmnet_priv)); Netdev private area is always zero on creation. See alloc_netdev(). + if (!rmnet_dev) + return 0; Do not confuse 0 with NULL. Did you run sparse? + + priv = netdev_priv(rmne

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-21 Thread Stephen Hemminger
> +void rmnet_vnd_setup(struct net_device *rmnet_dev) > +{ > + struct rmnet_priv *priv; > + > + /* Clear out private data */ > + priv = netdev_priv(rmnet_dev); > + memset(priv, 0, sizeof(struct rmnet_priv)); Netdev private area is always zero on creation. See alloc_netdev(). > +s

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-19 Thread kbuild test robot
Hi Subash, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-ether-Add-support-for-multiplexing-and-aggregation-type/20170819-194110 config: openrisc-allyesconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 5.4

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-16 Thread Subash Abhinov Kasiviswanathan
I'm probably forgetting a bit of the original context. Say you have one of these "network devices in IP mode". What happens with the device *before* you attach an rmnet child? Can it pass traffic before that point at all, or does the modem expect MAP already? Hi Dan All traffic needs to be i

Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-16 Thread Dan Williams
On Wed, 2017-08-16 at 18:55 -0600, Subash Abhinov Kasiviswanathan wrote: > RmNet driver provides a transport agnostic MAP (multiplexing and > aggregation protocol) support in embedded module. Module provides > virtual network devices which can be attached to any IP-mode > physical device. This will

[PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

2017-08-16 Thread Subash Abhinov Kasiviswanathan
RmNet driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded module. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a single consiste