Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Jiri Pirko
Wed, Jul 25, 2018 at 04:04:03PM CEST, pab...@redhat.com wrote: >On Wed, 2018-07-25 at 15:52 +0200, Jiri Pirko wrote: >> Tue, Jul 24, 2018 at 10:06:43PM CEST, pab...@redhat.com wrote: >> > When mirred is invoked from the ingress path, and it wants to redirect >> > the processed packet, it can now

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Paolo Abeni
On Wed, 2018-07-25 at 15:52 +0200, Jiri Pirko wrote: > Tue, Jul 24, 2018 at 10:06:43PM CEST, pab...@redhat.com wrote: > > When mirred is invoked from the ingress path, and it wants to redirect > > the processed packet, it can now use the TC_ACT_REINJECT action, > > filling the tcf_result

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Jiri Pirko
Tue, Jul 24, 2018 at 10:06:43PM CEST, pab...@redhat.com wrote: >When mirred is invoked from the ingress path, and it wants to redirect >the processed packet, it can now use the TC_ACT_REINJECT action, >filling the tcf_result accordingly, and avoiding a per packet >skb_clone(). > >Overall this

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Jiri Pirko
Wed, Jul 25, 2018 at 12:14:32PM CEST, pab...@redhat.com wrote: >On Tue, 2018-07-24 at 14:15 -0700, Cong Wang wrote: >> On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote: >> > + >> > + /* let's the caller reinject the packet, if possible */ >> > + if

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Jamal Hadi Salim
On 24/07/18 05:15 PM, Cong Wang wrote: On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote: + + /* let's the caller reinject the packet, if possible */ + if (skb_at_tc_ingress(skb)) { + res->ingress = want_ingress; +

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-25 Thread Paolo Abeni
On Tue, 2018-07-24 at 14:15 -0700, Cong Wang wrote: > On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote: > > + > > + /* let's the caller reinject the packet, if possible */ > > + if (skb_at_tc_ingress(skb)) { > > + res->ingress = want_ingress; > >

Re: [PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-24 Thread Cong Wang
On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote: > + > + /* let's the caller reinject the packet, if possible */ > + if (skb_at_tc_ingress(skb)) { > + res->ingress = want_ingress; > + res->qstats =

[PATCH net-next v3 5/5] act_mirred: use TC_ACT_REINJECT when possible

2018-07-24 Thread Paolo Abeni
When mirred is invoked from the ingress path, and it wants to redirect the processed packet, it can now use the TC_ACT_REINJECT action, filling the tcf_result accordingly, and avoiding a per packet skb_clone(). Overall this gives a ~10% improvement in forwarding performance for the TC S/W data