Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-07 Thread GMAIL
On Monday 06 July 2015 09:02 PM, Andy Gospodarek wrote: On Mon, Jul 06, 2015 at 05:34:01PM +0530, GMAIL wrote: On Friday 03 July 2015 11:46 PM, Jay Vosburgh wrote: GMAILranamazh...@gmail.com wrote: [...] Looks good, added cosmetic changes for more readability, it might save some

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-06 Thread GMAIL
On Friday 03 July 2015 11:46 PM, Jay Vosburgh wrote: GMAIL ranamazh...@gmail.com wrote: Hi Jay, On Friday 03 July 2015 02:12 AM, Jay Vosburgh wrote: [ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-06 Thread Andy Gospodarek
On Mon, Jul 06, 2015 at 05:34:01PM +0530, GMAIL wrote: On Friday 03 July 2015 11:46 PM, Jay Vosburgh wrote: GMAIL ranamazh...@gmail.com wrote: [...] Looks good, added cosmetic changes for more readability, it might save some instructions :) diff --git a/drivers/net/bonding/bond_main.c

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-03 Thread Jay Vosburgh
GMAIL ranamazh...@gmail.com wrote: Hi Jay, On Friday 03 July 2015 02:12 AM, Jay Vosburgh wrote: [ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should not become active until current active slave is up. But if

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-03 Thread GMAIL
Hi Jay, On Friday 03 July 2015 02:12 AM, Jay Vosburgh wrote: [ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should not become active until current active slave is up. But if we set first I think you

[PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-02 Thread Mazhar Rana
When primary_reselect is set to failure, primary interface should not become active until current active slave is up. But if we set first member of bond device as a primary interface and primary_reselect is set to failure then whenever primary interface's link get back(up) it become active slave

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

2015-07-02 Thread Jay Vosburgh
[ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should not become active until current active slave is up. But if we set first I think you mean until current active slave is down here, not up. member of