Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-02 Thread Santosh Shilimkar
On 3/2/2018 6:42 AM, David Miller wrote: From: "santosh.shilim...@oracle.com" Date: Thu, 1 Mar 2018 22:22:07 -0800 Versioning comment typically goes below "---" and not part of commit message. I like them to be in the commit message most of the time. Especially for patch series header posti

Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-02 Thread David Miller
From: "santosh.shilim...@oracle.com" Date: Thu, 1 Mar 2018 22:22:07 -0800 > Versioning comment typically goes below "---" and not part of > commit message. I like them to be in the commit message most of the time. Especially for patch series header postings. Later if someone reviews the patch

Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-02 Thread David Miller
From: Ka-Cheong Poon Date: Thu, 1 Mar 2018 21:07:18 -0800 > Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the > accept socket") has a reference counting issue in TCP socket creation > when accepting a new connection. The code uses sock_create_lite() to > create a kernel socke

Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-02 Thread Sowmini Varadhan
On (03/01/18 21:07), Ka-Cheong Poon wrote: > Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the > accept socket") has a reference counting issue in TCP socket creation > when accepting a new connection. The code uses sock_create_lite() to > create a kernel socket. But it does no

Re: [PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-01 Thread santosh.shilim...@oracle.com
On 3/1/18 9:07 PM, Ka-Cheong Poon wrote: Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the accept socket") has a reference counting issue in TCP socket creation when accepting a new connection. The code uses sock_create_lite() to create a kernel socket. But it does not do _

[PATCH v2 net] rds: Incorrect reference counting in TCP socket creation

2018-03-01 Thread Ka-Cheong Poon
Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the accept socket") has a reference counting issue in TCP socket creation when accepting a new connection. The code uses sock_create_lite() to create a kernel socket. But it does not do __module_get() on the socket owner. When the