Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-15 Thread Leon Romanovsky
On Wed, Sep 14, 2016 at 11:15:37PM -0700, Christoph Hellwig wrote: > On Thu, Sep 15, 2016 at 12:10:10AM +, Adit Ranadive wrote: > > On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote: > > > > + props->max_fmr = dev->dsr->caps.max_fmr; > > > > + props->max_map_per_fmr = d

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Christoph Hellwig
On Thu, Sep 15, 2016 at 12:10:10AM +, Adit Ranadive wrote: > On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote: > > > + props->max_fmr = dev->dsr->caps.max_fmr; > > > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr; > > > > Please don't add FMR support to any new drivers

RE: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Adit Ranadive
On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote: > > + props->max_fmr = dev->dsr->caps.max_fmr; > > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr; > > Please don't add FMR support to any new drivers. We don't and our device reports these as 0. If you want me to more

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Christoph Hellwig
> + props->max_fmr = dev->dsr->caps.max_fmr; > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr; Please don't add FMR support to any new drivers.

Re: [PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-14 Thread Yuval Shaia
On Sun, Sep 11, 2016 at 09:49:15PM -0700, Adit Ranadive wrote: > + > +/** > + * pvrdma_alloc_pd - allocate protection domain > + * @ibdev: the IB device > + * @context: user context > + * @udata: user data > + * > + * @return: the ib_pd protection domain pointer on success, otherwise errno. > + */

[PATCH v4 05/16] IB/pvrdma: Add functions for Verbs support

2016-09-11 Thread Adit Ranadive
This patch implements the remaining Verbs functions registered with the core RDMA stack. Reviewed-by: Jorgen Hansen Reviewed-by: George Zhang Reviewed-by: Aditya Sarwade Reviewed-by: Bryan Tan Signed-off-by: Adit Ranadive --- Changes v3->v4: - Renamed priviledged -> privileged. - Added erro