Re: [PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-03 Thread Xin Long
On Mon, Jul 2, 2018 at 11:05 PM, David Ahern wrote: > On 7/2/18 12:30 AM, Xin Long wrote: >> @@ -2143,6 +2149,10 @@ static int devinet_conf_proc(struct ctl_table *ctl, >> int write, >> if ((new_value == 0) && (old_value != 0)) >> rt_cache_flush(

Re: [PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-02 Thread David Ahern
On 7/2/18 12:30 AM, Xin Long wrote: > @@ -2143,6 +2149,10 @@ static int devinet_conf_proc(struct ctl_table *ctl, > int write, > if ((new_value == 0) && (old_value != 0)) > rt_cache_flush(net); > > + if (i == IPV4_DEVCONF_BC_FORWARDI

Re: [PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-02 Thread Davide Caratti
On Mon, 2018-07-02 at 14:30 +0800, Xin Long wrote: > This patch implements the feature described in rfc1812#section-5.3.5.2 > and rfc2644. It allows the router to forward directed broadcast when > sysctl bc_forwarding is enabled. > > Note that this feature could be done by iptables -j TEE, but it

[PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-01 Thread Xin Long
This patch implements the feature described in rfc1812#section-5.3.5.2 and rfc2644. It allows the router to forward directed broadcast when sysctl bc_forwarding is enabled. Note that this feature could be done by iptables -j TEE, but it would cause some problems: - target TEE's gateway param has