Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-17 Thread Jesse Brandeburg
On Sun, 16 Jul 2017 10:23:08 +0200 Jesper Dangaard Brouer wrote: > On Tue, 11 Jul 2017 12:37:10 -0700 John Fastabend > wrote: > > [...] > > > > hmm maybe Jesse or Alex have some clues. Adding them to the CC list. > > This seems related to

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-16 Thread Jesper Dangaard Brouer
On Tue, 11 Jul 2017 12:37:10 -0700 John Fastabend wrote: > > I have a really strange observation... if I change the CPU powersave > > settings, then the xdp_redirect_map performance drops in half! Above > > was with "tuned-adm profile powersave" (because, this is a

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-13 Thread David Miller
From: John Fastabend Date: Thu, 13 Jul 2017 10:00:15 -0700 > On 07/13/2017 09:16 AM, Jesper Dangaard Brouer wrote: >> On Thu, 13 Jul 2017 13:14:30 +0200 >> Jesper Dangaard Brouer wrote: >> >>> I'm still getting crashes (but much harder to provoke),

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-13 Thread John Fastabend
On 07/13/2017 09:16 AM, Jesper Dangaard Brouer wrote: > On Thu, 13 Jul 2017 13:14:30 +0200 > Jesper Dangaard Brouer wrote: > >> I'm still getting crashes (but much harder to provoke), but I figured >> out why. We sort of missed one case, where map_to_flush gets set, when >>

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-13 Thread Jesper Dangaard Brouer
On Thu, 13 Jul 2017 13:14:30 +0200 Jesper Dangaard Brouer wrote: > I'm still getting crashes (but much harder to provoke), but I figured > out why. We sort of missed one case, where map_to_flush gets set, when > the ndo_xdp_xmit() call starts to fail, and the ixgbe driver

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-13 Thread Jesper Dangaard Brouer
On Tue, 11 Jul 2017 11:26:54 -0700 John Fastabend wrote: > On 07/11/2017 07:23 AM, Jesper Dangaard Brouer wrote: > > On Mon, 10 Jul 2017 17:59:17 -0700 > > John Fastabend wrote: > > > >> On 07/10/2017 11:30 AM, Jesper Dangaard Brouer wrote:

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread John Fastabend
On 07/11/2017 12:19 PM, Jesper Dangaard Brouer wrote: > On Tue, 11 Jul 2017 11:56:21 -0700 > John Fastabend wrote: > >> On 07/11/2017 11:44 AM, Jesper Dangaard Brouer wrote: >>> On Tue, 11 Jul 2017 20:01:36 +0200 >>> Jesper Dangaard Brouer wrote: >>>

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread Jesper Dangaard Brouer
On Tue, 11 Jul 2017 11:56:21 -0700 John Fastabend wrote: > On 07/11/2017 11:44 AM, Jesper Dangaard Brouer wrote: > > On Tue, 11 Jul 2017 20:01:36 +0200 > > Jesper Dangaard Brouer wrote: > > > >> On Tue, 11 Jul 2017 10:48:29 -0700 > >> John

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread John Fastabend
On 07/11/2017 11:44 AM, Jesper Dangaard Brouer wrote: > On Tue, 11 Jul 2017 20:01:36 +0200 > Jesper Dangaard Brouer wrote: > >> On Tue, 11 Jul 2017 10:48:29 -0700 >> John Fastabend wrote: >> >>> On 07/11/2017 08:36 AM, Jesper Dangaard Brouer wrote:

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread Jesper Dangaard Brouer
On Tue, 11 Jul 2017 20:01:36 +0200 Jesper Dangaard Brouer wrote: > On Tue, 11 Jul 2017 10:48:29 -0700 > John Fastabend wrote: > > > On 07/11/2017 08:36 AM, Jesper Dangaard Brouer wrote: > > > On Sat, 8 Jul 2017 21:06:17 +0200 > > > Jesper Dangaard

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread John Fastabend
On 07/11/2017 11:01 AM, Jesper Dangaard Brouer wrote: > On Tue, 11 Jul 2017 10:48:29 -0700 > John Fastabend wrote: > >> On 07/11/2017 08:36 AM, Jesper Dangaard Brouer wrote: >>> On Sat, 8 Jul 2017 21:06:17 +0200 >>> Jesper Dangaard Brouer wrote: >>>

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread John Fastabend
On 07/11/2017 07:23 AM, Jesper Dangaard Brouer wrote: > On Mon, 10 Jul 2017 17:59:17 -0700 > John Fastabend wrote: > >> On 07/10/2017 11:30 AM, Jesper Dangaard Brouer wrote: >>> On Sat, 8 Jul 2017 21:06:17 +0200 >>> Jesper Dangaard Brouer wrote: >>>

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread Jesper Dangaard Brouer
On Tue, 11 Jul 2017 10:48:29 -0700 John Fastabend wrote: > On 07/11/2017 08:36 AM, Jesper Dangaard Brouer wrote: > > On Sat, 8 Jul 2017 21:06:17 +0200 > > Jesper Dangaard Brouer wrote: > > > >> My plan is to test this latest patchset again, Monday

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread John Fastabend
On 07/11/2017 08:36 AM, Jesper Dangaard Brouer wrote: > On Sat, 8 Jul 2017 21:06:17 +0200 > Jesper Dangaard Brouer wrote: > >> My plan is to test this latest patchset again, Monday and Tuesday. >> I'll try to assess stability and provide some performance numbers. > >

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread Jesper Dangaard Brouer
On Sat, 8 Jul 2017 21:06:17 +0200 Jesper Dangaard Brouer wrote: > My plan is to test this latest patchset again, Monday and Tuesday. > I'll try to assess stability and provide some performance numbers. Performance numbers: 14378479 pkt/s = XDP_DROP without touching memory

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-11 Thread Jesper Dangaard Brouer
On Mon, 10 Jul 2017 17:59:17 -0700 John Fastabend wrote: > On 07/10/2017 11:30 AM, Jesper Dangaard Brouer wrote: > > On Sat, 8 Jul 2017 21:06:17 +0200 > > Jesper Dangaard Brouer wrote: > > > >> On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) > >> David

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-10 Thread John Fastabend
On 07/10/2017 11:30 AM, Jesper Dangaard Brouer wrote: > On Sat, 8 Jul 2017 21:06:17 +0200 > Jesper Dangaard Brouer wrote: > >> On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) >> David Miller wrote: >> >>> From: John Fastabend >>>

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-10 Thread Jesper Dangaard Brouer
On Sat, 8 Jul 2017 21:06:17 +0200 Jesper Dangaard Brouer wrote: > On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) > David Miller wrote: > > > From: John Fastabend > > Date: Fri, 07 Jul 2017 10:48:36 -0700 > > > > > On 07/07/2017

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-08 Thread Jesper Dangaard Brouer
On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) David Miller wrote: > From: John Fastabend > Date: Fri, 07 Jul 2017 10:48:36 -0700 > > > On 07/07/2017 10:34 AM, John Fastabend wrote: > >> This series adds two new XDP helper routines bpf_redirect() and

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-08 Thread David Miller
From: John Fastabend Date: Fri, 07 Jul 2017 10:48:36 -0700 > On 07/07/2017 10:34 AM, John Fastabend wrote: >> This series adds two new XDP helper routines bpf_redirect() and >> bpf_redirect_map(). The first variant bpf_redirect() is meant >> to be used the same way it

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-07 Thread John Fastabend
On 07/07/2017 10:34 AM, John Fastabend wrote: > This series adds two new XDP helper routines bpf_redirect() and > bpf_redirect_map(). The first variant bpf_redirect() is meant > to be used the same way it is currently being used by the cls_bpf > classifier. An xdp packet will be redirected

[RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-07 Thread John Fastabend
This series adds two new XDP helper routines bpf_redirect() and bpf_redirect_map(). The first variant bpf_redirect() is meant to be used the same way it is currently being used by the cls_bpf classifier. An xdp packet will be redirected immediately when this is called. The other variant