Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-22 Thread Vishwanathapura, Niranjana
On Mon, Feb 13, 2017 at 10:09:35AM -0700, Jason Gunthorpe wrote: On Sun, Feb 12, 2017 at 01:26:35PM +, Liran Liss wrote: > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > > ChangeLog: > = > v2 => v3: > a)

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-13 Thread Jason Gunthorpe
On Sun, Feb 12, 2017 at 01:26:35PM +, Liran Liss wrote: > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > > > > > ChangeLog: > > = > > v2 => v3: > > a) Introduce and adopt generic RDMA netdev interface

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-12 Thread Liran Liss
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > > ChangeLog: > = > v2 => v3: > a) Introduce and adopt generic RDMA netdev interface including, > - having bottom hfi1 driver directly interfacing with

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-08 Thread Jason Gunthorpe
On Tue, Feb 07, 2017 at 04:54:16PM -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: > >On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > >>This is Ethernet - not IP - encapsulation over a non-InfiniBand > >>device/protocol. > > >

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-08 Thread Hefty, Sean
> > Even reading your statement twice did not make me any wiser. > > You mentioned "better hardware resource usage". Compared to what? Is > that > > perhaps compared to IPoIB? Since Ethernet frames have an extra > header and > > are larger than IPoIB frames, how can larger frames result in better

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Weiny, Ira
> > On Tue, 2017-02-07 at 16:54 -0800, Vishwanathapura, Niranjana wrote: > > On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: > > > On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > > > > This is Ethernet - not IP - encapsulation over a non-InfiniBand > device/protocol. > >

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 09:00:05PM +, Hefty, Sean wrote: > > I didn't read patches yet, and prefer to ask it in advance. Does this > > new ULP work with all > > drivers/infiniband/hw/* devices as it is expected from ULP? > > Like the way ipoib or srp work with all hw devices? What is the real

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 01:43:03PM -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 01:00:05PM -0800, Hefty, Sean wrote: > > > I didn't read patches yet, and prefer to ask it in advance. Does this > > > new ULP work with all > > > drivers/infiniband/hw/* devices as it is expected

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 16:54 -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: > > On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > > > This is Ethernet - not IP - encapsulation over a non-InfiniBand > > > device/protocol. > > > >

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: This is Ethernet - not IP - encapsulation over a non-InfiniBand device/protocol. That's more than clear from the cover letter. In my opinion the cover letter should explain

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > This is Ethernet - not IP - encapsulation over a non-InfiniBand > device/protocol. That's more than clear from the cover letter. In my opinion the cover letter should explain why it is considered useful to have such a driver upstream and

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Hefty, Sean
> This may have been stated before, but what is missing from this > description > is an explanation of why accepting an Ethernet over RDMA driver in the > upstream kernel is considered useful. We already have an IPoIB driver, > so > why to add another driver to the kernel tree for communicating IP

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 01:00:05PM -0800, Hefty, Sean wrote: I didn't read patches yet, and prefer to ask it in advance. Does this new ULP work with all drivers/infiniband/hw/* devices as it is expected from ULP? Like the way ipoib or srp work with all hw devices? What is the real point of

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 12:22 -0800, Vishwanathapura, Niranjana wrote: > Intel Omni-Path Host Fabric Interface (HFI) Virtual Network Interface > Controller (VNIC) feature supports Ethernet functionality over Omni-Path > fabric by encapsulating the Ethernet packets between HFI nodes. This may have

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Hefty, Sean
> I didn't read patches yet, and prefer to ask it in advance. Does this > new ULP work with all > drivers/infiniband/hw/* devices as it is expected from ULP? Like the way ipoib or srp work with all hw devices? What is the real point of this question?

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 12:22:59PM -0800, Vishwanathapura, Niranjana wrote: > ChangeLog: > = > v2 => v3: > a) Introduce and adopt generic RDMA netdev interface including, > - having bottom hfi1 driver directly interfacing with netstack. > - optimizing interface between hfi_vnic

[RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
ChangeLog: = v2 => v3: a) Introduce and adopt generic RDMA netdev interface including, - having bottom hfi1 driver directly interfacing with netstack. - optimizing interface between hfi_vnic and hfi1 driver. b) Remove bitfield usage. c) Move hfi_vnic driver to