The later check for 'k[0] != 0' requires a non-empty filter name,
otherwise NULL pointer dereference in 'q' might happen.

Signed-off-by: Phil Sutter <p...@nwl.cc>
---
 tc/tc_filter.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tc/tc_filter.c b/tc/tc_filter.c
index b13fb9185d4fd..a799edb35886d 100644
--- a/tc/tc_filter.c
+++ b/tc/tc_filter.c
@@ -412,6 +412,9 @@ static int tc_filter_get(int cmd, unsigned int flags, int 
argc, char **argv)
                        usage();
                        return 0;
                } else {
+                       if (!strlen(*argv))
+                               invarg("invalid filter name", *argv);
+
                        strncpy(k, *argv, sizeof(k)-1);
 
                        q = get_filter_kind(k);
-- 
2.13.1

Reply via email to