Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-02 Thread Ido Schimmel
On Fri, Dec 02, 2016 at 12:27:25AM +0100, Hannes Frederic Sowa wrote: > I really like that. Would you mind adding this? Yes. I'll send another version to Jiri today after testing and hopefully we can submit today / tomorrow. I think Linus is still undecided about -rc8 and I would like to get this

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 02.12.2016 00:14, Ido Schimmel wrote: [...] >> Basically, if you delete a node right now the kernel might simply do a >> RCU_INIT_POINTER(ptr_location, NULL), which has absolutely no barriers >> or synchronization with the reader side. Thus you might get a callback >> from the notifier for a d

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 10:57:52PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 19:22, Ido Schimmel wrote: > > On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: > >> On 30.11.2016 17:32, Ido Schimmel wrote: > >>> On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic So

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 30.11.2016 19:22, Ido Schimmel wrote: > On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 17:32, Ido Schimmel wrote: >>> On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: On 30.11.2016 11:09, Jiri Pirko wrote: > From: Ido Schimmel

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 10:09:19PM +0100, Hannes Frederic Sowa wrote: > On 01.12.2016 21:54, Ido Schimmel wrote: > > On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: > >> On 01.12.2016 21:04, David Miller wrote: > >>> > >>> Hannes and Ido, > >>> > >>> It looks like we are very

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 21:54, Ido Schimmel wrote: > On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: >> On 01.12.2016 21:04, David Miller wrote: >>> >>> Hannes and Ido, >>> >>> It looks like we are very close to having this in mergable shape, can >>> you guys work out this final issue a

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 30.11.2016 17:32, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 11:09, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Make sure the device has a complete view of the FIB tables by invoking >>> their dump during mod

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Ido Schimmel
On Thu, Dec 01, 2016 at 09:40:48PM +0100, Hannes Frederic Sowa wrote: > On 01.12.2016 21:04, David Miller wrote: > > > > Hannes and Ido, > > > > It looks like we are very close to having this in mergable shape, can > > you guys work out this final issue and figure out if it really is > > a merge

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread Hannes Frederic Sowa
On 01.12.2016 21:04, David Miller wrote: > > Hannes and Ido, > > It looks like we are very close to having this in mergable shape, can > you guys work out this final issue and figure out if it really is > a merge stopped or not? Sure, if the fib notification register could be done under protecti

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-12-01 Thread David Miller
Hannes and Ido, It looks like we are very close to having this in mergable shape, can you guys work out this final issue and figure out if it really is a merge stopped or not? Thanks.

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-11-30 Thread Ido Schimmel
On Wed, Nov 30, 2016 at 05:49:56PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 17:32, Ido Schimmel wrote: > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: > >> On 30.11.2016 11:09, Jiri Pirko wrote: > >>> From: Ido Schimmel > >>> > >>> Make sure the device has a com

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-11-30 Thread Hannes Frederic Sowa
On 30.11.2016 17:32, Ido Schimmel wrote: > Hi Hannes, > > On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: >> On 30.11.2016 11:09, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Make sure the device has a complete view of the FIB tables by invoking >>> their dump during mod

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-11-30 Thread Ido Schimmel
Hi Hannes, On Wed, Nov 30, 2016 at 04:37:48PM +0100, Hannes Frederic Sowa wrote: > On 30.11.2016 11:09, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Make sure the device has a complete view of the FIB tables by invoking > > their dump during module init. > > > > Signed-off-by: Ido Schimmel

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-11-30 Thread Hannes Frederic Sowa
On 30.11.2016 11:09, Jiri Pirko wrote: > From: Ido Schimmel > > Make sure the device has a complete view of the FIB tables by invoking > their dump during module init. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko > --- > .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 23

[patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

2016-11-30 Thread Jiri Pirko
From: Ido Schimmel Make sure the device has a complete view of the FIB tables by invoking their dump during module init. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 23 ++ 1 file changed, 23 insertions(+)