Re: Pull request for 'ipg' branch

2007-12-17 Thread Jeff Garzik
Francois Romieu wrote: Please pull from branch 'ipg' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git ipg to get the changes below. Distance from 'upstream' (558f08ed31c6909d3c9ae5d6dbf81220ede4b54a)

Re: Pull request for 'ipg' branch

2007-12-05 Thread Francois Romieu
Joe Perches [EMAIL PROTECTED] : [...] - if ((sp-LED_Mode 0x01) == 1) + if ((sp-led_mode 0x01) == 1) I think the use of hex and decimal constants is odd. I think if (sp-led_mode 0x01) is better. Yes, the whole context of this code in the driver is a bit special. [...] /* Assign

Pull request for 'ipg' branch

2007-12-04 Thread Francois Romieu
Please pull from branch 'ipg' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git ipg to get the changes below. Distance from 'upstream' (558f08ed31c6909d3c9ae5d6dbf81220ede4b54a) ---

Re: Pull request for 'ipg' branch

2007-12-04 Thread Joe Perches
On Tue, 2007-12-04 at 22:45 +0100, Francois Romieu wrote: diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c index dbd23bb..f736c35 100644 --- a/drivers/net/ipg.c +++ b/drivers/net/ipg.c -MODULE_DESCRIPTION(IC Plus IP1000 Gigabit Ethernet Adapter Linux Driver -DrvVer);