Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-11 Thread Erik Mouw
On Fri, Sep 08, 2006 at 08:36:36AM -0500, Larry Finger wrote: Erik Mouw wrote: Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really fixes the problem, can we try to get it merged before 2.6.18 closes? I don't know if vanilla 2.6.18-rc6 locks up on other

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-11 Thread Larry Finger
Erik Mouw wrote: On Fri, Sep 08, 2006 at 08:36:36AM -0500, Larry Finger wrote: Erik Mouw wrote: Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really fixes the problem, can we try to get it merged before 2.6.18 closes? I don't know if vanilla 2.6.18-rc6 locks

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-08 Thread Erik Mouw
On Thu, Sep 07, 2006 at 01:17:05PM -0500, Larry Finger wrote: I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx timeouts and would like it to get as much testing as possible as this bug affects V2.6.18-rcX. If the problem is truly fixed, I hope to get the fix into

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-08 Thread Michael Buesch
On Friday 08 September 2006 11:42, Erik Mouw wrote: On Thu, Sep 07, 2006 at 01:17:05PM -0500, Larry Finger wrote: I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx timeouts and would like it to get as much testing as possible as this bug affects V2.6.18-rcX. If the

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-08 Thread Michael Buesch
On Friday 08 September 2006 15:25, Larry Finger wrote: Michael Buesch wrote: On Thursday 07 September 2006 20:17, Larry Finger wrote: Hi all, I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx timeouts and would like it to get as much testing as possible as

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-08 Thread Erik Mouw
On Fri, Sep 08, 2006 at 11:45:27AM +0200, Michael Buesch wrote: The crash is fixed in wireless-2.6. The actual cause of the controller restart not. So at least it does not crash anymore. Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really fixes the problem,

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-08 Thread Larry Finger
Erik Mouw wrote: On Fri, Sep 08, 2006 at 11:45:27AM +0200, Michael Buesch wrote: The crash is fixed in wireless-2.6. The actual cause of the controller restart not. So at least it does not crash anymore. Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-07 Thread Michael Buesch
On Thursday 07 September 2006 20:17, Larry Finger wrote: Hi all, I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx timeouts and would like it to get as much testing as possible as this bug affects V2.6.18-rcX. If the problem is truly fixed, I hope to get the fix

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-07 Thread Larry Finger
Michael Buesch wrote: The real question is: Why does this patch help? Let's explain it. We don't stop networking just for fun there. While executing long preemptible periodic work, we must ensure that the TX path into the driver is not entered. It's the same reason why we disable IRQs in the

RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-07 Thread Larry Finger
Hi all, I think I have a fix for the bcm43xx bug that leads to NETDEV WATCHDOG tx timeouts and would like it to get as much testing as possible as this bug affects V2.6.18-rcX. If the problem is truly fixed, I hope to get the fix into mainline before release of the bug into the stable series.