Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-15 Thread Emmanuel Grumbach
On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko vda.li...@googlemail.com wrote: On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: +#define IWL_READ_WRITE(static_inline) \ +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ +{ \

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-14 Thread Sergei Shtylyov
Hello. On 7/14/2015 3:22 PM, Denys Vlasenko wrote: With CONFIG_IWLWIFI_DEVICE_TRACING=y, these functions are rather large, too big for inlining. With this .config: http://busybox.net/~vda/kernel_config, after uninlining these functions have sizes and callsite counts as follows:

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-14 Thread Denys Vlasenko
On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: +#define IWL_READ_WRITE(static_inline) \ +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ +{ \ + trace_iwlwifi_dev_iowrite8(trans-dev, ofs, val); \ +