Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

2017-09-12 Thread Timur Tabi
On 08/01/2017 04:37 PM, Timur Tabi wrote: The EMAC has the option of sending only a single pause frame when flow control is enabled and the RX queue is full. Although sending only one pause frame has little value, this would allow admins to enable automatic flow control without having to worry

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

2017-08-01 Thread Florian Fainelli
On 08/01/2017 03:00 PM, Timur Tabi wrote: > On 08/01/2017 04:51 PM, Florian Fainelli wrote: > >> A few adapters (bcmgenet, bcmsysport) support configuring the pause >> quanta so it would not be inconceivable to try to update >> ethtool_pauseparam to include additional fields such as: > >

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

2017-08-01 Thread Timur Tabi
On 08/01/2017 04:51 PM, Florian Fainelli wrote: A few adapters (bcmgenet, bcmsysport) support configuring the pause quanta so it would not be inconceivable to try to update ethtool_pauseparam to include additional fields such as: Wouldn't this require a change to the user space tool? -

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

2017-08-01 Thread Florian Fainelli
On 08/01/2017 02:37 PM, Timur Tabi wrote: > The EMAC has the option of sending only a single pause frame when > flow control is enabled and the RX queue is full. Although sending > only one pause frame has little value, this would allow admins to > enable automatic flow control without having to