Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 10:44:16AM -0400, David Miller wrote: > From: Simon Horman > Date: Wed, 26 Apr 2017 13:13:16 +0200 > > > On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: > >> From: Jamal Hadi Salim > >> Date: Tue, 25 Apr 2017

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread David Miller
From: Simon Horman Date: Wed, 26 Apr 2017 13:13:16 +0200 > On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: >> From: Jamal Hadi Salim >> Date: Tue, 25 Apr 2017 08:42:32 -0400 >> >> > So are we going to standardize these strings? >>

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Daniel Borkmann
On 04/26/2017 03:03 PM, Jamal Hadi Salim wrote: On 17-04-26 07:13 AM, Simon Horman wrote: I don't feel strongly about this and perhaps it can be revisited at some point but perhaps it would be worth documenting that he strings do not form part of the UAPI as my expectation would have been that

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Jamal Hadi Salim
On 17-04-26 07:13 AM, Simon Horman wrote: I don't feel strongly about this and perhaps it can be revisited at some point but perhaps it would be worth documenting that he strings do not form part of the UAPI as my expectation would have been that they do f.e. to facilitate internationalisation.

Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-26 Thread Simon Horman
On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: > From: Jamal Hadi Salim > Date: Tue, 25 Apr 2017 08:42:32 -0400 > > > So are we going to standardize these strings? > > No. > > > i.e what if some user has written a bash script that depends on this > > string

Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-25 Thread David Miller
From: Jamal Hadi Salim Date: Tue, 25 Apr 2017 08:42:32 -0400 > So are we going to standardize these strings? No. > i.e what if some user has written a bash script that depends on this > string and it gets changed later. They can't do that. It's free form extra information

Re: [RFC 3/4] nfp: make use of extended ack message reporting

2017-04-25 Thread Jamal Hadi Salim
Good stuff. Question below: On 17-04-25 04:06 AM, Jakub Kicinski wrote: Try to carry error messages to the user via the netlink extended [..] +nfp_net_check_config(struct nfp_net *nn, struct nfp_net_dp *dp, +struct netlink_ext_ack *extack) { /* XDP-enabled tests